Changes

Summary

[sanitizer][zorg] Print URL with local reproducer info

Change Type	Path in Repository	Path in Workspace
Revision 359607 by vitalybuka: [sanitizer][zorg] Print URL with local reproducer info
	/zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_functions.sh	zorg/buildbot/builders/sanitizers/buildbot_functions.sh

Summary

Make some comments that were meant to be for public documentation actually public documentation (i.e. // -> ///).
[llvm-objcopy] Simplify SHT_NOBITS -> SHT_PROGBITS promotion GNU objcopy uses bfd_elf_get_default_section_type to decide the candidate section type, which roughly translates to our [a] (I assume SEC_COMMON implies SHF_ALLOC): (!(Sec.Flags & ELF::SHF_ALLOC) || Flags & (SectionFlag::SecContents | SectionFlag::SecLoad))) Then, it updates the section type in bfd/elf.c:elf_fake_sections if: if (this_hdr->sh_type == SHT_NULL) this_hdr->sh_type = sh_type; // common case else if (this_hdr->sh_type == SHT_NOBITS && sh_type == SHT_PROGBITS && (asect->flags & SEC_ALLOC) != 0) // uncommon case ... this_hdr->sh_type = sh_type; If the following condition is met the uncommon branch is executed: if (elf_section_type (osec) == SHT_NULL && (osec->flags == isec->flags || (final_link && ((osec->flags ^ isec->flags) & ~(SEC_LINK_ONCE | SEC_LINK_DUPLICATES | SEC_RELOC)) == 0))) I suggest we just ignore this clause and follow the common case behavior, which is done in this patch. Rationales to do so: If --set-section-flags is a no-op (osec->flags == isec->flags) (corresponds to the "readonly" test in set-section-flags.test), GNU objcopy will require (Sec.Flags & ELF::SHF_ALLOC). [a] is essentially: Flags & (SectionFlag::SecContents | SectionFlag::SecLoad) This special case is not really useful. Non-SHF_ALLOC SHT_NOBITS sections do not make much sense and it doesn't matter if they are SHT_NOBITS or SHT_PROGBITS. For all other RUN lines in set-section-flags.test, the new behavior matches GNU objcopy, i.e. this patch improves compatibility. Differential Revision: https://reviews.llvm.org/D60189
gn build: Fix build on macOS after r359570 / r359527
gn build: Merge r359626
[WebAssembly] Update expectations for gcc torture tests This is needed to make the wasm waterfall green again after we land the update to WASI: https://github.com/WebAssembly/waterfall/pull/492 Differential Revision: https://reviews.llvm.org/D61351
[InstCombine] Limit a vector demanded elts rule which was producing invalid IR. The demanded elts rules introduced for GEPs in https://reviews.llvm.org/rL356293 replaced vector constants with undefs (by design). It turns out that the LangRef disallows such cases when indexing structs. The right fix is probably to relax the langref requirement, and update other passes to expect the result, but for the moment, limit the transform to avoid compiler crashes. This should fix https://bugs.llvm.org/show_bug.cgi?id=41624.
[WebAssembly] Test the "wasm32-wasi" triple Add triple tests for "wasm32-wasi" and "wasm64-wasi", and also remove the "-musl" component from the existing wasm triple tests as we're not using that in practice (WASI libc is derived in part from musl, but it is not fully musl-compatible). Differential Revision: https://reviews.llvm.org/D61334 Reviewer: sbc100
[MemorySSA] Invalidate MemorySSA if AA or DT are invalidated. Summary: MemorySSA keeps internal pointers of AA and DT. If these get invalidated, so should MemorySSA. Reviewers: george.burgess.iv, chandlerc Subscribers: jlebar, Prazek, llvm-commits Tags: LLVM Differential Revision: https://reviews.llvm.org/D61043
[ORC] Move SimpleCompiler/ConcurrentIRCompiler definitions into a .cpp file. SimpleCompiler is no longer templated, so there's no reason for this code to be in a header any more.
[llvm-profdata] Fix indentation error in docs. NFC.
[AliasAnalysis/NewPassManager] Invalidate AAManager less often. Summary: This is a redo of D60914. The objective is to not invalidate AAManager, which is stateless, unless there is an explicit invalidate in one of the AAResults. To achieve this, this patch adds an API to PAC, to check precisely this: is this analysis not invalidated explicitly == is this analysis not abandoned == is this analysis stateless, so preserved without explicitly being marked as preserved by everyone Reviewers: chandlerc Subscribers: mehdi_amini, jlebar, george.burgess.iv, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61284
[AMDGPU] gfx1010 VMEM and SMEM implementation Differential Revision: https://reviews.llvm.org/D61330
[llvm-profdata] Fix indentation error. NFC
Add an include of Module since we actually access it now and remove the forward declaration.
Fix a few -Werror warnings: - Remove a variable only used in an assert - Fix pessimizing move warning around copy elision
[PassManagerBuilder] Add option for interleaved loops, for loop vectorize. Summary: Match NewPassManager behavior: add option for interleaved loops in the old pass manager, and use that instead of the flag used to disable loop unroll. No changes in the defaults. Reviewers: chandlerc Subscribers: mehdi_amini, jlebar, dmgreen, hsaito, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61030
[JITLink] Add debugging output to print resolved external atoms.
[ORC][JITLink] Name in-memory compiled objects after their source modules. In-memory compiled object buffer identifiers will now be derived from the identifiers of their source IR modules. This makes it easier to connect in-memory objects with their source modules in debugging output.
[llvm-profdata] Add overlap command to compute similarity b/w two profile files Add overlap functionality to llvm-profdata tool to compute the similarity between two profile files. Differential Revision: https://reviews.llvm.org/D60977
[NFC][InlineCost] cleanup - comments, overflow handling. Reviewed By: apilipenko Tags: #llvm Differential Revision: https://reviews.llvm.org/D60751
[X86][SSE] Fold extract_subvector(extend(x)) -> extend_vector_inreg(x) This adds any extend support - folding to zero_extend_vector_inreg (PMOVZX) for legality Minor improvement for PR39709
[WebAssembly] Fix test after r359602 Update the expected output for this test now that the EXPLICIT_NAME flag is being printed.
Fix stack-use-after free after r359580 `Candidate` was a StringRef refering to a temporary string. Instead, create a local variable for the string and use a StringRef referring to that.
[WebAssembly] Support EXPLICIT_NAME symbols in llvm-readobj Teach llvm-readobj about WASM_SYMBOL_EXPLICIT_NAME. Differential Revision: https://reviews.llvm.org/D61323 Reviewer: sbc100
[WebAssembly] Support f16 libcalls Add support for f16 libcalls in WebAssembly. This entails adding signatures for the remaining F16 libcalls, and renaming gnu_f2h_ieee/gnu_h2f_ieee to truncsfhf2/extendhfsf2 for consistency between f32 and f64/f128 (compiler-rt already supports this). Differential Revision: https://reviews.llvm.org/D61287 Reviewer: dschuff
[X86] Remove if that's always true It's been like this since it was added in a refactor of this code. Fixes PR41659
[SimplifyLibCalls] Clean up code (NFC) Fix pointer check after dereferencing (PR41665).
[AArch64] add more tests for constant folding failures; NFC
[X86] If PreprocessISelDAG reorders a load before a call, make sure we remove dead nodes from the graph The reordering can leave at least a dead TokenFactor in the graph. This cause the linearize scheduler to fail with something like the assert seen in PR22614. This is only one of many ways we can break the linearize scheduler today so I can't say for sure that any of the other failures in that bug were caused by this issue. This takes the heavy hammer approach of just running RemoveDeadNodes unconditionally at the end of the PreprocessISelDAG. If this turns out to be a compile time hit, we can try to refine it. Differential Revision: https://reviews.llvm.org/D61164
[X86] Initial cleanups on the FixupLEAs pass. Separate Atom LEA creation from other LEA optimizations. This removes some of the class variables. Merge basic block processing into runOnMachineFunction to keep the flags local. Pass MachineBasicBlock around instead of an iterator. We can get the iterator in the few places that need it. Allows a range-based outer for loop. Separate the Atom optimization from the rest of the optimizations. This allows fixupIncDec to create INC/DEC and still allow Atom to turn it back into LEA when profitable by its heuristics. I'd like to improve fixupIncDec to turn LEAs into ADD any time the base or index register is equal to the destination register. This is profitable regardless of the various slow flags. But again we would want Atom to be able to undo that. Differential Revision: https://reviews.llvm.org/D60993
Re-reland "[Option] Fix PR37006 prefix choice in findNearest" This was first reviewed in https://reviews.llvm.org/D46776 and landed in r332299, but got reverted because it broke the PS4 bots. https://reviews.llvm.org/D50410 fixed this, and then this change was re-reviewed at https://reviews.llvm.org/D50515 and relanded in r341329. It got reverted due to causing MSan issues. However, nobody wrote down the error message and the bot link is dead, so I'm relanding this to capture the MSan error. I'll then either fix it, or copy it somewhere and revert if fixing looks difficult.

Summary

Fix auto-init test r359628 changed the initialization of padding to follow C, but I didn't update the C++ tests.
[WebAssembly] Use the "wasm32-wasi" triple in tests Similar to https://reviews.llvm.org/D61334, update clang tests to use the "wasm32-wasi" triple, removing the "-musl" environment and omitting the "-unknown" vendor. Differential Revision: https://reviews.llvm.org/D61338 Reviewer: sbc100
Variable auto-init: don't initialize aggregate padding of all aggregates Summary: C guarantees that brace-init with fewer initializers than members in the aggregate will initialize the rest of the aggregate as-if it were static initialization. In turn static initialization guarantees that padding is initialized to zero bits. Quoth the Standard: C17 6.7.9 Initialization ❡21 If there are fewer initializers in a brace-enclosed list than there are elements or members of an aggregate, or fewer characters in a string literal used to initialize an array of known size than there are elements in the array, the remainder of the aggregate shall be initialized implicitly the same as objects that have static storage duration. C17 6.7.9 Initialization ❡10 If an object that has automatic storage duration is not initialized explicitly, its value is indeterminate. If an object that has static or thread storage duration is not initialized explicitly, then: * if it has pointer type, it is initialized to a null pointer; * if it has arithmetic type, it is initialized to (positive or unsigned) zero; * if it is an aggregate, every member is initialized (recursively) according to these rules, and any padding is initialized to zero bits; * if it is a union, the first named member is initialized (recursively) according to these rules, and any padding is initialized to zero bits; <rdar://problem/50188861> Reviewers: glider, pcc, kcc, rjmccall, erik.pilkington Subscribers: jkorous, dexonsmith, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61280
Remove two unnecessary wrappers of canPassInRegisters These extra layers aren't necessary.
Set LoopInterleaved in the PassManagerBuilder. Summary: Corresponds to D61030. Subscribers: jlebar, cfe-commits, llvm-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61142
[Driver] Support compiler-rt crtbegin.o/crtend.o for Linux When compiler-rt is selected as the runtime library for Linux targets use its crtbegin.o/crtend.o implemenetation rather than platform one if available. Differential Revision: https://reviews.llvm.org/D59264
Add requires amdgpu-registered-target for amdgpu-float16.cpp
AMDGPU: Enable _Float16
[LibTooling] Fix broken test after r359574. r359574 changed the way that failures are reported, which broke the test TransformerTest.NodePartNameDeclRefFailure which detects a faiure.
[LibTooling] Change Transformer's TextGenerator to a partial function. Summary: Changes the signature of the TextGenerator std::function to return an Expected<std::string> instead of std::string to allow for (non-fatal) failures. Previously, we expected that any failures would be expressed with assertions. However, that's unfriendly to running the code in servers or other places that don't want their library calls to crash the program. Correspondingly, updates Transformer's handling of failures in TextGenerators and the signature of `ChangeConsumer`. Reviewers: ilya-biryukov Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61015

Change Type	Path in Repository	Path in Workspace
Revision 359636 by jfb: Fix auto-init test r359628 changed the initialization of padding to follow C, but I didn't update the C++ tests.
	/cfe/trunk/test/CodeGenCXX/auto-var-init.cpp	trunk/test/CodeGenCXX/auto-var-init.cpp
Revision 359630 by djg: [WebAssembly] Use the "wasm32-wasi" triple in tests Similar to https://reviews.llvm.org/D61334, update clang tests to use the "wasm32-wasi" triple, removing the "-musl" environment and omitting the "-unknown" vendor. Differential Revision: https://reviews.llvm.org/D61338 Reviewer: sbc100
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/test/Driver/wasm-toolchain.c	trunk/test/Driver/wasm-toolchain.c
	/cfe/trunk/test/Driver/wasm-toolchain.cpp	trunk/test/Driver/wasm-toolchain.cpp
	/cfe/trunk/test/Preprocessor/init.c	trunk/test/Preprocessor/init.c
Revision 359628 by jfb: Variable auto-init: don't initialize aggregate padding of all aggregates Summary: C guarantees that brace-init with fewer initializers than members in the aggregate will initialize the rest of the aggregate as-if it were static initialization. In turn static initialization guarantees that padding is initialized to zero bits. Quoth the Standard: C17 6.7.9 Initialization ❡21 If there are fewer initializers in a brace-enclosed list than there are elements or members of an aggregate, or fewer characters in a string literal used to initialize an array of known size than there are elements in the array, the remainder of the aggregate shall be initialized implicitly the same as objects that have static storage duration. C17 6.7.9 Initialization ❡10 If an object that has automatic storage duration is not initialized explicitly, its value is indeterminate. If an object that has static or thread storage duration is not initialized explicitly, then: * if it has pointer type, it is initialized to a null pointer; * if it has arithmetic type, it is initialized to (positive or unsigned) zero; * if it is an aggregate, every member is initialized (recursively) according to these rules, and any padding is initialized to zero bits; * if it is a union, the first named member is initialized (recursively) according to these rules, and any padding is initialized to zero bits; <rdar://problem/50188861> Reviewers: glider, pcc, kcc, rjmccall, erik.pilkington Subscribers: jkorous, dexonsmith, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61280
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/lib/CodeGen/CGDecl.cpp	trunk/lib/CodeGen/CGDecl.cpp
	/cfe/trunk/test/CodeGen/padding-init.c	trunk/test/CodeGen/padding-init.c
Revision 359623 by rnk: Remove two unnecessary wrappers of canPassInRegisters These extra layers aren't necessary.
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/lib/CodeGen/CGCXXABI.cpp	trunk/lib/CodeGen/CGCXXABI.cpp
	/cfe/trunk/lib/CodeGen/CGCXXABI.h	trunk/lib/CodeGen/CGCXXABI.h
	/cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp	trunk/lib/CodeGen/ItaniumCXXABI.cpp
	/cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp	trunk/lib/CodeGen/MicrosoftCXXABI.cpp
Revision 359616 by asbirlea: Set LoopInterleaved in the PassManagerBuilder. Summary: Corresponds to D61030. Subscribers: jlebar, cfe-commits, llvm-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61142
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/lib/CodeGen/BackendUtil.cpp	trunk/lib/CodeGen/BackendUtil.cpp
Revision 359603 by phosek: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux When compiler-rt is selected as the runtime library for Linux targets use its crtbegin.o/crtend.o implemenetation rather than platform one if available. Differential Revision: https://reviews.llvm.org/D59264
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/lib/Driver/ToolChains/Gnu.cpp	trunk/lib/Driver/ToolChains/Gnu.cpp
	/cfe/trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-i386.o	trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-i386.o
	/cfe/trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-x86_64.o	trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-x86_64.o
	/cfe/trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtend-i386.o	trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtend-i386.o
	/cfe/trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtend-x86_64.o	trunk/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtend-x86_64.o
	/cfe/trunk/test/Driver/linux-ld.c	trunk/test/Driver/linux-ld.c
Revision 359598 by yaxunl: Add requires amdgpu-registered-target for amdgpu-float16.cpp
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/test/CodeGenCXX/amdgpu-float16.cpp	trunk/test/CodeGenCXX/amdgpu-float16.cpp
Revision 359594 by yaxunl: AMDGPU: Enable _Float16
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/lib/Basic/Targets/AMDGPU.cpp	trunk/lib/Basic/Targets/AMDGPU.cpp
	/cfe/trunk/test/CodeGenCXX/amdgpu-float16.cpp	trunk/test/CodeGenCXX/amdgpu-float16.cpp
Revision 359578 by ymandel: [LibTooling] Fix broken test after r359574. r359574 changed the way that failures are reported, which broke the test TransformerTest.NodePartNameDeclRefFailure which detects a faiure.
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/unittests/Tooling/TransformerTest.cpp	trunk/unittests/Tooling/TransformerTest.cpp
Revision 359574 by ymandel: [LibTooling] Change Transformer's TextGenerator to a partial function. Summary: Changes the signature of the TextGenerator std::function to return an Expected<std::string> instead of std::string to allow for (non-fatal) failures. Previously, we expected that any failures would be expressed with assertions. However, that's unfriendly to running the code in servers or other places that don't want their library calls to crash the program. Correspondingly, updates Transformer's handling of failures in TextGenerators and the signature of `ChangeConsumer`. Reviewers: ilya-biryukov Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61015
Change Type	Path in Repository	Path in Workspace
	/cfe/trunk/include/clang/Tooling/Refactoring/Transformer.h	trunk/include/clang/Tooling/Refactoring/Transformer.h
	/cfe/trunk/lib/Tooling/Refactoring/Transformer.cpp	trunk/lib/Tooling/Refactoring/Transformer.cpp
	/cfe/trunk/unittests/Tooling/TransformerTest.cpp	trunk/unittests/Tooling/TransformerTest.cpp

Summary

[libFuzzer] Fix failing test: sigint.test Summary: Fix sigint.test by making it require msan rather than enumerating unsupported platforms. Reviewers: kcc Reviewed By: kcc Subscribers: #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61353
Added test.
[sanitizer_common] Added 64-bit signed flag parser. Summary: Adds a 64-bit signed flag parser for GWP-ASan's use. Reviewers: vlad.tsyrklevich, eugenis Subscribers: kubamracek, #sanitizers, llvm-commits, vitalybuka, morehouse, pcc, kcc Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61342
[libFuzzer] temporarily disable a test on windows, where there is no memmem in the usual place
[libFuzzer] add MagicSeparatorTest
Revert r359325 "[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void" Changing INTERCEPT_FUNCTION to return void is not functionally correct. IMO the best way to communicate failure or success of interception is with a return value, not some external address comparison. This change was also creating link errors for _except_handler4_common, which is exported from ucrtbase.dll in 32-bit Windows. Also revert dependent changes r359362 and r359466.
[libFuzzer] Replace -seed_corpus to better support fork mode on Win Summary: Pass seed corpus list in a file to get around argument length limits on Windows. This limit was preventing many uses of fork mode on Windows. Reviewers: kcc, morehouse Reviewed By: kcc Subscribers: #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D60980
[compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain This patch aims to: - Guard ompiler-rt/test/builtins/Unit/compiler_rt_logb_test.c with macros, so the test runs on GLIBC versions >= 2.23. This is because the test relies on comparing its computed values to libm. Oolder versions might not compute to the same value as the compiler-rt value. - Update compiler-rt/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc so that std::string is not used, since false positives may be detected. Differential Revision: https://reviews.llvm.org/D60644
Reland "[compiler-rt] Simple crtbegin.o and crtend.o implementation" Clang relies on existence of certain symbols that are normally provided by crtbegin.o/crtend.o. However, LLVM does not currently provide implementation of these files, instead relying on either libgcc or implementations provided as part of the system. This change provides an initial implementation of crtbegin.o/crtend.o that can be used on system that don't provide crtbegin.o/crtend.o as part of their C library. Differential Revision: https://reviews.llvm.org/D28791
fix broken test
remove extra zeros
remove stale comment
change order
fix comment
[libFuzzer] Enable for i386 Summary: Get libFuzzer to build on i386 and fix tests. Subscribers: mgorny, #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61070
Fix issues with testing for i386
Enable x86 builds
Revert "[compiler-rt] Simple crtbegin.o and crtend.o implementation" This reverts commit r359576 since it's failing on Windows bots.
[compiler-rt] Simple crtbegin.o and crtend.o implementation Clang relies on existence of certain symbols that are normally provided by crtbegin.o/crtend.o. However, LLVM does not currently provide implementation of these files, instead relying on either libgcc or implementations provided as part of the system. This change provides an initial implementation of crtbegin.o/crtend.o that can be used on system that don't provide crtbegin.o/crtend.o as part of their C library. Differential Revision: https://reviews.llvm.org/D28791

Change Type	Path in Repository	Path in Workspace
Revision 359638 by metzman: [libFuzzer] Fix failing test: sigint.test Summary: Fix sigint.test by making it require msan rather than enumerating unsupported platforms. Reviewers: kcc Reviewed By: kcc Subscribers: #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61353
	/compiler-rt/trunk/test/fuzzer/sigint.test	trunk/test/fuzzer/sigint.test
Revision 359632 by hctim: Added test.
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc	trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc
Revision 359631 by hctim: [sanitizer_common] Added 64-bit signed flag parser. Summary: Adds a 64-bit signed flag parser for GWP-ASan's use. Reviewers: vlad.tsyrklevich, eugenis Subscribers: kubamracek, #sanitizers, llvm-commits, vitalybuka, morehouse, pcc, kcc Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61342
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h	trunk/lib/sanitizer_common/sanitizer_flag_parser.h
Revision 359624 by kcc: [libFuzzer] temporarily disable a test on windows, where there is no memmem in the usual place
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/magic-separator.test	trunk/test/fuzzer/magic-separator.test
Revision 359620 by kcc: [libFuzzer] add MagicSeparatorTest
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/MagicSeparatorTest.cpp	trunk/test/fuzzer/MagicSeparatorTest.cpp
	/compiler-rt/trunk/test/fuzzer/magic-separator.test	trunk/test/fuzzer/magic-separator.test
Revision 359611 by rnk: Revert r359325 "[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void" Changing INTERCEPT_FUNCTION to return void is not functionally correct. IMO the best way to communicate failure or success of interception is with a return value, not some external address comparison. This change was also creating link errors for _except_handler4_common, which is exported from ucrtbase.dll in 32-bit Windows. Also revert dependent changes r359362 and r359466.
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/lib/asan/asan_interceptors.h	trunk/lib/asan/asan_interceptors.h
	/compiler-rt/trunk/lib/interception/interception_linux.cc	trunk/lib/interception/interception_linux.cc
	/compiler-rt/trunk/lib/interception/interception_linux.h	trunk/lib/interception/interception_linux.h
	/compiler-rt/trunk/lib/interception/tests/interception_linux_test.cc	trunk/lib/interception/tests/interception_linux_test.cc
	/compiler-rt/trunk/lib/msan/msan_interceptors.cc	trunk/lib/msan/msan_interceptors.cc
	/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc	trunk/lib/tsan/rtl/tsan_interceptors.cc
Revision 359610 by metzman: [libFuzzer] Replace -seed_corpus to better support fork mode on Win Summary: Pass seed corpus list in a file to get around argument length limits on Windows. This limit was preventing many uses of fork mode on Windows. Reviewers: kcc, morehouse Reviewed By: kcc Subscribers: #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D60980
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/lib/fuzzer/FuzzerDriver.cpp	trunk/lib/fuzzer/FuzzerDriver.cpp
	/compiler-rt/trunk/lib/fuzzer/FuzzerFlags.def	trunk/lib/fuzzer/FuzzerFlags.def
	/compiler-rt/trunk/lib/fuzzer/FuzzerFork.cpp	trunk/lib/fuzzer/FuzzerFork.cpp
	/compiler-rt/trunk/lib/fuzzer/FuzzerIO.cpp	trunk/lib/fuzzer/FuzzerIO.cpp
	/compiler-rt/trunk/lib/fuzzer/FuzzerIO.h	trunk/lib/fuzzer/FuzzerIO.h
	/compiler-rt/trunk/test/fuzzer/seed_inputs.test	trunk/test/fuzzer/seed_inputs.test
Revision 359606 by amyk: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain This patch aims to: - Guard ompiler-rt/test/builtins/Unit/compiler_rt_logb_test.c with macros, so the test runs on GLIBC versions >= 2.23. This is because the test relies on comparing its computed values to libm. Oolder versions might not compute to the same value as the compiler-rt value. - Update compiler-rt/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc so that std::string is not used, since false positives may be detected. Differential Revision: https://reviews.llvm.org/D60644
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c	trunk/test/builtins/Unit/compiler_rt_logb_test.c
	/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc	trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc
Revision 359591 by phosek: Reland "[compiler-rt] Simple crtbegin.o and crtend.o implementation" Clang relies on existence of certain symbols that are normally provided by crtbegin.o/crtend.o. However, LLVM does not currently provide implementation of these files, instead relying on either libgcc or implementations provided as part of the system. This change provides an initial implementation of crtbegin.o/crtend.o that can be used on system that don't provide crtbegin.o/crtend.o as part of their C library. Differential Revision: https://reviews.llvm.org/D28791
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/CMakeLists.txt	trunk/CMakeLists.txt
	/compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake	trunk/cmake/Modules/AddCompilerRT.cmake
	/compiler-rt/trunk/cmake/config-ix.cmake	trunk/cmake/config-ix.cmake
	/compiler-rt/trunk/lib/CMakeLists.txt	trunk/lib/CMakeLists.txt
	/compiler-rt/trunk/lib/crt	trunk/lib/crt
	/compiler-rt/trunk/lib/crt/CMakeLists.txt	trunk/lib/crt/CMakeLists.txt
	/compiler-rt/trunk/lib/crt/crtbegin.c	trunk/lib/crt/crtbegin.c
	/compiler-rt/trunk/lib/crt/crtend.c	trunk/lib/crt/crtend.c
	/compiler-rt/trunk/test/CMakeLists.txt	trunk/test/CMakeLists.txt
	/compiler-rt/trunk/test/crt	trunk/test/crt
	/compiler-rt/trunk/test/crt/CMakeLists.txt	trunk/test/crt/CMakeLists.txt
	/compiler-rt/trunk/test/crt/ctor_dtor.c	trunk/test/crt/ctor_dtor.c
	/compiler-rt/trunk/test/crt/dso_handle.cpp	trunk/test/crt/dso_handle.cpp
	/compiler-rt/trunk/test/crt/lit.cfg	trunk/test/crt/lit.cfg
	/compiler-rt/trunk/test/crt/lit.site.cfg.in	trunk/test/crt/lit.site.cfg.in
Revision 359590 by metzman: fix broken test
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/trace-malloc-threaded.test	trunk/test/fuzzer/trace-malloc-threaded.test
Revision 359589 by metzman: remove extra zeros
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/fork.test	trunk/test/fuzzer/fork.test
Revision 359588 by metzman: remove stale comment
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/lit.cfg	trunk/test/fuzzer/lit.cfg
Revision 359587 by metzman: change order
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/lib/fuzzer/CMakeLists.txt	trunk/lib/fuzzer/CMakeLists.txt
Revision 359586 by metzman: fix comment
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/fork.test	trunk/test/fuzzer/fork.test
Revision 359585 by metzman: [libFuzzer] Enable for i386 Summary: Get libFuzzer to build on i386 and fix tests. Subscribers: mgorny, #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61070
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/lib/fuzzer/CMakeLists.txt	trunk/lib/fuzzer/CMakeLists.txt
	/compiler-rt/trunk/test/fuzzer/compressed.test	trunk/test/fuzzer/compressed.test
Revision 359584 by metzman: Fix issues with testing for i386
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/test/fuzzer/CMakeLists.txt	trunk/test/fuzzer/CMakeLists.txt
	/compiler-rt/trunk/test/fuzzer/compressed.test	trunk/test/fuzzer/compressed.test
	/compiler-rt/trunk/test/fuzzer/lit.cfg	trunk/test/fuzzer/lit.cfg
	/compiler-rt/trunk/test/fuzzer/lit.site.cfg.in	trunk/test/fuzzer/lit.site.cfg.in
	/compiler-rt/trunk/test/fuzzer/trace-malloc-threaded.test	trunk/test/fuzzer/trace-malloc-threaded.test
Revision 359583 by metzman: Enable x86 builds
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/cmake/config-ix.cmake	trunk/cmake/config-ix.cmake
	/compiler-rt/trunk/lib/fuzzer/CMakeLists.txt	trunk/lib/fuzzer/CMakeLists.txt
	/compiler-rt/trunk/test/fuzzer/dataflow.test	trunk/test/fuzzer/dataflow.test
	/compiler-rt/trunk/test/fuzzer/fork.test	trunk/test/fuzzer/fork.test
	/compiler-rt/trunk/test/fuzzer/only-some-bytes.test	trunk/test/fuzzer/only-some-bytes.test
Revision 359579 by phosek: Revert "[compiler-rt] Simple crtbegin.o and crtend.o implementation" This reverts commit r359576 since it's failing on Windows bots.
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/CMakeLists.txt	trunk/CMakeLists.txt
	/compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake	trunk/cmake/Modules/AddCompilerRT.cmake
	/compiler-rt/trunk/cmake/config-ix.cmake	trunk/cmake/config-ix.cmake
	/compiler-rt/trunk/lib/CMakeLists.txt	trunk/lib/CMakeLists.txt
	/compiler-rt/trunk/lib/crt	trunk/lib/crt
	/compiler-rt/trunk/test/CMakeLists.txt	trunk/test/CMakeLists.txt
	/compiler-rt/trunk/test/crt	trunk/test/crt
Revision 359576 by phosek: [compiler-rt] Simple crtbegin.o and crtend.o implementation Clang relies on existence of certain symbols that are normally provided by crtbegin.o/crtend.o. However, LLVM does not currently provide implementation of these files, instead relying on either libgcc or implementations provided as part of the system. This change provides an initial implementation of crtbegin.o/crtend.o that can be used on system that don't provide crtbegin.o/crtend.o as part of their C library. Differential Revision: https://reviews.llvm.org/D28791
Change Type	Path in Repository	Path in Workspace
	/compiler-rt/trunk/CMakeLists.txt	trunk/CMakeLists.txt
	/compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake	trunk/cmake/Modules/AddCompilerRT.cmake
	/compiler-rt/trunk/cmake/config-ix.cmake	trunk/cmake/config-ix.cmake
	/compiler-rt/trunk/lib/CMakeLists.txt	trunk/lib/CMakeLists.txt
	/compiler-rt/trunk/lib/crt	trunk/lib/crt
	/compiler-rt/trunk/lib/crt/CMakeLists.txt	trunk/lib/crt/CMakeLists.txt
	/compiler-rt/trunk/lib/crt/crtbegin.c	trunk/lib/crt/crtbegin.c
	/compiler-rt/trunk/lib/crt/crtend.c	trunk/lib/crt/crtend.c
	/compiler-rt/trunk/test/CMakeLists.txt	trunk/test/CMakeLists.txt
	/compiler-rt/trunk/test/crt	trunk/test/crt
	/compiler-rt/trunk/test/crt/CMakeLists.txt	trunk/test/crt/CMakeLists.txt
	/compiler-rt/trunk/test/crt/dso_handle.cpp	trunk/test/crt/dso_handle.cpp
	/compiler-rt/trunk/test/crt/lit.cfg	trunk/test/crt/lit.cfg
	/compiler-rt/trunk/test/crt/lit.site.cfg.in	trunk/test/crt/lit.site.cfg.in

Summary

Support overaligned types in `aligned_storage`. Summary: The current implementation of aligned storage was written before we had `alignas`, so it used a list of builtin types to force the alignment. But this doesn't work overaligned requests. This patch adds a fallback case supporting over-alignment. It only affects case that were previously ill-formed. Reviewers: rsmith, ldionne, dlj, mclow.lists Reviewed By: mclow.lists Subscribers: mclow.lists, dexonsmith, libcxx-commits Differential Revision: https://reviews.llvm.org/D61301
[libc++][CMake] Refactor how we link against system libraries Summary: Instead of populating the global LIBCXX_LIBRARIES, we use the link-time dependency management built into CMake to propagate link flags. This leads to a cleaner and easier-to-follow build. Reviewers: phosek, smeenai, EricWF Subscribers: mgorny, christof, jkorous, dexonsmith, jfb, mstorsjo, libcxx-commits Tags: #libc Differential Revision: https://reviews.llvm.org/D60969

Change Type	Path in Repository	Path in Workspace
Revision 359596 by ericwf: Support overaligned types in `aligned_storage`. Summary: The current implementation of aligned storage was written before we had `alignas`, so it used a list of builtin types to force the alignment. But this doesn't work overaligned requests. This patch adds a fallback case supporting over-alignment. It only affects case that were previously ill-formed. Reviewers: rsmith, ldionne, dlj, mclow.lists Reviewed By: mclow.lists Subscribers: mclow.lists, dexonsmith, libcxx-commits Differential Revision: https://reviews.llvm.org/D61301
	/libcxx/trunk/include/type_traits	trunk/include/type_traits
	/libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp	trunk/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp
Revision 359571 by ldionne: [libc++][CMake] Refactor how we link against system libraries Summary: Instead of populating the global LIBCXX_LIBRARIES, we use the link-time dependency management built into CMake to propagate link flags. This leads to a cleaner and easier-to-follow build. Reviewers: phosek, smeenai, EricWF Subscribers: mgorny, christof, jkorous, dexonsmith, jfb, mstorsjo, libcxx-commits Tags: #libc Differential Revision: https://reviews.llvm.org/D60969
Change Type	Path in Repository	Path in Workspace
	/libcxx/trunk/benchmarks/CMakeLists.txt	trunk/benchmarks/CMakeLists.txt
	/libcxx/trunk/cmake/Modules/HandleLibcxxFlags.cmake	trunk/cmake/Modules/HandleLibcxxFlags.cmake
	/libcxx/trunk/lib/CMakeLists.txt	trunk/lib/CMakeLists.txt

Change Type	Path in Repository	Path in Workspace
Revision 359640 by echristo: Make some comments that were meant to be for public documentation actually public documentation (i.e. // -> ///).
	/llvm/trunk/include/llvm/Passes/PassBuilder.h	trunk/include/llvm/Passes/PassBuilder.h
Revision 359639 by maskray: [llvm-objcopy] Simplify SHT_NOBITS -> SHT_PROGBITS promotion GNU objcopy uses bfd_elf_get_default_section_type to decide the candidate section type, which roughly translates to our [a] (I assume SEC_COMMON implies SHF_ALLOC): (!(Sec.Flags & ELF::SHF_ALLOC) \|\| Flags & (SectionFlag::SecContents \| SectionFlag::SecLoad))) Then, it updates the section type in bfd/elf.c:elf_fake_sections if: if (this_hdr->sh_type == SHT_NULL) this_hdr->sh_type = sh_type; // common case else if (this_hdr->sh_type == SHT_NOBITS && sh_type == SHT_PROGBITS && (asect->flags & SEC_ALLOC) != 0) // uncommon case ... this_hdr->sh_type = sh_type; If the following condition is met the uncommon branch is executed: if (elf_section_type (osec) == SHT_NULL && (osec->flags == isec->flags \|\| (final_link && ((osec->flags ^ isec->flags) & ~(SEC_LINK_ONCE \| SEC_LINK_DUPLICATES \| SEC_RELOC)) == 0))) I suggest we just ignore this clause and follow the common case behavior, which is done in this patch. Rationales to do so: If --set-section-flags is a no-op (osec->flags == isec->flags) (corresponds to the "readonly" test in set-section-flags.test), GNU objcopy will require (Sec.Flags & ELF::SHF_ALLOC). [a] is essentially: Flags & (SectionFlag::SecContents \| SectionFlag::SecLoad) This special case is not really useful. Non-SHF_ALLOC SHT_NOBITS sections do not make much sense and it doesn't matter if they are SHT_NOBITS or SHT_PROGBITS. For all other RUN lines in set-section-flags.test, the new behavior matches GNU objcopy, i.e. this patch improves compatibility. Differential Revision: https://reviews.llvm.org/D60189
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/test/tools/llvm-objcopy/ELF/rename-section-flag.test	trunk/test/tools/llvm-objcopy/ELF/rename-section-flag.test
	/llvm/trunk/test/tools/llvm-objcopy/ELF/set-section-flags.test	trunk/test/tools/llvm-objcopy/ELF/set-section-flags.test
	/llvm/trunk/tools/llvm-objcopy/ELF/ELFObjcopy.cpp	trunk/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
Revision 359637 by nico: gn build: Fix build on macOS after r359570 / r359527
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn	trunk/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
Revision 359635 by nico: gn build: Merge r359626
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/utils/gn/secondary/llvm/lib/ExecutionEngine/Orc/BUILD.gn	trunk/utils/gn/secondary/llvm/lib/ExecutionEngine/Orc/BUILD.gn
Revision 359634 by sbc: [WebAssembly] Update expectations for gcc torture tests This is needed to make the wasm waterfall green again after we land the update to WASI: https://github.com/WebAssembly/waterfall/pull/492 Differential Revision: https://reviews.llvm.org/D61351
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/lib/Target/WebAssembly/known_gcc_test_failures.txt	trunk/lib/Target/WebAssembly/known_gcc_test_failures.txt
Revision 359633 by reames: [InstCombine] Limit a vector demanded elts rule which was producing invalid IR. The demanded elts rules introduced for GEPs in https://reviews.llvm.org/rL356293 replaced vector constants with undefs (by design). It turns out that the LangRef disallows such cases when indexing structs. The right fix is probably to relax the langref requirement, and update other passes to expect the result, but for the moment, limit the transform to avoid compiler crashes. This should fix https://bugs.llvm.org/show_bug.cgi?id=41624.
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp	trunk/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
	/llvm/trunk/test/Transforms/InstCombine/vec_demanded_elts.ll	trunk/test/Transforms/InstCombine/vec_demanded_elts.ll
Revision 359629 by djg: [WebAssembly] Test the "wasm32-wasi" triple Add triple tests for "wasm32-wasi" and "wasm64-wasi", and also remove the "-musl" component from the existing wasm triple tests as we're not using that in practice (WASI libc is derived in part from musl, but it is not fully musl-compatible). Differential Revision: https://reviews.llvm.org/D61334 Reviewer: sbc100
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/unittests/ADT/TripleTest.cpp	trunk/unittests/ADT/TripleTest.cpp
Revision 359627 by asbirlea: [MemorySSA] Invalidate MemorySSA if AA or DT are invalidated. Summary: MemorySSA keeps internal pointers of AA and DT. If these get invalidated, so should MemorySSA. Reviewers: george.burgess.iv, chandlerc Subscribers: jlebar, Prazek, llvm-commits Tags: LLVM Differential Revision: https://reviews.llvm.org/D61043
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/include/llvm/Analysis/MemorySSA.h	trunk/include/llvm/Analysis/MemorySSA.h
	/llvm/trunk/lib/Analysis/MemorySSA.cpp	trunk/lib/Analysis/MemorySSA.cpp
	/llvm/trunk/test/Analysis/MemorySSA/invalidate.ll	trunk/test/Analysis/MemorySSA/invalidate.ll
Revision 359626 by lhames: [ORC] Move SimpleCompiler/ConcurrentIRCompiler definitions into a .cpp file. SimpleCompiler is no longer templated, so there's no reason for this code to be in a header any more.
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileUtils.h	trunk/include/llvm/ExecutionEngine/Orc/CompileUtils.h
	/llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt	trunk/lib/ExecutionEngine/Orc/CMakeLists.txt
	/llvm/trunk/lib/ExecutionEngine/Orc/CompileUtils.cpp	trunk/lib/ExecutionEngine/Orc/CompileUtils.cpp
Revision 359625 by xur: [llvm-profdata] Fix indentation error in docs. NFC.
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/docs/CommandGuide/llvm-profdata.rst	trunk/docs/CommandGuide/llvm-profdata.rst
Revision 359622 by asbirlea: [AliasAnalysis/NewPassManager] Invalidate AAManager less often. Summary: This is a redo of D60914. The objective is to not invalidate AAManager, which is stateless, unless there is an explicit invalidate in one of the AAResults. To achieve this, this patch adds an API to PAC, to check precisely this: is this analysis not invalidated explicitly == is this analysis not abandoned == is this analysis stateless, so preserved without explicitly being marked as preserved by everyone Reviewers: chandlerc Subscribers: mehdi_amini, jlebar, george.burgess.iv, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61284
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/include/llvm/Analysis/AliasAnalysis.h	trunk/include/llvm/Analysis/AliasAnalysis.h
	/llvm/trunk/include/llvm/IR/PassManager.h	trunk/include/llvm/IR/PassManager.h