SuccessChanges

Summary

  1. Perform lvalue conversions on the left of a pseudo-destructor call 'p->~T()'. (details)
  2. llvm-dwarfdump: Exit non-zero on an error path (details)
  3. [mlir][SPIRV] Adding an attribute to capture configuration for cooperative matrix operations. (details)
  4. llvm-symbolizer: Ensure non-zero exit when an error is printed (details)
  5. [AMDGPU] Pre-commit test for D89187 (details)
  6. Fix typeo in attach failed error message. (details)
  7. llvm-symbolizer: Exit non-zero when DWARF parsing errors have been rendered (details)
  8. Fix llvm-symbolizer assembly-based test to require x86 and specify x86 when assembling (details)
  9. Revert "[LLD] Set alignment as part of Characteristics in TLS table." (details)
  10. [LLD] Set alignment as part of Characteristics in TLS table. (details)
Commit 9dbb0886ea799061baf79d4dce3203524a8468cc by richard
Perform lvalue conversions on the left of a pseudo-destructor call 'p->~T()'.

Previously we failed to convert 'p' from array/function to pointer type,
and to represent the load of 'p' in the AST. The latter causes problems
for constant evaluation.
The file was modifiedclang/lib/Sema/SemaExprCXX.cpp
The file was modifiedclang/test/SemaCXX/pseudo-destructors.cpp
The file was modifiedclang/test/SemaCXX/constant-expression-cxx2a.cpp
Commit 5b346fd8c9949109802a34a8e702d31b6b3e1b70 by dblaikie
llvm-dwarfdump: Exit non-zero on an error path
The file was modifiedllvm/test/tools/llvm-dwarfdump/cmdline.test
The file was modifiedllvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
Commit 6d9a72ec80bbf4cfe10c81c944542ca195fc8d02 by ravishankarm
[mlir][SPIRV] Adding an attribute to capture configuration for cooperative matrix operations.

Each hardware that supports SPV_C_CooperativeMatrixNV has a list of
configurations that are supported natively. Add an attribute to
specify the configurations supported to the `spv.target_env`.

Reviewed By: antiagainst, ThomasRaoux

Differential Revision: https://reviews.llvm.org/D89364
The file was modifiedmlir/lib/Dialect/SPIRV/TargetAndABI.cpp
The file was modifiedmlir/test/Dialect/SPIRV/target-and-abi.mlir
The file was modifiedmlir/include/mlir/Dialect/SPIRV/TargetAndABI.td
Commit 338dd138ea4a70b52ab48e0c8aa38ec152b3569a by dblaikie
llvm-symbolizer: Ensure non-zero exit when an error is printed

(this doesn't cover all cases - libDebugInfoDWARF has a default error
handler that prints errors without any exit code handling - I'll be
following up with a patch for that after this)
The file was modifiedllvm/test/DebugInfo/symbolize-macho-universal-unknown-arch.test
The file was modifiedllvm/test/DebugInfo/symbolize-missing-file.test
The file was modifiedllvm/test/tools/llvm-symbolizer/sym.test
The file was modifiedllvm/test/tools/llvm-symbolizer/input-base.test
The file was modifiedllvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
Commit 75357ebc5017ac2f8e2be3fd098b23641a15a487 by carl.ritson
[AMDGPU] Pre-commit test for D89187
The file was addedllvm/test/CodeGen/AMDGPU/sgpr-phys-copy.mir
Commit b19856881c1624df8b667d672193be52dfa23846 by Jason Molenda
Fix typeo in attach failed error message.
<rdar://problem/70296751>
The file was modifiedlldb/tools/debugserver/source/RNBRemote.cpp
Commit a7b209a6d40d77b43a38664b1fe64513587f24c6 by dblaikie
llvm-symbolizer: Exit non-zero when DWARF parsing errors have been rendered
The file was addedllvm/test/tools/llvm-symbolizer/invalid-dwarf.s
The file was modifiedllvm/lib/DebugInfo/Symbolize/Symbolize.cpp
The file was modifiedllvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
The file was modifiedllvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
Commit 1de0199748ef2a20cd146c100ea1b8e6726c4767 by dblaikie
Fix llvm-symbolizer assembly-based test to require x86 and specify x86 when assembling
The file was modifiedllvm/test/tools/llvm-symbolizer/invalid-dwarf.s
Commit f87c98def86be7b737799e9980af2a0b77e9bc28 by me
Revert "[LLD] Set alignment as part of Characteristics in TLS table."

Revert individual wip commits and will instead follow up with a
single commit with all the changes. Makes cherry-picking easier
and will contain all the right tags.

This reverts commit 32a4ad3b6ce6028a371b028cf06fa5feff9534bf.
This reverts commit 7fe13af676678815989a6d0ece684687953245e7.
This reverts commit 51fbc1bef657bb0f5808986555ec3517a84768c4.
This reverts commit f80950a8bb985c082b26534b0e157447bf803935.
This reverts commit 0778cad9f325df4d7b32b22f3dba201a16a0b8fe.
This reverts commit 8b70d527d7ec1c8b9e921177119a0d906ffad4f0.
The file was modifiedllvm/include/llvm/Object/COFF.h
The file was modifiedlld/COFF/Writer.cpp
The file was modifiedlld/test/COFF/tls-alignment-32.ll
The file was modifiedlld/test/COFF/tls-alignment-64.ll
Commit 6a73d6564a3c7d0757692aa93bdef5be0c8f01a5 by me
[LLD] Set alignment as part of Characteristics in TLS table.

Fixes https://bugs.llvm.org/show_bug.cgi?id=46473

LLD wasn't previously specifying any specific alignment in the TLS table's Characteristics field so the loader would just assume the default value (16 bytes). This works most of the time except if you have thread locals that want specific higher alignments (e.g. 32 as in the bug) *even* if they specify an alignment on the thread local. This change updates LLD to take the max alignment from tls section.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D88637
The file was modifiedlld/COFF/Writer.cpp
The file was modifiedllvm/include/llvm/Object/COFF.h
The file was modifiedlld/test/COFF/tls-alignment-64.ll
The file was modifiedlld/test/COFF/tls-alignment-32.ll