AbortedChanges

Summary

  1. Merging r309044, r309071, r309120, r309122, r309140 and r309227 (PR34157) ------------------------------------------------------------------------ r309044 | mgorny | 2017-07-25 15:38:31 -0700 (Tue, 25 Jul 2017) | 14 lines [lit] Fix UnboundLocalError for invalid shtest redirects Replace the incorrect variable reference when invalid redirect is used. This fixes the following issue: File "/usr/src/llvm/utils/lit/lit/TestRunner.py", line 316, in processRedirects raise InternalShellError(cmd, "Unsupported redirect: %r" % (r,)) UnboundLocalError: local variable 'r' referenced before assignment which in turn broke shtest-shell.py and max-failures.py lit tests. The breakage was introduced during refactoring in rL307310. Differential Revision: https://reviews.llvm.org/D35857 ------------------------------------------------------------------------ ------------------------------------------------------------------------ r309071 | rnk | 2017-07-25 18:27:18 -0700 (Tue, 25 Jul 2017) | 1 line [lit] Attempt to fix Python unittest adaptor logic ------------------------------------------------------------------------ ------------------------------------------------------------------------ r309120 | modocache | 2017-07-26 07:59:36 -0700 (Wed, 26 Jul 2017) | 36 lines Revert "[lit] Remove dead code not referenced in the LLVM SVN repo." Summary: This reverts rL306623, which removed `FileBasedTest`, an abstract base class, but did not also remove the usages of that class in the lit unit tests. The revert fixes four test failures in the lit unit test suite. Test plan: As per the instructions in `utils/lit/README.txt`, run the lit unit test suite: ``` utils/lit/lit.py \ --path /path/to/your/llvm/build/bin \ utils/lit/tests ``` Verify that the following tests fail before applying this patch, and pass once the patch is applied: ``` lit :: test-data.py lit :: test-output.py lit :: xunit-output.py ``` In addition, run `check-llvm` to make sure the existing LLVM test suite executes normally. Reviewers: george.karpenkov, mgorny, dlj Reviewed By: mgorny Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D35877 ------------------------------------------------------------------------ ------------------------------------------------------------------------ r309122 | modocache | 2017-07-26 08:02:05 -0700 (Wed, 26 Jul 2017) | 32 lines [lit] Fix type error for parallelism groups Summary: Whereas rL299560 and rL309071 call `parallelism_groups.items()`, under the assumption that `parallelism_groups` is a `dict` type, the default parameter for that attribute is a `list`. Change the default to a `dict` for type correctness. This regression in the unit tests would have been caught if the unit tests were being run continously. It also would have been caught if the lit project used a Python type checker such as `mypy`. Test Plan: As per the instructions in `utils/lit/README.txt`, run the lit unit test suite: ``` utils/lit/lit.py \ --path /path/to/your/llvm/build/bin \ utils/lit/tests ``` Verify that the test `lit :: unit/TestRunner.py` fails before applying this patch, but passes once this patch is applied. Reviewers: mgorny, rnk, rafael Reviewed By: mgorny Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D35878 ------------------------------------------------------------------------ ------------------------------------------------------------------------ r309140 | george.karpenkov | 2017-07-26 10:19:36 -0700 (Wed, 26 Jul 2017) | 3 lines Fix LIT test breakage Differential Revision: https://reviews.llvm.org/D35867 ------------------------------------------------------------------------ ------------------------------------------------------------------------ r309227 | rnk | 2017-07-26 15:57:32 -0700 (Wed, 26 Jul 2017) | 4 lines [lit] Fix race between shtest-shell and max-failures tests Previously these tests would use the same Output directory leading to flaky non-deterministic failures. ------------------------------------------------------------------------
  2. Merging r310704: ------------------------------------------------------------------------ r310704 | smaksimovic | 2017-08-11 04:39:07 -0700 (Fri, 11 Aug 2017) | 8 lines Revert r302670 for the upcoming 5.0.0 release This is causing failures when compiling clang with -O3 as one of the structures used by clang is passed by value and uses the fastcc calling convention. Faliures manifest for stage2 mips build. ------------------------------------------------------------------------
  3. Revert r310074 (see PR34067 #4)
  4. Merging r310700: ------------------------------------------------------------------------ r310700 | yamaguchi | 2017-08-11 02:44:42 -0700 (Fri, 11 Aug 2017) | 11 lines [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes Summary: I thought we should add this information to release notes, because we added a new flag to clang driver. Reviewers: v.g.vassilev, teemperor, ruiu Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D36567 ------------------------------------------------------------------------
  5. Merging r310694: ------------------------------------------------------------------------ r310694 | rsmith | 2017-08-10 20:39:40 -0700 (Thu, 10 Aug 2017) | 2 lines Implement latest feature test macro recommendations, P0096R4. ------------------------------------------------------------------------
  6. Merging r309054: ------------------------------------------------------------------------ r309054 | rsmith | 2017-07-25 16:31:42 -0700 (Tue, 25 Jul 2017) | 2 lines Reorder tests to match latest SD-6 draft. ------------------------------------------------------------------------
  7. Merging r310692: ------------------------------------------------------------------------ r310692 | rsmith | 2017-08-10 20:14:20 -0700 (Thu, 10 Aug 2017) | 2 lines PR33850: Update cxx_dr_status for Clang 5 branch. ------------------------------------------------------------------------
Revision 310730 by hans:
Merging r309044, r309071, r309120, r309122, r309140 and r309227 (PR34157)

------------------------------------------------------------------------
r309044 | mgorny | 2017-07-25 15:38:31 -0700 (Tue, 25 Jul 2017) | 14 lines

[lit] Fix UnboundLocalError for invalid shtest redirects

Replace the incorrect variable reference when invalid redirect is used.
This fixes the following issue:

  File "/usr/src/llvm/utils/lit/lit/TestRunner.py", line 316, in processRedirects
    raise InternalShellError(cmd, "Unsupported redirect: %r" % (r,))
UnboundLocalError: local variable 'r' referenced before assignment

which in turn broke shtest-shell.py and max-failures.py lit tests.

The breakage was introduced during refactoring in rL307310.

Differential Revision: https://reviews.llvm.org/D35857
------------------------------------------------------------------------

------------------------------------------------------------------------
r309071 | rnk | 2017-07-25 18:27:18 -0700 (Tue, 25 Jul 2017) | 1 line

[lit] Attempt to fix Python unittest adaptor logic
------------------------------------------------------------------------

------------------------------------------------------------------------
r309120 | modocache | 2017-07-26 07:59:36 -0700 (Wed, 26 Jul 2017) | 36 lines

Revert "[lit] Remove dead code not referenced in the LLVM SVN repo."

Summary:
This reverts rL306623, which removed `FileBasedTest`, an abstract base class,
but did not also remove the usages of that class in the lit unit tests.
The revert fixes four test failures in the lit unit test suite.

Test plan:
As per the instructions in `utils/lit/README.txt`, run the lit unit
test suite:

```
utils/lit/lit.py \
    --path /path/to/your/llvm/build/bin \
    utils/lit/tests
```

Verify that the following tests fail before applying this patch, and
pass once the patch is applied:

```
lit :: test-data.py
lit :: test-output.py
lit :: xunit-output.py
```

In addition, run `check-llvm` to make sure the existing LLVM test suite
executes normally.

Reviewers: george.karpenkov, mgorny, dlj

Reviewed By: mgorny

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D35877
------------------------------------------------------------------------

------------------------------------------------------------------------
r309122 | modocache | 2017-07-26 08:02:05 -0700 (Wed, 26 Jul 2017) | 32 lines

[lit] Fix type error for parallelism groups

Summary:
Whereas rL299560 and rL309071 call `parallelism_groups.items()`, under the
assumption that `parallelism_groups` is a `dict` type, the default
parameter for that attribute is a `list`. Change the default to a
`dict` for type correctness.

This regression in the unit tests would have been caught if the
unit tests were being run continously. It also would have been caught
if the lit project used a Python type checker such as `mypy`.

Test Plan:
As per the instructions in `utils/lit/README.txt`, run the lit unit
test suite:

```
utils/lit/lit.py \
    --path /path/to/your/llvm/build/bin \
    utils/lit/tests
```

Verify that the test `lit :: unit/TestRunner.py` fails before applying this
patch, but passes once this patch is applied.

Reviewers: mgorny, rnk, rafael

Reviewed By: mgorny

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D35878
------------------------------------------------------------------------

------------------------------------------------------------------------
r309140 | george.karpenkov | 2017-07-26 10:19:36 -0700 (Wed, 26 Jul 2017) | 3 lines

Fix LIT test breakage

Differential Revision: https://reviews.llvm.org/D35867
------------------------------------------------------------------------

------------------------------------------------------------------------
r309227 | rnk | 2017-07-26 15:57:32 -0700 (Wed, 26 Jul 2017) | 4 lines

[lit] Fix race between shtest-shell and max-failures tests

Previously these tests would use the same Output directory leading to
flaky non-deterministic failures.
------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/branches/release_50llvm.src
The file was modified/llvm/branches/release_50/utils/lit/lit/LitConfig.pyllvm.src/utils/lit/lit/LitConfig.py
The file was modified/llvm/branches/release_50/utils/lit/lit/TestRunner.pyllvm.src/utils/lit/lit/TestRunner.py
The file was modified/llvm/branches/release_50/utils/lit/lit/formats/__init__.pyllvm.src/utils/lit/lit/formats/__init__.py
The file was modified/llvm/branches/release_50/utils/lit/lit/formats/base.pyllvm.src/utils/lit/lit/formats/base.py
The file was modified/llvm/branches/release_50/utils/lit/lit/formats/shtest.pyllvm.src/utils/lit/lit/formats/shtest.py
The file was modified/llvm/branches/release_50/utils/lit/lit/run.pyllvm.src/utils/lit/lit/run.py
The file was added/llvm/branches/release_50/utils/lit/tests/Inputs/max-failuresllvm.src/utils/lit/tests/Inputs/max-failures
The file was modified/llvm/branches/release_50/utils/lit/tests/max-failures.pyllvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/branches/release_50/utils/lit/tests/selecting.pyllvm.src/utils/lit/tests/selecting.py
Revision 310728 by hans:
Merging r310704:
------------------------------------------------------------------------
r310704 | smaksimovic | 2017-08-11 04:39:07 -0700 (Fri, 11 Aug 2017) | 8 lines

Revert r302670 for the upcoming 5.0.0 release

This is causing failures when compiling clang with -O3
as one of the structures used by clang is passed by
value and uses the fastcc calling convention.

Faliures manifest for stage2 mips build.

------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_50clang.src
The file was modified/cfe/branches/release_50/lib/CodeGen/TargetInfo.cppclang.src/lib/CodeGen/TargetInfo.cpp
The file was removed/cfe/branches/release_50/test/CodeGen/mips-aggregate-arg.cclang.src/test/CodeGen/mips-aggregate-arg.c
Revision 310726 by hans:
Revert r310074 (see PR34067 #4)
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_50clang.src
The file was modified/cfe/branches/release_50/include/clang/Driver/Options.tdclang.src/include/clang/Driver/Options.td
The file was modified/cfe/branches/release_50/lib/Basic/Targets.cppclang.src/lib/Basic/Targets.cpp
The file was modified/cfe/branches/release_50/lib/Driver/ToolChains/Arch/Mips.cppclang.src/lib/Driver/ToolChains/Arch/Mips.cpp
The file was added/cfe/branches/release_50/test/CodeGen/mips-madd4.cclang.src/test/CodeGen/mips-madd4.c
The file was modified/cfe/branches/release_50/test/Preprocessor/init.cclang.src/test/Preprocessor/init.c
Revision 310723 by hans:
Merging r310700:
------------------------------------------------------------------------
r310700 | yamaguchi | 2017-08-11 02:44:42 -0700 (Fri, 11 Aug 2017) | 11 lines

[Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

Summary:
I thought we should add this information to release notes, because we
added a new flag to clang driver.

Reviewers: v.g.vassilev, teemperor, ruiu

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D36567
------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_50clang.src
The file was modified/cfe/branches/release_50/docs/ReleaseNotes.rstclang.src/docs/ReleaseNotes.rst
Revision 310722 by hans:
Merging r310694:
------------------------------------------------------------------------
r310694 | rsmith | 2017-08-10 20:39:40 -0700 (Thu, 10 Aug 2017) | 2 lines

Implement latest feature test macro recommendations, P0096R4.

------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_50clang.src
The file was modified/cfe/branches/release_50/lib/Frontend/InitPreprocessor.cppclang.src/lib/Frontend/InitPreprocessor.cpp
The file was modified/cfe/branches/release_50/test/Lexer/cxx-features.cppclang.src/test/Lexer/cxx-features.cpp
The file was modified/cfe/branches/release_50/www/cxx_status.htmlclang.src/www/cxx_status.html
Revision 310721 by hans:
Merging r309054:
------------------------------------------------------------------------
r309054 | rsmith | 2017-07-25 16:31:42 -0700 (Tue, 25 Jul 2017) | 2 lines

Reorder tests to match latest SD-6 draft.

------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_50clang.src
The file was modified/cfe/branches/release_50/test/Lexer/cxx-features.cppclang.src/test/Lexer/cxx-features.cpp
Revision 310720 by hans:
Merging r310692:
------------------------------------------------------------------------
r310692 | rsmith | 2017-08-10 20:14:20 -0700 (Thu, 10 Aug 2017) | 2 lines

PR33850: Update cxx_dr_status for Clang 5 branch.

------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_50clang.src
The file was modified/cfe/branches/release_50/test/CXX/drs/dr20xx.cppclang.src/test/CXX/drs/dr20xx.cpp
The file was modified/cfe/branches/release_50/test/CXX/drs/dr4xx.cppclang.src/test/CXX/drs/dr4xx.cpp
The file was modified/cfe/branches/release_50/www/cxx_dr_status.htmlclang.src/www/cxx_dr_status.html
The file was modified/cfe/branches/release_50/www/make_cxx_dr_statusclang.src/www/make_cxx_dr_status