FailedChanges

Summary

  1. [flang] Descriptor-based I/O using wrong size for contiguous unformatted I/O (details)
  2. [llvm-install-name-tool] Add more documentation (details)
  3. [BPI] Improve static heuristics for integer comparisons (details)
  4. [llvm-libtool-darwin] Refactor ArchiveWriter (details)
  5. [flang][openacc] Handle optional end directive in combined construct (details)
  6. [llvm-libtool-darwin] Add support for -arch_only (details)
  7. [JITLink][MachO] Return an error when MachO TLV relocations are encountered. (details)
  8. [llvm-jitlink] Don't demote unreferenced definitions in -harness mode. (details)
  9. [Diagnostics] Skip var decl of structs for -Wstring-concatenation (details)
  10. [Tests] Removed debug copy command (details)
  11. Fix PR45442: Bail out when MemorySSA information is not available (details)
  12. [AMDGPU] Fix misleading SDWA verifier error. NFC. (details)
  13. [AMDGPU] Inhibit SDWA if target instruction has FI (details)
  14. Revert "[llvm-jitlink] Don't demote unreferenced definitions in -harness mode." (details)
  15. [elfabi] Move llvm-elfabi related code to InterfaceStub library (details)
  16. [LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() (details)
  17. [ORC] Fix SymbolLookupSet::containsDuplicates() (details)
  18. [ORC] cloneToNewContext() can work with a const-ref to ThreadSafeModule (details)
  19. [mlir][DialectConversion] Update the documentation for dialect conversion (details)
  20. [mlir][docs] Update/Add documentation for MLIRs Pattern Rewrite infrastructure (details)
  21. [darwin][driver] fix isMacosxVersionLT minimum supported OS version check (details)
Commit 5c9aca1e9396c54151b066189748209554230b59 by pklausler
[flang] Descriptor-based I/O using wrong size for contiguous unformatted I/O

The descriptor-based I/O routine was using the size of the descriptor
rather than the size of the described data for the transfer.  Fix,
and add a comment to the relevant API.

Differential Revision: https://reviews.llvm.org/D85863
The file was modifiedflang/runtime/descriptor-io.h
The file was modifiedflang/runtime/descriptor.h
Commit 612b4dda7667284f81eec0d3447356e88a87f350 by sameerarora101
[llvm-install-name-tool] Add more documentation

Add documentation for the remaining options of
`llvm-install-name-tool`.

Reviewed by jhenderson, smeenai

Differential Revision: https://reviews.llvm.org/D85655
The file was modifiedllvm/docs/CommandGuide/llvm-install-name-tool.rst
Commit 50c743fa713002fe4e0c76d23043e6c1f9e9fe6f by Dávid Bolvanský
[BPI] Improve static heuristics for integer comparisons

Similarly as for pointers, even for integers a == b is usually false.

GCC also uses this heuristic.

Reviewed By: ebrevnov

Differential Revision: https://reviews.llvm.org/D85781
The file was modifiedllvm/test/CodeGen/X86/atomic-unordered.ll
The file was modifiedllvm/test/CodeGen/X86/conditional-tailcall.ll
The file was addedllvm/test/Analysis/BranchProbabilityInfo/integer_heuristics.ll
The file was modifiedllvm/test/CodeGen/ARM/2011-12-14-machine-sink.ll
The file was modifiedllvm/test/CodeGen/Thumb2/thumb2-branch.ll
The file was modifiedllvm/test/CodeGen/AArch64/aarch64-gep-opt.ll
The file was modifiedllvm/test/CodeGen/X86/conditional-tailcall-pgso.ll
The file was modifiedllvm/test/CodeGen/ARM/machine-cse-cmp.ll
The file was removedllvm/test/Analysis/BranchProbabilityInfo/zero_heuristics.ll
The file was modifiedllvm/test/CodeGen/PowerPC/brcond.ll
The file was modifiedllvm/test/CodeGen/Hexagon/newvaluejump2.ll
The file was modifiedllvm/test/CodeGen/SystemZ/int-cmp-40.ll
The file was modifiedllvm/test/CodeGen/X86/funnel-shift.ll
The file was modifiedllvm/test/CodeGen/X86/wide-integer-cmp.ll
The file was modifiedllvm/test/CodeGen/SystemZ/int-cmp-37.ll
The file was modifiedllvm/test/Analysis/BranchProbabilityInfo/loop.ll
The file was modifiedllvm/include/llvm/Analysis/BranchProbabilityInfo.h
The file was modifiedllvm/test/CodeGen/AArch64/combine-comparisons-by-cse.ll
The file was modifiedllvm/test/CodeGen/RISCV/branch.ll
The file was modifiedllvm/lib/Analysis/BranchProbabilityInfo.cpp
The file was modifiedllvm/test/CodeGen/RISCV/rv64m-w-insts-legalization.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/mve-float-loops.ll
The file was modifiedllvm/test/CodeGen/X86/machine-cse.ll
The file was modifiedllvm/test/CodeGen/Mips/selle.ll
The file was modifiedllvm/test/CodeGen/ARM/lsr-unfolded-offset.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp.ll
The file was modifiedllvm/test/CodeGen/X86/atomic-flags.ll
The file was modifiedllvm/test/CodeGen/X86/pr29170.ll
The file was modifiedllvm/test/CodeGen/X86/fast-isel-cmp-branch2.ll
The file was modifiedllvm/test/CodeGen/Mips/seleq.ll
The file was modifiedllvm/test/CodeGen/X86/indirect-branch-tracking-eh2.ll
The file was modifiedllvm/test/CodeGen/AArch64/fast-isel-cmp-branch.ll
The file was modifiedllvm/test/CodeGen/Mips/brconne.ll
The file was modifiedllvm/test/CodeGen/Mips/lcb5.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-satmul-loops.ll
The file was modifiedllvm/test/CodeGen/X86/3addr-16bit.ll
The file was modifiedllvm/test/CodeGen/X86/bmi.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp-pgso.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp-more-load-pairs.ll
The file was modifiedllvm/test/CodeGen/Mips/lcb2.ll
The file was modifiedllvm/test/CodeGen/Mips/brconlt.ll
The file was modifiedllvm/test/CodeGen/X86/nobt.ll
The file was modifiedllvm/test/CodeGen/ARM/cmpxchg-weak.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp-optsize.ll
The file was modifiedllvm/test/CodeGen/PowerPC/redundant-copy-after-tail-dup.ll
The file was modifiedllvm/test/CodeGen/X86/neg_cmp.ll
The file was modifiedcompiler-rt/test/profile/Linux/counter_promo_while.c
The file was modifiedllvm/test/CodeGen/X86/absolute-cmp.ll
The file was modifiedllvm/test/Transforms/PGOProfile/landingpad.ll
The file was modifiedllvm/test/CodeGen/X86/lsr-negative-stride.ll
The file was modifiedllvm/test/CodeGen/Mips/compactbranches/no-beqzc-bnezc.ll
The file was modifiedllvm/test/CodeGen/PowerPC/memCmpUsedInZeroEqualityComparison.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-postinc-lsr.ll
The file was modifiedllvm/test/CodeGen/AArch64/branch-relax-alignment.ll
The file was modifiedllvm/test/CodeGen/X86/bt.ll
The file was modifiedcompiler-rt/test/profile/Linux/counter_promo_for.c
The file was modifiedllvm/test/CodeGen/Mips/brcongt.ll
The file was modifiedllvm/test/CodeGen/Mips/longbranch/compact-branches-long-branch.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-postinc-distribute.ll
The file was modifiedllvm/test/DebugInfo/COFF/fpo-shrink-wrap.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/varying-outer-2d-reduction.ll
The file was modifiedllvm/test/Transforms/PGOProfile/counter_promo_mexits.ll
The file was modifiedllvm/test/CodeGen/X86/jump_sign.ll
The file was modifiedllvm/test/CodeGen/AArch64/cond-br-tuning.ll
Commit 8d58eb11f9dabacc37f1f5e2cc83149b24868180 by sameerarora101
[llvm-libtool-darwin] Refactor ArchiveWriter

Refactoring function `writeArchive` in ArchiveWriter. Added a new
function `writeArchiveBuffer` that returns the archive in a memory
buffer instead of writing it out to the disk. This refactor is necessary
so as to allow `llvm-libtool-darwin` to write universal files containing
archives.

Reviewed by jhenderson, MaskRay, smeenai

Differential Revision: https://reviews.llvm.org/D84858
The file was modifiedllvm/lib/Object/ArchiveWriter.cpp
The file was modifiedllvm/include/llvm/Object/ArchiveWriter.h
Commit 05169af5cea2c3b9aa0f38354d0e81ddf6b7a3d9 by clementval
[flang][openacc] Handle optional end directive in combined construct

OpenACC combined construct can have an optional end directive. This patch handle this
case in the parsing/unparsing with a canonicalization step. Unlike OmpEndLoopDirective,
this doesn't need a special treatment in the pre-fir tree as there is no clause attached to
a AccEndCombinedDirective.

Reviewed By: klausler

Differential Revision: https://reviews.llvm.org/D84481
The file was modifiedflang/lib/Parser/type-parsers.h
The file was modifiedflang/lib/Semantics/canonicalize-acc.cpp
The file was modifiedflang/lib/Parser/program-parsers.cpp
The file was modifiedflang/include/flang/Parser/parse-tree.h
The file was addedflang/test/Semantics/acc-canonicalization-validity.f90
The file was modifiedflang/test/Semantics/acc-clause-validity.f90
The file was modifiedflang/lib/Parser/unparse.cpp
The file was modifiedflang/lib/Semantics/check-acc-structure.cpp
The file was modifiedflang/lib/Parser/executable-parsers.cpp
The file was modifiedflang/lib/Parser/openacc-parsers.cpp
The file was modifiedflang/test/Lower/pre-fir-tree05.f90
Commit bd2853f7998d41e0d16c00e2b043e35b688eaf00 by sameerarora101
[llvm-libtool-darwin] Add support for -arch_only

Add support for -arch_only option for llvm-libtool-darwin. This diff
also adds support for accepting universal files as input and flattening
them to create the required static library. Supports input universal
files contaning both Mach-O object files or archives.

Differences from cctools' libtool:
- `-arch_only` can be specified multiple times
- archives containing universal files are considered invalid (libtool
allows such archives)

Reviewed by jhenderson, smeenai

Differential Revision: https://reviews.llvm.org/D84770
The file was modifiedllvm/docs/CommandGuide/llvm-libtool-darwin.rst
The file was modifiedllvm/tools/llvm-libtool-darwin/CMakeLists.txt
The file was modifiedllvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp
The file was addedllvm/test/tools/llvm-libtool-darwin/universal-file-flattening.test
The file was addedllvm/test/tools/llvm-libtool-darwin/cpu-subtype-matching.test
The file was modifiedllvm/tools/llvm-libtool-darwin/LLVMBuild.txt
Commit adaadbfeac98ab9d5ce34b8bb2ceedddc5dc1fd4 by Lang Hames
[JITLink][MachO] Return an error when MachO TLV relocations are encountered.

MachO TLV relocations aren't supported yet. Error out rather than falling
through to llvm_unreachable.
The file was modifiedllvm/lib/ExecutionEngine/JITLink/MachO_x86_64.cpp
Commit e137b550587a85b0d9c9c539edc79de0122b6946 by Lang Hames
[llvm-jitlink] Don't demote unreferenced definitions in -harness mode.

Demoting unreferenced externals is unsafe if multiple interdependent test
objects are used, including objects loaded from archives.
The file was modifiedllvm/tools/llvm-jitlink/llvm-jitlink.cpp
Commit 2f7adf5ee37934ee5769276644fcafbc9d4dcda3 by Dávid Bolvanský
[Diagnostics] Skip var decl of structs for -Wstring-concatenation
The file was modifiedclang/lib/Sema/SemaDecl.cpp
The file was modifiedclang/test/Sema/string-concat.c
Commit 3944d3df4f062db1e1fb1deab24e4c40bd5c8095 by Dávid Bolvanský
[Tests] Removed debug copy command
The file was modifiedcompiler-rt/test/profile/Linux/counter_promo_for.c
Commit 1a8c9cd1d96e680a3c519e9b3295ba9c4a34736d by 1894981+hiraditya
Fix PR45442: Bail out when MemorySSA information is not available

Reviewers: sebpop, uabelho, fhahn
Reviewed by: fhahn

Differential Revision: https://reviews.llvm.org/D85881
The file was modifiedllvm/test/Transforms/GVNHoist/pr45442.ll
The file was modifiedllvm/lib/Transforms/Scalar/GVNHoist.cpp
Commit d25cb5a8a23ec9192e32a318eb565e956b87f553 by Stanislav.Mekhanoshin
[AMDGPU] Fix misleading SDWA verifier error. NFC.

The old error from GFX9 shall be updated to GFX9+.
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit 0462aef5f359497b29bc811f94e8d6f7c1f2923e by Stanislav.Mekhanoshin
[AMDGPU] Inhibit SDWA if target instruction has FI

Differential Revision: https://reviews.llvm.org/D85918
The file was addedllvm/test/CodeGen/AMDGPU/sdwa-stack.mir
The file was modifiedllvm/lib/Target/AMDGPU/SIPeepholeSDWA.cpp
Commit 759f9a7acdfc33afd5d8bd1c33446c1b4d721388 by Lang Hames
Revert "[llvm-jitlink] Don't demote unreferenced definitions in -harness mode."

This reverts commit e137b550587a85b0d9c9c539edc79de0122b6946.

This commit broke a test case. Reverting while I investigate.
The file was modifiedllvm/tools/llvm-jitlink/llvm-jitlink.cpp
Commit d650cbc349ccc4f477568c2827f1bce650020058 by haowei
[elfabi] Move llvm-elfabi related code to InterfaceStub library

This change moves elfabi related code to llvm/InterfaceStub library
so it can be shared by multiple llvm tools without causing cyclic
dependencies.

Differential Revision: https://reviews.llvm.org/D85678
The file was addedllvm/include/llvm/InterfaceStub/TBEHandler.h
The file was removedllvm/tools/llvm-elfabi/ELFObjHandler.cpp
The file was addedllvm/lib/InterfaceStub/CMakeLists.txt
The file was removedllvm/lib/TextAPI/ELF/TBEHandler.cpp
The file was modifiedllvm/unittests/TextAPI/CMakeLists.txt
The file was removedllvm/unittests/TextAPI/ELFYAMLTest.cpp
The file was modifiedllvm/lib/TextAPI/CMakeLists.txt
The file was modifiedllvm/tools/llvm-elfabi/CMakeLists.txt
The file was modifiedllvm/lib/CMakeLists.txt
The file was modifiedllvm/tools/llvm-elfabi/LLVMBuild.txt
The file was addedllvm/lib/InterfaceStub/LLVMBuild.txt
The file was modifiedllvm/tools/llvm-elfabi/llvm-elfabi.cpp
The file was addedllvm/unittests/InterfaceStub/CMakeLists.txt
The file was removedllvm/include/llvm/TextAPI/ELF/ELFStub.h
The file was modifiedllvm/lib/LLVMBuild.txt
The file was addedllvm/include/llvm/InterfaceStub/ELFObjHandler.h
The file was removedllvm/tools/llvm-elfabi/ELFObjHandler.h
The file was addedllvm/lib/InterfaceStub/TBEHandler.cpp
The file was addedllvm/include/llvm/InterfaceStub/ELFStub.h
The file was addedllvm/unittests/InterfaceStub/ELFYAMLTest.cpp
The file was addedllvm/lib/InterfaceStub/ELFObjHandler.cpp
The file was removedllvm/lib/TextAPI/ELF/ELFStub.cpp
The file was modifiedllvm/unittests/CMakeLists.txt
The file was removedllvm/include/llvm/TextAPI/ELF/TBEHandler.h
The file was addedllvm/lib/InterfaceStub/ELFStub.cpp
Commit 25bbceb047a3ce85394d510a16bd3fcfd69b8c75 by shafik
[LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

When bit-field data was stored in a Scalar in ValueObjectChild during UpdateValue()
it was extracting the bit-field value. Later on in lldb_private::DumpDataExtractor(…)
we were again attempting to extract the bit-field. Which would then not obtain the
correct value. This will remove the extra extraction in UpdateValue().
We hit this specific case when values are passed in registers, which we could only
reproduce in an optimized build.

Differential Revision: https://reviews.llvm.org/D85376
The file was addedlldb/test/Shell/SymbolFile/DWARF/DW_AT_data_bit_offset-DW_OP_stack_value.s
The file was modifiedlldb/source/Core/ValueObjectChild.cpp
Commit 34a5669ccd8b8c4edd35488a5ece407f0ed77601 by Stefan Gränitz
[ORC] Fix SymbolLookupSet::containsDuplicates()
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Core.h
Commit f12db8cf750bb16515ba635143ca34b0c012968a by Stefan Gränitz
[ORC] cloneToNewContext() can work with a const-ref to ThreadSafeModule
The file was modifiedllvm/lib/ExecutionEngine/Orc/ThreadSafeModule.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/ThreadSafeModule.h
Commit fa4b3147e3368f63e27b86ef66cd35f484ceb6d6 by riddleriver
[mlir][DialectConversion] Update the documentation for dialect conversion

This revision updates the documentation for dialect conversion, as many concepts have changed/evolved over time.

Differential Revision: https://reviews.llvm.org/D85167
The file was modifiedmlir/docs/DialectConversion.md
Commit f7a13479b809cdeb9d63d0daa0d6ab61f04d5f7a by riddleriver
[mlir][docs] Update/Add documentation for MLIRs Pattern Rewrite infrastructure

This infrastructure has evolved a lot over the course of MLIRs lifetime, and has never truly been documented outside of rationale or proposals. This revision aims to document the infrastructure and user facing API, with the rationale specific portions moved to the Rationale folder and updated.

Differential Revision: https://reviews.llvm.org/D85260
The file was addedmlir/docs/PatternRewriter.md
The file was modifiedmlir/docs/Tutorials/Toy/Ch-3.md
The file was modifiedmlir/docs/Rationale/MLIRForGraphAlgorithms.md
The file was modifiedmlir/docs/DialectConversion.md
The file was removedmlir/docs/GenericDAGRewriter.md
The file was addedmlir/docs/Rationale/RationaleGenericDAGRewriter.md
Commit c2807b2e56c05080354818c221ed4a35abd8a5c8 by Alex Lorenz
[darwin][driver] fix isMacosxVersionLT minimum supported OS version check

The previous Driver's triple check only worked for -target, but not for -arch -mmacosx-version-min invocations
The file was modifiedclang/test/Driver/macos-apple-silicon-slice-link-libs.cpp
The file was modifiedclang/lib/Driver/ToolChains/Darwin.h
The file was addedclang/test/Driver/macos-apple-silicon-slice-link-libs-darwin-only.cpp