FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [clangd] Add bool return type to Index::refs API. (details)
  2. [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster (details)
  3. SLPVectorizer - make comparison operators + isInSchedulingRegion const (details)
  4. PPCReduceCRLogicals - fix static analyzer warnings. NFC - Fix (details)
  5. Sparc - fix uninitialized variable warnings. NFCI. (details)
  6. Fix uninitialized variable warning. NFCI. (details)
  7. Fix uninitialized variable warning. NFCI. (details)
  8. Fix uninitialized variable warning. NFCI. (details)
  9. PowerPC - fix uninitialized variable warnings. NFCI. (details)
  10. Remove commented out CHECK-NEXT to try and appease (details)
  11. DWARFDebugLoclists: Add an api to get the location lists of a DWARF unit (details)
  12. [InstCombine] propagate fast-math-flags (FMF) to select when inverting (details)
  13. [profile] Factor out logic for mmap'ing merged profile, NFC (details)
  14. Fix comment spelling {addresing -> addressing} (NFC) (details)
  15. [BPF] Add preserve_access_index attribute for record definition (details)
  16. [SLP] reduce code duplication for min/max vs. other reductions; NFCI (details)
  17. [BPF] add missing attribute in (details)
  18. Don't set LLVM_NO_DEAD_STRIP on AIX (details)
  19. Fix typo in DwarfDebug [NFC] (details)
  20. [RISCV] Use compiler-rt if no GCC installation detected (details)
  21. [BPF] fix clang test failure for bpf-attr-preserve-access-index-4.c (details)
  22. [SLP] improve test readability; NFC (details)
Commit 33e882d5ada0b42323be3277816b0817b8e6baa2 by hokein.wu
[clangd] Add bool return type to Index::refs API.
Summary: Similar to fuzzyFind, the bool indicates whether there are more
xref results.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: merge_guards_bot, MaskRay, jkorous, arphaman, kadircet,
usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70139
The file was modifiedclang-tools-extra/clangd/unittests/IndexTests.cpp
The file was modifiedclang-tools-extra/clangd/index/Index.h
The file was modifiedclang-tools-extra/clangd/index/MemIndex.cpp
The file was modifiedclang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
The file was modifiedclang-tools-extra/clangd/index/dex/Dex.cpp
The file was modifiedclang-tools-extra/clangd/index/dex/Dex.h
The file was modifiedclang-tools-extra/clangd/index/Index.cpp
The file was modifiedclang-tools-extra/clangd/index/MemIndex.h
The file was modifiedclang-tools-extra/clangd/index/Merge.h
The file was modifiedclang-tools-extra/clangd/index/Merge.cpp
The file was modifiedclang-tools-extra/clangd/unittests/DexTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/XRefsTests.cpp
Commit 16bdcc809c72c639a2888b6b859dca88453e3c28 by kadircet
[clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster
Summary: Flags that generate output could result in failures when
creating syntax only actions. This patch introduces initial logic for
filtering out those. The first such flag is "save-temps", which saves
intermediate files(bitcode, assembly, etc.) into a specified directory.
Fixes https://github.com/clangd/clangd/issues/191
Reviewers: hokein
Subscribers: ilya-biryukov, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70173
The file was modifiedclang/lib/Tooling/ArgumentsAdjusters.cpp
The file was modifiedclang/unittests/Tooling/ToolingTest.cpp
Commit d1bd5e476b6baeaaa7b5ad3debf4e4ff9bae295e by llvm-dev
SLPVectorizer - make comparison operators + isInSchedulingRegion const
Fixes cppcheck warnings.
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
Commit 66f2ed07468f78768528483ab53afdd3c489172d by llvm-dev
PPCReduceCRLogicals - fix static analyzer warnings. NFC - Fix
uninitialized variable warnings. - Fix null dereference warnings.
The file was modifiedllvm/lib/Target/PowerPC/PPCReduceCRLogicals.cpp
Commit b3be859baa8eb84d1d2a304032c328a54a0d1901 by llvm-dev
Sparc - fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/lib/Target/Sparc/LeonPasses.h
The file was modifiedllvm/lib/Target/Sparc/DelaySlotFiller.cpp
The file was modifiedllvm/lib/Target/Sparc/SparcISelDAGToDAG.cpp
Commit 6ebc5089b2d39493adddb3bd94121ada1f43c16c by llvm-dev
Fix uninitialized variable warning. NFCI.
The file was modifiedllvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.h
Commit 29a5a6eed0fc9e269e3fefdf963e7fd12931568c by llvm-dev
Fix uninitialized variable warning. NFCI.
The file was modifiedllvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
Commit e1670175f2c016e08507939c2cc6ab53857d898c by llvm-dev
Fix uninitialized variable warning. NFCI.
The file was modifiedllvm/lib/Target/SystemZ/SystemZLongBranch.cpp
Commit 86f07e826f4f119fa2c730e3cc3be65f2f898125 by llvm-dev
PowerPC - fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCMachineFunctionInfo.h
The file was modifiedllvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp
Commit e84b7a5fe230e42b8e6fe451369874a773bf1867 by llvm-dev
Remove commented out CHECK-NEXT to try and appease
llvm-clang-x86_64-expensive-checks-win buildbot
The file was modifiedllvm/test/Analysis/GlobalsModRef/intrinsic_addresstaken.ll
Commit 1eea3fa063884e36165d122db32228f307793485 by pavel
DWARFDebugLoclists: Add an api to get the location lists of a DWARF unit
Summary: This avoid the need to duplicate the location lists searching
logic in various users. The "inline location list dumping" code (which
is the only user actually updated to handle DWARF v5 location lists)  is
switched to this method. After adding v4 location list support, I'll
switch other users too.
Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70084
The file was modifiedllvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDie.cpp
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
Commit 3d6b53980ce4ee855484fc8ae6ac3f99c85e48c3 by spatel
[InstCombine] propagate fast-math-flags (FMF) to select when inverting
fcmp+select
As noted by the FIXME comment, this is not correct based on our current
FMF semantics. We should be propagating FMF from the final value in a
sequence (in this case the
'select'). So the behavior even without this patch is wrong, but we did
not allow FMF on 'select' until recently.
But if we do the correct thing right now in this patch, we'll inevitably
introduce regressions because we have not wired up FMF propagation for
'phi' and 'select' in other passes (like SimplifyCFG) or other places in
InstCombine. I'm not seeing a better incremental way to make progress.
That said, the potential extra damage over the existing wrong behavior
from this patch is very limited. AFAIK, the only way to have different
FMF on IR in the same function is if we have LTO inlined IR from 2
modules that were compiled using different fast-math settings.
As seen in the tests, we may actually see some improvements with this
patch because adding the FMF to the 'select' allows matching to min/max
intrinsics that were previously missed (in the common case, the 'fcmp'
and 'select' should have identical FMF to begin with).
Next steps in the transition:
    Make similar changes in instcombine as needed.
   Enable phi-to-select FMF propagation in SimplifyCFG.
   Remove dependencies on fcmp with FMF.
   Deprecate FMF on fcmp.
Differential Revision: https://reviews.llvm.org/D69720
The file was modifiedllvm/test/Transforms/InstCombine/clamp-to-minmax.ll
The file was modifiedllvm/test/Transforms/InstCombine/unordered-fcmp-select.ll
The file was modifiedllvm/test/Transforms/InstCombine/minmax-fp.ll
The file was modifiedllvm/test/Transforms/InstCombine/minmax-fold.ll
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
Commit e7aab320b1f59e077295318b9a152ed25dabe940 by Vedant Kumar
[profile] Factor out logic for mmap'ing merged profile, NFC
Split out the logic to get the size of a merged profile and to do a
compatibility check. This can be shared with both the continuous+merging
mode implementation, as well as the runtime-allocated counters
implementation planned for Fuchsia.
Lifted out of D69586.
Differential Revision: https://reviews.llvm.org/D70135
The file was modifiedcompiler-rt/lib/profile/InstrProfilingFile.c
Commit e5f3760e8c7f859e455a1d487910f25239a84fe7 by matthew.malcomson
Fix comment spelling {addresing -> addressing} (NFC)
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.h
Commit 4e2ce228ae7954a6499fbb8e4995c13ac8b60f9a by yhs
[BPF] Add preserve_access_index attribute for record definition
This is a resubmission for the previous reverted commit 943436040121
with the same subject. This commit fixed the segfault issue and
addressed additional review comments.
This patch introduced a new bpf specific attribute which can be added to
struct or union definition. For example,
struct s { ... } __attribute__((preserve_access_index));
union u { ... } __attribute__((preserve_access_index)); The goal is to
simplify user codes for cases where preserve access index happens for
certain struct/union, so user does not need to use clang
__builtin_preserve_access_index for every members.
The attribute has no effect if -g is not specified.
When the attribute is specified and -g is specified, any member access
defined by that structure or union, including array subscript access and
inner records, will be preserved through
__builtin_preserve_{array,struct,union}_access_index() IR intrinsics,
which will enable relocation generation in bpf backend.
The following is an example to illustrate the usage:
-bash-4.4$ cat t.c
#define __reloc__ __attribute__((preserve_access_index))
struct s1 {
   int c;
} __reloc__;
  struct s2 {
   union {
     struct s1 b[3];
   };
} __reloc__;
  struct s3 {
   struct s2 a;
} __reloc__;
  int test(struct s3 *arg) {
   return arg->a.b[2].c;
}
-bash-4.4$ clang -target bpf -g -S -O2 t.c
A relocation with access string "0:0:0:0:2:0" will be generated
representing access offset of arg->a.b[2].c.
forward declaration with attribute is also handled properly such that
the attribute is copied and populated in real record definition.
Differential Revision: https://reviews.llvm.org/D69759
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-2.c
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-5.c
The file was addedclang/test/Sema/bpf-attr-preserve-access-index.c
The file was modifiedclang/lib/CodeGen/CGExpr.cpp
The file was modifiedclang/include/clang/Basic/AttrDocs.td
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-3.c
The file was modifiedclang/lib/Sema/SemaDeclAttr.cpp
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-1.c
The file was modifiedclang/include/clang/Basic/Attr.td
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-8.c
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-4.c
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-6.c
The file was addedclang/test/CodeGen/bpf-attr-preserve-access-index-7.c
Commit e9bf7a60a03640e46642509947ec0b479efb8e88 by spatel
[SLP] reduce code duplication for min/max vs. other reductions; NFCI
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
Commit f5824799f612d9d3f19470a60533c2872bcc096b by yhs
[BPF] add missing attribute in
pragma-attribute-supported-attributes-list.test
Add the newly supported BPF specific
__attribute__((preserve_access_index) in the
pragma-attribute-supported-attributes-list.test.
The file was modifiedclang/test/Misc/pragma-attribute-supported-attributes-list.test
Commit 8b2b2c08d9945d1613ee2ce8923e0041bbb4c266 by daltenty
Don't set LLVM_NO_DEAD_STRIP on AIX
Summary: when building plugins, as AIX has symbols in it's standard
library that must be garbage collected or we will see link errors.
Export lists will handle this instead on AIX.
Reviewers: stevewan, sfertile, jasonliu, xingxue, DiggerLin
Reviewed By: DiggerLin
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70130
The file was modifiedllvm/cmake/modules/AddLLVM.cmake
Commit 7417cc149beebc2ce90abf2d60ac2b1e9867575c by david.stenberg
Fix typo in DwarfDebug [NFC]
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Commit 3289352e6bb9d2949c678c625478024bf2a5fbfb by ed.jones
[RISCV] Use compiler-rt if no GCC installation detected
If a GCC installation is not detected, then this attempts to use
compiler-rt and the compiler-rt crtbegin/crtend implementations as a
fallback.
Differential Revision: https://reviews.llvm.org/D68407
The file was modifiedclang/test/Driver/riscv64-toolchain-extra.c
The file was removedclang/test/Driver/Inputs/basic_riscv32_nogcc_tree/riscv32-unknown-elf/lib/crtbegin.o
The file was removedclang/test/Driver/Inputs/basic_riscv32_nogcc_tree/riscv32-unknown-elf/lib/crtend.o
The file was removedclang/test/Driver/Inputs/basic_riscv64_nogcc_tree/riscv64-unknown-elf/lib/crtbegin.o
The file was modifiedclang/test/Driver/riscv32-toolchain-extra.c
The file was modifiedclang/lib/Driver/ToolChains/RISCVToolchain.cpp
The file was removedclang/test/Driver/Inputs/basic_riscv64_nogcc_tree/riscv64-unknown-elf/lib/crtend.o
The file was modifiedclang/lib/Driver/ToolChains/RISCVToolchain.h
Commit 1583158042a7e1f8b4f5194b1db362328e6902f3 by yhs
[BPF] fix clang test failure for bpf-attr-preserve-access-index-4.c
Depending on different cmake configures, clang may generate different IR
name for slot variables. Let us use the regex instead of hard coding the
name. I did the same for other bpf-attr-preserve-access-index tests with
such an approach, but somehow did not do for this one.
The file was modifiedclang/test/CodeGen/bpf-attr-preserve-access-index-4.c
Commit 142cbe73e9fe834e6abaf2d709b4a429ca3a9c44 by spatel
[SLP] improve test readability; NFC
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/reduction.ll