Changes from Git (git http://labmaster3.local/git/llvm-project.git)


  1. [LLDB] On Windows, force error message formatting to English (details)
  2. [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (details)
  3. [IVDescriptors] Skip FOR where we have multiple sink points for now. (details)
  4. [mips] Check that features required by built-ins are enabled (details)
  5. [ORC][JITLink] Add support for weak references, and improve handling of (details)
  6. [LegacyPassManager] Simplify PMStack pop (details)
  7. [Clang] Bypass distro detection on non-Linux hosts (details)
  8. [LegacyPassManager] Simplify FunctionPass::assignPassManager (details)
  9. [OpenMP] build offload plugins before testing them (details)
Commit bdad3ec75ab35ade2433b1278689d483dcf9abc4 by alexandre.ganea
[LLDB] On Windows, force error message formatting to English
This fixes the Utility/StatusTest.ErrorWin32 unit test on non-English
Differential Revision:
The file was modifiedlldb/source/Utility/Status.cpp
Commit c671639af6a96c31d3c0e5487051bef28bad1640 by kkleine
[lldb] NFC: refactor CompileUnit::ResolveSymbolContext
Summary: I found the above named method hard to read because it had
a) many nested blocks, b) one return statement at the end with some
logic involved, c) a duplicated while-loop with just small differences
in it.
I decided to refactor this function by employing an early exit strategy.
In order to capture the logic in the return statement and to not have it
repeated more than once I chose to implement a very small lamda function
that captures all the variables it needs. I also replaced the two
while-loops with just one.
This is a non-functional change (NFC).
Reviewers: jdoerfert, teemperor
Reviewed By: teemperor
Subscribers: labath, teemperor, lldb-commits
Tags: #lldb
Differential Revision:
The file was modifiedlldb/include/lldb/Symbol/CompileUnit.h
The file was modifiedlldb/source/Symbol/CompileUnit.cpp
The file was modifiedlldb/source/Core/AddressResolverFileLine.cpp
The file was modifiedlldb/source/API/SBThread.cpp
Commit ec3efcf11ff2fcdb5a754e3bda942dd5bef0928e by florian_hahn
[IVDescriptors] Skip FOR where we have multiple sink points for now.
This fixes a crash with instructions where multiple operands are
The file was modifiedllvm/lib/Analysis/IVDescriptors.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll
Commit f4d32ae75bf515f443a2c99dce5c882f460c82bd by simon
[mips] Check that features required by built-ins are enabled
Now Clang does not check that features required by built-in functions
are enabled. That causes errors in the backend reported in PR44018.
This patch fixes this bug by checking that required features are
This should fix PR44018.
Differential Revision:
The file was modifiedclang/include/clang/Sema/Sema.h
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/include/clang/Basic/
The file was modifiedclang/test/CodeGen/builtins-mips-args.c
The file was modifiedclang/test/CodeGen/builtins-mips.c
The file was modifiedclang/lib/Basic/Targets/Mips.cpp
The file was addedclang/test/Sema/builtins-mips-features.c
Commit 674df13b5fa7ffbd273455d547eff4507a2fcaff by Lang Hames
[ORC][JITLink] Add support for weak references, and improve handling of
static libraries.
This patch substantially updates ORCv2's lookup API in order to support
weak references, and to better support static archives. Key changes:
-- Each symbol being looked for is now associated with a
  value. If the associated value is SymbolLookupFlags::RequiredSymbol
  the symbol must be defined in one of the JITDylibs being searched (or
  able to be generated in one of these JITDylibs via an attached
  generator) or the lookup will fail with an error. If the associated
value is
  SymbolLookupFlags::WeaklyReferencedSymbol then the symbol is permitted
to be
  undefined, in which case it will simply not appear in the resulting
  SymbolMap if the rest of the lookup succeeds.
   Since lookup now requires these flags for each symbol, the lookup
method now
  takes an instance of a new SymbolLookupSet type rather than a
  SymbolLookupSet is a vector-backed set of (name, flags) pairs. Clients
  responsible for ensuring that the set property (i.e. unique elements)
  though this is usually simple and SymbolLookupSet provides convenience
  methods to support this.
-- Lookups now have an associated LookupKind value, which is either
  LookupKind::Static or LookupKind::DLSym. Definition generators can
  the lookup kind when determining whether or not to generate new
  The StaticLibraryDefinitionGenerator is updated to only pull in new
  from the archive if the lookup kind is Static. This allows lookup to
  re-used to emulate dlsym for JIT'd symbols without pulling in new
  from archives (which would not happen in a normal dlsym call).
-- JITLink is updated to allow externals to be assigned weak linkage,
  weak externals now use the SymbolLookupFlags::WeaklyReferencedSymbol
  for lookups. Unresolved weak references will be assigned the default
value of
Since this patch was modifying the lookup API anyway, it alo replaces
all of the
"MatchNonExported" boolean arguments with a "JITDylibLookupFlags" enum
for readability. If a JITDylib's associated value is
JITDylibLookupFlags::MatchExportedSymbolsOnly then the lookup will only
match against exported (non-hidden) symbols in that JITDylib. If a
JITDylib's associated value is JITDylibLookupFlags::MatchAllSymbols then
the lookup will match against any symbol defined in the JITDylib.
The file was modifiedllvm/lib/ExecutionEngine/JITLink/JITLink.cpp
The file was modifiedllvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Core.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h
The file was addedllvm/test/ExecutionEngine/JITLink/X86/MachO_weak_references.s
The file was modifiedllvm/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp
The file was modifiedllvm/unittests/ExecutionEngine/Orc/LegacyAPIInteropTest.cpp
The file was modifiedllvm/tools/llvm-jitlink/llvm-jitlink.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/LazyReexports.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/IndirectionUtils.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
The file was modifiedllvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Speculation.h
The file was modifiedllvm/lib/ExecutionEngine/Orc/Core.cpp
The file was modifiedllvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/LLJIT.cpp
The file was modifiedllvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h
The file was modifiedllvm/lib/ExecutionEngine/Orc/Legacy.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp
The file was modifiedllvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
Commit a7abe6eac061a999e88d651e4857872f5ec52e5d by maskray
[LegacyPassManager] Simplify PMStack pop
The file was modifiedllvm/lib/IR/LegacyPassManager.cpp
Commit 1abd4c94d7575e4cd288e0024c1ec79f17b048a9 by alexandre.ganea
[Clang] Bypass distro detection on non-Linux hosts
Skip distro detection when we're not running on Linux, or when the
target triple is not Linux. This saves a few OS calls for each
invocation of clang.exe.
Differential Revision:
The file was modifiedclang/unittests/Driver/DistroTest.cpp
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/include/clang/Driver/Distro.h
The file was modifiedclang/lib/Driver/ToolChains/Linux.cpp
The file was modifiedclang/lib/Driver/ToolChains/Cuda.cpp
The file was modifiedclang/lib/Driver/Distro.cpp
Commit 4adddbd8ad4f71e8ce4cb4a38c755b126c5e9eff by maskray
[LegacyPassManager] Simplify FunctionPass::assignPassManager
And make it clear the parameter PreferredType is unused for
The file was modifiedllvm/lib/IR/LegacyPassManager.cpp
Commit 4d3198e243fa450a4109fd72ae1999f1a13570fa by bryan.chan
[OpenMP] build offload plugins before testing them
"make check-all" or "make check-libomptarget" would attempt to run
offloading tests before the offload plugins are built. This patch
corrects that by adding dependencies to the libomptarget CMake rules.
Reviewers: jdoerfert
Subscribers: mgorny, guansong, openmp-commits
Tags: #openmp
Differential Revision:
The file was modifiedopenmp/libomptarget/test/CMakeLists.txt
The file was modifiedopenmp/libomptarget/plugins/CMakeLists.txt
The file was modifiedopenmp/libomptarget/CMakeLists.txt