1. [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit (details)
  2. [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback (details)
  3. [COFF] Wrap definitions in namespace lld { namespace coff {. NFC (details)
  4. [Sanitizers] Porting getrandom/getentropy interceptors to FreeBSD (details)
  5. [UBSan] Appease linter (details)
Commit 067bb1f546efdb9cae33262b684aeb340798ff57 by Raphael Isemann
[lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit
test that function.
Summary: The `if (*cstr_end == '\0')` in the previous code checked if
the previous loop terminated because it found a null terminator or
because it reached the end of the data. However, in the case that we hit
the end of the data before finding a null terminator, `cstr_end` points
behind the last byte in our data and `*cstr_end` reads the memory behind
the array (which may be uninitialised)
This patch just rewrites that function use `std::find` and adds the
relevant unit tests.
Reviewers: labath
Reviewed By: labath
Subscribers: abidh, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision:
llvm-svn: 374311
The file was modifiedlldb/source/Utility/DataExtractor.cpp
The file was modifiedlldb/unittests/Utility/DataExtractorTest.cpp
Commit 95e264fc8a9335acec624c64a8352fb87a0dfa01 by Raphael Isemann
[lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback
Summary: The SearchCallback has a bool parameter that we always set to
false, we never use in any callback implementation and that also changes
its name from one file to the other (either `containing` and
`complete`). It was added in the original LLDB check in, so there isn't
any history what this was supposed to be, so let's just remove it.
Reviewers: jingham, JDevlieghere, labath
Reviewed By: jingham, labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision:
llvm-svn: 374313
The file was modifiedlldb/include/lldb/Core/SearchFilter.h
The file was modifiedlldb/include/lldb/Breakpoint/BreakpointResolverFileRegex.h
The file was modifiedlldb/source/Breakpoint/BreakpointResolverScripted.cpp
The file was modifiedlldb/include/lldb/Breakpoint/BreakpointResolverName.h
The file was modifiedlldb/include/lldb/Breakpoint/BreakpointResolverScripted.h
The file was modifiedlldb/source/Commands/CommandCompletions.cpp
The file was modifiedlldb/source/Core/AddressResolverName.cpp
The file was modifiedlldb/include/lldb/Interpreter/CommandCompletions.h
The file was modifiedlldb/source/Core/SearchFilter.cpp
The file was modifiedlldb/source/Breakpoint/BreakpointResolverFileLine.cpp
The file was modifiedlldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
The file was modifiedlldb/source/Breakpoint/BreakpointResolverAddress.cpp
The file was modifiedlldb/source/Core/AddressResolverFileLine.cpp
The file was modifiedlldb/include/lldb/Breakpoint/BreakpointResolverAddress.h
The file was modifiedlldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h
The file was modifiedlldb/include/lldb/Core/AddressResolverName.h
The file was modifiedlldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h
The file was modifiedlldb/source/Target/LanguageRuntime.cpp
The file was modifiedlldb/source/Breakpoint/BreakpointResolverName.cpp
The file was modifiedlldb/include/lldb/Core/AddressResolverFileLine.h
The file was modifiedlldb/include/lldb/Core/FileLineResolver.h
The file was modifiedlldb/source/Breakpoint/BreakpointResolverFileRegex.cpp
The file was modifiedlldb/source/Core/FileLineResolver.cpp
Commit d79c3be6187248b1a158911dc162f06a86d4c612 by maskray
[COFF] Wrap definitions in namespace lld { namespace coff {. NFC
Similar to D67323, but for COFF. Many lld/COFF/ files already use
`namespace lld { namespace coff {`. Only a few need changing.
Reviewed By: ruiu
Differential Revision:
llvm-svn: 374314
The file was modifiedlld/COFF/PDB.cpp
The file was modifiedlld/COFF/MapFile.cpp
The file was modifiedlld/COFF/Writer.cpp
The file was modifiedlld/COFF/InputFiles.cpp
The file was modifiedlld/COFF/LTO.cpp
The file was modifiedlld/COFF/DebugTypes.cpp
The file was modifiedlld/COFF/MinGW.cpp
Commit 90c8b59cfc6ea5c1b1f6e024c3a31b990b1b0e66 by David CARLIER
[Sanitizers] Porting getrandom/getentropy interceptors to FreeBSD
- Available from 12.x branch, by the time it lands next year in FreeBSD
tree, the 11.x's might be EOL.
- Intentionally changed the getrandom test to C code as with 12.0 (might
be fixed in CURRENT since), there is a linkage issue in C++ context.
Reviewers: emaste, dim, vitalybuka
Reviewed-By: vitalybuka
Differential Revision:
llvm-svn: 374315
The file was removedcompiler-rt/test/sanitizer_common/TestCases/Linux/getrandom.cpp
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h
The file was addedcompiler-rt/test/sanitizer_common/TestCases/Posix/getrandom.c
The file was modifiedcompiler-rt/lib/sanitizer_common/
Commit 6430adbe647a1837c0476f2c9ecc1c0ef5cba14c by lebedev.ri
[UBSan] Appease linter
llvm-svn: 374316
The file was modifiedcompiler-rt/lib/ubsan/