SuccessChanges

Summary

  1. [ScanDeps] clang-format, 80 cols. (details)
  2. ADT: Save a word in every StringSet entry (details)
  3. [lit] Add comment explaining the LIT_OPTS env var overrides command line (details)
  4. [PDB] Fix bug when using multiple PCH header objects with the same name. (details)
  5. [MSVC] Automatically add atlmfc folder to include and libpath. (details)
Commit 2f56266234e55b12437c800327c96a65e305bf08 by bigcheesegs
[ScanDeps] clang-format, 80 cols.
llvm-svn: 374439
The file was modifiedclang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp
Commit aab67b571a3dc984d8990fdb05285c76b11f83d6 by jordan_rose
ADT: Save a word in every StringSet entry
Add a specialization to StringMap (actually StringMapEntry) for a value
type of NoneType (the type of llvm::None), and use it for StringSet.
This'll save us a word from every entry in a StringSet, used for
alignment with the size_t that stores the string length.
I could have gone all the way to some kind of empty base class
optimization, but that seemed like overkill. Someone can consider adding
that in the future, though.
https://reviews.llvm.org/D68586
llvm-svn: 374440
The file was modifiedllvm/lib/LTO/LTOCodeGenerator.cpp
The file was modifiedllvm/include/llvm/ADT/StringSet.h
The file was modifiedllvm/include/llvm/ADT/StringMap.h
The file was modifiedllvm/include/llvm/IR/Metadata.h
The file was modifiedllvm/include/llvm/LTO/legacy/LTOCodeGenerator.h
Commit 3620e8fdb554de622327362ef303a37076044f3a by jlettner
[lit] Add comment explaining the LIT_OPTS env var overrides command line
options
Normally, command line options override environment variables.  Add
comment to state that we are doing the reverse on purpose.
llvm-svn: 374441
The file was modifiedllvm/utils/lit/lit/cl_arguments.py
Commit 02c53868116d9bc5e76400183250772af5807eb9 by zturner
[PDB] Fix bug when using multiple PCH header objects with the same name.
A common pattern in Windows is to have all your precompiled headers use
an object named stdafx.obj.  If you've got a project with many different
static libs, you might use a separate PCH for each one of these.
During the final link step, a file from A might reference the PCH object
from A, but it will have the same name (stdafx.obj) as any other PCH
from another project.  The only difference will be the path.  For
example, A might be A/stdafx.obj while B is B/stdafx.obj.
The existing algorithm checks only the filename that was passed on the
command line (or stored in archive), but this is insufficient in the
case where relative paths are used, because depending on the command
line object file / library order, it might find the wrong PCH object
first resulting in a signature mismatch.
The fix here is to simply check whether the absolute path of the PCH
object (which is stored in the input obj file for the file that
references the PCH) *ends with* the full relative path of whatever is
specified on the command line (or is in the archive).
Differential Revision: https://reviews.llvm.org/D66431
llvm-svn: 374442
The file was modifiedllvm/include/llvm/DebugInfo/PDB/GenericError.h
The file was addedlld/test/COFF/Inputs/precompa/precomp.obj
The file was addedlld/test/COFF/Inputs/precompa/useprecomp.obj
The file was addedlld/test/COFF/Inputs/precompb/precomp.obj
The file was modifiedlld/test/COFF/precomp-link.test
The file was modifiedlld/COFF/PDB.cpp
The file was addedlld/test/COFF/Inputs/precompb/useprecomp.obj
The file was addedlld/test/COFF/precomp-link-samename.test
The file was modifiedllvm/lib/DebugInfo/PDB/GenericError.cpp
Commit 79f243296654fa6089b4529219245fe00f372e5a by zturner
[MSVC] Automatically add atlmfc folder to include and libpath.
Differential Revision: https://reviews.llvm.org/D68736
llvm-svn: 374443
The file was modifiedclang/lib/Driver/ToolChains/MSVC.h
The file was modifiedclang/lib/Driver/ToolChains/MSVC.cpp