SuccessChanges

Summary

  1. Reland r374388: [lit] Make internal diff work in pipelines (details)
  2. Reland r374389: [lit] Clean up internal diff's encoding handling (details)
  3. Reland r374390: [lit] Extend internal diff to support `-` argument (details)
  4. Reland r374392: [lit] Extend internal diff to support -U (details)
  5. [lit] Fix internal diff's --strip-trailing-cr and use it (details)
Commit daf42dc36dc2e1092dc6a14a4bb0bce307de58ba by jdenny.ornl
Reland r374388: [lit] Make internal diff work in pipelines
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D66574
llvm-svn: 374648
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was addedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit e4f11a31927e7ca67ff54897de37ef75e31e05ff by jdenny.ornl
Reland r374389: [lit] Clean up internal diff's encoding handling
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D68664
llvm-svn: 374649
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.bin
Commit 32096a86b240a8f4be64094f58162137a17f72d7 by jdenny.ornl
Reland r374390: [lit] Extend internal diff to support `-` argument
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D67643
llvm-svn: 374650
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
Commit 92a8294f9eda2d9b3f7718cba68269a4fc8eea10 by jdenny.ornl
Reland r374392: [lit] Extend internal diff to support -U
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D68668
llvm-svn: 374651
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 0f80927316c7b12e5c170adec26608dda449497c by jdenny.ornl
[lit] Fix internal diff's --strip-trailing-cr and use it
Using GNU diff, `--strip-trailing-cr` removes a `\r` appearing before a
`\n` at the end of a line.  Without this patch, lit's internal diff only
removes `\r` if it appears as the last character.  That seems useless.
This patch fixes that.
This patch also adds `--strip-trailing-cr` to some tests that fail on
Windows bots when D68664 is applied.  Based on what I see in the bot
logs, I think the following is happening.  In each test there, lit diff
is comparing a file with `\r\n` line endings to a file with `\n` line
endings.  Without D68664, lit diff reads those files with Python's
universal newlines support activated, causing `\r` to be dropped.
However, with D68664, lit diff reads the files in binary mode instead
and thus reports that every line is different, just as GNU diff does (at
least under Ubuntu).  Adding `--strip-trailing-cr` to those tests
restores the previous behavior while permitting the behavior of lit diff
to be more like GNU diff.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D68839
llvm-svn: 374652
The file was modifiedllvm/test/MC/AsmParser/preserve-comments.s
The file was modifiedllvm/test/tools/llvm-profdata/roundtrip.test
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.dos
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txt
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/test/tools/llvm-profdata/profile-symbol-list.test
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.unix
The file was modifiedllvm/test/tools/llvm-cxxmap/remap.test
The file was modifiedllvm/test/tools/llvm-profdata/sample-remap.test