FailedChanges

Summary

  1. Revert r374657: "[lit] Try again to fix new tests that fail on Windows (details)
  2. [lit] Try yet again to fix new tests that fail on Windows bots (details)
  3. [lit] Adjust error handling for decode introduced by r374665 (details)
  4. [X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. (details)
  5. Fix cppcheck shadow variable name warnings. NFCI. (details)
  6. Replace for-loop of SmallVector::push_back with SmallVector::append. (details)
  7. [NFC][LoopIdiom] Adjust FIXME to be self-explanatory (details)
  8. [lit] Try errors="ignore" for decode introduced by r374665 (details)
Commit 8259f7ca120734b6fba0e67ae445492009f9871d by jdenny.ornl
Revert r374657: "[lit] Try again to fix new tests that fail on Windows
bots"
llvm-svn: 374664
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit a271acbf79326da83cab36a02938fc6cd5740b1b by jdenny.ornl
[lit] Try yet again to fix new tests that fail on Windows bots
I seem to have misread the bot logs on my last attempt.  When lit's
internal diff runs on Windows under Python 2.7, it's text diffs not
binary diffs that need decoding to avoid this error when writing the
diff to stdout:
``` UnicodeEncodeError: 'ascii' codec can't encode characters in
position 7-8: ordinal not in range(128)
```
There is no `decode` attribute in this case under Python 3.6.8 under
Ubuntu, so this patch checks for the `decode` attribute before using it
here.  Hopefully nothing else is needed when `decode` isn't available.
It might take a couple more attempts to figure out what error handling,
if any, is needed for this decoding.
llvm-svn: 374665
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 64c00893fae650bdfd1ae05136de3216f70c69b4 by jdenny.ornl
[lit] Adjust error handling for decode introduced by r374665
On that decode, Windows bots fail with:
``` UnicodeEncodeError: 'ascii' codec can't encode characters in
position 7-8: ordinal not in range(128)
```
That's the same error as before r374665 except it's now at the decode
before the write to stdout.
llvm-svn: 374666
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 6446079add805b3e0478f8709a30fd6b0434b4e1 by llvm-dev
[X86] Use any_of/all_of patterns in shuffle mask pattern recognisers.
NFCI.
llvm-svn: 374667
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 37041c7d226621b19492bb54da959f3374658727 by llvm-dev
Fix cppcheck shadow variable name warnings. NFCI.
llvm-svn: 374668
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 66417a9f036d1b653298fae9d541b71cfcfd3447 by llvm-dev
Replace for-loop of SmallVector::push_back with SmallVector::append.
NFCI.
llvm-svn: 374669
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit c8ac97edc899515fe676dea89b828cbd9630e6c1 by lebedev.ri
[NFC][LoopIdiom] Adjust FIXME to be self-explanatory
llvm-svn: 374670
The file was modifiedllvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
Commit 1e98a6c57a0f71b5a5b06c7d6de5f35d89fd102d by jdenny.ornl
[lit] Try errors="ignore" for decode introduced by r374665
Still trying to fix the same error as in r374666.
llvm-svn: 374671
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py