Changes

Fix an unused variable introduced in rL374955 / rG21703543.
Even though this is a unit test, it still may be run under optimization.
llvm-svn: 374961

[libTooling] Put all Transformer declarations in a single namespace.
Summary: This revision introduces a new namespace, `clang::transformer`,
to hold the declarations for the Transformer library.
Reviewers: gribozavr
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68876
llvm-svn: 374962

CodeExtractor: NFC: Use Range based loop
Reviewers: vsk, tejohnson, fhahn
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68924
llvm-svn: 374963

update ScriptInterpreterPython to use File, not FILE*
Summary: ScriptInterpreterPython needs to save and restore sys.stdout
and friends when LLDB runs a python script.
It currently does this using FILE*, which is not optimal.  If whatever
was in sys.stdout can not be represented as a FILE*, then it will not be
restored correctly when the script is finished.
It also means that if the debugger's own output stream is not 
representable as a file, ScriptInterpreterPython will not be able to
redirect python's  output correctly.
This patch updates ScriptInterpreterPython to represent files with 
lldb_private::File, and to represent whatever the user had in sys.stdout
as simply a PythonObject.
This will make lldb interoperate better with other scripts or programs 
that need to manipulate sys.stdout.
Reviewers: JDevlieghere, jasonmolenda, labath
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68962
llvm-svn: 374964

Revert "[ASan] Refine diagnoses messages"
This reverts commit 4d1ecadda59ce82e5fa6e28dd15bf794eee88363.
llvm-svn: 374965

[Concepts] ConceptSpecializationExprs mangling
Implement mangling for CSEs to match regular template-ids. Reviewed as
part of D41569.
llvm-svn: 374967

[libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug
Summary: The workaround added in https://reviews.llvm.org/rL299575
appears to be working around a bug in Android JB 4.1.x and 4.2.x (API 16
and 17).
Starting in API 16, Android added support for PIE binaries, but the 
dynamic linker failed to initialize dlpi_addr to the address that the 
executable was loaded at. The bug was fixed in Android JB 4.3.x (API
18).
Improve the true load bias calculation:
 * The code was assuming that the first segment would be the PT_PHDR
  segment. I think it's better to be explicit and search for PT_PHDR.
(It
  will be almost as fast in practice.)
 * It's more correct to use p_vaddr rather than p_offset. If a PIE
  executable is linked with a non-zero image base (e.g. lld's
  -Wl,--image-base=xxxx), then we must use p_vaddr here.
The "phdr->p_vaddr < image_base" condition seems unnecessary and maybe 
slightly wrong. If the OS were to load a binary at an address smaller
than a vaddr in the binary, we would still want to do this workaround.
The workaround is safe when the linker bug isn't present, because it 
should calculate an image_base equal to dlpi_addr. Note that with API 21 
and up, this workaround should never activate for dynamically-linked 
objects, because non-PIE executables aren't allowed.
Consolidate the fix into a single block of code that calculates the true 
image base, and make it clear that the fix no longer applies after API
18.
See https://github.com/android/ndk/issues/505 for details.
Reviewers: mclow.lists, srhines, danalbert, compnerd
Reviewed By: compnerd
Subscribers: srhines, krytarowski, christof, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D68971
llvm-svn: 374969

[LegalizeTypes] Don't call PromoteTargetBoolean from SplitVecOp_VSETCC.
PromoteTargetBoolean calls getSetccResultType to get the return type.
But we were passing it the setcc result type rather than the setcc input
type. This causes an issue on X86 with avx512vl where the setcc result
type for vXf16 vectors is vXi16 while the result type for vXi16 vectors
is vXi1.
There's really no guarantee that getSetccResultType is the type we need
here. So now we just grab the extend type from getExtendForContent and
extend to the original result VT of the node we're splitting.
llvm-svn: 374970

Fix failing mangle-concept.cpp test.
llvm-svn: 374971

[LegalizeTypes] Don't use PromoteTargetBoolean in WidenVecOp_SETCC.
Similar to r374970, but I don't have a test for this.
PromoteTargetBoolean is intended to be use for legalizing an operand
that needs to be promoted. It picks its type based on the return from
getSetccResultType and is intended to be used when we have freedom to
pick the new type. But the return type we need for WidenVecOp_SETCC is
completely determined by the type of the input node.
llvm-svn: 374972

[CMake] Disable building all Darwin libraries (except builtins) for
macOS i386 when the SDK is >= 10.15.
Summary: In the macOS 10.15 SDK the ability to link i386 binaries was
removed and in the corresponding OS it is not possible to run macOS i386
binaries.
The consequence of these changes meant that targets like `check-asan` 
would fail because:
* Unit tests could not be linked for i386
* Lit tests for i386 would fail due to not being able to execute
 compiled binaries.
The simplest fix to this is to simply disable building for i386 for 
macOS when using the 10.15 SDK (or newer). This disables building the 
i386 slice for most compiler-rt libraries and consequently disables the 
unit and lit tests for macOS i386.
Note that because the `DARWIN_osx_ARCHS` CMake variable is a cache 
variable this patch will have no affect on existing builds unless the
existing cache variable is deleted. The simplest way to deal with this
is delete existing builds and just do a fresh configure.
Note this should not affect the builtins which are managed with the
`DARWIN_osx_BUILTIN_ARCHS` CMake cache variable.
For those who wish to force using a particular set of architectures when 
using newer SDKs passing `-DDARWIN_osx_ARCHS=i386;x86_64;x86_64h` to 
CMake should provide a usable (but completely unsupported) workaround.
rdar://problem/55668535 rdar://problem/47939978
Reviewers: kubamracek, yln, azhar, kcc, dvyukov, vitalybuka, cryptoad,
eugenis, thakis, phosek
Subscribers: mgorny, #sanitizers, llvm-commits
Tags: #llvm, #sanitizers
Differential Revision: https://reviews.llvm.org/D68292
llvm-svn: 374977

[NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap
In LiveDebugVariables.cpp: Prior to this patch, UserValues were grouped
into linked list chains. Each chain was the union of two sets: { A:
Matching Source variable } or
{ B: Matching virtual register }. A ptr to the heads (or 'leaders') of
each of these chains were kept in a map with the { Source variable }
used as the key (set A predicate) and another with { Virtual register }
as key
(set B predicate).
There was a search through the chains in the function getUserValue
looking for UserValues with matching { Source variable, Complex
expression, Inlined-at location }. Essentially searching for a subset of
A through two interleaved linked lists of set A and B. Importantly, by
design, the subset will only contain one or zero elements here. That is
to say a UserValue can be uniquely identified by the tuple { Source
variable, Complex expression, Inlined-at
location } if it exists.
This patch removes the linked list and instead uses a DenseMap to map 
the tuple { Source variable, Complex expression, Inlined-at location } 
to UserValue ptrs so that the getUserValue search predicate is this map
key. The virtual register map now maps a vreg to a SmallVector<UserVal
*> so that set B is still available for quick searches.
Reviewers: aprantl, probinson, vsk, dblaikie
Reviewed By: aprantl
Subscribers: russell.gallop, gbedwell, bjope, hiraditya, llvm-commits
Tags: #debug-info, #llvm
Differential Revision: https://reviews.llvm.org/D68816
llvm-svn: 374979

[HardwareLoops] Optimisation remarks
This adds the initial plumbing to support optimisation remarks in the IR
hardware-loop pass.
I have left a todo in a comment where we can improve the reporting, and
will iterate on that now that we have this initial support in.
Differential Revision: https://reviews.llvm.org/D68579
llvm-svn: 374980

[ARM][ParallelDSP] Change smlad insertion order
Instead of inserting everything after the 'root' of the reduction, 
insert all instructions as close to their operands as possible. This can
help reduce register pressure.
Differential Revision: https://reviews.llvm.org/D67392
llvm-svn: 374981

[clangd] Add RemoveUsingNamespace tweak.
Summary: Removes the 'using namespace' under the cursor and qualifies
all accesses in the current file. E.g.:
 using namespace std;
 vector<int> foo(std::map<int, int>); Would become:
 std::vector<int> foo(std::map<int, int>);
Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, mgrang, arphaman,
kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68562
llvm-svn: 374982

gn build: Merge r374982
llvm-svn: 374983

[AMDGPU] Extend the SI Load/Store optimizer
Summary: Extend the SI Load/Store optimizer to merge MIMG load
instructions. Handle different flavours of image_load and image_sample
instructions.
When the instructions of the same subclass differ only in dmask, merge 
them and update dmask accordingly.
Reviewers: nhaehnle
Reviewed By: nhaehnle
Subscribers: arsenm, kzhuravl, jvesely, wdng, nhaehnle, yaxunl,
dstuttard, tpr, t-tye, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64911
llvm-svn: 374984

Revert 374967 "[Concepts] ConceptSpecializationExprs mangling"
This reverts commit 5e34ad109ced8dbdea9500ee28180315b2aeba3d.
The mangling test fails on Windows: 
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15944
It also fails on ppc64le: 
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/21092
Also revert follow-up  374971 "Fix failing mangle-concept.cpp test."
(it did not help on Win/ppc64le).
llvm-svn: 374985

SimpleLoopUnswitch - fix uninitialized variable and null dereference
warnings. NFCI.
llvm-svn: 374986

CGBuiltin - silence static analyzer getAs<> null dereference warnings.
NFCI.
The static analyzer is warning about potential null dereferences, but in
these cases we should be able to use castAs<> directly and if not assert
will fire for us.
llvm-svn: 374987

CGExprConstant - silence static analyzer getAs<> null dereference
warning. NFCI.
The static analyzer is warning about a potential null dereference, but
in these cases we should be able to use castAs<> directly and if not
assert will fire for us.
llvm-svn: 374988

CGDebugInfo - silence static analyzer dyn_cast<> null dereference
warnings. NFCI.
The static analyzer is warning about potential null dereferences, but in
these cases we should be able to use cast<> directly and if not assert
will fire for us.
llvm-svn: 374989

[ARM] Add a register class for GPR pairs without SP and use it. NFCI
Summary: Currently Thumb2InstrInfo.cpp uses a register class which is 
auto-generated by tablegen. Such approach is fragile because 
auto-generated classes might change when other register classes are 
added. For example, before https://reviews.llvm.org/D62667 we were using
GPRPair_with_gsub_1_in_rGPRRegClass, but had to change it to
GPRPair_with_gsub_1_in_GPRwithAPSRnospRegClass because the former class
stopped being generated (this did not change the functionality though).
This patch adds a register class consisting of even-odd GPR register 
pairs from (R0, R1) to (R10, R11), which excludes (R12, SP) and uses it
in Thumb2InstrInfo.cpp instead of 
GPRPair_with_gsub_1_in_GPRwithAPSRnospRegClass.
Reviewers: ostannard, simon_tatham, dmgreen, efriedma
Reviewed By: simon_tatham
Subscribers: kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69026
llvm-svn: 374990

RewriteModernObjC - silence static analyzer getAs<> null dereference
warnings. NFCI.
The static analyzer is warning about potential null dereferences, but in
these cases we should be able to use castAs<> directly and if not assert
will fire for us.
llvm-svn: 374991

Revert "[HardwareLoops] Optimisation remarks"
while I investigate the PPC build bot failures.
This reverts commit ad763751565b9663bc338fa2ca5ade86c6ca22ec.
llvm-svn: 374992

[InstCombine][AMDGPU] Fix crash with v3i16/v3f16 buffer intrinsics
Summary: This is something of a workaround to avoid a crash later on in
type legalizer (WidenVectorResult()). Also added some f16 tests,
including a non-working v3f16 case with a FIXME.
Reviewers: arsenm, tpr, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr,
t-tye, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68865
llvm-svn: 374993

RealFile - fix self-initialization warning in constructor.
llvm-svn: 374994

RedirectingFileSystem::openFileForRead - replace bitwise & with boolean
&& to fix warning
Seems to be just a typo - now matches other instances which do something
similar
llvm-svn: 374995

Refactored LibcxxAndAbiBuilder to support github.
llvm-svn: 374973

Removed redundant quotation marks from -DLLVM_LIT_ARGS.
llvm-svn: 374975

LLVMBuilfFactory should always have is_legacy_mode attribute.
llvm-svn: 374976