SuccessChanges

Summary

  1. NFC: Fix variable only used in asserts by propagating the value. (details)
  2. Reapply r375051: [support] GlobPattern: add support for `\` and (details)
  3. [Builtins] Provide a mechanism to selectively disable tests based on (details)
  4. [lldb] Don't emit artificial constructor declarations as global (details)
  5. [PowerPC] Turn on CR-Logical reducer pass (details)
  6. [NFC][InstCombine] Some more preparatory cleanup for (details)
Commit 05c3d90248db372083d4314fb74f677837adf01d by saugustine
NFC: Fix variable only used in asserts by propagating the value.
Summary: This fixes builds with assertions disabled that would otherwise
fail with unused variable warnings
Subscribers: nemanjai, hiraditya, kbarton, MaskRay, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69123
llvm-svn: 375148
The file was modifiedllvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
Commit 48993d5ab9413f0e5b94dfa292a233ce55b09e3e by rupprecht
Reapply r375051: [support] GlobPattern: add support for `\` and
`[!...]`, and allow `]` in more places
Reland r375051 (reverted in r375052) after fixing lld tests on Windows
in r375126 and r375131.
Original description: Update GlobPattern in libSupport to handle a few
more cases. It does not fully match the `fnmatch` used by GNU objcopy
since named character classes (e.g. `[[:digit:]]`) are not supported,
but this should support most existing use cases (mostly just `*` is
what's used anyway).
This will be used to implement the `--wildcard` flag in llvm-objcopy to
be more compatible with GNU objcopy.
This is split off of D66613 to land the libSupport changes separately.
The llvm-objcopy part will land soon.
Reviewers: jhenderson, MaskRay, evgeny777, espindola, alexshap
Reviewed By: MaskRay
Subscribers: nickdesaulniers, emaste, arichardson, hiraditya,
jakehehrlich, abrachet, seiya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66613
llvm-svn: 375149
The file was modifiedllvm/lib/Support/GlobPattern.cpp
The file was modifiedllvm/include/llvm/Support/GlobPattern.h
The file was modifiedllvm/unittests/Support/GlobPatternTest.cpp
Commit 5be7eb3ab4da6e89ed23b137e6baaa13a530c9b3 by dan
[Builtins] Provide a mechanism to selectively disable tests based on
whether an implementation is provided by a builtin library.
Summary: If a platform removes some builtin implementations (e.g. via
the Darwin-excludes mechanism) then this can lead to test failures
because the test expects an implementation to be available.
To solve this lit features are added for each configuration based on
which sources are included in the builtin library. The features are of
the form `librt_has_<name>` where `<name>` is the name of the source
file with the file extension removed. This handles C and assembly
sources.
With the lit features in place it is possible to make certain tests
require them.
Example:
``` REQUIRES: librt_has_comparedf2
```
All top-level tests in `test/builtins/Unit` (i.e. not under
`arm`, `ppc`, and `riscv`) have been annotated with the appropriate
`REQUIRES: librt_has_*` statement.
rdar://problem/55520987
Reviewers: beanz, steven_wu, arphaman, dexonsmith, phosek, thakis
Subscribers: mgorny, #sanitizers, llvm-commits
Tags: #llvm, #sanitizers
Differential Revision: https://reviews.llvm.org/D68064
llvm-svn: 375150
The file was modifiedcompiler-rt/test/builtins/Unit/muloti4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/extendhfsf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixsfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/lit.site.cfg.py.in
The file was modifiedcompiler-rt/test/builtins/Unit/udivmoddi4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/unorddf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulsc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/lshrdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixdfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ctzti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/adddf3vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/popcountsi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatsidfvfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatuntitf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/gtsf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/lttf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatundixf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/lesf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulvti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/comparesf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatdidf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/subdf3vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/muldc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/subvsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunssfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/subvdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/extenddftf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulosi4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatuntixf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/udivsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floattixf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/udivmodti4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floattisf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulodi4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/udivmodsi4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixtfsi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/unordsf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsxfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ashlti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floattitf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ucmpti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/cmpti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsxfsi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/truncdfsf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/addvdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/extendsftf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulvsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixdfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunstfsi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/bswapdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsdfsi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixtfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/subvti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/enable_execute_stack_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/getf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixdfsivfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/lshrti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negvti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatuntidf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/modsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/nedf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/netf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/absvdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatdisf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/truncdfhf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunssfsivfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/clzti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/powitf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divsf3vfp_test.c
The file was removedcompiler-rt/test/builtins/Unit/extebdsfdf2vfp_test.c
The file was addedcompiler-rt/test/builtins/Unit/extendsfdf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negvdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/gedf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/clear_cache_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/clzsi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/trunctfdf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divtc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ledf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/eqdf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/addvti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/comparedf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/absvsi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negsf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsdfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatsitf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/lit.cfg.py
The file was modifiedcompiler-rt/test/builtins/Unit/parityti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixtfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/multf3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/paritysi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/gesf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ashldi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/nesf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ashrti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/addsf3vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ffsti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/letf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ffsdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatsisfvfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/gttf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divsc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ltsf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/umoddi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatunditf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/cmpdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divdf3vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ucmpdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divxc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunstfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatunsitf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/multi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/udivti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/modti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatdixf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/gtdf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/cpu_model_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixxfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatundisf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divdc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/powidf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ashrdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/moddi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ctzsi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ltdf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/truncdfsf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/muldf3vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/udivdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ctzdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divdf3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/muldi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ffssi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatunssisfvfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/popcountdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunssfsi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsxfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatunssidfvfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negvsi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/unordtf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulxc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floattidf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/popcountti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/addvsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/umodti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixsfsivfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/eqtf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/eqsf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/umodsi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunssfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixsfdi_test.c
The file was modifiedcompiler-rt/test/builtins/CMakeLists.txt
The file was modifiedcompiler-rt/test/builtins/Unit/divmodsi4_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/multc3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatuntisf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/addtf3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/powisf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/trunctfsf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/paritydi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divtf3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatundidf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/subtf3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/negdf2vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunstfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/powixf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulvdi3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsdfsivfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixxfdi_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/truncsfhf2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/floatditf_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/absvti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/subsf3vfp_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/bswapsi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/clzdi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divsf3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/trampoline_setup_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/divti3_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/fixunsdfti_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/mulsf3vfp_test.c
Commit 6237c9fe6ce966ce366005a55df8c267ea32a064 by Raphael Isemann
[lldb] Don't emit artificial constructor declarations as global
functions
Summary: When we have a artificial constructor DIE, we currently create
from that a global function with the name of that class. That ends up
causing a bunch of funny errors such as "must use 'struct' tag to refer
to type 'Foo' in this scope" when doing `Foo f`. Also causes that
constructing a class via `Foo()` actually just calls that global
function.
The fix is that when we have an artificial method decl, we always treat
it as handled even if we don't create a CXXMethodDecl for it (which we
never do for artificial methods at the moment).
Fixes rdar://55757491 and probably some other radars.
Reviewers: aprantl, vsk, shafik
Reviewed By: aprantl
Subscribers: jingham, shafik, labath, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68130
llvm-svn: 375151
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/main.cpp
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/TestIgnoreArtificialConstructors.py
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/ignore-artificial-constructors/main.cpp
Commit 8a3d7c9cbd305764d1f6c2d42cdd82cf2876b99f by nemanja.i.ibm
[PowerPC] Turn on CR-Logical reducer pass
Quite a while ago, we implemented a pass that will reduce the number of
CR-logical operations we emit. It does so by converting a CR-logical
operation into a branch. We have kept this off by default because it
seemed to cause a significant regression with one benchmark. However,
that regression turned out to be due to a completely unrelated reason -
AADB introducing a self-copy that is a priority-setting nop and it was
just exacerbated by this pass.
Now that we understand the reason for the only degradation, we can turn
this pass on by default. We have long since fixed the cause for the
degradation.
Differential revision: https://reviews.llvm.org/D52431
llvm-svn: 375152
The file was modifiedllvm/test/CodeGen/PowerPC/pr42492.ll
The file was modifiedllvm/test/CodeGen/PowerPC/2008-10-28-f128-i32.ll
The file was modifiedllvm/test/CodeGen/PowerPC/brcond.ll
The file was modifiedllvm/lib/Target/PowerPC/PPCTargetMachine.cpp
The file was modifiedllvm/test/CodeGen/PowerPC/tocSaveInPrologue.ll
The file was modifiedllvm/test/CodeGen/PowerPC/vec-min-max.ll
Commit 31a691e2a2293a9ecb5330f081f2410bc1ff4474 by lebedev.ri
[NFC][InstCombine] Some more preparatory cleanup for
dropRedundantMaskingOfLeftShiftInput()
llvm-svn: 375153
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineShifts.cpp