SuccessChanges

Summary

  1. Revert rG70f5aecedef9a6e347e425eb5b843bf797b95319 - "Reland (details)
  2. [LCSSA] Forget values we create LCSSA phis for (details)
  3. [clangd] Add a hidden tweak to dump symbol under the cursor. (details)
  4. Fix unused variable warning. NFCI. (details)
  5. Revert "[NFC] Replace a linked list in LiveDebugVariables pass with a (details)
  6. Fix a spelling mistake in a comment. NFC (details)
Commit 2c496bb5309c972d59b11f05aee4782ddc087e71 by llvm-dev
Revert rG70f5aecedef9a6e347e425eb5b843bf797b95319 - "Reland
[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2)"
This fails on EXPENSIVE_CHECKS builds
The file was removedllvm/test/CodeGen/AArch64/wrong-callee-save-size-after-livedebugvariables.mir
The file was modifiedllvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h
The file was modifiedllvm/lib/CodeGen/RegUsageInfoCollector.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.cpp
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.h
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp
The file was modifiedllvm/test/DebugInfo/MIR/Mips/live-debug-values-reg-copy.mir
The file was modifiedllvm/lib/CodeGen/LiveDebugValues.cpp
The file was modifiedllvm/test/DebugInfo/MIR/X86/live-debug-values-reg-copy.mir
Commit 596e4ab97a1637d2c7781aed20e3d62bcf07ef5d by florian_hahn
[LCSSA] Forget values we create LCSSA phis for
Summary: Currently we only forget the loop we added LCSSA phis for. But
SCEV expressions in other loops could also depend on the instruction we
added a PHI for and currently we do not invalidate those expressions.
This can happen when we use ScalarEvolution before converting a function
to LCSSA form. The SCEV expressions will refer to the non-LCSSA value.
If this SCEV expression is then used with the expander, we do not
preserve LCSSA form.
This patch properly forgets the values we created PHIs for. Those need
to be recomputed again. This patch fixes PR43458.
Currently SCEV::verify does not catch this mismatch and any test would
need to run multiple passes to trigger the error (e.g. -loop-reduce
-loop-unroll). I will also look into catching this kind of mismatch in
the verifier. Also, we currently forget the whole loop in LCSSA and I'll
check if we can be more surgical.
Reviewers: efriedma, sanjoy.google, reames
Reviewed By: efriedma
Subscribers: zzheng, hiraditya, javed.absar, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68194
The file was addedllvm/test/Transforms/LoopUnroll/unroll-preserve-scev-lcssa.ll
The file was modifiedllvm/lib/Transforms/Utils/LCSSA.cpp
The file was modifiedllvm/include/llvm/Transforms/Utils/LoopUtils.h
Commit 80b0cdde0ffc4ca59e99fed3dcb18412ff97568c by hokein.wu
[clangd] Add a hidden tweak to dump symbol under the cursor.
Summary: This provides a convenient way to see the SymbolID/USR of the
symbol, mainly for debugging purpose.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69517
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
Commit ec82eb2d024a3535bc9fa1dbe36764be017381b1 by llvm-dev
Fix unused variable warning. NFCI.
The file was modifiedllvm/lib/CodeGen/MachineInstr.cpp
Commit 67720e7bf7dfb28750706e3b27d16a1933af9ca0 by andrea.dibiagio
Revert "[NFC] Replace a linked list in LiveDebugVariables pass with a
DenseMap"
This reverts commit 8af5ada09319e5a021d57a1a03715b2fd022e415.
As Bjorn pointed out in D68816, the iteration over `UserVals` may not be
safe.
Reverting on behalf of Orlando.
The file was modifiedllvm/lib/CodeGen/LiveDebugVariables.cpp
Commit b1c4b4d5cbbea295ea7a9162e7cf16f0f41c935c by greg.bedwell
Fix a spelling mistake in a comment. NFC
The file was modifiedllvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp