FailedChanges

Summary

  1. [LLDB][PythonFile] fix dangerous borrow semantics on python2 (details)
  2. [LLDB][Python] warning fix for LLDBSwigPythonBreakpointCallbackFunction (details)
Commit 3071ebf7b38341e89be04aa64c257c4643e0648c by lawrence_danna
[LLDB][PythonFile] fix dangerous borrow semantics on python2
Summary: It is inherently unsafe to allow a python program to manipulate
borrowed memory from a python object's destructor.     It would be nice
to flush a borrowed file when python is finished with it, but it's not
safe to do on python 2.
Python 3 does not suffer from this issue.
Reviewers: labath, mgorny
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D69532
The file was modifiedlldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py
The file was modifiedlldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
Commit fb01c01bf3f60d1d229126ea4088519adae5c015 by lawrence_danna
[LLDB][Python] warning fix for LLDBSwigPythonBreakpointCallbackFunction
This is a quick followup to this commit:
https://reviews.llvm.org/rGa69bbe02a2352271e8b14542073f177e24c499c1
In that, I #pragma-squelch this warning in `ScriptInterpreterPython.cpp`
but we get the same warning in `PythonTestSuite.cpp`.
This patch squelches the same warning in the same way as the reviweed
commit.   I'm submitting it without review under the
"obviously correct" rule.
At least if this is incorrect the main commit was also incorrect.
By the way, as far as I can tell, these functions are extern "C" because
SWIG does that to everything, not because they particularly need to be.
The file was modifiedlldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp