FailedChanges

Summary

  1. Fix compiler-rt build on macOS without XCode (details)
  2. [compiler-rt] Use xcrun instead of xcodebuild to find the SDK directory (details)
  3. [update_cc_test_checks.py] Pass the builtin include dir to clang (details)
  4. Remove unneeded template alias, causes issues with some MSVC version (details)
  5. [clang][ScanDeps] Fix issue with multiple commands with the same input. (details)
  6. [WebAssembly] Expand setcc of v2i64 (details)
  7. [LVI] Regenerate test checks; NFC (details)
  8. [CVP] Add tests for icmp on local ranges; NFC (details)
Commit 52beec76de83934b9be4448deb3a509b224e4a7e by Alexander.Richardson
Fix compiler-rt build on macOS without XCode
Summary: Starting with 8a5bfbe6db2824642bf9a1d27a24c5b6132b244f (D68292)
this file unconditionally uses xcodebuild to get the SDK version. On my
system this always fails with
`xcode-select: error: tool 'xcodebuild' requires Xcode, but active
developer directory '/Library/Developer/CommandLineTools' is a command
line tools instance`
Reviewers: delcypher, yln
Reviewed By: delcypher, yln
Subscribers: dberris, mgorny, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D69610
The file was modifiedcompiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
Commit 8baedb82bafe2a9efb341b6207238b2af0f1ce07 by Alexander.Richardson
[compiler-rt] Use xcrun instead of xcodebuild to find the SDK directory
Summary: xcodebuild does not work unless XCode is installed whereas
xcrun also work when only the Command Line Tools are installed. Unlike
the check for the version (D69610), this did not cause an erro for me
since the fallback to
/usr/include for the OSX sysroot worked.
Reviewers: yln, delcypher
Reviewed By: yln
Subscribers: dberris, mgorny, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D69659
The file was modifiedcompiler-rt/cmake/config-ix.cmake
The file was modifiedcompiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
Commit d9cc7d14085a9c7d3f04380d974160be759a09eb by Alexander.Richardson
[update_cc_test_checks.py] Pass the builtin include dir to clang
Summary: This is required to update tests that make use of builtin
headers. To fix this use the same command expansion as lit does for
%clang_cc1. I tested this by updating
clang/test/CodeGen/arm-mve-intrinsics/scalar-shifts.c.
%clang_cc1 will now expand to `clang -cc1 -internal-isystem
$LLVM_BUILD/lib/clang/$VERSION/include -nostdsysteminc`.
Reviewers: MaskRay
Reviewed By: MaskRay
Subscribers: kristof.beyls, dmgreen, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69611
The file was modifiedllvm/utils/update_cc_test_checks.py
Commit 19f1dc7b527eade11dae9425c420cc9f450393b6 by rnk
Remove unneeded template alias, causes issues with some MSVC version
I built locally with the latest MSVC in c++14 and c++17, but it does not
complain for me. Osman Zakir on llvm-dev reports that they run into
compile errors here.
In any case, it seems prefereable to reuse clang's LLVM.h header to
bring in llvm::Optional and Expected.
The file was modifiedclang/lib/AST/Interp/ByteCodeStmtGen.cpp
Commit d816d9bdc585bbf77a7a1c47a7199fd9e0c34402 by bigcheesegs
[clang][ScanDeps] Fix issue with multiple commands with the same input.
Previously, given a CompilationDatabase with two commands for the same
source file we would report that file twice with the union of the
dependencies for each command both times.
This was due to the way `ClangTool` runs actions given an input source
file (see the comment in `DependencyScanningTool.cpp`). This commit adds
a `SingleCommandCompilationDatabase` that is created with each
`CompileCommand` in the original CDB, which is then used for each
`ClangTool` invocation. This gives us a single run of
`DependencyScanningAction` per `CompileCommand`.
I looked at using `AllTUsToolExecutor` which is a parallel tool
executor, but I'm not sure it's suitable for `clang-scan-deps` as it
does a lot more sharing of state than `AllTUsToolExecutor` expects.
Differential Revision: https://reviews.llvm.org/D69643
The file was modifiedclang/test/ClangScanDeps/error.cpp
The file was modifiedclang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
The file was modifiedclang/test/ClangScanDeps/Inputs/regular_cdb.json
The file was modifiedclang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
The file was modifiedclang/test/ClangScanDeps/regular_cdb.cpp
The file was modifiedclang/tools/clang-scan-deps/ClangScanDeps.cpp
Commit 11850a6305c5778b180243eb06aefe86762dd4ce by tlively
[WebAssembly] Expand setcc of v2i64
Summary: The SIMD spec does not include i64x2 comparisons, so they need
to be expanded. Using setOperationAction to expand them also causes
f64x2 comparisons to be expanded, so setCondCodeAction needs to be used
instead. But since there are no legal condition codes, the legalizer
does not know how to expand the comparisons. We therefore manually
unroll the operation, taking care to fill each lane with -1 or 0 rather
than 1 or 0 for consistency with the other vector comparisons.
Reviewers: aheejin
Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69604
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-comparisons.ll
Commit 1cfe3e6df9fa017c688f69bedd76942b7f09dea9 by nikita.ppv
[LVI] Regenerate test checks; NFC
The file was modifiedllvm/test/Transforms/JumpThreading/bb-unreachable-from-entry.ll
The file was modifiedllvm/test/Transforms/JumpThreading/induction.ll
The file was modifiedllvm/test/Transforms/JumpThreading/header-succ.ll
Commit 2f8a43e1997d76d0e902a9283be8b82ca89fb603 by nikita.ppv
[CVP] Add tests for icmp on local ranges; NFC
We currently don't simplify these, because getPredicateAt() does not use
block values.
The file was modifiedllvm/test/Transforms/CorrelatedValuePropagation/icmp.ll