SuccessChanges

Summary

  1. [NFC][llvm-readobj] Pull common code into a helper (details)
  2. [NFC][llvm-readobj] Split getSectionIndexName function into two (details)
Commit 490f6f3211cb54d109a14be78520441b711af669 by jh7370
[NFC][llvm-readobj] Pull common code into a helper
This will make planned changes to this code easier to make.
Reviewed by: MaskRay, grimar
Differential Revision: https://reviews.llvm.org/D69669
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
Commit d835bc004af25d3431977047e13d1bbc5cef5b91 by jh7370
[NFC][llvm-readobj] Split getSectionIndexName function into two
getSectionIndexName was trying to fetch two things at once, which led to
a somewhat tricky to understand interface involving passing output
parameters in, and also made it hard to return Errors further up the
stack.
This change is in preparation for changing the error handling.
Additionally, update a related test now that yaml2obj supports
SHT_SYMTAB_SHNDX properly (see d3963051c490), and add missing LLVM-style
coverage for symbols with shndx SHN_XINDEX. This test (after fixing)
caught a mistake in my first attempt at this patch, hence I'm including
it as part of this patch.
Reviewed by: grimar, MaskRay
Differential Revision: https://reviews.llvm.org/D69670
The file was modifiedllvm/test/tools/llvm-readobj/elf-symbol-shndx.test
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp