FailedChanges

Summary

  1. MemoryRegion: Print "don't know" permission values as such (details)
Commit 28cf9698abd39221001ace885a7d1c1f488b967c by pavel
MemoryRegion: Print "don't know" permission values as such
Summary: The permissions in a memory region have ternary states (yes,
no, don't know), but the memory region command only prints in binary,
treating
"don't know" as "yes", which is particularly confusing as for instance
the unwinder will treat an unknown value as "no".
This patch makes is so that we distinguish all three states when
printing the values, using "?" to indicate the lack of information. It
is implemented via a special argument to the format provider for the
OptionalBool enumeration.
Reviewers: clayborg, jingham
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D69106
The file was modifiedlldb/test/Shell/Minidump/memory-region-from-module.yaml
The file was modifiedlldb/include/lldb/Target/MemoryRegionInfo.h
The file was modifiedlldb/source/Target/MemoryRegionInfo.cpp
The file was modifiedlldb/source/Commands/CommandObjectMemory.cpp