FailedChanges

Summary

  1. [llvm-ar] Support verbose mode for operation 'x' (details)
  2. [XCOFF] Fix link errors from explicit template instantiation (details)
Commit 7d2b0ec345487537e37a24b323d612c7c06295cd by maskray
[llvm-ar] Support verbose mode for operation 'x'
Reviewed By: jhenderson, kongyi
Differential Revision: https://reviews.llvm.org/D69911
The file was modifiedllvm/tools/llvm-ar/llvm-ar.cpp
The file was modifiedllvm/test/tools/llvm-ar/extract.test
Commit c989993ba1a666f04f7aee7df51d9f4de0588b71 by rnk
[XCOFF] Fix link errors from explicit template instantiation
I happen to be using clang-cl+lld-link locally, and I get these link
errors:
lld-link: error: undefined symbol: public: unsigned short __cdecl
llvm::object::XCOFFSectionHeader<struct
llvm::object::XCOFFSectionHeader64>::getSectionType(void) const
>>> referenced by
C:\src\llvm-project\llvm\tools\llvm-readobj\XCOFFDumper.cpp:106
>>>             
tools\llvm-readobj\CMakeFiles\llvm-readobj.dir\XCOFFDumper.cpp.obj:(public:
virtual void __cdecl `anonymous
namespace'::XCOFFDumper::printSectionHeaders(void))
I suspect this is because the explicit template instaniation appears
before the inline method definitions in the .cpp file, so they aren't
available at the point of instantiation. Move the explicit instantiation
later.
Also, forward declare the explicit instantiation for good measure.
The file was modifiedllvm/include/llvm/Object/XCOFFObjectFile.h
The file was modifiedllvm/lib/Object/XCOFFObjectFile.cpp