SuccessChanges

Summary

  1. AMDGPU Reduce reported maximum group size to 1024 (details)
  2. AMDGPU: Switch backend default max workgroup size to 1024 (details)
Commit 25c5da5a426168b38fb3e9baa918faa75e4a92b4 by arsenm2
AMDGPU Reduce reported maximum group size to 1024
While some targets allow encoding 2048, this was never tested or
supported.
The file was modifiedllvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/attr-amdgpu-flat-work-group-size-v3.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/large-work-group-promote-alloca.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/attr-amdgpu-flat-work-group-size.ll
Commit 4b472139513ba460595804f8113497844b41fbcc by arsenm2
AMDGPU: Switch backend default max workgroup size to 1024
Previously this would default to 256, not the maximum supported size of
1024. Using a maximum lower than the hardware maximum requires language
runtimes to enforce this limit for correctness, which no language has
correctly done. Switch the default to the conservatively correct
maximum, and force frontends to opt-in to the more optimal 256 default
maximum.
I don't really understand why the changes in occupancy-levels.ll
increased the computed occupancy, which I expected to decrease. I'm not
sure if these tests should be forcing the old maximum.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-icmp.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-select.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/hsa-metadata-kernel-code-props-v3.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/array-ptr-calc-i32.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/hsa-metadata-kernel-code-props.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/private-memory-r600.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/promote-alloca-addrspacecast.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-phi.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/lower-range-metadata-intrinsic-call.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/occupancy-levels.ll