SuccessChanges

Summary

  1. [LLDB] Implement pure virtual method in MockConnection (details)
  2. Revert a hunk from 9634064cfa1b9bf7b7 (details)
  3. [LLDB] Cleanup the DataEncoder utility. (NFC) (details)
Commit 33c3e0b96c14e5986fec778625c1e2a37b452956 by Jonas Devlieghere
[LLDB] Implement pure virtual method in MockConnection
I made GetReadObject pure virtual in the base class and forgot to add
the method to the mock class.
The file was modifiedlldb/unittests/Process/gdb-remote/GDBRemoteTestUtils.h
Commit bfe663ce22db6697459510ae5c139da2197df56c by rnk
Revert a hunk from 9634064cfa1b9bf7b7
This causes errors when building LLDB because the Windows implementation
doesn't implement this method:
C:\src\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\ScriptInterpreterPython.cpp(915,19):
error: allocating an object of abstract class type
'lldb_private::ConnectionGenericFile'
             new ConnectionGenericFile(read_file, true));
                 ^
C:\src\llvm-project\lldb\include\lldb/Utility/Connection.h(174,28):
note: unimplemented pure virtual method 'GetReadObject' in
'ConnectionGenericFile'
virtual lldb::IOObjectSP GetReadObject() = 0;
                          ^
The file was modifiedlldb/include/lldb/Utility/Connection.h
Commit 8ac053eea20b56f80653191a210682f8bd6fc10d by Jonas Devlieghere
[LLDB] Cleanup the DataEncoder utility. (NFC)
This commit removes unused methods from the DataEncoder class and cleans
up the API by making all the internal methods private.
The file was modifiedlldb/source/Utility/DataEncoder.cpp
The file was modifiedlldb/include/lldb/Utility/DataEncoder.h
The file was modifiedlldb/source/Expression/DWARFExpression.cpp
The file was modifiedlldb/source/Plugins/Platform/Android/AdbClient.cpp