SuccessChanges

Summary

  1. [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (details)
  2. Revert "re-land [DebugInfo] Add debug location to stubs generated by (details)
Commit 50e99563fb0459f5160572eef3c4e6062b8ad3f2 by mitchell
[clang-tidy] modernize-use-override new option AllowOverrideAndFinal
Summary: In addition to adding `override` wherever possible,
clang-tidy's `modernize-use-override` nicely removes `virtual` when
`override` or `final` is specified, and further removes override when
final is specified. While this is great default behavior, when code
needs to be compiled with gcc at high warning levels that include `gcc
-Wsuggest-override` or `gcc -Werror=suggest-override`, clang-tidy's
removal of the redundant `override` keyword causes gcc to emit a warning
or error. This discrepancy / conflict has been noted by others including
a comment on Stack Overflow and by Mozilla's Firefox developers.
This patch adds an AllowOverrideAndFinal option defaulting to 0 - thus
preserving current behavior - that when enabled allows both `override`
and `final` to co-exist, while still fixing all other issues.
The patch includes a test file verifying all combinations of
virtual/override/final, and mentions the new option in the release
notes.
Reviewers: alexfh, djasper, JonasToth
Patch by: poelmanc
Subscribers: JonasToth, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70165
The file was modifiedclang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init-msvc.cpp
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp
Commit caf3166d40ffbb0d61b29f423318ce6cfbcf4a9f by alexandre.ganea
Revert "re-land [DebugInfo] Add debug location to stubs generated by
CGDeclCXX and mark them as artificial"
This reverts commit 9c1baa23526c6d7d06eafefbf82d73bfe9bb3aaf.
The file was removedclang/test/CodeGenCXX/debug-info-atexit-stub.cpp
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedclang/include/clang/AST/GlobalDecl.h
The file was modifiedclang/lib/CodeGen/CGDeclCXX.cpp
The file was modifiedclang/test/CodeGenCXX/debug-info-global-ctor-dtor.cpp
The file was modifiedclang/test/CodeGenCXX/debug-info-line.cpp
The file was removedclang/test/CodeGenCXX/debug-info-destroy-helper.cpp