SuccessChanges

Summary

  1. Fix -Wunused-result warnings in LLDB (details)
  2. Avoid including Builtins.h in Preprocessor.h (details)
Commit 4d23764dddc23e74ad165086d7f471a3e0e52bf8 by rnk
Fix -Wunused-result warnings in LLDB
Three uses of try_lock intentionally ignore the result, as explained in
the comment. Make that explicit with a void cast.
Add what appears to be a missing return in the clang expression parser
code. It's a functional change, but presumably the right one.
Differential Revision: https://reviews.llvm.org/D70281
The file was modifiedlldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
Commit 979da9a4c3ba435b384a11af7bd3154b0309b487 by rnk
Avoid including Builtins.h in Preprocessor.h
Builtins are rarely if ever accessed via the Preprocessor. They are
typically found on the ASTContext, so there should be no performance
penalty to using a pointer indirection to store the builtin context.
The file was modifiedclang/lib/Frontend/FrontendAction.cpp
The file was modifiedclang-tools-extra/clangd/index/FileIndex.h
The file was modifiedclang/lib/Lex/Preprocessor.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
The file was modifiedclang-tools-extra/clangd/index/FileIndex.cpp
The file was modifiedclang-tools-extra/clang-tidy/bugprone/MacroRepeatedSideEffectsCheck.cpp
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/lib/Frontend/ChainedIncludesSource.cpp
The file was modifiedclang/lib/Sema/SemaCoroutine.cpp
The file was modifiedclang/lib/Analysis/ReachableCode.cpp
The file was modifiedclang/include/clang/Basic/Builtins.h
The file was modifiedclang/lib/Lex/PPMacroExpansion.cpp
The file was modifiedclang/include/clang/Lex/Preprocessor.h
The file was modifiedclang/lib/Sema/SemaExprObjC.cpp