FailedChanges

Summary

  1. gn build: (manually) try to merge 1689ad27af (details)
  2. gn build: Merge 30e7ee3c4ba (details)
  3. Revert "[clangd] Implement rename by using SelectionTree and (details)
  4. [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini (details)
Commit e4ec2ecf6d4768d681a89263c0a4d29a7b7761ad by thakis
gn build: (manually) try to merge 1689ad27af
The file was modifiedllvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
Commit 327904d3cfe03faf1615578066d1a3889c2b9a2a by llvmgnsyncbot
gn build: Merge 30e7ee3c4ba
The file was modifiedllvm/utils/gn/secondary/llvm/lib/IR/BUILD.gn
Commit f805c60a093325c16ce4200d2615ef48555d9cb8 by wolfgang_pieb
Revert "[clangd] Implement rename by using SelectionTree and
findExplicitReferences."
This reverts commit 4f80fc2491cc35730a9a84b86975278b7daa8522.
Caused buildbot failure at
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/58251
The file was modifiedclang-tools-extra/clangd/unittests/RenameTests.cpp
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp
Commit b29c7fdb617cba4c83037840842a872e8bf2f6b1 by aaronpuchert
[OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini
Summary: The termination function duplicated the functionality of the
__attribute((destructor))-annotated function __kmp_internal_end_fini,
and we have no indication that this doesn't work.
The function might cause issues with link-time optimization turned on:
until very recently, none of the usual linkers was reporting functions
named in -Wl,-fini as used to the LTO plugin, so it might be dropped. If
the function is dropped, -Wl,-fini=__kmp_internal_end_fini doesn't do
what we want: with ld.bfd and lld it drops the FINI attribute from
.dynamic and with gold we get FINI = 0x0, which leads to a crash on
cleanup. This can be reproduced by building with
    -DLLVM_ENABLE_PROJECTS="clang;openmp" \
   -DLLVM_ENABLE_LTO=Thin \
   -DLLVM_USE_LINKER=gold
The issue in lld has been fixed in f95273f75aa, but gold remains without
fix so far.
Fixes PR43927.
Reviewers: JonChesterfield, jdoerfert, AndreyChurbanov
Reviewed By: AndreyChurbanov
Differential Revision: https://reviews.llvm.org/D69927
The file was modifiedopenmp/runtime/cmake/LibompHandleFlags.cmake
The file was modifiedopenmp/runtime/src/kmp_runtime.cpp
The file was modifiedopenmp/runtime/cmake/config-ix.cmake
The file was modifiedopenmp/runtime/src/kmp.h