FailedChanges

Summary

  1. Merging r347556: ------------------------------------------------------------------------ r347556 | nemanjai | 2018-11-26 06:35:38 -0800 (Mon, 26 Nov 2018) | 11 lines [PowerPC] Vector load/store builtins overstate alignment of pointers A number of builtins in altivec.h load/store vectors from pointers to scalar types. Currently they just cast the pointer to a vector pointer, but expressions like that have the alignment of the target type. Of course, the input pointer did not have that alignment so this triggers UBSan (and rightly so). This resolves https://bugs.llvm.org/show_bug.cgi?id=39704 Differential revision: https://reviews.llvm.org/D54787 ------------------------------------------------------------------------
  2. Merging r347431: ------------------------------------------------------------------------ r347431 | rnk | 2018-11-21 14:01:10 -0800 (Wed, 21 Nov 2018) | 12 lines [mingw] Use unmangled name after the $ in the section name GCC does it this way, and we have to be consistent. This includes stdcall and fastcall functions with suffixes. I confirmed that a fastcall function named "foo" ends up in ".text$foo", not ".text$@foo@8". Based on a patch by Andrew Yohn! Fixes PR39218. Differential Revision: https://reviews.llvm.org/D54762 ------------------------------------------------------------------------
  3. Merging r344444 and r344445: ------------------------------------------------------------------------ r344444 | baloghadamsoftware | 2018-10-13 03:34:52 -0700 (Sat, 13 Oct 2018) | 11 lines [clang-tidy] Optimize query in bugprone-exception-escape Checking whether a functions throws indirectly may be very expensive because it needs to visit its whole call graph. Therefore we should first check whether the function is forbidden to throw and only check whether it throws afterward. This also seems to solve bug https://bugs.llvm.org/show_bug.cgi?id=39167 where the execution time is so long that it seems to hang. Differential Revision: https://reviews.llvm.org/D53187 ------------------------------------------------------------------------ ------------------------------------------------------------------------ r344445 | baloghadamsoftware | 2018-10-13 04:17:59 -0700 (Sat, 13 Oct 2018) | 3 lines [clang-tidy] Fix for typos in the tests for `bugprone-exception-escape` ------------------------------------------------------------------------
Revision 347935 by tstellar:
Merging r347556:

------------------------------------------------------------------------
r347556 | nemanjai | 2018-11-26 06:35:38 -0800 (Mon, 26 Nov 2018) | 11 lines

[PowerPC] Vector load/store builtins overstate alignment of pointers

A number of builtins in altivec.h load/store vectors from pointers to scalar
types. Currently they just cast the pointer to a vector pointer, but expressions
like that have the alignment of the target type. Of course, the input pointer
did not have that alignment so this triggers UBSan (and rightly so).

This resolves https://bugs.llvm.org/show_bug.cgi?id=39704

Differential revision: https://reviews.llvm.org/D54787

------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/branches/release_70/lib/Headers/altivec.h (diff)clang.src/lib/Headers/altivec.h
The file was modified/cfe/branches/release_70/test/CodeGen/builtins-ppc-altivec.c (diff)clang.src/test/CodeGen/builtins-ppc-altivec.c
The file was modified/cfe/branches/release_70/test/CodeGen/builtins-ppc-quadword.c (diff)clang.src/test/CodeGen/builtins-ppc-quadword.c
The file was modified/cfe/branches/release_70/test/CodeGen/builtins-ppc-vsx.c (diff)clang.src/test/CodeGen/builtins-ppc-vsx.c
Revision 347931 by tstellar:
Merging r347431:

------------------------------------------------------------------------
r347431 | rnk | 2018-11-21 14:01:10 -0800 (Wed, 21 Nov 2018) | 12 lines

[mingw] Use unmangled name after the $ in the section name

GCC does it this way, and we have to be consistent. This includes
stdcall and fastcall functions with suffixes. I confirmed that a
fastcall function named "foo" ends up in ".text$foo", not
".text$@foo@8".

Based on a patch by Andrew Yohn!

Fixes PR39218.

Differential Revision: https://reviews.llvm.org/D54762
------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/branches/release_70/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (diff)llvm.src/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
The file was modified/llvm/branches/release_70/test/CodeGen/X86/mingw-comdats.ll (diff)llvm.src/test/CodeGen/X86/mingw-comdats.ll
Revision 347921 by tstellar:
Merging r344444 and r344445:

------------------------------------------------------------------------
r344444 | baloghadamsoftware | 2018-10-13 03:34:52 -0700 (Sat, 13 Oct 2018) | 11 lines

[clang-tidy] Optimize query in bugprone-exception-escape

Checking whether a functions throws indirectly may be very expensive because it
needs to visit its whole call graph. Therefore we should first check whether the
function is forbidden to throw and only check whether it throws afterward. This
also seems to solve bug https://bugs.llvm.org/show_bug.cgi?id=39167 where the
execution time is so long that it seems to hang.

Differential Revision: https://reviews.llvm.org/D53187

------------------------------------------------------------------------

------------------------------------------------------------------------
r344445 | baloghadamsoftware | 2018-10-13 04:17:59 -0700 (Sat, 13 Oct 2018) | 3 lines

[clang-tidy] Fix for typos in the tests for `bugprone-exception-escape`

------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/branches/release_70/clang-tidy/bugprone/ExceptionEscapeCheck.cpp (diff)clang-tools-extra.src/clang-tidy/bugprone/ExceptionEscapeCheck.cpp
The file was modified/clang-tools-extra/branches/release_70/docs/clang-tidy/checks/bugprone-exception-escape.rst (diff)clang-tools-extra.src/docs/clang-tidy/checks/bugprone-exception-escape.rst
The file was modified/clang-tools-extra/branches/release_70/test/clang-tidy/bugprone-exception-escape.cpp (diff)clang-tools-extra.src/test/clang-tidy/bugprone-exception-escape.cpp