FailedChanges

Summary

  1. Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS. The patch in r350643 incorrectly sets the COFF emission based on bits instead of bytes. This patch converts the 32 via CharUnits to bits to compare the correct values. Change-Id: Icf38a16470ad5ae3531374969c033557ddb0d323
  2. Fix misspelled filenames in file headers
  3. tsan: add more benchmarks func_entry_exit.cc is for __tsan_func_entry/exit (spends ~75% there), we don't yet have any. mop.cc is for memory access functions, as compared to mini_bench_local/shared.cc this benchmark passes through deduplication logic (ContainsSameAccess).
  4. [LSR] Generate cross iteration indexes Modify GenerateConstantOffsetsImpl to create offsets that can be used by indexed addressing modes. If formulae can be generated which result in the constant offset being the same size as the recurrence, we can generate a pre-indexed access. This allows the pointer to be updated via the single pre-indexed access so that (hopefully) no add/subs are required to update it for the next iteration. For small cores, this can significantly improve performance DSP-like loops. Differential Revision: https://reviews.llvm.org/D55373
  5. [clang-cl] support /Oy- on aarch64 MSVC supports /Oy- on aarch64, so clang-cl should too. Patch by Nathan Froyd! Differential Revision: https://reviews.llvm.org/D57838
  6. tsan: Optimize performance of Thread sanitizer memory access functions - Manually unwind code in MemoryAccessImpl1() because clang do not optimize it - Check for .rodata section only in read operations - Place LIKELY/UNLIKELY on fast paths This speeds up synthetic memory access benchmarks by 10-20%. [dvyukov: fixed up consts in check_analyze.sh] Author: yuri (Yuri Per) Reviewed in: https://reviews.llvm.org/D57882 Context: https://reviews.llvm.org/D54889
  7. Typo: s/follwing/following
  8. [ARM GlobalISel] Support G_ICMP for Thumb2 Mark as legal and use the t2* equivalents of the arm mode instructions, e.g. t2CMPrr instead of plain CMPrr.
  9. sanitizers: Introduce ThreadType enum Replace bool workerthread flag with ThreadType enum. This change is preparation for fiber support. [dvyukov: fixed build of sanitizer_thread_registry_test.cc] Author: yuri (Yuri Per) Reviewed in: https://reviews.llvm.org/D57839 Context: https://reviews.llvm.org/D54889
  10. [clang-tidy] Fixed a std::bind() transformation There was an extra semicolon that was somehow working in some contexts. Patch by oleg.smolsky.
  11. [ARM] Reformat isRedundantFlagInstr for D57833. NFC
  12. tsan: Implement pthread_exit() interceptor for Thread sanitizer This change is preparation for fiber support. Author: yuri (Yuri Per) Reviewed in: https://reviews.llvm.org/D57876 Context: https://reviews.llvm.org/D54889
  13. [BPF] add code-gen support for JMP32 instructions JMP32 instructions has been added to eBPF ISA. They are 32-bit variants of existing BPF conditional jump instructions, but the comparison happens on low 32-bit sub-register only, therefore some unnecessary extensions could be saved. JMP32 instructions will only be available for -mcpu=v3. Host probe hook has been updated accordingly. JMP32 instructions will only be enabled in code-gen when -mattr=+alu32 enabled, meaning compiling the program using sub-register mode. For JMP32 encoding, it is a new instruction class, and is using the reserved eBPF class number 0x6. This patch has been tested by compiling and running kernel bpf selftests with JMP32 enabled. Acked-by: Yonghong Song <yhs@fb.com> Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
  14. AArch64: implement copy for paired GPR registers. When doing 128-bit atomics using CASP we might need to copy a GPRPair to a different register, but that was unimplemented up to now.
  15. [clang-tidy] Expand and clarify the NOLINT documentation a bit.
  16. [clangd] Suggest adding missing includes for typos (like include-fixer). Summary: This adds include-fixer feature into clangd based on D56903. Clangd now captures diagnostics caused by typos and attach include insertion fixes to potentially fix the typo. Reviewers: sammccall Reviewed By: sammccall Subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny Tags: #clang Differential Revision: https://reviews.llvm.org/D57021
  17. [sanitizer] Fix Android tests On Android some fields can be null
  18. [CMake] Mark runtime library link libraries as private There's no need to expose these dependencies to consumers. This matches the change made to other runtimes in D57456. Differential Revision: https://reviews.llvm.org/D57873
  19. [BranchFolding] Remove dead code for handling EHPad blocks Summary: This code tries to handle the case where IBB is an EHPad, but there's an earlier check that uses PBB->hasEHPadSuccessor(). Where PBB is a predecessor of IBB. The hasEHPadSuccessor function would have visited IBB and seen that it was an EHPad and returned false. This would prevent us from reaching this code with IBB as an EHPad. Looks like this code was originally added in rL37427 (ancient) and made dead in rL143001. Reviewers: rnk, void, efriedma Reviewed By: rnk Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D57358
Revision 353411 by erichkeane:
Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.

The patch in r350643 incorrectly sets the COFF emission based on bits
instead of bytes. This patch converts the 32 via CharUnits to bits to
compare the correct values.

Change-Id: Icf38a16470ad5ae3531374969c033557ddb0d323
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.cpp (diff)clang.src/lib/CodeGen/CodeGenModule.cpp
The file was modified/cfe/trunk/test/CodeGen/microsoft-no-common-align.c (diff)clang.src/test/CodeGen/microsoft-no-common-align.c
Revision 353408 by maskray:
Fix misspelled filenames in file headers
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/VariadicFunction.h (diff)llvm.src/include/llvm/ADT/VariadicFunction.h
The file was modified/llvm/trunk/include/llvm/CodeGen/MIRYamlMapping.h (diff)llvm.src/include/llvm/CodeGen/MIRYamlMapping.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/CVRecord.h (diff)llvm.src/include/llvm/DebugInfo/CodeView/CVRecord.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/DebugCrossImpSubsection.h (diff)llvm.src/include/llvm/DebugInfo/CodeView/DebugCrossImpSubsection.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/GenericError.h (diff)llvm.src/include/llvm/DebugInfo/PDB/GenericError.h
The file was modified/llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h (diff)llvm.src/include/llvm/ExecutionEngine/Orc/RPCUtils.h
The file was modified/llvm/trunk/include/llvm/FuzzMutate/RandomIRBuilder.h (diff)llvm.src/include/llvm/FuzzMutate/RandomIRBuilder.h
The file was modified/llvm/trunk/include/llvm/IR/Intrinsics.h (diff)llvm.src/include/llvm/IR/Intrinsics.h
The file was modified/llvm/trunk/include/llvm/Support/ARMWinEH.h (diff)llvm.src/include/llvm/Support/ARMWinEH.h
The file was modified/llvm/trunk/include/llvm/Support/CBindingWrapping.h (diff)llvm.src/include/llvm/Support/CBindingWrapping.h
The file was modified/llvm/trunk/include/llvm/Support/DOTGraphTraits.h (diff)llvm.src/include/llvm/Support/DOTGraphTraits.h
The file was modified/llvm/trunk/include/llvm/Support/FormatCommon.h (diff)llvm.src/include/llvm/Support/FormatCommon.h
The file was modified/llvm/trunk/include/llvm/Support/SMTAPI.h (diff)llvm.src/include/llvm/Support/SMTAPI.h
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h (diff)llvm.src/include/llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/LowerMemIntrinsics.h (diff)llvm.src/include/llvm/Transforms/Utils/LowerMemIntrinsics.h
Revision 353407 by dvyukov:
tsan: add more benchmarks

func_entry_exit.cc is for __tsan_func_entry/exit (spends ~75% there),
we don't yet have any.
mop.cc is for memory access functions, as compared to mini_bench_local/shared.cc
this benchmark passes through deduplication logic (ContainsSameAccess).
Change TypePath in RepositoryPath in Workspace
The file was added/compiler-rt/trunk/lib/tsan/benchmarks/func_entry_exit.cccompiler-rt.src/lib/tsan/benchmarks/func_entry_exit.cc
The file was added/compiler-rt/trunk/lib/tsan/benchmarks/mop.cccompiler-rt.src/lib/tsan/benchmarks/mop.cc
Revision 353403 by sam_parker:
[LSR] Generate cross iteration indexes
   
Modify GenerateConstantOffsetsImpl to create offsets that can be used
by indexed addressing modes. If formulae can be generated which
result in the constant offset being the same size as the recurrence,
we can generate a pre-indexed access. This allows the pointer to be
updated via the single pre-indexed access so that (hopefully) no
add/subs are required to update it for the next iteration. For small
cores, this can significantly improve performance DSP-like loops.

Differential Revision: https://reviews.llvm.org/D55373
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h (diff)llvm.src/include/llvm/Analysis/TargetTransformInfo.h
The file was modified/llvm/trunk/include/llvm/Analysis/TargetTransformInfoImpl.h (diff)llvm.src/include/llvm/Analysis/TargetTransformInfoImpl.h
The file was modified/llvm/trunk/lib/Analysis/TargetTransformInfo.cpp (diff)llvm.src/lib/Analysis/TargetTransformInfo.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMTargetTransformInfo.h (diff)llvm.src/lib/Target/ARM/ARMTargetTransformInfo.h
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp (diff)llvm.src/lib/Transforms/Scalar/LoopStrengthReduce.cpp
The file was added/llvm/trunk/test/CodeGen/ARM/dsp-loop-indexing.llllvm.src/test/CodeGen/ARM/dsp-loop-indexing.ll
The file was modified/llvm/trunk/test/CodeGen/ARM/loop-align-cortex-m.ll (diff)llvm.src/test/CodeGen/ARM/loop-align-cortex-m.ll
The file was added/llvm/trunk/test/CodeGen/ARM/loop-indexing.llllvm.src/test/CodeGen/ARM/loop-indexing.ll
The file was modified/llvm/trunk/test/Transforms/LoopStrengthReduce/ARM/complexity.ll (diff)llvm.src/test/Transforms/LoopStrengthReduce/ARM/complexity.ll
Revision 353402 by mstorsjo:
[clang-cl] support /Oy- on aarch64

MSVC supports /Oy- on aarch64, so clang-cl should too.

Patch by Nathan Froyd!

Differential Revision: https://reviews.llvm.org/D57838
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Driver/ToolChains/MSVC.cpp (diff)clang.src/lib/Driver/ToolChains/MSVC.cpp
The file was modified/cfe/trunk/test/Driver/cl-options.c (diff)clang.src/test/Driver/cl-options.c
Revision 353401 by dvyukov:
tsan: Optimize performance of Thread sanitizer memory access functions

- Manually unwind code in MemoryAccessImpl1() because clang do not optimize it
- Check for .rodata section only in read operations
- Place LIKELY/UNLIKELY on fast paths

This speeds up synthetic memory access benchmarks by 10-20%.

[dvyukov: fixed up consts in check_analyze.sh]

Author: yuri (Yuri Per)
Reviewed in: https://reviews.llvm.org/D57882
Context: https://reviews.llvm.org/D54889
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/tsan/check_analyze.sh (diff)compiler-rt.src/lib/tsan/check_analyze.sh
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_interface_atomic.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_interface_atomic.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_rtl.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_update_shadow_word_inl.h (diff)compiler-rt.src/lib/tsan/rtl/tsan_update_shadow_word_inl.h
Revision 353393 by hans:
Typo: s/follwing/following
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Driver/Options.td (diff)clang.src/include/clang/Driver/Options.td
Revision 353392 by rovka:
[ARM GlobalISel] Support G_ICMP for Thumb2

Mark as legal and use the t2* equivalents of the arm mode instructions,
e.g. t2CMPrr instead of plain CMPrr.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMInstructionSelector.cpp (diff)llvm.src/lib/Target/ARM/ARMInstructionSelector.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMLegalizerInfo.cpp (diff)llvm.src/lib/Target/ARM/ARMLegalizerInfo.cpp
The file was added/llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalize-cmp.mirllvm.src/test/CodeGen/ARM/GlobalISel/arm-legalize-cmp.mir
The file was modified/llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalizer.mir (diff)llvm.src/test/CodeGen/ARM/GlobalISel/arm-legalizer.mir
The file was added/llvm/trunk/test/CodeGen/ARM/GlobalISel/thumb-instruction-select-cmp.mirllvm.src/test/CodeGen/ARM/GlobalISel/thumb-instruction-select-cmp.mir
Revision 353390 by dvyukov:
sanitizers: Introduce ThreadType enum

Replace bool workerthread flag with ThreadType enum.
This change is preparation for fiber support.

[dvyukov: fixed build of sanitizer_thread_registry_test.cc]

Author: yuri (Yuri Per)
Reviewed in: https://reviews.llvm.org/D57839
Context: https://reviews.llvm.org/D54889
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_fuchsia.cc (diff)compiler-rt.src/lib/asan/asan_fuchsia.cc
The file was modified/compiler-rt/trunk/lib/asan/asan_mac.cc (diff)compiler-rt.src/lib/asan/asan_mac.cc
The file was modified/compiler-rt/trunk/lib/asan/asan_rtems.cc (diff)compiler-rt.src/lib/asan/asan_rtems.cc
The file was modified/compiler-rt/trunk/lib/asan/asan_thread.cc (diff)compiler-rt.src/lib/asan/asan_thread.cc
The file was modified/compiler-rt/trunk/lib/lsan/lsan_thread.cc (diff)compiler-rt.src/lib/lsan/lsan_thread.cc
The file was modified/compiler-rt/trunk/lib/lsan/lsan_thread.h (diff)compiler-rt.src/lib/lsan/lsan_thread.h
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc (diff)compiler-rt.src/lib/sanitizer_common/sanitizer_thread_registry.cc
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h (diff)compiler-rt.src/lib/sanitizer_common/sanitizer_thread_registry.h
The file was modified/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_thread_registry_test.cc (diff)compiler-rt.src/lib/sanitizer_common/tests/sanitizer_thread_registry_test.cc
The file was modified/compiler-rt/trunk/lib/tsan/go/tsan_go.cc (diff)compiler-rt.src/lib/tsan/go/tsan_go.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_interceptors.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_platform_mac.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_platform_mac.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_report.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_report.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_report.h (diff)compiler-rt.src/lib/tsan/rtl/tsan_report.h
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_rtl.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.h (diff)compiler-rt.src/lib/tsan/rtl/tsan_rtl.h
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_report.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_rtl_report.cc
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_rtl_thread.cc
Revision 353389 by jonastoth:
[clang-tidy] Fixed a std::bind() transformation

There was an extra semicolon that was somehow working in some contexts.

Patch by oleg.smolsky.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/modernize/AvoidBindCheck.cpp (diff)clang-tools-extra.src/clang-tidy/modernize/AvoidBindCheck.cpp
The file was modified/clang-tools-extra/trunk/test/clang-tidy/modernize-avoid-bind.cpp (diff)clang-tools-extra.src/test/clang-tidy/modernize-avoid-bind.cpp
Revision 353386 by dmgreen:
[ARM] Reformat isRedundantFlagInstr for D57833. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMBaseInstrInfo.cpp (diff)llvm.src/lib/Target/ARM/ARMBaseInstrInfo.cpp
Revision 353385 by dvyukov:
tsan: Implement pthread_exit() interceptor for Thread sanitizer

This change is preparation for fiber support.

Author: yuri (Yuri Per)
Reviewed in: https://reviews.llvm.org/D57876
Context: https://reviews.llvm.org/D54889
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc (diff)compiler-rt.src/lib/tsan/rtl/tsan_interceptors.cc
The file was added/compiler-rt/trunk/test/tsan/thread_exit.ccompiler-rt.src/test/tsan/thread_exit.c
Revision 353384 by jiwang:
[BPF] add code-gen support for JMP32 instructions

JMP32 instructions has been added to eBPF ISA. They are 32-bit variants of
existing BPF conditional jump instructions, but the comparison happens on
low 32-bit sub-register only, therefore some unnecessary extensions could
be saved.

JMP32 instructions will only be available for -mcpu=v3. Host probe hook has
been updated accordingly.

JMP32 instructions will only be enabled in code-gen when -mattr=+alu32
enabled, meaning compiling the program using sub-register mode.

For JMP32 encoding, it is a new instruction class, and is using the
reserved eBPF class number 0x6.

This patch has been tested by compiling and running kernel bpf selftests
with JMP32 enabled.

Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Support/Host.cpp (diff)llvm.src/lib/Support/Host.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPF.td (diff)llvm.src/lib/Target/BPF/BPF.td
The file was modified/llvm/trunk/lib/Target/BPF/BPFISelLowering.cpp (diff)llvm.src/lib/Target/BPF/BPFISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPFISelLowering.h (diff)llvm.src/lib/Target/BPF/BPFISelLowering.h
The file was modified/llvm/trunk/lib/Target/BPF/BPFInstrFormats.td (diff)llvm.src/lib/Target/BPF/BPFInstrFormats.td
The file was modified/llvm/trunk/lib/Target/BPF/BPFInstrInfo.td (diff)llvm.src/lib/Target/BPF/BPFInstrInfo.td
The file was modified/llvm/trunk/lib/Target/BPF/BPFSubtarget.cpp (diff)llvm.src/lib/Target/BPF/BPFSubtarget.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPFSubtarget.h (diff)llvm.src/lib/Target/BPF/BPFSubtarget.h
The file was modified/llvm/trunk/lib/Target/BPF/Disassembler/BPFDisassembler.cpp (diff)llvm.src/lib/Target/BPF/Disassembler/BPFDisassembler.cpp
The file was modified/llvm/trunk/test/MC/BPF/insn-unit-32.s (diff)llvm.src/test/MC/BPF/insn-unit-32.s
Revision 353383 by Tim Northover:
AArch64: implement copy for paired GPR registers.

When doing 128-bit atomics using CASP we might need to copy a GPRPair to a
different register, but that was unimplemented up to now.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.cpp (diff)llvm.src/lib/Target/AArch64/AArch64InstrInfo.cpp
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.h (diff)llvm.src/lib/Target/AArch64/AArch64InstrInfo.h
The file was added/llvm/trunk/test/CodeGen/AArch64/seqpaircopy.mirllvm.src/test/CodeGen/AArch64/seqpaircopy.mir
Revision 353382 by alexfh:
[clang-tidy] Expand and clarify the NOLINT documentation a bit.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/docs/clang-tidy/index.rst (diff)clang-tools-extra.src/docs/clang-tidy/index.rst
Revision 353380 by ioeric:
[clangd] Suggest adding missing includes for typos (like include-fixer).

Summary:
This adds include-fixer feature into clangd based on D56903. Clangd now captures
diagnostics caused by typos and attach include insertion fixes to potentially
fix the typo.

Reviewers: sammccall

Reviewed By: sammccall

Subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57021
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/ClangdUnit.cpp (diff)clang-tools-extra.src/clangd/ClangdUnit.cpp
The file was modified/clang-tools-extra/trunk/clangd/IncludeFixer.cpp (diff)clang-tools-extra.src/clangd/IncludeFixer.cpp
The file was modified/clang-tools-extra/trunk/clangd/IncludeFixer.h (diff)clang-tools-extra.src/clangd/IncludeFixer.h
The file was modified/clang-tools-extra/trunk/clangd/SourceCode.h (diff)clang-tools-extra.src/clangd/SourceCode.h
The file was modified/clang-tools-extra/trunk/unittests/clangd/DiagnosticsTests.cpp (diff)clang-tools-extra.src/unittests/clangd/DiagnosticsTests.cpp
Revision 353377 by Vitaly Buka:
[sanitizer] Fix Android tests

On Android some fields can be null
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc (diff)compiler-rt.src/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc
Revision 353376 by phosek:
[CMake] Mark runtime library link libraries as private

There's no need to expose these dependencies to consumers. This
matches the change made to other runtimes in D57456.

Differential Revision: https://reviews.llvm.org/D57873
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake (diff)compiler-rt.src/cmake/Modules/AddCompilerRT.cmake
Revision 353375 by ctopper:
[BranchFolding] Remove dead code for handling EHPad blocks

Summary: This code tries to handle the case where IBB is an EHPad, but there's an earlier check that uses PBB->hasEHPadSuccessor(). Where PBB is a predecessor of IBB. The hasEHPadSuccessor function would have visited IBB and seen that it was an EHPad and returned false. This would prevent us from reaching this code with IBB as an EHPad.

Looks like this code was originally added in rL37427 (ancient) and made dead in rL143001.

Reviewers: rnk, void, efriedma

Reviewed By: rnk

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D57358
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/BranchFolding.cpp (diff)llvm.src/lib/CodeGen/BranchFolding.cpp