FailedChanges

Summary

  1. [TEST] Add failing test from PR40454
  2. [clangd] Make system header mappings available for PreambleParsedCallback Summary: SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file ast updates but not on preamble ast updates. Fixes https://github.com/clangd/clangd/issues/8 Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58029
  3. test-release.sh: Add option to use ninja Allow the use of ninja instead of make. This is useful on some platforms where we'd like to be able to limit the number of link jobs without slowing down the other steps of the release. This patch adds a -use-ninja command line option, which sets the generator to Ninja both for LLVM and the test-suite. It also deals with some differences between make and ninja: * DESTDIR handling - ninja doesn't like this to be listed after the target, but both make and ninja can handle it before the command * Verbose mode - ninja uses -v, make uses VERBOSE=1 * Keep going mode - make has a -k mode, which builds as much as possible even when failures are encountered; for ninja we need to set a hard limit (we use 100 since most people won't look at 100 failures anyway) I haven't tested with gmake.
  4. [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces Summary: We add a new test to show that redecl chains are not handled properly amongst namespaces. We cannot pass this test now, so this is disabled. Subsequent patches will make this test pass. Reviewers: a_sidorin, shafik, a.sidorin Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D57901
  5. Attempt to fix buildbot after r353679 #2
  6. [DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics. Check that when SimplifyCFG is flattening a 'br', all their debug intrinsic instructions are removed, including any dbg.label referencing a label associated with the basic blocks being removed. As the test case involves a CFG transformation, move it to the correct location. Differential Revision: https://reviews.llvm.org/D57444
  7. Attempt to fix buildbot after r353679
  8. Small refactoring of FileError. NFC. Differential revision: https://reviews.llvm.org/D57945
  9. [ARM] LoadStoreOptimizer: reoder limit The whole design of generating LDMs/STMs is fragile and unreliable: it depends on rescheduling here in the LoadStoreOptimizer that isn't register pressure aware and regalloc that isn't aware of generating LDMs/STMs. This patch adds a (hidden) option to control the total number of instructions that can be re-ordered. I appreciate this looks only a tiny bit better than a hard-coded constant, but at least it allows more easy experimentation with different values for now. Ideally we calculate this reorder limit based on some heuristics, and take register pressure into account. I might be looking into that next. Differential Revision: https://reviews.llvm.org/D57954
  10. Move CFLGraph and the AA summary code over to the new `CallBase` instruction base class rather than the `CallSite` wrapper.
  11. [llvm] [cmake] Use current directory in GenerateVersionFromVCS Find dependent scripts of GenerateVersionFromVCS in current directory rather than ../../cmake/modules. I do not see any reason why the former would not work and The latter is incorrect when GenerateVersionFromVCS is used from install directory (i.e. in stand-alone builds). Differential Revision: https://reviews.llvm.org/D57996
  12. Remove `CallSite` from the CodeMetrics analysis, moving it to the new `CallBase` and simpler APIs therein.
  13. Remove a declaration that is dead, and not even implemented any longer.
  14. [libcxx] Preserve order, avoid duplicates when merging static archives glob can return files in arbitrary order which breaks deterministic builds. Rather, use `ar t` to list the files in each archive and preserve the original order. Using `ar q` results in duplicate entries in the archive, instead use `ar r` to avoid duplicates. Differential Revision: https://reviews.llvm.org/D58024
  15. [ARM] LoadStoreOptimizer: just a clean-up. NFC. Differential Revision: https://reviews.llvm.org/D57955
  16. The new file header didn't get carried over when these files were "moved" somehow, update them to use it.
  17. Update some newly added files that mistakenly used the old file header to the new one.
  18. Update more files added with the old header to the new one.
  19. Update new files added to llvm-objcopy to use the new file header.
  20. Update files that were mistakenly added with the old file header to the new one.
  21. Update files that were mistakenly added with the old file header.
  22. [CallSite removal] Port InstSimplify over to use `CallBase` both in its interface and implementation. Port code with: `cast<CallBase>(CS.getInstruction())`.
  23. [CallSite removal] Migrate ConstantFolding APIs and implementation to `CallBase`. Users have been updated. You can see how to update any out-of-tree usages: pass `cast<CallBase>(CS.getInstruction())`.
  24. [CallSite removal] Migrate the statepoint GC infrastructure to use the `CallBase` class rather than `CallSite` wrappers. I pushed this change down through most of the statepoint infrastructure, completely removing the use of CallSite where I could reasonably do so. I ended up making a couple of cut-points: generic call handling (instcombine, TLI, SDAG). As soon as it hit truly generic handling with users outside the immediate code, I simply transitioned into or out of a `CallSite` to make this a reasonable sized chunk. Differential Revision: https://reviews.llvm.org/D56122
  25. [X86] Removed unused SDTypeProfile. NFC
  26. [CMake][Fuchsia] Drop libclang.so from distribution This is no longer needed now that all users have switched to clangd.
  27. gn build: Fix clang-tidy dep on ClangSACheckers. Patch by Mirko Bonadei <mbonadei@webrtc.org>! Differential Revision: https://reviews.llvm.org/D57998
  28. long double is double on OpenBSD/NetBSD/PPC. Patch by George Koehler.
Revision 353688 by mkazantsev:
[TEST] Add failing test from PR40454
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/IndVarSimplify/pr40454.llllvm.src/test/Transforms/IndVarSimplify/pr40454.ll
Revision 353687 by kadircet:
[clangd] Make system header mappings available for PreambleParsedCallback

Summary:
SystemHeaderMappings were added only after takeIncludes call, which
resulted in getting mapping on main file ast updates but not on preamble ast
updates.
Fixes https://github.com/clangd/clangd/issues/8

Reviewers: hokein

Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D58029
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/ClangdUnit.cpp (diff)clang-tools-extra.src/clangd/ClangdUnit.cpp
The file was modified/clang-tools-extra/trunk/unittests/clangd/FileIndexTests.cpp (diff)clang-tools-extra.src/unittests/clangd/FileIndexTests.cpp
Revision 353685 by rovka:
test-release.sh: Add option to use ninja

Allow the use of ninja instead of make. This is useful on some
platforms where we'd like to be able to limit the number of link jobs
without slowing down the other steps of the release.

This patch adds a -use-ninja command line option, which sets the
generator to Ninja both for LLVM and the test-suite. It also deals with
some differences between make and ninja:
* DESTDIR handling - ninja doesn't like this to be listed after the
  target, but both make and ninja can handle it before the command
* Verbose mode - ninja uses -v, make uses VERBOSE=1
* Keep going mode - make has a -k mode, which builds as much as possible
  even when failures are encountered; for ninja we need to set a hard
  limit (we use 100 since most people won't look at 100 failures anyway)

I haven't tested with gmake.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/release/test-release.sh (diff)llvm.src/utils/release/test-release.sh
Revision 353684 by martong:
[ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces

Summary:
We add a new test to show that redecl chains are not handled properly
amongst namespaces. We cannot pass this test now, so this is disabled.
Subsequent patches will make this test pass.

Reviewers: a_sidorin, shafik, a.sidorin

Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57901
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/AST/ASTImporterTest.cpp (diff)clang.src/unittests/AST/ASTImporterTest.cpp
Revision 353683 by evgeny777:
Attempt to fix buildbot after r353679 #2
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/Error.h (diff)llvm.src/include/llvm/Support/Error.h
Revision 353682 by carlos.alberto.enciso:
[DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Check that when SimplifyCFG is flattening a 'br', all their debug intrinsic instructions are removed, including any dbg.label referencing a label associated with the basic blocks being removed.

As the test case involves a CFG transformation, move it to the correct location.

Differential Revision: https://reviews.llvm.org/D57444
Change TypePath in RepositoryPath in Workspace
The file was removed/llvm/trunk/test/CodeGen/X86/bbi-23595.llllvm.src/test/CodeGen/X86/bbi-23595.ll
The file was added/llvm/trunk/test/Transforms/SimplifyCFG/bbi-23595.llllvm.src/test/Transforms/SimplifyCFG/bbi-23595.ll
Revision 353681 by evgeny777:
Attempt to fix buildbot after r353679
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/Error.h (diff)llvm.src/include/llvm/Support/Error.h
Revision 353679 by evgeny777:
Small refactoring of FileError. NFC.

Differential revision: https://reviews.llvm.org/D57945
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/Error.h (diff)llvm.src/include/llvm/Support/Error.h
The file was modified/llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp (diff)llvm.src/tools/llvm-objcopy/CopyConfig.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp (diff)llvm.src/tools/llvm-objcopy/llvm-objcopy.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.h (diff)llvm.src/tools/llvm-objcopy/llvm-objcopy.h
Revision 353678 by sjoerdmeijer:
[ARM] LoadStoreOptimizer: reoder limit

The whole design of generating LDMs/STMs is fragile and unreliable: it depends on
rescheduling here in the LoadStoreOptimizer that isn't register pressure aware
and regalloc that isn't aware of generating LDMs/STMs.
This patch adds a (hidden) option to control the total number of instructions that
can be re-ordered. I appreciate this looks only a tiny bit better than a hard-coded
constant, but at least it allows more easy experimentation with different values
for now. Ideally we calculate this reorder limit based on some heuristics, and take
register pressure into account. I might be looking into that next.

Differential Revision: https://reviews.llvm.org/D57954
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp (diff)llvm.src/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
The file was modified/llvm/trunk/test/CodeGen/ARM/prera-ldst-insertpt.mir (diff)llvm.src/test/CodeGen/ARM/prera-ldst-insertpt.mir
Revision 353676 by chandlerc:
Move CFLGraph and the AA summary code over to the new `CallBase`
instruction base class rather than the `CallSite` wrapper.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/AliasAnalysisSummary.cpp (diff)llvm.src/lib/Analysis/AliasAnalysisSummary.cpp
The file was modified/llvm/trunk/lib/Analysis/AliasAnalysisSummary.h (diff)llvm.src/lib/Analysis/AliasAnalysisSummary.h
The file was modified/llvm/trunk/lib/Analysis/CFLGraph.h (diff)llvm.src/lib/Analysis/CFLGraph.h
Revision 353674 by mgorny:
[llvm] [cmake] Use current directory in GenerateVersionFromVCS

Find dependent scripts of GenerateVersionFromVCS in current directory
rather than ../../cmake/modules.  I do not see any reason why the former
would not work and The latter is incorrect when GenerateVersionFromVCS
is used from install directory (i.e. in stand-alone builds).

Differential Revision: https://reviews.llvm.org/D57996
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/modules/GenerateVersionFromVCS.cmake (diff)llvm.src/cmake/modules/GenerateVersionFromVCS.cmake
Revision 353673 by chandlerc:
Remove `CallSite` from the CodeMetrics analysis, moving it to the new
`CallBase` and simpler APIs therein.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/CodeMetrics.h (diff)llvm.src/include/llvm/Analysis/CodeMetrics.h
The file was modified/llvm/trunk/lib/Analysis/CodeMetrics.cpp (diff)llvm.src/lib/Analysis/CodeMetrics.cpp
Revision 353672 by chandlerc:
Remove a declaration that is dead, and not even implemented any longer.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/CodeMetrics.h (diff)llvm.src/include/llvm/Analysis/CodeMetrics.h
Revision 353671 by phosek:
[libcxx] Preserve order, avoid duplicates when merging static archives

glob can return files in arbitrary order which breaks deterministic
builds. Rather, use `ar t` to list the files in each archive and
preserve the original order. Using `ar q` results in duplicate entries
in the archive, instead use `ar r` to avoid duplicates.

Differential Revision: https://reviews.llvm.org/D58024
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/utils/merge_archives.py (diff)libcxx.src/utils/merge_archives.py
Revision 353670 by sjoerdmeijer:
[ARM] LoadStoreOptimizer: just a clean-up. NFC.

Differential Revision: https://reviews.llvm.org/D57955
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp (diff)llvm.src/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
Revision 353669 by chandlerc:
The new file header didn't get carried over when these files were
"moved" somehow, update them to use it.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/utils/docker/scripts/build_gcc_version.sh (diff)libcxx.src/utils/docker/scripts/build_gcc_version.sh
The file was modified/libcxx/trunk/utils/docker/scripts/build_llvm_version.sh (diff)libcxx.src/utils/docker/scripts/build_llvm_version.sh
Revision 353668 by chandlerc:
Update some newly added files that mistakenly used the old file header
to the new one.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/test/std/containers/associative/map/gcc_workaround.pass.cpp (diff)libcxx.src/test/std/containers/associative/map/gcc_workaround.pass.cpp
The file was modified/libcxx/trunk/test/std/containers/associative/set/gcc_workaround.pass.cpp (diff)libcxx.src/test/std/containers/associative/set/gcc_workaround.pass.cpp
Revision 353667 by chandlerc:
Update more files added with the old header to the new one.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/Scalar/LowerWidenableCondition.h (diff)llvm.src/include/llvm/Transforms/Scalar/LowerWidenableCondition.h
The file was modified/llvm/trunk/lib/Transforms/Scalar/LowerWidenableCondition.cpp (diff)llvm.src/lib/Transforms/Scalar/LowerWidenableCondition.cpp
Revision 353666 by chandlerc:
Update new files added to llvm-objcopy to use the new file header.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/MachOObjcopy.cpp (diff)llvm.src/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/MachOObjcopy.h (diff)llvm.src/tools/llvm-objcopy/MachO/MachOObjcopy.h
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.cpp (diff)llvm.src/tools/llvm-objcopy/MachO/MachOReader.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.h (diff)llvm.src/tools/llvm-objcopy/MachO/MachOReader.h
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/MachOWriter.cpp (diff)llvm.src/tools/llvm-objcopy/MachO/MachOWriter.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/MachOWriter.h (diff)llvm.src/tools/llvm-objcopy/MachO/MachOWriter.h
The file was modified/llvm/trunk/tools/llvm-objcopy/MachO/Object.h (diff)llvm.src/tools/llvm-objcopy/MachO/Object.h
Revision 353665 by chandlerc:
Update files that were mistakenly added with the old file header to the
new one.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Vectorize/VPlanPredicator.cpp (diff)llvm.src/lib/Transforms/Vectorize/VPlanPredicator.cpp
The file was modified/llvm/trunk/lib/Transforms/Vectorize/VPlanPredicator.h (diff)llvm.src/lib/Transforms/Vectorize/VPlanPredicator.h
The file was modified/llvm/trunk/unittests/Transforms/Vectorize/VPlanPredicatorTest.cpp (diff)llvm.src/unittests/Transforms/Vectorize/VPlanPredicatorTest.cpp
Revision 353664 by chandlerc:
Update files that were mistakenly added with the old file header.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/unittests/CodeGen/TypeTraitsTest.cpp (diff)llvm.src/unittests/CodeGen/TypeTraitsTest.cpp
Revision 353662 by chandlerc:
[CallSite removal] Port InstSimplify over to use `CallBase` both in its
interface and implementation.

Port code with: `cast<CallBase>(CS.getInstruction())`.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/InstructionSimplify.h (diff)llvm.src/include/llvm/Analysis/InstructionSimplify.h
The file was modified/llvm/trunk/lib/Analysis/InstructionSimplify.cpp (diff)llvm.src/lib/Analysis/InstructionSimplify.cpp
Revision 353661 by chandlerc:
[CallSite removal] Migrate ConstantFolding APIs and implementation to
`CallBase`.

Users have been updated. You can see how to update any out-of-tree
usages: pass `cast<CallBase>(CS.getInstruction())`.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/ConstantFolding.h (diff)llvm.src/include/llvm/Analysis/ConstantFolding.h
The file was modified/llvm/trunk/lib/Analysis/ConstantFolding.cpp (diff)llvm.src/lib/Analysis/ConstantFolding.cpp
The file was modified/llvm/trunk/lib/Analysis/InlineCost.cpp (diff)llvm.src/lib/Analysis/InlineCost.cpp
The file was modified/llvm/trunk/lib/Analysis/InstructionSimplify.cpp (diff)llvm.src/lib/Analysis/InstructionSimplify.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/SCCP.cpp (diff)llvm.src/lib/Transforms/Scalar/SCCP.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/Evaluator.cpp (diff)llvm.src/lib/Transforms/Utils/Evaluator.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/Local.cpp (diff)llvm.src/lib/Transforms/Utils/Local.cpp
Revision 353660 by chandlerc:
[CallSite removal] Migrate the statepoint GC infrastructure to use the
`CallBase` class rather than `CallSite` wrappers.

I pushed this change down through most of the statepoint infrastructure,
completely removing the use of CallSite where I could reasonably do so.
I ended up making a couple of cut-points: generic call handling
(instcombine, TLI, SDAG). As soon as it hit truly generic handling with
users outside the immediate code, I simply transitioned into or out of
a `CallSite` to make this a reasonable sized chunk.

Differential Revision: https://reviews.llvm.org/D56122
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/TargetLowering.h (diff)llvm.src/include/llvm/CodeGen/TargetLowering.h
The file was modified/llvm/trunk/include/llvm/IR/Statepoint.h (diff)llvm.src/include/llvm/IR/Statepoint.h
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/Local.h (diff)llvm.src/include/llvm/Transforms/Utils/Local.h
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h (diff)llvm.src/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/StatepointLowering.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/TargetLowering.cpp
The file was modified/llvm/trunk/lib/IR/Statepoint.cpp (diff)llvm.src/lib/IR/Statepoint.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/PlaceSafepoints.cpp (diff)llvm.src/lib/Transforms/Scalar/PlaceSafepoints.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp (diff)llvm.src/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/Local.cpp (diff)llvm.src/lib/Transforms/Utils/Local.cpp
Revision 353659 by ctopper:
[X86] Removed unused SDTypeProfile. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86InstrFPStack.td (diff)llvm.src/lib/Target/X86/X86InstrFPStack.td
Revision 353658 by phosek:
[CMake][Fuchsia] Drop libclang.so from distribution

This is no longer needed now that all users have switched to clangd.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/cmake/caches/Fuchsia-stage2.cmake (diff)clang.src/cmake/caches/Fuchsia-stage2.cmake
Revision 353657 by nico:
gn build: Fix clang-tidy dep on ClangSACheckers.

Patch by Mirko Bonadei <mbonadei@webrtc.org>!

Differential Revision: https://reviews.llvm.org/D57998
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
Revision 353656 by brad:
long double is double on OpenBSD/NetBSD/PPC.

Patch by George Koehler.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Basic/Targets/PPC.h (diff)clang.src/lib/Basic/Targets/PPC.h
The file was modified/cfe/trunk/test/CodeGen/powerpc_types.c (diff)clang.src/test/CodeGen/powerpc_types.c