FailedChanges

Summary

  1. Move multiline raw string literal out of macro. NFC Certain combinations of gcc and ccache fail when the raw string literal is preprocessed. This just moves the string out as is done elsewhere in the same file.
  2. Revert r354199: Make Optional<T> Trivially Copyable when T is trivially copyable
  3. Make Optional<T> Trivially Copyable when T is trivially copyable This is another attempt in the process, works nicely on my setup, let's check how it behaves on other targets.
  4. [compiler-rt] Cleanup usage of C++ ABI library Add missed value "libcxxabi" and introduce SANITIZER_TEST_CXX for linking unit tests. This needs to be a full C++ library and cannot be libcxxabi. Recommit r354132 which I reverted in r354153 because it broke a sanitizer bot. This was because of the "fixes" for pthread linking, so I've removed these changes. Differential Revision: https://reviews.llvm.org/D58012
  5. [X86] When type legalizing the result of a i64 fp_to_uint on 32-bit targets. Generate all of the ops as i64 and let them be legalized. No need to manually split everything. We can let the type legalizer work for us. The test change seems to be caused by some DAG ordering issue that was previously circumventing a one use check in LowerSELECT where FP selects are turned into blends if the setcc has one use. But it was running after an integer select and the same setcc had been legalized to cmov and X86SISD::CMP. This dropped the use count of the setcc, but wasn't what was intended.
  6. llvm-nm: Observe -no-llvm-bc for archive members Summary: This change fixes the `-no-llvm-bc` flag to work with object files within archives. Currently the `-no-llvm-bc` flag works for regular object files, but not static libraries, where it continues to show bitcode symbol info. Original support was added in D4371. Reviewers: compnerd, smeenai, pcc Reviewed By: compnerd Subscribers: rupprecht, keith, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D48798
  7. [clang-tidy] Delete obsolete objc-property-declaration options ✂️ Summary: The Acronyms and IncludeDefaultAcronyms options were deprecated in https://reviews.llvm.org/D51832. These options can be removed. Tested by running the clang-tidy tests. This is an amended resubmission of https://reviews.llvm.org/D56945. Reviewers: Eugene.Zelenko, aaron.ballman Reviewed By: aaron.ballman Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D57080
  8. [CMake] Use variables rather than ":" delimiters This is a follow up to D37644, this block was missed in that change. Differential Revision: https://reviews.llvm.org/D58093
  9. [X86] Don't prevent load folding for cvtsi2ss/cvtsi2sd based on hasPartialRegUpdate. Preventing the load fold won't fix the partial register update since the input we can fold is a GPR. So it will do nothing to prevent a false dependency on an XMM register.
Revision 354201 by dmgreen:
Move multiline raw string literal out of macro. NFC

Certain combinations of gcc and ccache fail when the raw
string literal is preprocessed. This just moves the string
out as is done elsewhere in the same file.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp (diff)clang.src/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Revision 354200 by serge_sans_paille:
Revert r354199: Make Optional<T> Trivially Copyable when T is trivially copyable
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/Optional.h (diff)llvm.src/include/llvm/ADT/Optional.h
The file was modified/llvm/trunk/unittests/ADT/OptionalTest.cpp (diff)llvm.src/unittests/ADT/OptionalTest.cpp
Revision 354199 by serge_sans_paille:
Make Optional<T> Trivially Copyable when T is trivially copyable

This is another attempt in the process, works nicely on my setup,
let's check how it behaves on other targets.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/Optional.h (diff)llvm.src/include/llvm/ADT/Optional.h
The file was modified/llvm/trunk/unittests/ADT/OptionalTest.cpp (diff)llvm.src/unittests/ADT/OptionalTest.cpp
Revision 354198 by hahnfeld:
[compiler-rt] Cleanup usage of C++ ABI library

Add missed value "libcxxabi" and introduce SANITIZER_TEST_CXX for linking
unit tests. This needs to be a full C++ library and cannot be libcxxabi.

Recommit r354132 which I reverted in r354153 because it broke a sanitizer
bot. This was because of the "fixes" for pthread linking, so I've removed
these changes.

Differential Revision: https://reviews.llvm.org/D58012
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/CMakeLists.txt (diff)compiler-rt.src/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/asan/CMakeLists.txt (diff)compiler-rt.src/lib/asan/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/fuzzer/tests/CMakeLists.txt (diff)compiler-rt.src/lib/fuzzer/tests/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/hwasan/CMakeLists.txt (diff)compiler-rt.src/lib/hwasan/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/scudo/CMakeLists.txt (diff)compiler-rt.src/lib/scudo/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/scudo/standalone/tests/CMakeLists.txt (diff)compiler-rt.src/lib/scudo/standalone/tests/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/tsan/dd/CMakeLists.txt (diff)compiler-rt.src/lib/tsan/dd/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/tsan/tests/CMakeLists.txt (diff)compiler-rt.src/lib/tsan/tests/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/ubsan/CMakeLists.txt (diff)compiler-rt.src/lib/ubsan/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/xray/tests/CMakeLists.txt (diff)compiler-rt.src/lib/xray/tests/CMakeLists.txt
Revision 354197 by ctopper:
[X86] When type legalizing the result of a i64 fp_to_uint on 32-bit targets. Generate all of the ops as i64 and let them be legalized.

No need to manually split everything. We can let the type legalizer work for us.

The test change seems to be caused by some DAG ordering issue that was previously circumventing a one use check in LowerSELECT where FP selects are turned into blends if the setcc has one use. But it was running after an integer select and the same setcc had been legalized to cmov and X86SISD::CMP. This dropped the use count of the setcc, but wasn't what was intended.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/vec_cast3.ll (diff)llvm.src/test/CodeGen/X86/vec_cast3.ll
Revision 354196 by kastiglione:
llvm-nm: Observe -no-llvm-bc for archive members

Summary:
This change fixes the `-no-llvm-bc` flag to work with object files within
archives. Currently the `-no-llvm-bc` flag works for regular object files, but
not static libraries, where it continues to show bitcode symbol info.

Original support was added in D4371.

Reviewers: compnerd, smeenai, pcc

Reviewed By: compnerd

Subscribers: rupprecht, keith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D48798
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/tools/llvm-nm/X86/archive-no-llvm-bc.testllvm.src/test/tools/llvm-nm/X86/archive-no-llvm-bc.test
The file was modified/llvm/trunk/tools/llvm-nm/llvm-nm.cpp (diff)llvm.src/tools/llvm-nm/llvm-nm.cpp
Revision 354195 by stephanemoore:
[clang-tidy] Delete obsolete objc-property-declaration options ✂️

Summary:
The Acronyms and IncludeDefaultAcronyms options were deprecated in
https://reviews.llvm.org/D51832. These options can be removed.

Tested by running the clang-tidy tests.

This is an amended resubmission of https://reviews.llvm.org/D56945.

Reviewers: Eugene.Zelenko, aaron.ballman

Reviewed By: aaron.ballman

Subscribers: xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57080
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.cpp (diff)clang-tools-extra.src/clang-tidy/objc/PropertyDeclarationCheck.cpp
The file was modified/clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.h (diff)clang-tools-extra.src/clang-tidy/objc/PropertyDeclarationCheck.h
The file was modified/clang-tools-extra/trunk/docs/ReleaseNotes.rst (diff)clang-tools-extra.src/docs/ReleaseNotes.rst
The file was modified/clang-tools-extra/trunk/docs/clang-tidy/checks/objc-property-declaration.rst (diff)clang-tools-extra.src/docs/clang-tidy/checks/objc-property-declaration.rst
Revision 354194 by phosek:
[CMake] Use variables rather than ":" delimiters

This is a follow up to D37644, this block was missed in that change.

Differential Revision: https://reviews.llvm.org/D58093
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/runtimes/CMakeLists.txt (diff)llvm.src/runtimes/CMakeLists.txt
Revision 354193 by ctopper:
[X86] Don't prevent load folding for cvtsi2ss/cvtsi2sd based on hasPartialRegUpdate.

Preventing the load fold won't fix the partial register update since the
input we can fold is a GPR. So it will do nothing to prevent a false dependency
on an XMM register.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86InstrInfo.cpp (diff)llvm.src/lib/Target/X86/X86InstrInfo.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/fast-isel-int-float-conversion-x86-64.ll (diff)llvm.src/test/CodeGen/X86/fast-isel-int-float-conversion-x86-64.ll
The file was modified/llvm/trunk/test/CodeGen/X86/fast-isel-int-float-conversion.ll (diff)llvm.src/test/CodeGen/X86/fast-isel-int-float-conversion.ll
The file was modified/llvm/trunk/test/CodeGen/X86/fast-isel-uint-float-conversion-x86-64.ll (diff)llvm.src/test/CodeGen/X86/fast-isel-uint-float-conversion-x86-64.ll
The file was modified/llvm/trunk/test/CodeGen/X86/fast-isel-uint-float-conversion.ll (diff)llvm.src/test/CodeGen/X86/fast-isel-uint-float-conversion.ll
The file was modified/llvm/trunk/test/CodeGen/X86/stack-folding-fp-avx1.ll (diff)llvm.src/test/CodeGen/X86/stack-folding-fp-avx1.ll
The file was modified/llvm/trunk/test/CodeGen/X86/stack-folding-fp-sse42.ll (diff)llvm.src/test/CodeGen/X86/stack-folding-fp-sse42.ll