FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-zorg.git)

Summary

  1. [libc builder] Add integration test step to non asan builds. (details)
  2. [libc builder] Fix type in integration test command. (details)
Commit fdece131fdcc2bd0ea9e919592b07e5a56a6b9fa by paulatoth
[libc builder] Add integration test step to non asan builds.

Reviewers: sivachandra

Reviewed By: sivachandra

Tags: #zorg

Differential Revision: https://reviews.llvm.org/D81039
The file was modifiedzorg/buildbot/builders/annotated/libc-linux.py
Commit d93182bd9603056049608bc9d26fa5f003ed216d by paulatoth
[libc builder] Fix type in integration test command.
The file was modifiedzorg/buildbot/builders/annotated/libc-linux.py

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [llvm] Fix unused variable warning (details)
  2. PR23029 / C++ DR2233: Allow expanded parameter packs to follow (details)
  3. [X86] Cleanup inconsistencies in our zext/sext vector patterns. (details)
  4. [LLD] Have only one SpecificAllocator per type (details)
  5. [X86] Remove DeleteNode calls from PreprocessISelDAG. Rely on the RemoveDeadNodes call at the end. (details)
  6. Undo removal of test for dr777. (details)
  7. [mlir] NFC - Add AffineMinMaxOpBase getDim/SymbolOperands (details)
  8. Undo initialization of TRI in CGP as this is unconditionally initialized (details)
  9. [lld-macho] Fix PAGEZERO=4GB errors on Windows by ensuring enum is uint64_t (details)
  10. [mlir][Affine] Enable fusion of loops with vector loads/stores (details)
  11. [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer (details)
  12. [Analyzer][NFC] Fix markup in WebKit checkers documentation (details)
  13. [StackSafety] Delete useless test (details)
  14. [MTE] Convert StackSafety into analysis (details)
  15. [lldb/Test] Don't use the env to pass around configuration variables (NFC) (details)
  16. [X86] Add a flag to guard the wide load (details)
  17. [mlir][spirv] Fix encoding of cooperative matrix type to match SPIRV spec (details)
  18. [mlir][spirv] Fix coop matrix getExtension (details)
  19. [lldb/Test] Pass Make arguments in invocation instead of environment (details)
  20. [lldb/Test] Don't use the env to pass around configuration variables (NFC) (details)
  21. Remove redundant code (NFC) (details)
  22. [SampleFDO] Add use-sample-profile function attribute. (details)
  23. [MTE] Move tagging in pipeline (details)
  24. [NFC, StackSafety] Change type of internal container (details)
  25. [NFC,MTE] Drop unneeded attribute from test (details)
  26. [JumpThreading] Simplify FindMostPopularDest (NFC) (details)
  27. [AArch64][GlobalISel] Select zip1 and zip2 (details)
  28. Revert "[NFC, StackSafety] Change type of internal container" (details)
  29. Replace dyn_cast<>() with isa<>() when the result isn't used (NFC) (details)
  30. [AMDGPU] Make SGPR spills exec mask agnostic (details)
  31. Fix build: TableGen uses `is<T>` instead of `isa<T>` as predicate (details)
  32. [lldb/Interpreter] Remove redundant argument (NFC) (details)
  33. [flang] Implemented 2 Semantic checks for DATA statement and fixed a few bugs (details)
  34. [Support] Add file lock/unlock functions (details)
  35. [X86] Add CLWB to Tremont CPU. Remove CLDEMOTE, MOVDIRI, MOVDIR64B, and WAITPKG to match gcc. (details)
  36. [CodeGen] Fix warnings in getPackedVectorTypeFromPredicateType (details)
  37. [NFC][PowerPC] Remove unused node PPCISD::VMADDFP and PPCISD::VNMSUBFP (details)
  38. [Driver] Add negative option for -fkeep-static-consts (details)
  39. [NFC, StackSafety] Change type of internal container (details)
  40. [StackSafety] Skip non-pointer parameters (details)
  41. [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming (details)
  42. Revert "[WebAssembly] Eliminate range checks on br_tables" (details)
  43. [gn build] Port 755a8959152 (details)
  44. [AMDGPU/MemOpsCluster] Code clean-up around accessing of memory operand width (details)
  45. [AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (details)
  46. [StackSafety,NFC] Rename internal class (details)
  47. [StackSafety,NFC] Convert to template internal stuff (details)
  48. Revert "[Support] Add file lock/unlock functions" (details)
  49. [AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix) (details)
  50. Syntax tree: ignore implicit expressions at the top level of statements (details)
  51. Split syntax tree tests into more granular ones (details)
  52. [CSInfo][MIPS][DwarfDebug] Add support for delay slots (details)
  53. [NFC,StackSafety] Fix template arg name (details)
  54. [llvm] Fix unused variable warnings (details)
  55. [mlir][Linalg] NFC - Make markers use Identifier instead of StringRef (details)
  56. TargetFrameLowering.h - remove unnecessary includes. NFC. (details)
  57. Fix MSVC "not all control paths return a value" warning. NFC. (details)
Commit af86a10bad28d1829370bfa9b8b7bb9302f637d2 by kadircet
[llvm] Fix unused variable warning
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Commit b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8 by richard
PR23029 / C++ DR2233: Allow expanded parameter packs to follow
parameters with default arguments.

Directly follow the wording by relaxing the AST invariant that all
parameters after one with a default arguemnt also have default
arguments, and removing the diagnostic on missing default arguments
on a pack-expanded parameter following a parameter with a default
argument.

Testing also revealed that we need to special-case explicit
specializations of templates with a pack following a parameter with a
default argument, as such explicit specializations are otherwise
impossible to write. The standard wording doesn't address this case; a
issue has been filed.

This exposed a bug where we would briefly consider a parameter to have
no default argument while we parse a delay-parsed default argument for
that parameter, which is also fixed.

Partially incorporates a patch by Raul Tambre.
The file was addedclang/test/CXX/expr/expr.post/expr.call/p4.cpp
The file was modifiedclang/test/SemaCXX/warn-bool-conversion.cpp
The file was modifiedclang/www/cxx_dr_status.html
The file was modifiedclang/lib/AST/DeclCXX.cpp
The file was modifiedclang/lib/Sema/SemaOverload.cpp
The file was modifiedclang/include/clang/AST/Decl.h
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p5-cxx03-extra-copy.cpp
The file was modifiedclang/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p5-cxx0x-no-extra-copy.cpp
The file was modifiedclang/test/SemaCXX/abstract.cpp
The file was modifiedclang/test/SemaCXX/constant-expression-cxx11.cpp
The file was modifiedclang/include/clang/Sema/Template.h
The file was modifiedclang/lib/Sema/SemaDeclCXX.cpp
The file was modifiedclang/test/SemaCXX/decl-init-ref.cpp
The file was modifiedclang/lib/Sema/SemaTemplateInstantiateDecl.cpp
The file was modifiedclang/test/CXX/drs/dr1xx.cpp
The file was modifiedclang/test/CXX/drs/dr0xx.cpp
The file was modifiedclang/lib/AST/Decl.cpp
The file was modifiedclang/test/CXX/drs/dr22xx.cpp
The file was modifiedclang/test/CXX/drs/dr7xx.cpp
The file was modifiedclang/test/SemaCXX/implicit-exception-spec.cpp
The file was modifiedclang/lib/Sema/SemaTemplateInstantiate.cpp
Commit ca4bd052f68c11a95fe7ac4f115b82ea05dd1c08 by craig.topper
[X86] Cleanup inconsistencies in our zext/sext vector patterns.

-Fix one place where we had a X86vzload64 but should have had
X86vzload32.
-Make sure all patterns that have scalar_to_vector+loadi64 also
have scalar_to_vector+f64 to match 32-bit codegen.
-Add some bitcasts that were missing from patterns.
-Make sure that if we have a scalar_to_vector+load pattern
we also have a vzload pattern.

We probably need some better canonicalization to avoid having
so many patterns.
The file was modifiedllvm/lib/Target/X86/X86InstrAVX512.td
The file was modifiedllvm/lib/Target/X86/X86InstrSSE.td
Commit 3eb16fe4e945631988d6d302d0bc317d8c07279c by rnk
[LLD] Have only one SpecificAllocator per type

Previously, the SpecificAllocator was a static local in the `make<T>`
function template. Using static locals is nice because they are only
constructed and registered if they are accessed. However, if there are
multiple calls to make<> with different constructor parameters, we would
get multiple static local variable instances. This is undesirable and
leads to extra memory allocations. I noticed there were two sources of
DefinedRegular allocations while checking heap profiles.
The file was modifiedlld/include/lld/Common/Memory.h
Commit 961c1b5f7244e0fca93b504a6d234476e17adbbe by craig.topper
[X86] Remove DeleteNode calls from PreprocessISelDAG. Rely on the RemoveDeadNodes call at the end.

Add a MadeChange flag so we don't call RemoveDeadNodes unless
something changed.
The file was modifiedllvm/lib/Target/X86/X86ISelDAGToDAG.cpp
Commit 16437992cac249f6fe1efd392d20e3469b47e39e by richard
Undo removal of test for dr777.
The file was modifiedclang/test/CXX/drs/dr7xx.cpp
The file was modifiedclang/www/cxx_dr_status.html
Commit 7de45878059a4e38dd6ceba43a058cee5d283b97 by ntv
[mlir] NFC - Add AffineMinMaxOpBase getDim/SymbolOperands
The file was modifiedmlir/include/mlir/Dialect/Affine/IR/AffineOps.td
Commit 153a24ab0fc5e1caa2bc304933870bfb5f7198e6 by echristo
Undo initialization of TRI in CGP as this is unconditionally initialized
later.
The file was modifiedllvm/lib/CodeGen/CodeGenPrepare.cpp
Commit d767de44bf9527cb5058f5fe16aac2f23c21977c by jezng
[lld-macho] Fix PAGEZERO=4GB errors on Windows by ensuring enum is uint64_t

It appears that MSVC doesn't resize the enum properly to fit the
constants.
The file was modifiedlld/MachO/Target.h
Commit 8a418e5f8e89af7197e2d7dc10e39885b05fe0b8 by diego.caballero
[mlir][Affine] Enable fusion of loops with vector loads/stores

This patch enables affine loop fusion for loops with affine vector loads
and stores. For that, we only had to use affine memory op interfaces in
LoopFusionUtils.cpp and Utils.cpp so that vector loads and stores are
also taken into account.

Reviewed By: andydavis1, ftynse

Differential Revision: https://reviews.llvm.org/D80971
The file was modifiedmlir/lib/Transforms/Utils/LoopFusionUtils.cpp
The file was modifiedmlir/include/mlir/Dialect/Affine/IR/AffineMemoryOpInterfaces.td
The file was modifiedmlir/lib/Transforms/Utils/Utils.cpp
The file was modifiedmlir/include/mlir/Dialect/Affine/IR/AffineOps.td
The file was modifiedmlir/test/Transforms/loop-fusion.mlir
Commit 8eda71616fecd098cbd7d2447859c8ac1315966f by ndesaulniers
[Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

Summary:
An upgrade of LLVM for CrOS [0] containing [1] triggered a bunch of
errors related to writing to reserved registers for a Linux kernel's
arm64 compat vdso (which is a aarch32 image).

After a discussion on LKML [2], it was determined that
-f{no-}omit-frame-pointer was not being specified. Comparing GCC and
Clang [3], it becomes apparent that GCC defaults to omitting the frame
pointer implicitly when optimizations are enabled, and Clang does not.
ie. setting -O1 (or above) implies -fomit-frame-pointer. Clang was
defaulting to -fno-omit-frame-pointer implicitly unless -fomit-frame-pointer
was set explicitly.

Why this becomes a problem is that the Linux kernel's arm64 compat vdso
contains code that uses r7. r7 is used sometimes for the frame pointer
(for example, when targeting thumb (-mthumb)). See useR7AsFramePointer()
in llvm/llvm-project/llvm/lib/Target/ARM/ARMSubtarget.h. This is mostly
for legacy/compatibility reasons, and the 2019 Q4 revision of the ARM
AAPCS looks to standardize r11 as the frame pointer for aarch32, though
this is not yet implemented in LLVM.

Users that are reliant on the implicit value if unspecified when
optimizations are enabled should explicitly choose -fomit-frame-pointer
(new behavior) or -fno-omit-frame-pointer (old behavior).

[0] https://bugs.chromium.org/p/chromium/issues/detail?id=1084372
[1] https://reviews.llvm.org/D76848
[2] https://lore.kernel.org/lkml/20200526173117.155339-1-ndesaulniers@google.com/
[3] https://godbolt.org/z/0oY39t

Reviewers: kristof.beyls, psmith, danalbert, srhines, MaskRay, ostannard, efriedma

Reviewed By: psmith, danalbert, srhines, MaskRay, efriedma

Subscribers: efriedma, olista01, MaskRay, vhscampos, cfe-commits, llvm-commits, manojgupta, llozano, glider, hctim, eugenis, pcc, peter.smith, srhines

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D80828
The file was modifiedclang/lib/Basic/Targets/ARM.cpp
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/test/Driver/frame-pointer-elim.c
The file was modifiedllvm/docs/ReleaseNotes.rst
Commit 39fa431c8ccad45de9ec67e8681da923d0cd28c7 by Jan Korous
[Analyzer][NFC] Fix markup in WebKit checkers documentation
The file was modifiedclang/docs/analyzer/checkers.rst
Commit fc07c1af69584d71a6a6ab3da7afd4837b08ea37 by Vitaly Buka
[StackSafety] Delete useless test
The file was removedllvm/test/Analysis/StackSafetyAnalysis/scev-udiv.ll
Commit 232d348c6eff8493fc016b1ea8a99db0e5620d81 by Vitaly Buka
[MTE] Convert StackSafety into analysis

This lets us to remove !stack-safe metadata and
better controll when to perform StackSafety
analysis.

Reviewers: eugenis

Subscribers: hiraditya, steven_wu, dexonsmith, cfe-commits, llvm-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D80771
The file was modifiedllvm/lib/Target/AArch64/AArch64StackTagging.cpp
The file was modifiedllvm/test/CodeGen/AArch64/O3-pipeline.ll
The file was removedllvm/test/Analysis/StackSafetyAnalysis/ipa-attr.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetMachine.cpp
The file was modifiedllvm/test/CodeGen/AArch64/stack-tagging.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64.h
The file was modifiedclang/lib/CodeGen/BackendUtil.cpp
The file was modifiedclang/test/Driver/memtag.c
The file was modifiedclang/test/Driver/memtag_lto.c
The file was modifiedllvm/include/llvm/Analysis/StackSafetyAnalysis.h
The file was modifiedllvm/lib/Passes/PassRegistry.def
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 5138a91ef4f365a3e71eec4cea6b4599dfaabf26 by Jonas Devlieghere
[lldb/Test] Don't use the env to pass around configuration variables (NFC)

Don't use the environment to pass values to the builder that are present
in the dotest configuration module. A subsequent patch will pass the
remaining values through the configuration instead of the environment.
The file was modifiedlldb/packages/Python/lldbsuite/test/dotest.py
The file was modifiedlldb/packages/Python/lldbsuite/test/plugins/builder_base.py
Commit 587af86f1d8adc77b229ed27b2f553e99f9710cd by carrot
[X86] Add a flag to guard the wide load

As shown in http://lists.llvm.org/pipermail/llvm-dev/2020-May/141854.html,
widen load can also cause stall. Add a flag to guard the widening code,
so users can disable it and evaluate its performance impact.

Differential Revision: https://reviews.llvm.org/D80943
The file was modifiedllvm/lib/Target/X86/X86ISelDAGToDAG.cpp
The file was addedllvm/test/CodeGen/X86/no-wide-load.ll
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.td
Commit bbe79e27bdfbf59838e4d409038aef78a8161989 by thomasraoux
[mlir][spirv] Fix encoding of cooperative matrix type to match SPIRV spec

Scope, rows and columns need to be encoded in a separate constant operation.

Differential Revision: https://reviews.llvm.org/D80852
The file was modifiedmlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp
The file was modifiedmlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
Commit 81dd3a47189ec2e2c83d5948748dcfadb9463923 by thomasraoux
[mlir][spirv] Fix coop matrix getExtension

Stack variable was being used beyond its lifetime.

Differential Revision: https://reviews.llvm.org/D80948
The file was modifiedmlir/lib/Dialect/SPIRV/SPIRVTypes.cpp
Commit 393ac216489773e3676ec7d80c3d993f78a29b6a by Jonas Devlieghere
[lldb/Test] Pass Make arguments in invocation instead of environment

The Darwin builder is passing some of the make arguments trough the
environment instead of the command line. Update the dsym builder to do
the same as the other variants.
The file was modifiedlldb/packages/Python/lldbsuite/test/plugins/builder_darwin.py
Commit 4c53d4801cbbb1b573e4ef758f93ead12e1f59a2 by Jonas Devlieghere
[lldb/Test] Don't use the env to pass around configuration variables (NFC)

Don't use the environment to pass values to the builder. Use the
configuration instead.
The file was modifiedlldb/packages/Python/lldbsuite/test/lldbtest.py
The file was modifiedlldb/packages/Python/lldbsuite/test/dotest.py
The file was modifiedlldb/packages/Python/lldbsuite/test/configuration.py
The file was modifiedlldb/packages/Python/lldbsuite/test/plugins/builder_base.py
Commit 2d2a603d663328e25774982947e3a8a65e098678 by Adrian Prantl
Remove redundant code (NFC)

This has no effect on the testsuite and was only needed in an early
prototype from before debugserver was able to report the correct
platform.
The file was modifiedlldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
Commit 7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56 by wmi
[SampleFDO] Add use-sample-profile function attribute.

When sampleFDO is enabled, people may expect they can use
-fno-profile-sample-use to opt-out using sample profile for a certain file.
That could be either for debugging purpose or for performance tuning purpose.
However, when thinlto is enabled, if a function in file A compiled with
-fno-profile-sample-use is imported to another file B compiled with
-fprofile-sample-use, the inlined copy of the function in file B may still
get its profile annotated.

The inconsistency may even introduce profile unused warning because if the
target is not compiled with explicit debug information flag, the function
in file A won't have its debug information enabled (debug information will
be enabled implicitly only when -fprofile-sample-use is used). After it is
imported into file B which is compiled with -fprofile-sample-use, profile
annotation for the outline copy of the function will fail because the
function has no debug information, and that will trigger  profile unused
warning.

We add a new attribute use-sample-profile to control whether a function
will use its sample profile no matter for its outline or inline copies.
That will make the behavior of -fno-profile-sample-use consistent.

Differential Revision: https://reviews.llvm.org/D79959
The file was modifiedllvm/test/Transforms/SampleProfile/inline-stats.ll
The file was addedllvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-topdown.ll
The file was modifiedllvm/test/Transforms/SampleProfile/discriminator.ll
The file was modifiedllvm/test/LTO/Resolution/X86/load-sample-prof-icp.ll
The file was modifiedllvm/test/Transforms/SampleProfile/profile-sample-accurate.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-coverage.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-cold-callsite-samplepgo.ll
The file was modifiedllvm/test/LTO/Resolution/X86/load-sample-prof.ll
The file was modifiedllvm/test/Transforms/SampleProfile/propagate.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-callee-update.ll
The file was modifiedllvm/test/Transforms/SampleProfile/remarks.ll
The file was modifiedllvm/test/Transforms/SampleProfile/section-accurate-samplepgo.ll
The file was modifiedllvm/test/Transforms/SampleProfile/Inputs/profile-symbol-list.ll
The file was modifiedllvm/test/Transforms/SampleProfile/fnptr.ll
The file was modifiedllvm/test/Transforms/SampleProfile/function_metadata.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-combine.ll
The file was modifiedllvm/test/Transforms/SampleProfile/warm-inline-instance.ll
The file was addedllvm/test/Transforms/SampleProfile/Inputs/use-sample-profile-attr.prof
The file was modifiedllvm/lib/Transforms/IPO/SampleProfile.cpp
The file was modifiedllvm/test/Transforms/SampleProfile/nolocinfo.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline.ll
The file was modifiedllvm/test/Transforms/SampleProfile/entry_counts_cold.ll
The file was modifiedllvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
The file was modifiedllvm/test/Transforms/SampleProfile/cov-zero-samples.ll
The file was modifiedllvm/test/Transforms/SampleProfile/early-inline.ll
The file was addedllvm/test/Transforms/Inline/inline-incompat-attrs.ll
The file was modifiedllvm/test/Transforms/SampleProfile/entry_counts_missing_dbginfo.ll
The file was modifiedllvm/test/Transforms/SampleProfile/offset.ll
The file was addedclang/test/CodeGen/use-sample-profile-attr.c
The file was modifiedllvm/test/Transforms/SampleProfile/coverage-warning.ll
The file was modifiedllvm/test/Transforms/SampleProfile/syntax.ll
The file was modifiedllvm/test/Transforms/SampleProfile/gcc-simple.ll
The file was modifiedllvm/test/Transforms/SampleProfile/entry_counts.ll
The file was modifiedllvm/test/Transforms/SampleProfile/profile-format-compress.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-cold.ll
The file was addedllvm/test/Transforms/SampleProfile/use-sample-profile-attr.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-mergeprof.ll
The file was modifiedllvm/test/Transforms/SampleProfile/remap.ll
The file was modifiedllvm/include/llvm/IR/Attributes.td
The file was modifiedllvm/test/Transforms/SampleProfile/calls.ll
The file was modifiedllvm/test/Transforms/SampleProfile/profile-format.ll
The file was modifiedllvm/test/Transforms/SampleProfile/branch.ll
The file was modifiedclang/lib/CodeGen/CodeGenFunction.cpp
The file was modifiedllvm/test/LTO/Resolution/X86/load-sample-prof-lto.ll
The file was modifiedllvm/test/Transforms/SampleProfile/indirect-call.ll
The file was modifiedllvm/test/Transforms/SampleProfile/cold-indirect-call.ll
Commit f48bc44ace1a100bef676e630d5089779e7b87bf by Vitaly Buka
[MTE] Move tagging in pipeline

Summary:
This removes two analyses from pipeline.

Depends on D80771.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80780
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetMachine.cpp
The file was modifiedllvm/test/CodeGen/AArch64/O3-pipeline.ll
Commit f62813e7eae148a6175de28bfa384524a9f2bf94 by Vitaly Buka
[NFC, StackSafety] Change type of internal container

Summary: Depends on D80771.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80847
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 85fdec988fc55d56988d57fa88e2b870f6e0e8e9 by Vitaly Buka
[NFC,MTE] Drop unneeded attribute from test

Summary: Depends on D80847.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: hiraditya, steven_wu, dexonsmith, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D80954
The file was modifiedclang/test/Driver/memtag_lto.c
Commit f355c7fc2f8fb0db829313b8e43f974ed730cf6d by kazu
[JumpThreading] Simplify FindMostPopularDest (NFC)

Summary:
This patch simplifies FindMostPopularDest without changing the
functionality.

Given a list of jump threading destinations, the function finds the
most popular destination.  To ensure determinism when there are
multiple destinations with the highest popularity, the function picks
the first one in the successor list with the highest popularity.

Without this patch:

- The function populates DestPopularity -- a histogram mapping
  destinations to their respective occurrence counts.

- Then we iterate over DestPopularity, looking for the highest
  popularity while building a vector of destinations with the highest
  popularity.

- Finally, we iterate the successor list, looking for the destination
  with the highest popularity.

With this patch:

- We implement DestPopularity with MapVector instead of DenseMap.  We
  populate the map with popularity 0 for all successors in the order
  they appear in the successor list.

- We build the histogram in the same way as before.

- We simply use std::max_element on DestPopularity to find the most
  popular destination.  The use of MapVector ensures determinism.

Reviewers: wmi, efriedma

Reviewed By: wmi

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81030
The file was modifiedllvm/lib/Transforms/Scalar/JumpThreading.cpp
Commit 8b96703652ade915eb444b8dae91ae6a16d32d75 by Jessica Paquette
[AArch64][GlobalISel] Select zip1 and zip2

Port the code to recognize a zip1/zip2 shuffle mask from AArch64ISelLowering
and put it into the post-legalizer combiner.

Add G_ZIP1 and G_ZIP2 to AArch64InstrGISel.td and hook them up as equivalent
nodes to AArch64zip1 and AArch64zip2. This allows us to select them.

Minor code size improvements for SPECINT2000 at -O3 on 197.parser, 252.eon, and
186.crafty.

Differential Revision: https://reviews.llvm.org/D80969
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrGISel.td
The file was modifiedllvm/lib/Target/AArch64/AArch64PostLegalizerCombiner.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64Combine.td
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/select-zip.mir
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-zip.mir
Commit f9bb101d394d62027ba33e132691540f1e63cea8 by joker.eph
Revert "[NFC, StackSafety] Change type of internal container"

This reverts commit f62813e7eae148a6175de28bfa384524a9f2bf94.
GCC 5.3 build is broken.
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit a09bb6d77b39d3f87c76b525b355e158245a63cd by joker.eph
Replace dyn_cast<>() with isa<>() when the result isn't used (NFC)

Fixed warning reported by some GCC version.
The file was modifiedmlir/lib/TableGen/Operator.cpp
Commit da33c96d4762e0e59f1eff16f60d5c1575490331 by carl.ritson
[AMDGPU] Make SGPR spills exec mask agnostic

Explicitly set the exec mask for SGPR spills and reloads.
This fixes a bug where SGPR spills to memory could be incorrect
if the exec mask was 0 (or differed between spill and reload).

Additionally pack scalar subregisters (upto 16/32 per VGPR),
so that the majority of scalar types can be spilt or reloaded
with a simple memory access.  This should amortize some of the
additional overhead of manipulating the exec mask.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D80282
The file was modifiedllvm/test/CodeGen/AMDGPU/control-flow-fastregalloc.ll
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.h
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/spill-scavenge-offset.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/spill-wide-sgpr.ll
The file was addedllvm/test/CodeGen/AMDGPU/sgpr-spill.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/spill-m0.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/partial-sgpr-to-vgpr-spills.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/si-spill-sgpr-stack.ll
Commit 48c800cc1bff13d1f5ae5e457a064cf6627280f1 by joker.eph
Fix build: TableGen uses `is<T>` instead of `isa<T>` as predicate
The file was modifiedmlir/lib/TableGen/Operator.cpp
Commit def72b91950d44a68b8613f25fa1a09926171222 by Jonas Devlieghere
[lldb/Interpreter] Remove redundant argument (NFC)
The file was modifiedlldb/source/Interpreter/CommandReturnObject.cpp
Commit 70f1b4b4122088c1bd7324b519bc449dbfeaf298 by asudhaku
[flang] Implemented 2 Semantic checks for DATA statement and fixed a few bugs

Summary
  - Implemented C876, C877
  - Fixed IsConstantExpr to check C879
  - Fixed bugs in few test cases - data01.f90, block-data01.f90,
  pre-fir-tree02.f90
  - Modified implementation of C8106 to identify all automatic objects
  and modified equivalence01.f90 to reflect the changes

Differential Revision: https://reviews.llvm.org/D78424
The file was modifiedflang/lib/Evaluate/check-expression.cpp
The file was modifiedflang/lib/Semantics/resolve-names-utils.cpp
The file was modifiedflang/test/Semantics/data03.f90
The file was modifiedflang/lib/Semantics/check-data.cpp
The file was modifiedflang/test/Semantics/equivalence01.f90
The file was modifiedflang/lib/Semantics/tools.cpp
The file was modifiedflang/test/Lower/pre-fir-tree02.f90
The file was modifiedflang/include/flang/Semantics/tools.h
The file was addedflang/test/Semantics/data04.f90
The file was modifiedflang/test/Semantics/data01.f90
The file was modifiedflang/test/Semantics/block-data01.f90
Commit f51bc4fb60fbcef26d18eff549fc68307fd46489 by sepavloff
[Support] Add file lock/unlock functions

New functions `lockFile`, `tryLockFile` and `unlockFile` implement
simple file locking. They lock or unlock entire file. This must be
enough to support simulataneous writes to log files in parallel builds.

Differential Revision: https://reviews.llvm.org/D78896
The file was modifiedllvm/lib/Support/Windows/Path.inc
The file was modifiedllvm/unittests/Support/Path.cpp
The file was modifiedllvm/lib/Support/Unix/Path.inc
The file was modifiedllvm/include/llvm/Support/FileSystem.h
Commit bb1d8bf2707bdca89c1f5e719057f1000232ccc3 by craig.topper
[X86] Add CLWB to Tremont CPU. Remove CLDEMOTE, MOVDIRI, MOVDIR64B, and WAITPKG to match gcc.
The file was modifiedclang/lib/Basic/Targets/X86.cpp
The file was modifiedclang/test/Preprocessor/predefined-arch-macros.c
The file was modifiedllvm/lib/Target/X86/X86.td
Commit e602cd878e308133cbbfdb73df686de2aa890bc1 by david.sherwood
[CodeGen] Fix warnings in getPackedVectorTypeFromPredicateType

Use getVectorElementCount() instead of getVectorNumElements().
The code changed in this patch is covered by an existing test:

  CodeGen/AArch64/sve-intrinsics-contiguous-prefetches.ll

Differential Revision: https://reviews.llvm.org/D80615
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
Commit a462561ceec6aa6daffb5ee01dd029dbdaa6d603 by qshanz
[NFC][PowerPC] Remove unused node PPCISD::VMADDFP and PPCISD::VNMSUBFP

These two nodes were added by 69caef2b781130a7d0eeaf8898eb346b6423ae03 in 2005
and they are not used by PowerPC backend anymore. And the ISD::FMA is a prefer
way for VMADDFP if we really want to create that node. For VNMSUBFP, we will
also add a more generic node FNMSUB in D76585 if we really want it.

Reviewed By: qiucf

Differential Revision: https://reviews.llvm.org/D80429
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.h
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrAltivec.td
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.td
Commit ac47588bc4ff5927a01ed6fcd269ce86aba52a7c by shengchen.kan
[Driver] Add negative option for -fkeep-static-consts
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
Commit e128f01be996f5f9a0e0cf5565d8a0696783b85d by Vitaly Buka
[NFC, StackSafety] Change type of internal container

Summary: Depends on D80771.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: mehdi_amini, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80847
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit d3b7f90d00fc23f5e5576e28fe4290b5f1dd0a9d by Vitaly Buka
[StackSafety] Skip non-pointer parameters

Summary: Depends on D80908.

Reviewers: eugenis, pcc

Reviewed By: eugenis

Subscribers: hiraditya, steven_wu, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80956
The file was modifiedllvm/test/Analysis/StackSafetyAnalysis/ipa.ll
The file was modifiedllvm/test/Analysis/StackSafetyAnalysis/memintrin.ll
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
The file was modifiedllvm/test/Analysis/StackSafetyAnalysis/local.ll
Commit 65fa0a9f7f3e6090e335c14f9edea19358d87613 by n.james93
[clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

Updates the docs to include `MacroDefinition` documentation. The docs are still missing `ObjCIVar` however I don't have a clue about how that looks in code. If someone wants to show the code block needed for the example I'll add that in too.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D80877
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
Commit 755a89591528b692315ad0325347e2fd4637271b by tlively
Revert "[WebAssembly] Eliminate range checks on br_tables"

This reverts commit f99d5f8c32a822580a732d15a34e8197da55d22b.
The change was causing UBSan and other failures on some bots.
The file was modifiedllvm/lib/Target/WebAssembly/CMakeLists.txt
The file was modifiedllvm/test/CodeGen/WebAssembly/indirectbr.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
The file was modifiedllvm/lib/Target/WebAssembly/WebAssembly.h
The file was removedllvm/test/CodeGen/WebAssembly/switch-unreachable-default.ll
The file was modifiedllvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
The file was removedllvm/lib/Target/WebAssembly/WebAssemblyFixBrTableDefaults.cpp
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
The file was modifiedllvm/test/CodeGen/WebAssembly/cfg-stackify.ll
The file was modifiedllvm/test/CodeGen/WebAssembly/stack-insts.ll
The file was modifiedllvm/test/CodeGen/WebAssembly/switch.ll
Commit f2f3a80fd853fba0c7bd763a92c0d445052693a8 by llvmgnsyncbot
[gn build] Port 755a8959152
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/WebAssembly/BUILD.gn
Commit 29c17ed96ed53399279c3358cffde51224178e72 by mahesha.comp
[AMDGPU/MemOpsCluster] Code clean-up around accessing of memory operand width

Summary:
Clean-up the width computing logic given a memory operand, and re-arrange code to avoid
code duplication.

Reviewers: foad, rampitec, arsenm, vpykhtin, javedabsar

Reviewed By: foad

Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80946
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.h
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit c823cfde21b20c60f8cf02e28af234e01964469a by jay.foad
[AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics

Differential Revision: https://reviews.llvm.org/D80702
The file was modifiedllvm/lib/Analysis/ConstantFolding.cpp
The file was addedllvm/test/Analysis/ConstantFolding/AMDGPU/sin.ll
The file was addedllvm/test/Analysis/ConstantFolding/AMDGPU/cos.ll
Commit a019579fe56819688a36ba718afc8c7c4f3b04b1 by Vitaly Buka
[StackSafety,NFC] Rename internal class
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 6e51a080f744013eaaff6be2f4864afd0882acfa by Vitaly Buka
[StackSafety,NFC] Convert to template internal stuff

It's going to be usefull for ThinLTO.
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 8577595e03faf740ee0cfae1bbb2d0ff6f4e4516 by sepavloff
Revert "[Support] Add file lock/unlock functions"

This reverts commit f51bc4fb60fbcef26d18eff549fc68307fd46489.
It broke the Solaris buildbots (Builder clang-solaris11-sparcv9 Build #5494
<http://lab.llvm.org:8014/builders/clang-solaris11-sparcv9/builds/54).
The file was modifiedllvm/include/llvm/Support/FileSystem.h
The file was modifiedllvm/unittests/Support/Path.cpp
The file was modifiedllvm/lib/Support/Unix/Path.inc
The file was modifiedllvm/lib/Support/Windows/Path.inc
Commit 7c7941fb4bd884ee7dce96fdfdf657c0fdb608dd by jay.foad
[AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix)

Try to fix Windows buildbots.
The file was modifiedllvm/lib/Analysis/ConstantFolding.cpp
Commit b34b7691facd89022e7fee174debdbd2bf7920f3 by gribozavr
Syntax tree: ignore implicit expressions at the top level of statements

Summary:
I changed `markStmtChild` to ignore implicit expressions the same way as
`markExprChild` does it already. The test that I modified crashes
without this change.

Reviewers: hlopko, eduucaldas

Reviewed By: hlopko, eduucaldas

Subscribers: gribozavr2, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81019
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp
Commit d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a by gribozavr
Split syntax tree tests into more granular ones

Summary:
Doing so allows us to increase test coverage by removing unnecessary
language restrictions.

Reviewers: hlopko, eduucaldas

Reviewed By: hlopko, eduucaldas

Subscribers: gribozavr2, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81040
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
Commit dd1bc59b729a31d6c0fe3aecc8559b9349363bf9 by djordje.todorovic
[CSInfo][MIPS][DwarfDebug] Add support for delay slots

This adds call site info support for call instructions with delay slot.
Search for instructions inside call delay slot, which load value
into parameter forwarding registers.
Return address of the call points to instruction after call delay slot,
which is not the one, immediately after the call instruction.

Patch by Nikola Tesic

Differential revision: https://reviews.llvm.org/D78107
The file was addedllvm/test/DebugInfo/Mips/dbg-call-site-low-pc.ll
The file was addedllvm/test/DebugInfo/MIR/Mips/dbg-call-site-delay-slot-interpretation.mir
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was addedllvm/test/DebugInfo/MIR/Mips/dbg-call-site-delay-slot-interpretation-64bit.mir
Commit 264d435ee10c699b12562eea695793199ff757f5 by Vitaly Buka
[NFC,StackSafety] Fix template arg name
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit c5468253aa555c2df98bd1f49d1e9d44b0150a2e by kadircet
[llvm] Fix unused variable warnings
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Commit e349fb70a23f3a39e058605e4e2db66da5e5ea4a by ntv
[mlir][Linalg] NFC - Make markers use Identifier instead of StringRef

Summary: This removes string ownership worries by putting everything into the context and allows more constructing identifiers programmatically.

Reviewers: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul

Tags: #mlir

Differential Revision: https://reviews.llvm.org/D81027
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
The file was modifiedmlir/test/lib/Transforms/TestLinalgTransforms.cpp
The file was modifiedmlir/test/Dialect/Linalg/transform-patterns.mlir
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
Commit 7a96c181d0f09aae3ebe50c1eea71aa1b11d5789 by llvm-dev
TargetFrameLowering.h - remove unnecessary includes. NFC.

Move TargetFrameLowering.h include to the top of the TargetFrameLoweringImpl.cpp includes (clang-format doesn't do this by default as the filenames don't match).
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
Commit e6ba0a55fd39b600f3f431308f4a7e36e48f91ae by llvm-dev
Fix MSVC "not all control paths return a value" warning. NFC.

Add llvm_unreachable after switch statement for CheckerRegistry::StateFromCmdLine enum
The file was modifiedclang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp