FailedChanges

Summary

  1. [WebAssembly] Fix use of SDNodeFlags after API change in r301803
  2. [PDB/CodeView] Rename some classes. In preparation for introducing writing capabilities for each of these classes, I would like to adopt a Foo / FooRef naming convention, where Foo indicates that the class can manipulate and serialize Foos, and FooRef indicates that it is an immutable view of an existing Foo. In other words, Foo is a writer and FooRef is a reader. This patch names some existing readers to conform to the FooRef convention, while offering no functional change.
  3. Emulate TrackingVH using WeakVH Summary: This frees up one slot in the HandleBaseKind enum, which I will use later to add a new kind of value handle. The size of the HandleBaseKind enum is important because we store a HandleBaseKind in the low two bits of a (in the worst case) 4 byte aligned pointer. Reviewers: davide, chandlerc Subscribers: mcrosier, llvm-commits Differential Revision: https://reviews.llvm.org/D32634
  4. [JumpThread] Add some assertions for expected ConstantInt/BlockAddress
  5. Remove unnecessary conditions as suggested by clang-tidy. NFC Patch by: Gergely Angeli! Differential Revision: https://reviews.llvm.org/D31936
  6. [SelectionDAG] Use known ones to provide a better bound for the known zeros for CTTZ/CTLZ operations. This is the SelectionDAG version of D32521. If know where at least one 1 is located in the input to these intrinsics we can place an upper bound on the number of bits needed to represent the count and thus increase the number of known zeros in the output. I think we can also refine this further for CTTZ_UNDEF/CTLZ_UNDEF by assuming that the answer will never be BitWidth. I've left this out for now because it caused other test failures across multiple targets. Usually because of turning ADD into OR based on this new information. I'll fix CTPOP in a future patch. Differential Revision: https://reviews.llvm.org/D32692
  7. Relax testcase to fix a PS4 buildbot failure.
Revision 301811 by dschuff:
[WebAssembly] Fix use of SDNodeFlags after API change in r301803
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td (diff)llvm-revision.src/llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td
Revision 301810 by zturner:
[PDB/CodeView] Rename some classes.

In preparation for introducing writing capabilities for each of
these classes, I would like to adopt a Foo / FooRef naming
convention, where Foo indicates that the class can manipulate and
serialize Foos, and FooRef indicates that it is an immutable view of
an existing Foo.  In other words, Foo is a writer and FooRef is a
reader.  This patch names some existing readers to conform to the
FooRef convention, while offering no functional change.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugFileChecksumFragment.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugFileChecksumFragment.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugFragment.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugFragment.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugFragmentVisitor.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugFragmentVisitor.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugLineFragment.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugLineFragment.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugUnknownFragment.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugUnknownFragment.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/ModuleDebugStream.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/ModuleDebugStream.h
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugFileChecksumFragment.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugFileChecksumFragment.cpp
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugFragment.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugFragment.cpp
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugFragmentVisitor.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugFragmentVisitor.cpp
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugLineFragment.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugLineFragment.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp
The file was modified/llvm/trunk/tools/llvm-pdbdump/C13DebugFragmentVisitor.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-pdbdump/C13DebugFragmentVisitor.cpp
The file was modified/llvm/trunk/tools/llvm-pdbdump/C13DebugFragmentVisitor.h (diff)llvm-revision.src/llvm/trunk/tools/llvm-pdbdump/C13DebugFragmentVisitor.h
The file was modified/llvm/trunk/tools/llvm-pdbdump/LLVMOutputStyle.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-pdbdump/LLVMOutputStyle.cpp
The file was modified/llvm/trunk/tools/llvm-pdbdump/YAMLOutputStyle.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-pdbdump/YAMLOutputStyle.cpp
The file was modified/llvm/trunk/tools/llvm-pdbdump/YAMLOutputStyle.h (diff)llvm-revision.src/llvm/trunk/tools/llvm-pdbdump/YAMLOutputStyle.h
The file was modified/llvm/trunk/tools/llvm-pdbdump/fuzzer/llvm-pdbdump-fuzzer.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-pdbdump/fuzzer/llvm-pdbdump-fuzzer.cpp
The file was modified/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
Revision 301809 by sanjoy:
Emulate TrackingVH using WeakVH

Summary:
This frees up one slot in the HandleBaseKind enum, which I will use
later to add a new kind of value handle.  The size of the
HandleBaseKind enum is important because we store a HandleBaseKind in
the low two bits of a (in the worst case) 4 byte aligned pointer.

Reviewers: davide, chandlerc

Subscribers: mcrosier, llvm-commits

Differential Revision: https://reviews.llvm.org/D32634
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/ValueHandle.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ValueHandle.h
The file was modified/llvm/trunk/lib/IR/Value.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Value.cpp
The file was modified/llvm/trunk/unittests/IR/ValueHandleTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/ValueHandleTest.cpp
Revision 301808 by trentxintong:
[JumpThread] Add some assertions for expected ConstantInt/BlockAddress
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp
Revision 301807 by xazax:
Remove unnecessary conditions as suggested by clang-tidy. NFC

Patch by: Gergely Angeli!

Differential Revision: https://reviews.llvm.org/D31936
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/DFAPacketizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/DFAPacketizer.cpp
The file was modified/llvm/trunk/lib/Support/SourceMgr.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/SourceMgr.cpp
The file was modified/llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp
Revision 301806 by ctopper:
[SelectionDAG] Use known ones to provide a better bound for the known zeros for CTTZ/CTLZ operations.

This is the SelectionDAG version of D32521. If know where at least one 1 is located in the input to these intrinsics we can place an upper bound on the number of bits needed to represent the count and thus increase the number of known zeros in the output.

I think we can also refine this further for CTTZ_UNDEF/CTLZ_UNDEF by assuming that the answer will never be BitWidth. I've left this out for now because it caused other test failures across multiple targets. Usually because of turning ADD into OR based on this new information.

I'll fix CTPOP in a future patch.

Differential Revision: https://reviews.llvm.org/D32692
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/clz.ll (diff)llvm-revision.src/llvm/trunk/test/CodeGen/X86/clz.ll
Revision 301805 by Adrian Prantl:
Relax testcase to fix a PS4 buildbot failure.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp (diff)llvm-revision.src/cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp