FailedChanges

Summary

  1. New file missed from r301846.
  2. Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas. If a file has no diagnostic pragmas, we build its diagnostic state lazily, but in this case we never set up the root state to be the diagnostic state in which the module was originally built, so the diagnostic flags for files in the module with no diagnostic pragmas were incorrectly based on the user of the module rather than the diagnostic state when the module was built.
  3. [sanitizer-coverage] remove more stale code
  4. Adds initial llvm-dwarfdump --verify support with unit tests. lldb-dwarfdump gets a new "--verify" option that will verify a single file's DWARF debug info and will print out any errors that it finds. It will return an non-zero exit status if verification fails, and a zero exit status if verification succeeds. Adding the --quiet option will suppress any output the STDOUT or STDERR. The first part of the verify does the following: - verifies that all CU relative references (DW_FORM_ref1, DW_FORM_ref2, DW_FORM_ref4, DW_FORM_ref8, DW_FORM_ref_udata) have valid CU offsets - verifies that all DW_FORM_ref_addr references have valid .debug_info offsets - verifies that all DW_AT_ranges attributes have valid .debug_ranges offsets - verifies that all DW_AT_stmt_list attributes have valid .debug_line offsets - verifies that all DW_FORM_strp attributes have valid .debug_str offsets Unit tests were added for each of the above cases. Differential Revision: https://reviews.llvm.org/D32707
  5. Bitcode: Make the summary reader responsible for merging. NFCI. This is to prepare for an upcoming change which uses pointers instead of GUIDs to represent references. Differential Revision: https://reviews.llvm.org/D32469
  6. [APInt] In operator!, handle single word case by comparing VAL to 0 directly and handle multiword case by comparing countLeadingZerosSlowCase() to BitWidth. We were using operator=(0) which implicitly calls countLeadingZeros but only to compare with 64 to determine if we can compare VAL or pVal[0] to uint64_t. By handling the multiword case with countLeadingZerosSlowCase==BitWidth we can prevent a load of pVal[0] from being inserted inline at each call site. This saves a little bit of code size.
  7. [AArch64] Move GISel accessor initialization from TargetMachine to Subtarget. NFC
  8. Put back REQUIRES: system-darwin to fix asan bot. These tests do not appear to be Darwin-specific, and this REQUIRES: appears to be hiding a real bug; this change is just restoring the prior state to get the buildbots happy again while we investigate. (The system-darwin requirement is covered by PR32851.)
  9. [ubsan] Fall back to the fast unwinder when print_stacktrace=1 This makes it possible to get stacktrace info when print_stacktrace=1 on Darwin (where the slow unwinder is not currently supported [1]). This should not regress any other platforms. [1] The thread about r300295 has a relatively recent discusion about this. We should be able to enable the existing slow unwind functionality for Darwin, but this needs more testing. Differential Revision: https://reviews.llvm.org/D32517
  10. [APInt] Fix copy/paste mistake in comment for isNullValue. NFC
Revision 301847 by rsmith:
New file missed from r301846.
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/test/Modules/Inputs/diag_flags.hllvm-revision.src/cfe/trunk/test/Modules/Inputs/diag_flags.h
Revision 301846 by rsmith:
Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas.

If a file has no diagnostic pragmas, we build its diagnostic state lazily, but
in this case we never set up the root state to be the diagnostic state in which
the module was originally built, so the diagnostic flags for files in the
module with no diagnostic pragmas were incorrectly based on the user of the
module rather than the diagnostic state when the module was built.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Serialization/ASTReader.cpp (diff)llvm-revision.src/cfe/trunk/lib/Serialization/ASTReader.cpp
The file was modified/cfe/trunk/test/Modules/Inputs/module.map (diff)llvm-revision.src/cfe/trunk/test/Modules/Inputs/module.map
The file was added/cfe/trunk/test/Modules/diag-flags.cppllvm-revision.src/cfe/trunk/test/Modules/diag-flags.cpp
Revision 301845 by kcc:
[sanitizer-coverage] remove more stale code
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc (diff)llvm-revision.src/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc (diff)llvm-revision.src/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc
The file was removed/compiler-rt/trunk/test/asan/TestCases/coverage-levels.ccllvm-revision.src/compiler-rt/trunk/test/asan/TestCases/coverage-levels.cc
Revision 301844 by gclayton:
Adds initial llvm-dwarfdump --verify support with unit tests.

lldb-dwarfdump gets a new "--verify" option that will verify a single file's DWARF debug info and will print out any errors that it finds. It will return an non-zero exit status if verification fails, and a zero exit status if verification succeeds. Adding the --quiet option will suppress any output the STDOUT or STDERR.

The first part of the verify does the following:

- verifies that all CU relative references (DW_FORM_ref1, DW_FORM_ref2, DW_FORM_ref4, DW_FORM_ref8, DW_FORM_ref_udata) have valid CU offsets
- verifies that all DW_FORM_ref_addr references have valid .debug_info offsets
- verifies that all DW_AT_ranges attributes have valid .debug_ranges offsets
- verifies that all DW_AT_stmt_list attributes have valid .debug_line offsets
- verifies that all DW_FORM_strp attributes have valid .debug_str offsets

Unit tests were added for each of the above cases.

Differential Revision: https://reviews.llvm.org/D32707
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/DIContext.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/DIContext.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFContext.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFContext.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFFormValue.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFFormValue.h
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp
The file was modified/llvm/trunk/tools/llvm-dwarfdump/llvm-dwarfdump.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
The file was modified/llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
Revision 301843 by pcc:
Bitcode: Make the summary reader responsible for merging. NFCI.

This is to prepare for an upcoming change which uses pointers instead of
GUIDs to represent references.

Differential Revision: https://reviews.llvm.org/D32469
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Bitcode/BitcodeReader.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Bitcode/BitcodeReader.h
The file was modified/llvm/trunk/include/llvm/IR/ModuleSummaryIndex.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ModuleSummaryIndex.h
The file was modified/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (diff)llvm-revision.src/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
The file was modified/llvm/trunk/lib/IR/ModuleSummaryIndex.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/ModuleSummaryIndex.cpp
The file was modified/llvm/trunk/lib/LTO/LTO.cpp (diff)llvm-revision.src/llvm/trunk/lib/LTO/LTO.cpp
The file was modified/llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp (diff)llvm-revision.src/llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
The file was modified/llvm/trunk/tools/llvm-lto/llvm-lto.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-lto/llvm-lto.cpp
Revision 301842 by ctopper:
[APInt] In operator!, handle single word case by comparing VAL to 0 directly and handle multiword case by comparing countLeadingZerosSlowCase() to BitWidth.

We were using operator=(0) which implicitly calls countLeadingZeros but only to compare with 64 to determine if we can compare VAL or pVal[0] to uint64_t. By handling the multiword case with countLeadingZerosSlowCase==BitWidth we can prevent a load of pVal[0] from being inserted inline at each call site. This saves a little bit of code size.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/APInt.h (diff)llvm-revision.src/llvm/trunk/include/llvm/ADT/APInt.h
Revision 301841 by qcolombet:
[AArch64] Move GISel accessor initialization from TargetMachine to Subtarget.

NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.cpp
Revision 301840 by rsmith:
Put back REQUIRES: system-darwin to fix asan bot.

These tests do not appear to be Darwin-specific, and this REQUIRES: appears to
be hiding a real bug; this change is just restoring the prior state to get the
buildbots happy again while we investigate. (The system-darwin requirement is
covered by PR32851.)
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Modules/crash-vfs-headermaps.m (diff)llvm-revision.src/cfe/trunk/test/Modules/crash-vfs-headermaps.m
The file was modified/cfe/trunk/test/Modules/crash-vfs-include-pch.m (diff)llvm-revision.src/cfe/trunk/test/Modules/crash-vfs-include-pch.m
The file was modified/cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m (diff)llvm-revision.src/cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m
The file was modified/cfe/trunk/test/Modules/crash-vfs-relative-incdir.m (diff)llvm-revision.src/cfe/trunk/test/Modules/crash-vfs-relative-incdir.m
The file was modified/cfe/trunk/test/Modules/crash-vfs-run-reproducer.m (diff)llvm-revision.src/cfe/trunk/test/Modules/crash-vfs-run-reproducer.m
Revision 301839 by Vedant Kumar:
[ubsan] Fall back to the fast unwinder when print_stacktrace=1

This makes it possible to get stacktrace info when print_stacktrace=1 on
Darwin (where the slow unwinder is not currently supported [1]). This
should not regress any other platforms.

[1] The thread about r300295 has a relatively recent discusion about
this. We should be able to enable the existing slow unwind functionality
for Darwin, but this needs more testing.

Differential Revision: https://reviews.llvm.org/D32517
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/ubsan/ubsan_diag.cc (diff)llvm-revision.src/compiler-rt/trunk/lib/ubsan/ubsan_diag.cc
The file was modified/compiler-rt/trunk/test/ubsan/TestCases/Misc/missing_return.cpp (diff)llvm-revision.src/compiler-rt/trunk/test/ubsan/TestCases/Misc/missing_return.cpp
The file was modified/compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/misaligned.cpp (diff)llvm-revision.src/compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/misaligned.cpp
Revision 301838 by ctopper:
[APInt] Fix copy/paste mistake in comment for isNullValue. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/APInt.h (diff)llvm-revision.src/llvm/trunk/include/llvm/ADT/APInt.h