FailedChanges

Summary

  1. Actually remove the MSVC STL when linking and testing libc++ on Windows
  2. Update llvm-readobj -coff-resources to display tree structure. Summary: Continue making updates to llvm-readobj to display resource sections. This is necessary for testing the up and coming cvtres tool. Reviewers: zturner Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D32609
  3. [ConstantRange][SimplifyCFG] Add a helper method to allow SimplifyCFG to determine if a ConstantRange has more than 8 elements without requiring an allocation if the ConstantRange is 64-bits wide. Previously SimplifyCFG used getSetSize which returns an APInt that is 1 bit wider than the ConstantRange's bit width. In the reasonably common case that the ConstantRange is 64-bits wide, this requires returning a 65-bit APInt. APInt's can only store 64-bits without a memory allocation so this is inefficient. The new method takes the 8 as an input and tells if the range contains more than that many elements without requiring any wider math.
  4. Temporarly XFAIL aligned new/delete tests on Windows. Libc++ doesn't provide its own definitions of new/delete on Windows, instead using the versions provided by VCRuntime. However VCRuntime does not yet implement aligned new/delete so these tests fail. It might be possible for libc++ to provide its own definitions only for aligned new/delete as long as MSVC doesn't provide it. However before this can be done libc++ needs to figure out how to implement std::get_new_handler.
  5. [ConstantRange] Remove 'Of' from name of ConstantRange::isSizeStrictlySmallerThanOf so that it reads better. NFC
Revision 302387 by ericwf:
Actually remove the MSVC STL when linking and testing libc++ on Windows
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/utils/libcxx/test/config.py (diff)llvm-revision.src/libcxx/trunk/utils/libcxx/test/config.py
Revision 302386 by ecbeckmann:
Update llvm-readobj -coff-resources to display tree structure.

Summary: Continue making updates to llvm-readobj to display resource sections.  This is necessary for testing the up and coming cvtres tool.

Reviewers: zturner

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D32609
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Object/COFF.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Object/COFF.h
The file was modified/llvm/trunk/include/llvm/Support/COFF.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/COFF.h
The file was modified/llvm/trunk/lib/Object/COFFObjectFile.cpp (diff)llvm-revision.src/llvm/trunk/lib/Object/COFFObjectFile.cpp
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/resourcesllvm-revision.src/llvm/trunk/test/tools/llvm-readobj/Inputs/resources
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/cursor_small.bmpllvm-revision.src/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/cursor_small.bmp
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/okay_small.bmpllvm-revision.src/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/okay_small.bmp
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/test_resource.rcllvm-revision.src/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/test_resource.rc
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/test_resource.resllvm-revision.src/llvm/trunk/test/tools/llvm-readobj/Inputs/resources/test_resource.res
The file was modified/llvm/trunk/test/tools/llvm-readobj/resources.test (diff)llvm-revision.src/llvm/trunk/test/tools/llvm-readobj/resources.test
The file was modified/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
Revision 302385 by ctopper:
[ConstantRange][SimplifyCFG] Add a helper method to allow SimplifyCFG to determine if a ConstantRange has more than 8 elements without requiring an allocation if the ConstantRange is 64-bits wide.

Previously SimplifyCFG used getSetSize which returns an APInt that is 1 bit wider than the ConstantRange's bit width. In the reasonably common case that the ConstantRange is 64-bits wide, this requires returning a 65-bit APInt. APInt's can only store 64-bits without a memory allocation so this is inefficient.

The new method takes the 8 as an input and tells if the range contains more than that many elements without requiring any wider math.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/ConstantRange.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ConstantRange.h
The file was modified/llvm/trunk/lib/IR/ConstantRange.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/ConstantRange.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
Revision 302384 by ericwf:
Temporarly XFAIL aligned new/delete tests on Windows.

Libc++ doesn't provide its own definitions of new/delete on Windows,
instead using the versions provided by VCRuntime. However VCRuntime
does not yet implement aligned new/delete so these tests fail.

It might be possible for libc++ to provide its own definitions only
for aligned new/delete as long as MSVC doesn't provide it. However
before this can be done libc++ needs to figure out how to implement
std::get_new_handler.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp
The file was modified/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp
Revision 302383 by ctopper:
[ConstantRange] Remove 'Of' from name of ConstantRange::isSizeStrictlySmallerThanOf so that it reads better. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/ConstantRange.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ConstantRange.h
The file was modified/llvm/trunk/lib/IR/ConstantRange.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/ConstantRange.cpp