Changes

Summary

Ignore !associated metadata with null argument. Fixes PR32577 (comment 10). Such metadata may legitimately appear in LTO.
Relax Dwarf filecheck test for 32-bit hosts
Use the frame index side table for byval and inalloca arguments Summary: For inalloca functions, this is a very common code pattern: %argpack = type <{ i32, i32, i32 }> define void @f(%argpack* inalloca %args) { entry: %a = getelementptr inbounds %argpack, %argpack* %args, i32 0, i32 0 %b = getelementptr inbounds %argpack, %argpack* %args, i32 0, i32 1 %c = getelementptr inbounds %argpack, %argpack* %args, i32 0, i32 2 tail call void @llvm.dbg.declare(metadata i32* %a, ... "a") tail call void @llvm.dbg.declare(metadata i32* %c, ... "b") tail call void @llvm.dbg.declare(metadata i32* %b, ... "c") Even though these GEPs can be simplified to a constant offset from EBP or RSP, we don't do that at -O0, and each GEP is computed into a register. Registers used to compute argument addresses are typically spilled and clobbered very quickly after the initial computation, so live debug variable tracking loses information very quickly if we use DBG_VALUE instructions. This change moves processing of dbg.declare between argument lowering and basic block isel, so that we can ask if an argument has a frame index or not. If the argument lives in a register as is the case for byval arguments on some targets, then we don't put it in the side table and during ISel we emit DBG_VALUE instructions. Reviewers: aprantl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D32980
Add basic test case for -instnamer
[InstNamer] Use range-for
[InstNamer] Don't check type of arguments (they're never void)
Delete trailing whitespace

Change Type	Path in Repository	Path in Workspace
Revision 302485 by eugenis: Ignore !associated metadata with null argument. Fixes PR32577 (comment 10). Such metadata may legitimately appear in LTO.
	/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (diff)	llvm-revision.src/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
	/llvm/trunk/test/CodeGen/X86/elf-associated.ll (diff)	llvm-revision.src/llvm/trunk/test/CodeGen/X86/elf-associated.ll
Revision 302484 by rnk: Relax Dwarf filecheck test for 32-bit hosts
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/test/CodeGen/X86/2010-01-18-DbgValue.ll (diff)	llvm-revision.src/llvm/trunk/test/CodeGen/X86/2010-01-18-DbgValue.ll
Revision 302483 by rnk: Use the frame index side table for byval and inalloca arguments Summary: For inalloca functions, this is a very common code pattern: %argpack = type <{ i32, i32, i32 }> define void @f(%argpack* inalloca %args) { entry: %a = getelementptr inbounds %argpack, %argpack* %args, i32 0, i32 0 %b = getelementptr inbounds %argpack, %argpack* %args, i32 0, i32 1 %c = getelementptr inbounds %argpack, %argpack* %args, i32 0, i32 2 tail call void @llvm.dbg.declare(metadata i32* %a, ... "a") tail call void @llvm.dbg.declare(metadata i32* %c, ... "b") tail call void @llvm.dbg.declare(metadata i32* %b, ... "c") Even though these GEPs can be simplified to a constant offset from EBP or RSP, we don't do that at -O0, and each GEP is computed into a register. Registers used to compute argument addresses are typically spilled and clobbered very quickly after the initial computation, so live debug variable tracking loses information very quickly if we use DBG_VALUE instructions. This change moves processing of dbg.declare between argument lowering and basic block isel, so that we can ask if an argument has a frame index or not. If the argument lives in a register as is the case for byval arguments on some targets, then we don't put it in the side table and during ISel we emit DBG_VALUE instructions. Reviewers: aprantl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D32980
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp (diff)	llvm-revision.src/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
	/llvm/trunk/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp (diff)	llvm-revision.src/llvm/trunk/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
	/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (diff)	llvm-revision.src/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
	/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (diff)	llvm-revision.src/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
	/llvm/trunk/test/CodeGen/X86/2010-01-18-DbgValue.ll (diff)	llvm-revision.src/llvm/trunk/test/CodeGen/X86/2010-01-18-DbgValue.ll
	/llvm/trunk/test/CodeGen/X86/2012-11-30-handlemove-dbg.ll	llvm-revision.src/llvm/trunk/test/CodeGen/X86/2012-11-30-handlemove-dbg.ll
	/llvm/trunk/test/CodeGen/X86/dbg-baseptr.ll (diff)	llvm-revision.src/llvm/trunk/test/CodeGen/X86/dbg-baseptr.ll
	/llvm/trunk/test/DebugInfo/X86/dbg-declare-inalloca.ll	llvm-revision.src/llvm/trunk/test/DebugInfo/X86/dbg-declare-inalloca.ll
Revision 302482 by sanjoy: Add basic test case for -instnamer
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/test/Transforms/InstNamer	llvm-revision.src/llvm/trunk/test/Transforms/InstNamer
	/llvm/trunk/test/Transforms/InstNamer/basic.ll	llvm-revision.src/llvm/trunk/test/Transforms/InstNamer/basic.ll
Revision 302481 by sanjoy: [InstNamer] Use range-for
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/lib/Transforms/Utils/InstructionNamer.cpp (diff)	llvm-revision.src/llvm/trunk/lib/Transforms/Utils/InstructionNamer.cpp
Revision 302480 by sanjoy: [InstNamer] Don't check type of arguments (they're never void)
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/lib/Transforms/Utils/InstructionNamer.cpp (diff)	llvm-revision.src/llvm/trunk/lib/Transforms/Utils/InstructionNamer.cpp
Revision 302479 by sanjoy: Delete trailing whitespace
Change Type	Path in Repository	Path in Workspace
	/llvm/trunk/lib/Transforms/Utils/InstructionNamer.cpp (diff)	llvm-revision.src/llvm/trunk/lib/Transforms/Utils/InstructionNamer.cpp