FailedChanges

Summary

  1. [ubsan][test] Restore float-divide-by-zero test Removed by rCTE365307 to fix buildbots. It can be restored now because D64317/rC365587 brought back -fsanitize=float-divide-by-zero
  2. [analyzer] CastValueChecker: Remove a dump() Summary: Fix a nit.
  3. [X86] Limit getTargetConstantFromNode to only work on NormalLoads not extending loads. This seems to fix a failure reported by Jordan Rupprecht, but we don't have a reduced test case yet.
  4. [Support] Move llvm::MemoryBuffer to sys::fs::file_t Summary: On Windows, Posix integer file descriptors are a compatibility layer over native file handles provided by the C runtime. There is a hard limit on the maximum number of file descriptors that a process can open, and the limit is 8192. LLD typically doesn't run into this limit because it opens input files, maps them into memory, and then immediately closes the file descriptor. This prevents it from running out of FDs. For various reasons, I'd like to open handles to every input file and keep them open during linking. That requires migrating MemoryBuffer over to taking open native file handles instead of integer FDs. Reviewers: aganea, Bigcheese Reviewed By: aganea Subscribers: smeenai, silvas, mehdi_amini, hiraditya, steven_wu, dexonsmith, dang, llvm-commits, zturner Tags: #llvm Differential Revision: https://reviews.llvm.org/D63453
  5. [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272 D63793 removed float-divide-by-zero from the "undefined" set but it failed to add it to getSupportedSanitizers(), thus the sanitizer is rejected by the driver: clang-9: error: unsupported option '-fsanitize=float-divide-by-zero' for target 'x86_64-unknown-linux-gnu' Also, add SanitizerMask::FloatDivideByZero to a few other masks to make -fsanitize-trap, -fsanitize-recover, -fsanitize-minimal-runtime and -fsanitize-coverage work. Reviewed By: rsmith, vitalybuka Differential Revision: https://reviews.llvm.org/D64317
  6. AMDGPU/GlobalISel: Add support for wide loads >= 256-bits Summary: This adds support for the most commonly used wide load types: <8xi32>, <16xi32>, <4xi64>, and <8xi64> Reviewers: arsenm Reviewed By: arsenm Subscribers: hiraditya, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, volkan, Petar.Avramovic, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D57399
Revision 365591 by maskray:
[ubsan][test] Restore float-divide-by-zero test

Removed by rCTE365307 to fix buildbots. It can be restored now because D64317/rC365587 brought back -fsanitize=float-divide-by-zero
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/ubsan/TestCases/Integer/div-zero.cpp (diff)compiler-rt.src/test/ubsan/TestCases/Integer/div-zero.cpp
Revision 365590 by charusso:
[analyzer] CastValueChecker: Remove a dump()

Summary: Fix a nit.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp
Revision 365589 by ctopper:
[X86] Limit getTargetConstantFromNode to only work on NormalLoads not extending loads.

This seems to fix a failure reported by Jordan Rupprecht, but we
don't have a reduced test case yet.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 365588 by rnk:
[Support] Move llvm::MemoryBuffer to sys::fs::file_t

Summary:
On Windows, Posix integer file descriptors are a compatibility layer
over native file handles provided by the C runtime. There is a hard
limit on the maximum number of file descriptors that a process can open,
and the limit is 8192. LLD typically doesn't run into this limit because
it opens input files, maps them into memory, and then immediately closes
the file descriptor. This prevents it from running out of FDs.

For various reasons, I'd like to open handles to every input file and
keep them open during linking. That requires migrating MemoryBuffer over
to taking open native file handles instead of integer FDs.

Reviewers: aganea, Bigcheese

Reviewed By: aganea

Subscribers: smeenai, silvas, mehdi_amini, hiraditya, steven_wu, dexonsmith, dang, llvm-commits, zturner

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D63453
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/FileSystem.h (diff)llvm.src/include/llvm/Support/FileSystem.h
The file was modified/llvm/trunk/include/llvm/Support/MemoryBuffer.h (diff)llvm.src/include/llvm/Support/MemoryBuffer.h
The file was modified/llvm/trunk/lib/LTO/Caching.cpp (diff)llvm.src/lib/LTO/Caching.cpp
The file was modified/llvm/trunk/lib/LTO/LTOModule.cpp (diff)llvm.src/lib/LTO/LTOModule.cpp
The file was modified/llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp (diff)llvm.src/lib/LTO/ThinLTOCodeGenerator.cpp
The file was modified/llvm/trunk/lib/Object/ArchiveWriter.cpp (diff)llvm.src/lib/Object/ArchiveWriter.cpp
The file was modified/llvm/trunk/lib/Support/FileOutputBuffer.cpp (diff)llvm.src/lib/Support/FileOutputBuffer.cpp
The file was modified/llvm/trunk/lib/Support/MemoryBuffer.cpp (diff)llvm.src/lib/Support/MemoryBuffer.cpp
The file was modified/llvm/trunk/lib/Support/Unix/Path.inc (diff)llvm.src/lib/Support/Unix/Path.inc
The file was modified/llvm/trunk/lib/Support/VirtualFileSystem.cpp (diff)llvm.src/lib/Support/VirtualFileSystem.cpp
The file was modified/llvm/trunk/lib/Support/Windows/Path.inc (diff)llvm.src/lib/Support/Windows/Path.inc
The file was modified/llvm/trunk/lib/XRay/InstrumentationMap.cpp (diff)llvm.src/lib/XRay/InstrumentationMap.cpp
The file was modified/llvm/trunk/lib/XRay/Profile.cpp (diff)llvm.src/lib/XRay/Profile.cpp
The file was modified/llvm/trunk/lib/XRay/Trace.cpp (diff)llvm.src/lib/XRay/Trace.cpp
The file was modified/llvm/trunk/tools/llvm-xray/xray-fdr-dump.cpp (diff)llvm.src/tools/llvm-xray/xray-fdr-dump.cpp
The file was modified/llvm/trunk/unittests/Support/MemoryBufferTest.cpp (diff)llvm.src/unittests/Support/MemoryBufferTest.cpp
The file was modified/llvm/trunk/unittests/Support/Path.cpp (diff)llvm.src/unittests/Support/Path.cpp
The file was modified/llvm/trunk/unittests/Support/ReplaceFileTest.cpp (diff)llvm.src/unittests/Support/ReplaceFileTest.cpp
Revision 365587 by maskray:
[Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

D63793 removed float-divide-by-zero from the "undefined" set but it
failed to add it to getSupportedSanitizers(), thus the sanitizer is
rejected by the driver:

    clang-9: error: unsupported option '-fsanitize=float-divide-by-zero' for target 'x86_64-unknown-linux-gnu'

Also, add SanitizerMask::FloatDivideByZero to a few other masks to make -fsanitize-trap, -fsanitize-recover, -fsanitize-minimal-runtime and -fsanitize-coverage work.

Reviewed By: rsmith, vitalybuka

Differential Revision: https://reviews.llvm.org/D64317
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/Sanitizers.h (diff)clang.src/include/clang/Basic/Sanitizers.h
The file was modified/cfe/trunk/lib/Driver/SanitizerArgs.cpp (diff)clang.src/lib/Driver/SanitizerArgs.cpp
The file was modified/cfe/trunk/lib/Driver/ToolChain.cpp (diff)clang.src/lib/Driver/ToolChain.cpp
The file was modified/cfe/trunk/test/Driver/fsanitize-blacklist.c (diff)clang.src/test/Driver/fsanitize-blacklist.c
The file was modified/cfe/trunk/test/Driver/fsanitize-coverage.c (diff)clang.src/test/Driver/fsanitize-coverage.c
The file was modified/cfe/trunk/test/Driver/fsanitize.c (diff)clang.src/test/Driver/fsanitize.c
The file was modified/cfe/trunk/test/Driver/sanitizer-ld.c (diff)clang.src/test/Driver/sanitizer-ld.c
The file was modified/cfe/trunk/test/Modules/check-for-sanitizer-feature.cpp (diff)clang.src/test/Modules/check-for-sanitizer-feature.cpp
Revision 365586 by tstellar:
AMDGPU/GlobalISel: Add support for wide loads >= 256-bits

Summary:
This adds support for the most commonly used wide load types:
<8xi32>, <16xi32>, <4xi64>, and <8xi64>

Reviewers: arsenm

Reviewed By: arsenm

Subscribers: hiraditya, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, volkan, Petar.Avramovic, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D57399
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def (diff)llvm.src/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h (diff)llvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/legalize-load.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/legalize-load.mir
The file was added/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mirllvm.src/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir