FailedChanges

Summary

  1. [Coding style change] Rename variables so that they start with a lowercase letter This patch is mechanically generated by clang-llvm-rename tool that I wrote using Clang Refactoring Engine just for creating this patch. You can see the source code of the tool at https://reviews.llvm.org/D64123. There's no manual post-processing; you can generate the same patch by re-running the tool against lld's code base. Here is the main discussion thread to change the LLVM coding style: https://lists.llvm.org/pipermail/llvm-dev/2019-February/130083.html In the discussion thread, I proposed we use lld as a testbed for variable naming scheme change, and this patch does that. I chose to rename variables so that they are in camelCase, just because that is a minimal change to make variables to start with a lowercase letter. Note to downstream patch maintainers: if you are maintaining a downstream lld repo, just rebasing ahead of this commit would cause massive merge conflicts because this patch essentially changes every line in the lld subdirectory. But there's a remedy. clang-llvm-rename tool is a batch tool, so you can rename variables in your downstream repo with the tool. Given that, here is how to rebase your repo to a commit after the mass renaming: 1. rebase to the commit just before the mass variable renaming, 2. apply the tool to your downstream repo to mass-rename variables locally, and 3. rebase again to the head. Most changes made by the tool should be identical for a downstream repo and for the head, so at the step 3, almost all changes should be merged and disappear. I'd expect that there would be some lines that you need to merge by hand, but that shouldn't be too many. Differential Revision: https://reviews.llvm.org/D64121
  2. Fix modular build issues caused by BitCodes.h Consolidate llvm::BWH_* statics into an enum to fix module build issues. This fixes the LLVM_Bitcode module, getting rid of -Wmodules-ambiguous-internal-linkage. Differential Revision: https://reviews.llvm.org/D64469
Revision 365595 by ruiu:
[Coding style change] Rename variables so that they start with a lowercase letter

This patch is mechanically generated by clang-llvm-rename tool that I wrote
using Clang Refactoring Engine just for creating this patch. You can see the
source code of the tool at https://reviews.llvm.org/D64123. There's no manual
post-processing; you can generate the same patch by re-running the tool against
lld's code base.

Here is the main discussion thread to change the LLVM coding style:
https://lists.llvm.org/pipermail/llvm-dev/2019-February/130083.html
In the discussion thread, I proposed we use lld as a testbed for variable
naming scheme change, and this patch does that.

I chose to rename variables so that they are in camelCase, just because that
is a minimal change to make variables to start with a lowercase letter.

Note to downstream patch maintainers: if you are maintaining a downstream lld
repo, just rebasing ahead of this commit would cause massive merge conflicts
because this patch essentially changes every line in the lld subdirectory. But
there's a remedy.

clang-llvm-rename tool is a batch tool, so you can rename variables in your
downstream repo with the tool. Given that, here is how to rebase your repo to
a commit after the mass renaming:

1. rebase to the commit just before the mass variable renaming,
2. apply the tool to your downstream repo to mass-rename variables locally, and
3. rebase again to the head.

Most changes made by the tool should be identical for a downstream repo and
for the head, so at the step 3, almost all changes should be merged and
disappear. I'd expect that there would be some lines that you need to merge by
hand, but that shouldn't be too many.

Differential Revision: https://reviews.llvm.org/D64121
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/AArch64ErrataFix.cpp (diff)lld.src/ELF/AArch64ErrataFix.cpp
The file was modified/lld/trunk/ELF/AArch64ErrataFix.h (diff)lld.src/ELF/AArch64ErrataFix.h
The file was modified/lld/trunk/ELF/Arch/AArch64.cpp (diff)lld.src/ELF/Arch/AArch64.cpp
The file was modified/lld/trunk/ELF/Arch/AMDGPU.cpp (diff)lld.src/ELF/Arch/AMDGPU.cpp
The file was modified/lld/trunk/ELF/Arch/ARM.cpp (diff)lld.src/ELF/Arch/ARM.cpp
The file was modified/lld/trunk/ELF/Arch/AVR.cpp (diff)lld.src/ELF/Arch/AVR.cpp
The file was modified/lld/trunk/ELF/Arch/Hexagon.cpp (diff)lld.src/ELF/Arch/Hexagon.cpp
The file was modified/lld/trunk/ELF/Arch/MSP430.cpp (diff)lld.src/ELF/Arch/MSP430.cpp
The file was modified/lld/trunk/ELF/Arch/Mips.cpp (diff)lld.src/ELF/Arch/Mips.cpp
The file was modified/lld/trunk/ELF/Arch/MipsArchTree.cpp (diff)lld.src/ELF/Arch/MipsArchTree.cpp
The file was modified/lld/trunk/ELF/Arch/PPC.cpp (diff)lld.src/ELF/Arch/PPC.cpp
The file was modified/lld/trunk/ELF/Arch/PPC64.cpp (diff)lld.src/ELF/Arch/PPC64.cpp
The file was modified/lld/trunk/ELF/Arch/RISCV.cpp (diff)lld.src/ELF/Arch/RISCV.cpp
The file was modified/lld/trunk/ELF/Arch/SPARCV9.cpp (diff)lld.src/ELF/Arch/SPARCV9.cpp
The file was modified/lld/trunk/ELF/Arch/X86.cpp (diff)lld.src/ELF/Arch/X86.cpp
The file was modified/lld/trunk/ELF/Arch/X86_64.cpp (diff)lld.src/ELF/Arch/X86_64.cpp
The file was modified/lld/trunk/ELF/CallGraphSort.cpp (diff)lld.src/ELF/CallGraphSort.cpp
The file was modified/lld/trunk/ELF/Config.h (diff)lld.src/ELF/Config.h
The file was modified/lld/trunk/ELF/DWARF.cpp (diff)lld.src/ELF/DWARF.cpp
The file was modified/lld/trunk/ELF/DWARF.h (diff)lld.src/ELF/DWARF.h
The file was modified/lld/trunk/ELF/Driver.cpp (diff)lld.src/ELF/Driver.cpp
The file was modified/lld/trunk/ELF/Driver.h (diff)lld.src/ELF/Driver.h
The file was modified/lld/trunk/ELF/DriverUtils.cpp (diff)lld.src/ELF/DriverUtils.cpp
The file was modified/lld/trunk/ELF/EhFrame.cpp (diff)lld.src/ELF/EhFrame.cpp
The file was modified/lld/trunk/ELF/EhFrame.h (diff)lld.src/ELF/EhFrame.h
The file was modified/lld/trunk/ELF/ICF.cpp (diff)lld.src/ELF/ICF.cpp
The file was modified/lld/trunk/ELF/InputFiles.cpp (diff)lld.src/ELF/InputFiles.cpp
The file was modified/lld/trunk/ELF/InputFiles.h (diff)lld.src/ELF/InputFiles.h
The file was modified/lld/trunk/ELF/InputSection.cpp (diff)lld.src/ELF/InputSection.cpp
The file was modified/lld/trunk/ELF/InputSection.h (diff)lld.src/ELF/InputSection.h
The file was modified/lld/trunk/ELF/LTO.cpp (diff)lld.src/ELF/LTO.cpp
The file was modified/lld/trunk/ELF/LTO.h (diff)lld.src/ELF/LTO.h
The file was modified/lld/trunk/ELF/LinkerScript.cpp (diff)lld.src/ELF/LinkerScript.cpp
The file was modified/lld/trunk/ELF/LinkerScript.h (diff)lld.src/ELF/LinkerScript.h
The file was modified/lld/trunk/ELF/MapFile.cpp (diff)lld.src/ELF/MapFile.cpp
The file was modified/lld/trunk/ELF/MarkLive.cpp (diff)lld.src/ELF/MarkLive.cpp
The file was modified/lld/trunk/ELF/OutputSections.cpp (diff)lld.src/ELF/OutputSections.cpp
The file was modified/lld/trunk/ELF/OutputSections.h (diff)lld.src/ELF/OutputSections.h
The file was modified/lld/trunk/ELF/Relocations.cpp (diff)lld.src/ELF/Relocations.cpp
The file was modified/lld/trunk/ELF/Relocations.h (diff)lld.src/ELF/Relocations.h
The file was modified/lld/trunk/ELF/ScriptLexer.cpp (diff)lld.src/ELF/ScriptLexer.cpp
The file was modified/lld/trunk/ELF/ScriptLexer.h (diff)lld.src/ELF/ScriptLexer.h
The file was modified/lld/trunk/ELF/ScriptParser.cpp (diff)lld.src/ELF/ScriptParser.cpp
The file was modified/lld/trunk/ELF/ScriptParser.h (diff)lld.src/ELF/ScriptParser.h
The file was modified/lld/trunk/ELF/SymbolTable.cpp (diff)lld.src/ELF/SymbolTable.cpp
The file was modified/lld/trunk/ELF/SymbolTable.h (diff)lld.src/ELF/SymbolTable.h
The file was modified/lld/trunk/ELF/Symbols.cpp (diff)lld.src/ELF/Symbols.cpp
The file was modified/lld/trunk/ELF/Symbols.h (diff)lld.src/ELF/Symbols.h
The file was modified/lld/trunk/ELF/SyntheticSections.cpp (diff)lld.src/ELF/SyntheticSections.cpp
The file was modified/lld/trunk/ELF/SyntheticSections.h (diff)lld.src/ELF/SyntheticSections.h
The file was modified/lld/trunk/ELF/Target.cpp (diff)lld.src/ELF/Target.cpp
The file was modified/lld/trunk/ELF/Target.h (diff)lld.src/ELF/Target.h
The file was modified/lld/trunk/ELF/Thunks.cpp (diff)lld.src/ELF/Thunks.cpp
The file was modified/lld/trunk/ELF/Thunks.h (diff)lld.src/ELF/Thunks.h
The file was modified/lld/trunk/ELF/Writer.cpp (diff)lld.src/ELF/Writer.cpp
The file was modified/lld/trunk/ELF/Writer.h (diff)lld.src/ELF/Writer.h
Revision 365594 by Kristina Brooks:
Fix modular build issues caused by BitCodes.h

Consolidate llvm::BWH_* statics into an enum to fix
module build issues. This fixes the LLVM_Bitcode module,
getting rid of -Wmodules-ambiguous-internal-linkage.

Differential Revision: https://reviews.llvm.org/D64469
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Bitstream/BitCodes.h (diff)llvm.src/include/llvm/Bitstream/BitCodes.h