FailedChanges

Summary

  1. [ELF] Update test case due to llvm r365618
  2. Fix const/non-const lambda return type warning. NFCI.
  3. Fix "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI.
  4. [SimpleLoopUnswitch] Don't consider unswitching `switch` insructions with one unique successor Only instructions with two or more unique successors should be considered for unswitching. Patch Author: Daniil Suchkov. Reviewers: reames, asbirlea, skatkov Reviewed By: skatkov Subscribers: hiraditya, llvm-commits Differential Revision: https://reviews.llvm.org/D64404
  5. [test-suite] Fix RISC-V Support in benchmark 1.3.0 Summary: Fixed by backporting the upstream fix from here: https://github.com/google/benchmark/pull/833 Reviewers: lebedev.ri Reviewed By: lebedev.ri Subscribers: asb, kito-cheng, shiva0217, rogfer01, rkruppe, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64237
  6. [AArch64] Fix vector vuqadd intrinsics operands Summary: Change the vuqadd vector instrinsics to have the second argument as unsigned values, not signed, accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics Reviewers: LukeCheeseman, ostannard Reviewed By: ostannard Subscribers: javed.absar, kristof.beyls, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64211
  7. [NFC][AArch64] Fix vector vsqadd intrinsics operands Summary: Change the vsqadd vector instrinsics to have the second argument as signed values, not unsigned, accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics Reviewers: LukeCheeseman, ostannard Reviewed By: ostannard Subscribers: javed.absar, kristof.beyls, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64210
  8. [clangd] Stop recording tokens before running clang-tidy modernize-trailing-return-type runs the preprocessor, breaking the token collection logic. This lead to a crash before, see the new test for a repro.
  9. [clangd] Consume error to avoid assertion failures When we fail to calculate #include insertion for a completion item. Note that this change does not add a test, although that would be good.
  10. Make functions and member variables distinguishable even after the name style change. NFC.
  11. [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present Summary: Use the same predicates as VSTMDB/VLDMIA since VPUSH/VPOP alias to these. Patch by Momchil Velikov. Reviewers: ostannard, simon_tatham, SjoerdMeijer, samparker, t.p.northover, dmgreen Reviewed By: dmgreen Subscribers: javed.absar, kristof.beyls, hiraditya, dmgreen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64413
  12. [docs][llvm-dwarfdump] Normalise some wording
  13. [clangd] Added highlighting for class and enum types. Summary: Added highlighting for non-builtin types using VisitTypeLoc. Ignoring namespace qualifiers as for now. Reviewers: hokein, sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64257
  14. [test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries. This converts 5 precompiled binaries to YAMLs, removes 4 from inputs and performs a cleanup. Differential revision: https://reviews.llvm.org/D64246
  15. [SimpleLoopUnswitch] Add a test case exposing a bug This test exposes a bug in SimpleLoopUnswitch that leads to a crash on assert(SuccessorsCount > 1 && "Cannot unswitch a condition without multiple distinct successors!"); when SimpleLoopUnswitch considers unswitching of a loop by a switch with one successor. Fix will be submitted soon. Patch Author: Daniil Suchkov. Reviewers: reames, asbirlea, skatkov Reviewed By: skatkov Subscribers: zzheng, llvm-commits Differential Revision: https://reviews.llvm.org/D64403
  16. [Syntax] Add assertion to catch invalid tokens early. NFC To help with identifiying root cause of a crash we are seeing.
  17. [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand Summary: Change the vqtb[lx][1-4]_s8 instrinsics to have the last argument as vector of unsigned valuse, not signed, accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics Reviewers: LukeCheeseman, DavidSpickett Reviewed By: DavidSpickett Subscribers: DavidSpickett, javed.absar, kristof.beyls, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64243
Revision 365619 by nikolaprica:
[ELF] Update test case due to llvm r365618
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/test/ELF/mips-got-string.s (diff)lld.src/test/ELF/mips-got-string.s
Revision 365613 by rksimon:
Fix const/non-const lambda return type warning. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Revision 365612 by rksimon:
Fix "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp (diff)llvm.src/lib/Target/AArch64/AArch64AsmPrinter.cpp
Revision 365611 by skatkov:
[SimpleLoopUnswitch] Don't consider unswitching `switch` insructions with one unique successor

Only instructions with two or more unique successors should be considered for unswitching.

Patch Author: Daniil Suchkov.

Reviewers: reames, asbirlea, skatkov
Reviewed By: skatkov
Subscribers: hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D64404
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp (diff)llvm.src/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
The file was modified/llvm/trunk/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch-redundant-switch.ll (diff)llvm.src/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch-redundant-switch.ll
Revision 365610 by lenary:
[test-suite] Fix RISC-V Support in benchmark 1.3.0

Summary:
Fixed by backporting the upstream fix from here:
  https://github.com/google/benchmark/pull/833

Reviewers: lebedev.ri

Reviewed By: lebedev.ri

Subscribers: asb, kito-cheng, shiva0217, rogfer01, rkruppe, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64237
Change TypePath in RepositoryPath in Workspace
The file was added/test-suite/trunk/MicroBenchmarks/libs/benchmark-1.3.0/README.llvmtest-suite.src/MicroBenchmarks/libs/benchmark-1.3.0/README.llvm
The file was modified/test-suite/trunk/MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h (diff)test-suite.src/MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h
Revision 365609 by dnsampaio:
[AArch64] Fix vector vuqadd intrinsics operands

Summary:
Change the vuqadd vector instrinsics to have the second argument as unsigned values, not signed,
accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics

Reviewers: LukeCheeseman, ostannard

Reviewed By: ostannard

Subscribers: javed.absar, kristof.beyls, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64211
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/arm_neon.td (diff)clang.src/include/clang/Basic/arm_neon.td
The file was modified/cfe/trunk/test/CodeGen/aarch64-neon-intrinsics.c (diff)clang.src/test/CodeGen/aarch64-neon-intrinsics.c
Revision 365608 by dnsampaio:
[NFC][AArch64] Fix vector vsqadd intrinsics operands

Summary:
Change the vsqadd vector instrinsics to have the second argument as signed values, not unsigned,
accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics

Reviewers: LukeCheeseman, ostannard

Reviewed By: ostannard

Subscribers: javed.absar, kristof.beyls, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64210
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/arm_neon.td (diff)clang.src/include/clang/Basic/arm_neon.td
Revision 365607 by ibiryukov:
[clangd] Stop recording tokens before running clang-tidy

modernize-trailing-return-type runs the preprocessor, breaking the token
collection logic.

This lead to a crash before, see the new test for a repro.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/ClangdUnit.cpp (diff)clang-tools-extra.src/clangd/ClangdUnit.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/ClangdUnitTests.cpp (diff)clang-tools-extra.src/clangd/unittests/ClangdUnitTests.cpp
Revision 365606 by ibiryukov:
[clangd] Consume error to avoid assertion failures

When we fail to calculate #include insertion for a completion item.
Note that this change does not add a test, although that would be good.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/CodeComplete.cpp (diff)clang-tools-extra.src/clangd/CodeComplete.cpp
Revision 365605 by ruiu:
Make functions and member variables distinguishable even after the name style change. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/COFF/Chunks.cpp (diff)lld.src/COFF/Chunks.cpp
The file was modified/lld/trunk/COFF/Chunks.h (diff)lld.src/COFF/Chunks.h
The file was modified/lld/trunk/COFF/Driver.cpp (diff)lld.src/COFF/Driver.cpp
The file was modified/lld/trunk/COFF/InputFiles.cpp (diff)lld.src/COFF/InputFiles.cpp
The file was modified/lld/trunk/COFF/SymbolTable.cpp (diff)lld.src/COFF/SymbolTable.cpp
The file was modified/lld/trunk/COFF/Symbols.h (diff)lld.src/COFF/Symbols.h
The file was modified/lld/trunk/COFF/Writer.cpp (diff)lld.src/COFF/Writer.cpp
The file was modified/lld/trunk/wasm/InputChunks.h (diff)lld.src/wasm/InputChunks.h
The file was modified/lld/trunk/wasm/OutputSections.cpp (diff)lld.src/wasm/OutputSections.cpp
The file was modified/lld/trunk/wasm/OutputSections.h (diff)lld.src/wasm/OutputSections.h
The file was modified/lld/trunk/wasm/SymbolTable.cpp (diff)lld.src/wasm/SymbolTable.cpp
The file was modified/lld/trunk/wasm/SyntheticSections.cpp (diff)lld.src/wasm/SyntheticSections.cpp
The file was modified/lld/trunk/wasm/SyntheticSections.h (diff)lld.src/wasm/SyntheticSections.h
The file was modified/lld/trunk/wasm/Writer.cpp (diff)lld.src/wasm/Writer.cpp
Revision 365604 by miyuki:
[ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present

Summary:
Use the same predicates as VSTMDB/VLDMIA since VPUSH/VPOP alias to
these.

Patch by Momchil Velikov.

Reviewers: ostannard, simon_tatham, SjoerdMeijer, samparker, t.p.northover, dmgreen

Reviewed By: dmgreen

Subscribers: javed.absar, kristof.beyls, hiraditya, dmgreen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64413
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMInstrFormats.td (diff)llvm.src/lib/Target/ARM/ARMInstrFormats.td
The file was modified/llvm/trunk/lib/Target/ARM/ARMInstrVFP.td (diff)llvm.src/lib/Target/ARM/ARMInstrVFP.td
The file was modified/llvm/trunk/test/MC/ARM/mve-fp-registers.s (diff)llvm.src/test/MC/ARM/mve-fp-registers.s
Revision 365603 by jhenderson:
[docs][llvm-dwarfdump] Normalise some wording
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/llvm-dwarfdump.rst (diff)llvm.src/docs/CommandGuide/llvm-dwarfdump.rst
Revision 365602 by jvikstrom:
[clangd] Added highlighting for class and enum types.

Summary: Added highlighting for non-builtin types using VisitTypeLoc. Ignoring namespace qualifiers as for now.

Reviewers: hokein, sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64257
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp (diff)clang-tools-extra.src/clangd/SemanticHighlighting.cpp
The file was modified/clang-tools-extra/trunk/clangd/SemanticHighlighting.h (diff)clang-tools-extra.src/clangd/SemanticHighlighting.h
The file was modified/clang-tools-extra/trunk/clangd/test/semantic-highlighting.test (diff)clang-tools-extra.src/clangd/test/semantic-highlighting.test
The file was modified/clang-tools-extra/trunk/clangd/unittests/SemanticHighlightingTests.cpp (diff)clang-tools-extra.src/clangd/unittests/SemanticHighlightingTests.cpp
Revision 365601 by grimar:
[test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries.

This converts 5 precompiled binaries to YAMLs,
removes 4 from inputs and performs a cleanup.

Differential revision: https://reviews.llvm.org/D64246
Change TypePath in RepositoryPath in Workspace
The file was removed/llvm/trunk/test/Object/Inputs/absolute.elf-x86-64llvm.src/test/Object/Inputs/absolute.elf-x86-64
The file was removed/llvm/trunk/test/Object/Inputs/relocatable-with-section-address.elf-x86-64llvm.src/test/Object/Inputs/relocatable-with-section-address.elf-x86-64
The file was removed/llvm/trunk/test/Object/Inputs/thumb-symbols.elf.armllvm.src/test/Object/Inputs/thumb-symbols.elf.arm
The file was removed/llvm/trunk/test/Object/Inputs/weak.elf-x86-64llvm.src/test/Object/Inputs/weak.elf-x86-64
The file was modified/llvm/trunk/test/Object/nm-trivial-object.test (diff)llvm.src/test/Object/nm-trivial-object.test
Revision 365600 by skatkov:
[SimpleLoopUnswitch] Add a test case exposing a bug

This test exposes a bug in SimpleLoopUnswitch that leads to a crash on
assert(SuccessorsCount > 1 && "Cannot unswitch a condition without multiple distinct successors!");
when SimpleLoopUnswitch considers unswitching of a loop by a switch with one successor.

Fix will be submitted soon.

Patch Author: Daniil Suchkov.

Reviewers: reames, asbirlea, skatkov
Reviewed By: skatkov
Subscribers: zzheng, llvm-commits
Differential Revision: https://reviews.llvm.org/D64403
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch-redundant-switch.llllvm.src/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch-redundant-switch.ll
Revision 365599 by ibiryukov:
[Syntax] Add assertion to catch invalid tokens early. NFC

To help with identifiying root cause of a crash we are seeing.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Tooling/Syntax/Tokens.h (diff)clang.src/include/clang/Tooling/Syntax/Tokens.h
The file was modified/cfe/trunk/lib/Tooling/Syntax/Tokens.cpp (diff)clang.src/lib/Tooling/Syntax/Tokens.cpp
Revision 365598 by dnsampaio:
[NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

Summary:
Change the vqtb[lx][1-4]_s8 instrinsics to have the last argument as vector of unsigned valuse, not
signed, accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics

Reviewers: LukeCheeseman, DavidSpickett

Reviewed By: DavidSpickett

Subscribers: DavidSpickett, javed.absar, kristof.beyls, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64243
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/arm_neon.td (diff)clang.src/include/clang/Basic/arm_neon.td
The file was modified/cfe/trunk/test/CodeGen/aarch64-neon-tbl.c (diff)clang.src/test/CodeGen/aarch64-neon-tbl.c