FailedChanges

Summary

  1. Replace FullComment member being visited with parameter Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55070
  2. Extend the CommentVisitor with parameter types Summary: This has precedent in the StmtVisitor. This change will make it possible to clean up the comment handling in ASTDumper. Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55069
  3. Remove unecessary methods The base class calls VisitExpr
  4. [test] Fix use of 'sort -b' in SimpleLoopUnswitch on NetBSD Add '-k 1' to 'sort -b' calls in SimpleLoopUnswitch tests, as required for sort implementation on NetBSD. The '-b' modifier is ineffective if specified without any key. Per the manpage: Note that the -b option has no effect unless key fields are specified. Differential Revision: https://reviews.llvm.org/D55168
  5. [test] Fix ScalarEvolution test to allow __func__ with prototype Fix ScalarEvolution/solve-quadratic.ll test to account for __func__ output listing the complete function prototype rather than just its name, as it does on NetBSD. Example Linux output: GetQuadraticEquation: addrec coeff bw: 4 GetQuadraticEquation: equation -2x^2 + -2x + -4, coeff bw: 5, multiplied by 2 Example NetBSD output: llvm::Optional<std::tuple<llvm::APInt, llvm::APInt, llvm::APInt, llvm::APInt, unsigned int> > GetQuadraticEquation(const llvm::SCEVAddRecExpr*): addrec coeff bw: 4 llvm::Optional<std::tuple<llvm::APInt, llvm::APInt, llvm::APInt, llvm::APInt, unsigned int> > GetQuadraticEquation(const llvm::SCEVAddRecExpr*): equation -2x^2 + -2x + -4, coeff bw: 5, multiplied by 2 Differential Revision: https://reviews.llvm.org/D55162
  6. [test] Fix BugPoint/compile-custom.ll to use detected python exec Spawn the custom compile command in BugPoint/compile-custom.ll via %python rather than relying on implicit 'env python' shebang, in order to fix it on systems that don't have 'python' executable such as NetBSD. Differential Revision: https://reviews.llvm.org/D55161
  7. Fix whitespace
Revision 348101 by steveire:
Replace FullComment member being visited with parameter

Reviewers: aaron.ballman

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D55070
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ASTDumper.cppclang.src/lib/AST/ASTDumper.cpp
Revision 348100 by steveire:
Extend the CommentVisitor with parameter types

Summary:
This has precedent in the StmtVisitor.  This change will make it
possible to clean up the comment handling in ASTDumper.

Reviewers: aaron.ballman

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D55069
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/CommentVisitor.hclang.src/include/clang/AST/CommentVisitor.h
Revision 348099 by steveire:
Remove unecessary methods

The base class calls VisitExpr
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ASTDumper.cppclang.src/lib/AST/ASTDumper.cpp
Revision 348097 by mgorny:
[test] Fix use of 'sort -b' in SimpleLoopUnswitch on NetBSD

Add '-k 1' to 'sort -b' calls in SimpleLoopUnswitch tests, as required
for sort implementation on NetBSD.  The '-b' modifier is ineffective
if specified without any key.  Per the manpage:

  Note that the -b option has no effect unless key fields are specified.

Differential Revision: https://reviews.llvm.org/D55168
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/SimpleLoopUnswitch/exponential-nontrivial-unswitch-nested.llllvm.src/test/Transforms/SimpleLoopUnswitch/exponential-nontrivial-unswitch-nested.ll
The file was modified/llvm/trunk/test/Transforms/SimpleLoopUnswitch/exponential-nontrivial-unswitch-nested2.llllvm.src/test/Transforms/SimpleLoopUnswitch/exponential-nontrivial-unswitch-nested2.ll
The file was modified/llvm/trunk/test/Transforms/SimpleLoopUnswitch/exponential-switch-unswitch.llllvm.src/test/Transforms/SimpleLoopUnswitch/exponential-switch-unswitch.ll
Revision 348096 by mgorny:
[test] Fix ScalarEvolution test to allow __func__ with prototype

Fix ScalarEvolution/solve-quadratic.ll test to account for __func__
output listing the complete function prototype rather than just its
name, as it does on NetBSD.

Example Linux output:

  GetQuadraticEquation: addrec coeff bw: 4
  GetQuadraticEquation: equation -2x^2 + -2x + -4, coeff bw: 5, multiplied by 2

Example NetBSD output:

  llvm::Optional<std::tuple<llvm::APInt, llvm::APInt, llvm::APInt, llvm::APInt, unsigned int> > GetQuadraticEquation(const llvm::SCEVAddRecExpr*): addrec coeff bw: 4
  llvm::Optional<std::tuple<llvm::APInt, llvm::APInt, llvm::APInt, llvm::APInt, unsigned int> > GetQuadraticEquation(const llvm::SCEVAddRecExpr*): equation -2x^2 + -2x + -4, coeff bw: 5, multiplied by 2

Differential Revision: https://reviews.llvm.org/D55162
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Analysis/ScalarEvolution/solve-quadratic.llllvm.src/test/Analysis/ScalarEvolution/solve-quadratic.ll
Revision 348095 by mgorny:
[test] Fix BugPoint/compile-custom.ll to use detected python exec

Spawn the custom compile command in BugPoint/compile-custom.ll via
%python rather than relying on implicit 'env python' shebang, in order
to fix it on systems that don't have 'python' executable such as NetBSD.

Differential Revision: https://reviews.llvm.org/D55161
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/BugPoint/compile-custom.llllvm.src/test/BugPoint/compile-custom.ll
Revision 348094 by steveire:
Fix whitespace
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/AST/ast-dump-array.cppclang.src/test/AST/ast-dump-array.cpp