FailedChanges

Summary

  1. [gn build] Fix cosmetic bug in write_cmake_config.py Before, #cmakedefine FOO resulted in #define FOO with a trailing space if FOO was set to something truthy. Make it so that it's just #define FOO without a trailing space. No functional difference. Differential Revision: https://reviews.llvm.org/D55172
  2. [gn build] Slightly simplify write_cmake_config. Before, the script had a bunch of special cases for #cmakedefine and #cmakedefine01 and then did general variable substitution. Now, the script always does general variable substitution for all lines and handles the special cases afterwards. This has no observable effect for the inputs we use, but is easier to explain and slightly easier to implement. Also mention to link to CMake's configure_file() in the docstring. (The new behavior doesn't quite match CMake on lines like #cmakedefine ${FOO}, but nobody does that.) Differential Revision: https://reviews.llvm.org/D55171
Revision 348107 by nico:
[gn build] Fix cosmetic bug in write_cmake_config.py

Before, #cmakedefine FOO resulted in #define FOO  with a trailing space if FOO
was set to something truthy. Make it so that it's just #define FOO without a
trailing space.

No functional difference.

Differential Revision: https://reviews.llvm.org/D55172
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/build/write_cmake_config.pyllvm.src/utils/gn/build/write_cmake_config.py
Revision 348106 by nico:
[gn build] Slightly simplify write_cmake_config.

Before, the script had a bunch of special cases for #cmakedefine and
#cmakedefine01 and then did general variable substitution. Now, the script
always does general variable substitution for all lines and handles the special
cases afterwards.

This has no observable effect for the inputs we use, but is easier to explain
and slightly easier to implement.

Also mention to link to CMake's configure_file() in the docstring.

(The new behavior doesn't quite match CMake on lines like #cmakedefine ${FOO},
but nobody does that.)

Differential Revision: https://reviews.llvm.org/D55171
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/build/write_cmake_config.pyllvm.src/utils/gn/build/write_cmake_config.py