SuccessChanges

Summary

  1. Add missing test for r366215
  2. [Remarks] Simplify and refactor the RemarkParser interface Before, everything was based on some kind of type erased parser implementation which container a lot of boilerplate code when multiple formats were to be supported. This simplifies it by: * the remark now owns its arguments * *always* returning an error from the implementation side * working around the way the YAML parser reports errors: catch them through callbacks and re-insert them in a proper llvm::Error * add a CParser wrapper that is used when implementing the C API to avoid cluttering the C++ API with useless state * LLVMRemarkParserGetNext now returns an object that needs to be released to avoid leaking resources * add a new API to dispose of a remark entry: LLVMRemarkEntryDispose
  3. [Remarks][NFC] Combine ParserFormat and SerializerFormat It's useless to have both.
  4. [ADCE] Fix non-deterministic behaviour due to iterating over a pointer set. Original patch by Yann Laigle-Chapuy Differential Revision: https://reviews.llvm.org/D64785
Revision 366218 by aemerson:
Add missing test for r366215
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/ADCE/blocks-with-dead-term-nondeterministic.llllvm.src/test/Transforms/ADCE/blocks-with-dead-term-nondeterministic.ll
Revision 366217 by thegameg:
[Remarks] Simplify and refactor the RemarkParser interface

Before, everything was based on some kind of type erased parser
implementation which container a lot of boilerplate code when multiple
formats were to be supported.

This simplifies it by:

* the remark now owns its arguments
* *always* returning an error from the implementation side
* working around the way the YAML parser reports errors: catch them through
callbacks and re-insert them in a proper llvm::Error
* add a CParser wrapper that is used when implementing the C API to
avoid cluttering the C++ API with useless state
* LLVMRemarkParserGetNext now returns an object that needs to be
released to avoid leaking resources
* add a new API to dispose of a remark entry: LLVMRemarkEntryDispose
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/Remarks.rst (diff)llvm.src/docs/Remarks.rst
The file was modified/llvm/trunk/include/llvm-c/Remarks.h (diff)llvm.src/include/llvm-c/Remarks.h
The file was modified/llvm/trunk/include/llvm/IR/RemarkStreamer.h (diff)llvm.src/include/llvm/IR/RemarkStreamer.h
The file was modified/llvm/trunk/include/llvm/Remarks/Remark.h (diff)llvm.src/include/llvm/Remarks/Remark.h
The file was modified/llvm/trunk/include/llvm/Remarks/RemarkParser.h (diff)llvm.src/include/llvm/Remarks/RemarkParser.h
The file was modified/llvm/trunk/include/llvm/Support/SourceMgr.h (diff)llvm.src/include/llvm/Support/SourceMgr.h
The file was modified/llvm/trunk/lib/IR/RemarkStreamer.cpp (diff)llvm.src/lib/IR/RemarkStreamer.cpp
The file was modified/llvm/trunk/lib/Remarks/Remark.cpp (diff)llvm.src/lib/Remarks/Remark.cpp
The file was modified/llvm/trunk/lib/Remarks/RemarkParser.cpp (diff)llvm.src/lib/Remarks/RemarkParser.cpp
The file was removed/llvm/trunk/lib/Remarks/RemarkParserImpl.hllvm.src/lib/Remarks/RemarkParserImpl.h
The file was modified/llvm/trunk/lib/Remarks/YAMLRemarkParser.cpp (diff)llvm.src/lib/Remarks/YAMLRemarkParser.cpp
The file was modified/llvm/trunk/lib/Remarks/YAMLRemarkParser.h (diff)llvm.src/lib/Remarks/YAMLRemarkParser.h
The file was modified/llvm/trunk/tools/llvm-opt-report/OptReport.cpp (diff)llvm.src/tools/llvm-opt-report/OptReport.cpp
The file was modified/llvm/trunk/tools/remarks-shlib/Remarks.exports (diff)llvm.src/tools/remarks-shlib/Remarks.exports
The file was modified/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp (diff)llvm.src/unittests/Remarks/YAMLRemarksParsingTest.cpp
Revision 366216 by thegameg:
[Remarks][NFC] Combine ParserFormat and SerializerFormat

It's useless to have both.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/RemarkStreamer.h (diff)llvm.src/include/llvm/IR/RemarkStreamer.h
The file was modified/llvm/trunk/include/llvm/Remarks/Remark.h (diff)llvm.src/include/llvm/Remarks/Remark.h
The file was added/llvm/trunk/include/llvm/Remarks/RemarkFormat.hllvm.src/include/llvm/Remarks/RemarkFormat.h
The file was modified/llvm/trunk/include/llvm/Remarks/RemarkParser.h (diff)llvm.src/include/llvm/Remarks/RemarkParser.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (diff)llvm.src/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
The file was modified/llvm/trunk/lib/IR/RemarkStreamer.cpp (diff)llvm.src/lib/IR/RemarkStreamer.cpp
The file was modified/llvm/trunk/lib/Remarks/CMakeLists.txt (diff)llvm.src/lib/Remarks/CMakeLists.txt
The file was added/llvm/trunk/lib/Remarks/RemarkFormat.cppllvm.src/lib/Remarks/RemarkFormat.cpp
The file was modified/llvm/trunk/lib/Remarks/RemarkParser.cpp (diff)llvm.src/lib/Remarks/RemarkParser.cpp
The file was modified/llvm/trunk/lib/Remarks/RemarkParserImpl.h (diff)llvm.src/lib/Remarks/RemarkParserImpl.h
The file was modified/llvm/trunk/lib/Remarks/YAMLRemarkParser.h (diff)llvm.src/lib/Remarks/YAMLRemarkParser.h
The file was modified/llvm/trunk/tools/llvm-opt-report/OptReport.cpp (diff)llvm.src/tools/llvm-opt-report/OptReport.cpp
The file was modified/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp (diff)llvm.src/unittests/Remarks/YAMLRemarksParsingTest.cpp
Revision 366215 by aemerson:
[ADCE] Fix non-deterministic behaviour due to iterating over a pointer set.

Original patch by Yann Laigle-Chapuy

Differential Revision: https://reviews.llvm.org/D64785
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/ADCE.cpp (diff)llvm.src/lib/Transforms/Scalar/ADCE.cpp