FailedChanges

Summary

  1. Precommit tests for D67514
  2. AMDGPU: Fix bug in r371671 on some builds.
  3. [analyzer][NFC] Fix inconsistent references to checkers as "checks" Traditionally, clang-tidy uses the term check, and the analyzer uses checker, but in the very early years, this wasn't the case, and code originating from the early 2010's still incorrectly refer to checkers as checks. This patch attempts to hunt down most of these, aiming to refer to checkers as checkers, but preserve references to callback functions (like checkPreCall) as checks. Differential Revision: https://reviews.llvm.org/D67140
  4. NFC, add missing cl::cat option category to clang-scan-deps options to ensure they show up in -help
  5. Add getauxval() compat for NetBSD Summary: getauxval() is not available on NetBSD and there is no a direct equivalent. Add a function that implements the same semantics with NetBSD internals. Reorder the GetPageSize() functions to prefer the sysctl approach for NetBSD. It no longer makes a difference which approach is better. Avoid changing conditional code path. Reviewers: vitalybuka, dvyukov, mgorny, joerg Reviewed By: vitalybuka Subscribers: llvm-commits, #sanitizers Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D67329
  6. Split many_tls_keys.cpp into two tests Summary: many_tls_keys_pthread.cpp for TSD many_tls_keys_thread.cpp for TLS The TSD test is unsupported on NetBSD as it assumes TLS used internally. TSD on NetBSD does not use TLS. Reviewers: joerg, vitalybuka, mgorny, dvyukov, kcc Reviewed By: vitalybuka Subscribers: jfb, llvm-commits, #sanitizers Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D67428
  7. [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers Short and sweet. Whenever I use -analyzer-list-enabled-checkers, I'm only interested about the configuration, not about the analysis. Differential Revision: https://reviews.llvm.org/D66714
  8. llvm-reduce: Remove unused plugin support/requirements
  9. Use host's executable suffix for clang when cross-compiling compiler-rt When cross-compiling compiler-rt as part of LLVM e. g. for Linux on a Windows host and using the just-built clang as cross-compiler, we set the -DBUILTINS_CMAKE_ARGS="-DCMAKE_SYSTEM_NAME=Linux" flag in top-level cmake invocation, which causes CMAKE_EXECUTABLE_SUFFIX to be an empty string in the nested cmake invocation for building builtins. But the compiler for compiling test cases is meant to be run on host, therefore it may have the '.exe' suffix. Handle this by asking cmake about the host system. Patch by Sergej Jaskiewicz <jaskiewiczs@icloud.com> Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D67401
  10. [MS] Warn when shadowing template parameters under -fms-compatibility Summary: C++ does not allow shadowing template parameters, but previously we allowed it under -fms-extensions. Now this behavior is controlled by -fms-compatibility, and we emit a -Wmicrosoft-template warning when it happens. Fixes PR43265 Reviewers: thakis, hans Subscribers: amccarth, rsmith, STL_MSFT, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D67463
Revision 371762 by reames:
Precommit tests for D67514
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Analysis/ScalarEvolution/trip-count15.llllvm.src/test/Analysis/ScalarEvolution/trip-count15.ll
Revision 371761 by kerbowa:
AMDGPU: Fix bug in r371671 on some builds.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIFixSGPRCopies.cpp (diff)llvm.src/lib/Target/AMDGPU/SIFixSGPRCopies.cpp
Revision 371760 by szelethus:
[analyzer][NFC] Fix inconsistent references to checkers as "checks"

Traditionally, clang-tidy uses the term check, and the analyzer uses checker,
but in the very early years, this wasn't the case, and code originating from the
early 2010's still incorrectly refer to checkers as checks.

This patch attempts to hunt down most of these, aiming to refer to checkers as
checkers, but preserve references to callback functions (like checkPreCall) as
checks.

Differential Revision: https://reviews.llvm.org/D67140
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Analysis/PathDiagnostic.h (diff)clang.src/include/clang/Analysis/PathDiagnostic.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h (diff)clang.src/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h (diff)clang.src/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugType.h (diff)clang.src/include/clang/StaticAnalyzer/Core/BugReporter/BugType.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/Checker.h (diff)clang.src/include/clang/StaticAnalyzer/Core/Checker.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/CheckerManager.h (diff)clang.src/include/clang/StaticAnalyzer/Core/CheckerManager.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h (diff)clang.src/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
The file was modified/cfe/trunk/lib/Analysis/PathDiagnostic.cpp (diff)clang.src/lib/Analysis/PathDiagnostic.cpp
The file was modified/cfe/trunk/lib/Analysis/plugins/SampleAnalyzer/MainCallChecker.cpp (diff)clang.src/lib/Analysis/plugins/SampleAnalyzer/MainCallChecker.cpp
The file was modified/cfe/trunk/lib/Frontend/CompilerInvocation.cpp (diff)clang.src/lib/Frontend/CompilerInvocation.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/CStringChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/DeleteWithNonVirtualDtorChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/DeleteWithNonVirtualDtorChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/IteratorChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/UndefinedArraySubscriptChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/UndefinedArraySubscriptChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/ValistChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp (diff)clang.src/lib/StaticAnalyzer/Core/BugReporter.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/Checker.cpp (diff)clang.src/lib/StaticAnalyzer/Core/Checker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/CheckerManager.cpp (diff)clang.src/lib/StaticAnalyzer/Core/CheckerManager.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp (diff)clang.src/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp (diff)clang.src/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp (diff)clang.src/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp (diff)clang.src/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp (diff)clang.src/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp (diff)clang.src/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
The file was modified/cfe/trunk/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp (diff)clang.src/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp
Revision 371759 by arphaman:
NFC, add missing cl::cat option category to clang-scan-deps options to ensure they show up in -help
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/clang-scan-deps/ClangScanDeps.cpp (diff)clang.src/tools/clang-scan-deps/ClangScanDeps.cpp
Revision 371758 by kamil:
Add getauxval() compat for NetBSD

Summary:
getauxval() is not available on NetBSD and there is no a direct equivalent.

Add a function that implements the same semantics with NetBSD internals.

Reorder the GetPageSize() functions to prefer the sysctl approach for NetBSD.
It no longer makes a difference which approach is better. Avoid changing
conditional code path.

Reviewers: vitalybuka, dvyukov, mgorny, joerg

Reviewed By: vitalybuka

Subscribers: llvm-commits, #sanitizers

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D67329
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_getauxval.h (diff)compiler-rt.src/lib/sanitizer_common/sanitizer_getauxval.h
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cpp (diff)compiler-rt.src/lib/sanitizer_common/sanitizer_linux.cpp
Revision 371757 by kamil:
Split many_tls_keys.cpp into two tests

Summary:
many_tls_keys_pthread.cpp for TSD
many_tls_keys_thread.cpp for TLS

The TSD test is unsupported on NetBSD as it assumes TLS used internally.
TSD on NetBSD does not use TLS.

Reviewers: joerg, vitalybuka, mgorny, dvyukov, kcc

Reviewed By: vitalybuka

Subscribers: jfb, llvm-commits, #sanitizers

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D67428
Change TypePath in RepositoryPath in Workspace
The file was removed/compiler-rt/trunk/test/lsan/TestCases/many_tls_keys.cppcompiler-rt.src/test/lsan/TestCases/many_tls_keys.cpp
The file was added/compiler-rt/trunk/test/lsan/TestCases/many_tls_keys_pthread.cppcompiler-rt.src/test/lsan/TestCases/many_tls_keys_pthread.cpp
The file was added/compiler-rt/trunk/test/lsan/TestCases/many_tls_keys_thread.cppcompiler-rt.src/test/lsan/TestCases/many_tls_keys_thread.cpp
Revision 371756 by szelethus:
[analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

Short and sweet. Whenever I use -analyzer-list-enabled-checkers, I'm only
interested about the configuration, not about the analysis.

Differential Revision: https://reviews.llvm.org/D66714
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/FrontendTool/ExecuteCompilerInvocation.cpp (diff)clang.src/lib/FrontendTool/ExecuteCompilerInvocation.cpp
The file was modified/cfe/trunk/test/Analysis/analyzer-enabled-checkers.c (diff)clang.src/test/Analysis/analyzer-enabled-checkers.c
Revision 371755 by dblaikie:
llvm-reduce: Remove unused plugin support/requirements
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Reduce/remove-args.ll (diff)llvm.src/test/Reduce/remove-args.ll
The file was modified/llvm/trunk/test/Reduce/remove-funcs.ll (diff)llvm.src/test/Reduce/remove-funcs.ll
The file was modified/llvm/trunk/test/Reduce/remove-global-vars.ll (diff)llvm.src/test/Reduce/remove-global-vars.ll
The file was modified/llvm/trunk/test/Reduce/remove-metadata.ll (diff)llvm.src/test/Reduce/remove-metadata.ll
The file was modified/llvm/trunk/tools/llvm-reduce/CMakeLists.txt (diff)llvm.src/tools/llvm-reduce/CMakeLists.txt
Revision 371754 by rnk:
Use host's executable suffix for clang when cross-compiling compiler-rt

When cross-compiling compiler-rt as part of LLVM e. g. for Linux on
a Windows host and using the just-built clang as cross-compiler, we set
the -DBUILTINS_CMAKE_ARGS="-DCMAKE_SYSTEM_NAME=Linux" flag in top-level
cmake invocation, which causes CMAKE_EXECUTABLE_SUFFIX to be an empty
string in the nested cmake invocation for building builtins.

But the compiler for compiling test cases is meant to be run on host,
therefore it may have the '.exe' suffix.

Handle this by asking cmake about the host system.

Patch by Sergej Jaskiewicz <jaskiewiczs@icloud.com>

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D67401
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/cmake/base-config-ix.cmake (diff)compiler-rt.src/cmake/base-config-ix.cmake
Revision 371753 by rnk:
[MS] Warn when shadowing template parameters under -fms-compatibility

Summary:
C++ does not allow shadowing template parameters, but previously we
allowed it under -fms-extensions. Now this behavior is controlled by
-fms-compatibility, and we emit a -Wmicrosoft-template warning when it
happens.

Fixes PR43265

Reviewers: thakis, hans

Subscribers: amccarth, rsmith, STL_MSFT, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67463
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (diff)clang.src/include/clang/Basic/DiagnosticSemaKinds.td
The file was modified/cfe/trunk/lib/Sema/SemaTemplate.cpp (diff)clang.src/lib/Sema/SemaTemplate.cpp
The file was modified/cfe/trunk/test/Parser/DelayedTemplateParsing.cpp (diff)clang.src/test/Parser/DelayedTemplateParsing.cpp
The file was modified/cfe/trunk/test/SemaCXX/MicrosoftCompatibility.cpp (diff)clang.src/test/SemaCXX/MicrosoftCompatibility.cpp