SuccessChanges

Summary

  1. [clangd][vscode] update the development doc.
  2. Move some definitions from Sema to Basic to fix shared libs build r371875 moved some functionality around to a Basic header file, but didn't move its definitions as well. This patch moves some things around so that shared library building can work.
  3. [docs][llvm-strings] Write llvm-strings documentation Previously we only had a stub document. Reviewed by: MaskRay Differential Revision: https://reviews.llvm.org/D67554
  4. [docs][llvm-size] Write llvm-size documentation Previously we only had a stub document. Reviewed by: serge-sans-paille, MaskRay Differential Revision: https://reviews.llvm.org/D67555
  5. [ARM] Fold VCMP into VPT MVE has VPT instructions, which perform the duties of both a VCMP and a VPST in a single instruction, performing the compare and starting the VPT block in one. This teaches the MVEVPTBlockPass to fold them, searching back through the basicblock for a valid VCMP and creating the VPT from its operands. There are some changes to the VPT instructions to accommodate this, altering the order of the operands to match the VCMP better, and changing P0 register defs to be VPR defs, as is used in other places. Differential Revision: https://reviews.llvm.org/D66577
  6. [InstCombine] remove unneeded one-use checks for icmp fold This fold and several others were added in: rL125734 <https://reviews.llvm.org/rL125734> ...with no explanation for the one-use checks other than the code comments about register pressure. Given that this is IR canonicalization, we shouldn't be worried about register pressure though; the backend should be able to adjust for that as needed. This is part of solving PR43310 the theoretically right way: https://bugs.llvm.org/show_bug.cgi?id=43310 ...ie, if we don't cripple basic transforms, then we won't need to add special-case code to detect larger patterns. rL371940 is a related patch in this series.
  7. [clangd] Bump vscode-clangd v0.0.17 CHANGELOG: - added semantic highlighting support (under the clangd.semanticHighlighting flag); - better error message when clangd fails to execute refactoring-like actions; - improved the readme doc;
  8. [InstCombine] add icmp tests with extra uses; NFC
  9. [InstCombine] fix comments to match code; NFC This blob was written before match() existed, so it could probably be reduced significantly. But I suspect it isn't well tested, so tests would have to be added to reduce risk from logic changes.
Revision 371986 by hokein:
[clangd][vscode] update the development doc.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/clients/clangd-vscode/DEVELOPING.md (diff)clang-tools-extra.src/clangd/clients/clangd-vscode/DEVELOPING.md
Revision 371985 by erichkeane:
Move some definitions from Sema to Basic to fix shared libs build

r371875 moved some functionality around to a Basic header file, but
didn't move its definitions as well.  This patch moves some things
around so that shared library building can work.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Basic/Attributes.cpp (diff)clang.src/lib/Basic/Attributes.cpp
The file was modified/cfe/trunk/lib/Sema/ParsedAttr.cpp (diff)clang.src/lib/Sema/ParsedAttr.cpp
The file was modified/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (diff)clang.src/utils/TableGen/ClangAttrEmitter.cpp
Revision 371984 by jhenderson:
[docs][llvm-strings] Write llvm-strings documentation

Previously we only had a stub document.

Reviewed by: MaskRay

Differential Revision: https://reviews.llvm.org/D67554
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/llvm-strings.rst (diff)llvm.src/docs/CommandGuide/llvm-strings.rst
Revision 371983 by jhenderson:
[docs][llvm-size] Write llvm-size documentation

Previously we only had a stub document.

Reviewed by: serge-sans-paille, MaskRay

Differential Revision: https://reviews.llvm.org/D67555
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/llvm-size.rst (diff)llvm.src/docs/CommandGuide/llvm-size.rst
Revision 371982 by dmgreen:
[ARM] Fold VCMP into VPT

MVE has VPT instructions, which perform the duties of both a VCMP and a VPST in
a single instruction, performing the compare and starting the VPT block in one.
This teaches the MVEVPTBlockPass to fold them, searching back through the
basicblock for a valid VCMP and creating the VPT from its operands.

There are some changes to the VPT instructions to accommodate this, altering
the order of the operands to match the VCMP better, and changing P0 register
defs to be VPR defs, as is used in other places.

Differential Revision: https://reviews.llvm.org/D66577
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMInstrMVE.td (diff)llvm.src/lib/Target/ARM/ARMInstrMVE.td
The file was modified/llvm/trunk/lib/Target/ARM/MVEVPTBlockPass.cpp (diff)llvm.src/lib/Target/ARM/MVEVPTBlockPass.cpp
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-masked-ldst.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-masked-ldst.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-masked-load.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-masked-load.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-masked-store.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-masked-store.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-pred-and.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-pred-and.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-pred-not.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-pred-not.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-pred-or.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-pred-or.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vcmpf.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-vcmpf.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vcmpfr.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-vcmpfr.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vcmpfz.ll (diff)llvm.src/test/CodeGen/Thumb2/mve-vcmpfz.ll
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block2.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block2.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block3.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block3.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block4.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block4.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block5.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block5.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block6.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block6.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block7.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block7.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-block8.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-block8.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/mve-vpt-nots.mir (diff)llvm.src/test/CodeGen/Thumb2/mve-vpt-nots.mir
Revision 371981 by spatel:
[InstCombine] remove unneeded one-use checks for icmp fold

This fold and several others were added in:
rL125734 <https://reviews.llvm.org/rL125734>
...with no explanation for the one-use checks other than the code
comments about register pressure.

Given that this is IR canonicalization, we shouldn't be worried
about register pressure though; the backend should be able to
adjust for that as needed.

This is part of solving PR43310 the theoretically right way:
https://bugs.llvm.org/show_bug.cgi?id=43310
...ie, if we don't cripple basic transforms, then we won't
need to add special-case code to detect larger patterns.

rL371940 is a related patch in this series.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp (diff)llvm.src/lib/Transforms/InstCombine/InstCombineCompares.cpp
The file was modified/llvm/trunk/test/Transforms/InstCombine/icmp.ll (diff)llvm.src/test/Transforms/InstCombine/icmp.ll
Revision 371980 by hokein:
[clangd] Bump vscode-clangd v0.0.17

CHANGELOG:
- added semantic highlighting support (under the clangd.semanticHighlighting
  flag);
- better error message when clangd fails to execute refactoring-like
  actions;
- improved the readme doc;
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json (diff)clang-tools-extra.src/clangd/clients/clangd-vscode/package.json
Revision 371979 by spatel:
[InstCombine] add icmp tests with extra uses; NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/icmp.ll (diff)llvm.src/test/Transforms/InstCombine/icmp.ll
Revision 371978 by spatel:
[InstCombine] fix comments to match code; NFC

This blob was written before match() existed, so it
could probably be reduced significantly.

But I suspect it isn't well tested, so tests would have
to be added to reduce risk from logic changes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp (diff)llvm.src/lib/Transforms/InstCombine/InstCombineCompares.cpp