SuccessChanges

Summary

  1. [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32 Add the missing piece of r372029. Somehow when the patch for review D61961 was committed, only the test case went in and the code didn't. This of course caused all kinds of build bot breaks. This patch just adds the code for that patch. Author: Lei Huang Differential revision: https://reviews.llvm.org/D61961
  2. [Remarks] Allow remarks::Format::YAML to take a string table It should be allowed to take a string table in case all the strings in the remarks point there, but it shouldn't use it during serialization.
  3. [test] Clean up previous raw profile before merging into it This fixes a test failure in instrprof-set-file-object-merging.c which seems to have been caused by reuse of stale data in old raw profiles.
  4. [OPENMP]Fix the test, NFC.
  5. [Modules][Objective-C] Use complete decl from module when diagnosing missing import Summary: Otherwise the definition (first found) for ObjCInterfaceDecl's might precede the module one, which will eventually lead to crash, since diagnoseMissingImport needs one coming from a module. This behavior changed after Richard's r342018, which started to look into the definition of ObjCInterfaceDecls. rdar://problem/49237144 Reviewers: rsmith, arphaman Subscribers: jkorous, dexonsmith, ributzka, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66982
  6. [compiler-rt][crt] make test case nontrivial in check_cxx_section_exists Summary: .init_array gets optimized away when building with -O2 and as a result, check_cxx_section_exists failed to pass -DCOMPILER_RT_HAS_INITFINI_ARRAY when building crtbegin.o and crtend.o, which causes binaries linked with them encounter segmentation fault. See https://crbug.com/855759 for details. This change prevents .init_array section to be optimized away even with -O2 or higher optimization level. Subscribers: dberris, mgorny, #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D67628
  7. [clang-tidy] add checks to bugprone-posix-return This check now also checks if any calls to pthread_* functions expect negative return values. These functions return either 0 on success or an errno on failure, which is positive only.
Revision 372043 by nemanjai:
[PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32

Add the missing piece of r372029.
Somehow when the patch for review D61961 was committed, only the test case
went in and the code didn't. This of course caused all kinds of build bot
breaks.
This patch just adds the code for that patch.

Author: Lei Huang
Differential revision: https://reviews.llvm.org/D61961
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (diff)llvm.src/lib/Target/PowerPC/PPCISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h (diff)llvm.src/lib/Target/PowerPC/PPCISelLowering.h
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCInstrVSX.td (diff)llvm.src/lib/Target/PowerPC/PPCInstrVSX.td
Revision 372042 by thegameg:
[Remarks] Allow remarks::Format::YAML to take a string table

It should be allowed to take a string table in case all the strings in
the remarks point there, but it shouldn't use it during serialization.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Remarks/BitstreamRemarkSerializer.h (diff)llvm.src/include/llvm/Remarks/BitstreamRemarkSerializer.h
The file was modified/llvm/trunk/include/llvm/Remarks/RemarkSerializer.h (diff)llvm.src/include/llvm/Remarks/RemarkSerializer.h
The file was modified/llvm/trunk/include/llvm/Remarks/YAMLRemarkSerializer.h (diff)llvm.src/include/llvm/Remarks/YAMLRemarkSerializer.h
The file was modified/llvm/trunk/lib/Remarks/BitstreamRemarkSerializer.cpp (diff)llvm.src/lib/Remarks/BitstreamRemarkSerializer.cpp
The file was modified/llvm/trunk/lib/Remarks/RemarkSerializer.cpp (diff)llvm.src/lib/Remarks/RemarkSerializer.cpp
The file was modified/llvm/trunk/lib/Remarks/RemarkStringTable.cpp (diff)llvm.src/lib/Remarks/RemarkStringTable.cpp
The file was modified/llvm/trunk/lib/Remarks/YAMLRemarkSerializer.cpp (diff)llvm.src/lib/Remarks/YAMLRemarkSerializer.cpp
The file was modified/llvm/trunk/unittests/Remarks/YAMLRemarksSerializerTest.cpp (diff)llvm.src/unittests/Remarks/YAMLRemarksSerializerTest.cpp
Revision 372041 by Vedant Kumar:
[test] Clean up previous raw profile before merging into it

This fixes a test failure in instrprof-set-file-object-merging.c which
seems to have been caused by reuse of stale data in old raw profiles.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/profile/instrprof-set-file-object-merging.c (diff)compiler-rt.src/test/profile/instrprof-set-file-object-merging.c
Revision 372040 by abataev:
[OPENMP]Fix the test, NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/OpenMP/parallel_for_codegen.cpp (diff)clang.src/test/OpenMP/parallel_for_codegen.cpp
Revision 372039 by Bruno Lopes:
[Modules][Objective-C] Use complete decl from module when diagnosing missing import

Summary:
Otherwise the definition (first found) for ObjCInterfaceDecl's might
precede the module one, which will eventually lead to crash, since
diagnoseMissingImport needs one coming from a module.

This behavior changed after Richard's r342018, which started to look
into the definition of ObjCInterfaceDecls.

rdar://problem/49237144

Reviewers: rsmith, arphaman

Subscribers: jkorous, dexonsmith, ributzka, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D66982
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaLookup.cpp (diff)clang.src/lib/Sema/SemaLookup.cpp
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-importclang.src/test/Modules/Inputs/interface-diagnose-missing-import
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.frameworkclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Headersclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Headers
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Headers/Bar.hclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Headers/Bar.h
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Headers/Foo.hclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Headers/Foo.h
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Modulesclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Modules
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Modules/module.modulemapclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/Modules/module.modulemap
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/PrivateHeadersclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/PrivateHeaders
The file was added/cfe/trunk/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/PrivateHeaders/RandoPriv.hclang.src/test/Modules/Inputs/interface-diagnose-missing-import/Foo.framework/PrivateHeaders/RandoPriv.h
The file was added/cfe/trunk/test/Modules/interface-diagnose-missing-import.mclang.src/test/Modules/interface-diagnose-missing-import.m
Revision 372038 by jcai19:
[compiler-rt][crt]  make test case nontrivial in check_cxx_section_exists

Summary:
.init_array gets optimized away when building with -O2 and as a result,
check_cxx_section_exists failed to pass -DCOMPILER_RT_HAS_INITFINI_ARRAY
when building crtbegin.o and crtend.o, which causes binaries linked with
them encounter segmentation fault. See https://crbug.com/855759 for
details. This change prevents .init_array section to be optimized away
even with -O2 or higher optimization level.

Subscribers: dberris, mgorny, #sanitizers, llvm-commits

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D67628
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/crt/CMakeLists.txt (diff)compiler-rt.src/lib/crt/CMakeLists.txt
Revision 372037 by jcai19:
[clang-tidy] add checks to bugprone-posix-return

This check now also checks if any calls to pthread_* functions expect negative return values. These functions return either 0 on success or an errno on failure, which is positive only.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/bugprone/PosixReturnCheck.cpp (diff)clang-tools-extra.src/clang-tidy/bugprone/PosixReturnCheck.cpp
The file was modified/clang-tools-extra/trunk/clang-tidy/bugprone/PosixReturnCheck.h (diff)clang-tools-extra.src/clang-tidy/bugprone/PosixReturnCheck.h
The file was modified/clang-tools-extra/trunk/docs/ReleaseNotes.rst (diff)clang-tools-extra.src/docs/ReleaseNotes.rst
The file was modified/clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-posix-return.rst (diff)clang-tools-extra.src/docs/clang-tidy/checks/bugprone-posix-return.rst
The file was modified/clang-tools-extra/trunk/test/clang-tidy/bugprone-posix-return.cpp (diff)clang-tools-extra.src/test/clang-tidy/bugprone-posix-return.cpp