FailedChanges

Summary

  1. [ARM] Fix for buildbots Remove setPreservesCFG from ARMConstantIslandPass and add a couple of -verify-machine-dom-info instances into the existing codegen tests.
  2. Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)" Summary: This reverts commit r372101. Causes ASAN build bot failures: http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176 From http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176/steps/64-bit%20check-asan/logs/stdio: ``` [ RUN ] AddressSanitizer.StrNCatOOBTest /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/compiler-rt/lib/asan/tests/asan_str_test.cpp:462: Failure Death test: strncat(to - 1, from, 0) Result: failed to die. ``` Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D67658
  3. Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings UBSan downstreams noticed that the assignment of SpellingNotCalculated to the spellings caused warnings.
  4. gn build: (manually) merge r372076
  5. [llvm-readobj/llvm-objdump] - Improve how tool locate the dynamic table and report warnings about that. Before this patch we gave a priority to a dynamic table found from the section header. It was discussed (here: https://reviews.llvm.org/D67078?id=218356#inline-602082) that probably preferring the table from PT_DYNAMIC is better, because it is what runtime loader sees. This patch makes the table from PT_DYNAMIC be chosen at first place if it is available. But also it adds logic to fall back to SHT_DYNAMIC if the table from the dynamic segment is broken or fall back to use no table if both are broken. It adds a few more diagnostic warnings for the logic above. Differential revision: https://reviews.llvm.org/D67547
Revision 372126 by sam_parker:
[ARM] Fix for buildbots

Remove setPreservesCFG from ARMConstantIslandPass and add a couple
of -verify-machine-dom-info instances into the existing codegen
tests.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp (diff)llvm.src/lib/Target/ARM/ARMConstantIslandPass.cpp
The file was modified/llvm/trunk/test/CodeGen/ARM/constant-islands-cfg.mir (diff)llvm.src/test/CodeGen/ARM/constant-islands-cfg.mir
The file was modified/llvm/trunk/test/CodeGen/Thumb2/constant-islands.ll (diff)llvm.src/test/CodeGen/Thumb2/constant-islands.ll
Revision 372125 by krasimir:
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)"

Summary:
This reverts commit r372101.

Causes ASAN build bot failures:

http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176
From http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176/steps/64-bit%20check-asan/logs/stdio:

```
[ RUN      ] AddressSanitizer.StrNCatOOBTest
/home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/compiler-rt/lib/asan/tests/asan_str_test.cpp:462: Failure
Death test: strncat(to - 1, from, 0)
    Result: failed to die.
```

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67658
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp (diff)llvm.src/lib/Transforms/Utils/SimplifyLibCalls.cpp
The file was modified/llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll (diff)llvm.src/test/Transforms/InstCombine/strncpy-1.ll
Revision 372124 by erichkeane:
Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings

UBSan downstreams noticed that the assignment of SpellingNotCalculated
to the spellings caused warnings.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/MicrosoftMangle.cpp (diff)clang.src/lib/AST/MicrosoftMangle.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (diff)clang.src/lib/CodeGen/CGDebugInfo.cpp
The file was modified/cfe/trunk/lib/Sema/SemaType.cpp (diff)clang.src/lib/Sema/SemaType.cpp
The file was modified/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (diff)clang.src/utils/TableGen/ClangAttrEmitter.cpp
Revision 372123 by nico:
gn build: (manually) merge r372076
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/llvm/unittests/BUILD.gn (diff)llvm.src/utils/gn/secondary/llvm/unittests/BUILD.gn
The file was added/llvm/trunk/utils/gn/secondary/llvm/unittests/Target/ARMllvm.src/utils/gn/secondary/llvm/unittests/Target/ARM
The file was added/llvm/trunk/utils/gn/secondary/llvm/unittests/Target/ARM/BUILD.gnllvm.src/utils/gn/secondary/llvm/unittests/Target/ARM/BUILD.gn
Revision 372122 by grimar:
[llvm-readobj/llvm-objdump] - Improve how tool locate the dynamic table and report warnings about that.

Before this patch we gave a priority to a dynamic table found
from the section header.

It was discussed (here: https://reviews.llvm.org/D67078?id=218356#inline-602082)
that probably preferring the table from PT_DYNAMIC is better,
because it is what runtime loader sees.

This patch makes the table from PT_DYNAMIC be chosen at first place if it is available.
But also it adds logic to fall back to SHT_DYNAMIC if the table from the dynamic segment is
broken or fall back to use no table if both are broken.

It adds a few more diagnostic warnings for the logic above.

Differential revision: https://reviews.llvm.org/D67547
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/llvm-readobj/elf-dynamic-malformed.test (diff)llvm.src/test/tools/llvm-readobj/elf-dynamic-malformed.test
The file was modified/llvm/trunk/test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test (diff)llvm.src/test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test
The file was modified/llvm/trunk/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test (diff)llvm.src/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test
The file was modified/llvm/trunk/tools/llvm-readobj/ELFDumper.cpp (diff)llvm.src/tools/llvm-readobj/ELFDumper.cpp