FailedChanges

Summary

  1. Reapply [llvm-ar] Include a line number when failing to parse an MRI script Reapply r372309 Errors that occur when reading an MRI script now include a corresponding line number. Differential Revision: https://reviews.llvm.org/D67449
  2. [X86] Convert tbm_bextri_u32/tbm_bextri_u64 intrinsics TargetConstant argument to a regular Constant during lowering. We reuse an ISD opcode here that can be reached from BMI that doesn't require it to be an immediate. Our isel patterns to match the TBM immediate form require a Constant and not a TargetConstant. We were accidentally getting the Constant due to a quirk of combineBEXTR calling SimplifyDemandedBits. The call to SimplifyDemandedBits ended up constant folding the TargetConstant to a regular Constant. But we should probably instead be asserting if SimplifyDemandedBits on a TargetConstant so we shouldn't rely on this behavior.
Revision 372374 by gbreynoo:
Reapply [llvm-ar] Include a line number when failing to parse an MRI script

Reapply r372309

Errors that occur when reading an MRI script now include a corresponding
line number.

Differential Revision: https://reviews.llvm.org/D67449
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Object/mri2.test (diff)llvm.src/test/Object/mri2.test
The file was modified/llvm/trunk/test/Object/mri3.test (diff)llvm.src/test/Object/mri3.test
The file was modified/llvm/trunk/test/Object/mri4.test (diff)llvm.src/test/Object/mri4.test
The file was modified/llvm/trunk/test/tools/llvm-ar/mri-addlib.test (diff)llvm.src/test/tools/llvm-ar/mri-addlib.test
The file was added/llvm/trunk/test/tools/llvm-ar/mri-errors.testllvm.src/test/tools/llvm-ar/mri-errors.test
The file was modified/llvm/trunk/tools/llvm-ar/llvm-ar.cpp (diff)llvm.src/tools/llvm-ar/llvm-ar.cpp
Revision 372373 by ctopper:
[X86] Convert tbm_bextri_u32/tbm_bextri_u64 intrinsics TargetConstant argument to a regular Constant during lowering.

We reuse an ISD opcode here that can be reached from BMI that
doesn't require it to be an immediate. Our isel patterns to match
the TBM immediate form require a Constant and not a TargetConstant.

We were accidentally getting the Constant due to a quirk of
combineBEXTR calling SimplifyDemandedBits. The call to
SimplifyDemandedBits ended up constant folding the TargetConstant
to a regular Constant. But we should probably instead be asserting
if SimplifyDemandedBits on a TargetConstant so we shouldn't rely
on this behavior.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86IntrinsicsInfo.h (diff)llvm.src/lib/Target/X86/X86IntrinsicsInfo.h