FailedChanges

Summary

  1. [lldb] Add missing include to ObjCLanguage.cpp to fix build (details)
  2. [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly (details)
  3. [X86] Add more add/sub carry tests (details)
  4. DWARFDebugLoclists: add location list "interpretation" logic (details)
  5. [lldb][NFC] Simplify a return in (details)
  6. [LoopInterchange] Only skip PHIs with incoming values from the inner (details)
  7. [lldb][test] Macros in expressions require DWARF 5 (details)
  8. [X86] Add PR39464 addcarry/subborrow test cases (details)
  9. FileCheckPattern::FindRegexVarEnd - make helper function static. NFC (details)
  10. [X86] Cleanup prefixes + regenerate for fp-intrinsics-fma.ll (details)
  11. [InstCombine] Skip scalable vectors in combineLoadToOperationType (details)
  12. [AArch64ExpandPseudos] Preserve renamable state when expanding MOVi64 & (details)
  13. [lldb] [Process/NetBSD] Use PT_STOP to stop the process [NFCI] (details)
Commit 874b6495b5fd6d7e2dc91d6a756eea67486ea7bb by Raphael Isemann
[lldb] Add missing include to ObjCLanguage.cpp to fix build
The file was modifiedlldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
Commit a75f8d98d7ac9e557b238a229a9a2647c71feed1 by paulhoad
[clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly
for some operator functions
Summary: https://bugs.llvm.org/show_bug.cgi?id=36294
Addressing bug related to returning after return type not being honoured
for some operator types.
```
$ bin/clang-format --style="{BasedOnStyle: llvm,
AlwaysBreakAfterReturnType: TopLevelDefinitions}" /tmp/foo.cpp class Foo
{ public:
bool operator!() const;
bool operator<(Foo const &) const;
bool operator*() const;
bool operator->() const;
bool operator+() const;
bool operator-() const;
bool f() const;
};
bool Foo::operator!() const { return true; } bool Foo::operator<(Foo
const &) const {
return true;
} bool Foo::operator*() const { return true; } bool Foo::operator->()
const { return true; } bool Foo::operator+() const {
return true;
} bool Foo::operator-() const {
return true;
} bool Foo::f() const {
return true;
}
```
Reviewers: mitchell-stellar, klimek, owenpan, sammccall, rianquinn
Reviewed By: sammccall
Subscribers: merge_guards_bot, cfe-commits
Tags: #clang-format, #clang-tools-extra, #clang
Differential Revision: https://reviews.llvm.org/D69573
The file was modifiedclang/lib/Format/TokenAnnotator.cpp
The file was modifiedclang/unittests/Format/FormatTest.cpp
Commit a9018fddf9ba17e53a35674bf0a93e78382c4c23 by dave
[X86] Add more add/sub carry tests
Preparation for: https://reviews.llvm.org/D70079
https://reviews.llvm.org/D70077
The file was modifiedllvm/test/CodeGen/SystemZ/int-uadd-03.ll
The file was modifiedllvm/test/CodeGen/SystemZ/int-usub-03.ll
The file was modifiedllvm/test/CodeGen/X86/addcarry.ll
The file was modifiedllvm/test/CodeGen/X86/subcarry.ll
Commit ebe2f56030458e7a4c2375c6d92a48f0ed01eb5b by pavel
DWARFDebugLoclists: add location list "interpretation" logic
Summary: This patch extracts the logic for computing the "absolute"
locations, which was partially present in the debug_loclists dumper,
completes it, and moves it into a separate function. This makes it
possible to later reuse the same logic for uses other than dumping.
The dumper is changed to reuse the location list interpreter, and its
format is changed somewhat. In "verbose" mode it prints the "raw" value
of a location list, the interpreted location (if available) and the
expression itself. In non-verbose mode it prints only one of the
location forms: it prefers the interpreted form, but falls back to the
"raw" format if interpretation is not possible (for instance, because we
were not given a base address, or the resolution of indirect addresses
failed).
This patch also undos some of the changes made in D69672, namely the
part about making all functions static. The main reason for this is that
I learned that the original approach (dumping only fully resolved
locations) meant that it was impossible to rewrite one of the existing
tests. To make that possible (and make the "inline location" dump work
in more cases), I now reuse the same dumping mechanism as is used for
section-based dumping. As this required having more objects know about
the various location lists classes, it seemed like a good idea to create
an interface abstracting the difference between them.
Therefore, I now create a DWARFLocationTable class, which will serve as
a base class for the location list classes. DWARFDebugLoclists is made
to inherit from that. DWARFDebugLoc will follow.
Another positive effect of this change is that section-based dumping
code will not need to use templates (as originally) envisioned, and that
the argument lists of the dumping functions become shorter.
Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70081
The file was modifiedllvm/test/DebugInfo/X86/loclists-dwp.ll
The file was modifiedllvm/test/DebugInfo/X86/fission-ranges.ll
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loc_dwo.s
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFContext.cpp
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
The file was modifiedllvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDie.cpp
The file was modifiedllvm/test/CodeGen/X86/debug-loclists.ll
The file was addedllvm/include/llvm/DebugInfo/DWARF/DWARFLocationExpression.h
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists_startx_length.s
Commit ec4c96d68566debcc4588c4189b4ef8a5f78729a by Raphael Isemann
[lldb][NFC] Simplify a return in
ThreadPlanStepInRange::DefaultShouldStopHereCallback
We know should_stop_here is false here, so we might as well return false
directly.
The file was modifiedlldb/source/Target/ThreadPlanStepInRange.cpp
Commit 1ee93240c02b0fd505a539691d58565376f8acdf by flo
[LoopInterchange] Only skip PHIs with incoming values from the inner
loop.
Currently we have limited support for outer loops with multiple basic
blocks after the inner loop exit. But the current checks for creating
PHIs for loop exit values only assumes the header and latches of the
outer loop. It is better to just skip incoming values defined in the
original inner loops. Those are handled earlier.
Reviewers: efriedma, mcrosier
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D70059
The file was modifiedllvm/lib/Transforms/Scalar/LoopInterchange.cpp
The file was addedllvm/test/Transforms/LoopInterchange/pr43797-lcssa-for-multiple-outer-loop-blocks.ll
Commit 3130a88137ddc6ee277c4e896f235cf93d883dfa by Tatyana Krasnukha
[lldb][test] Macros in expressions require DWARF 5
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/macros/Makefile
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/macros/TestMacros.py
Commit 002625113ba815d1d08463411e67875be6e19a3f by llvm-dev
[X86] Add PR39464 addcarry/subborrow test cases
Additional coverage for D70079
The file was modifiedllvm/test/CodeGen/X86/addcarry.ll
The file was modifiedllvm/test/CodeGen/X86/subcarry.ll
Commit 6da34a8b847f2c858f421278a38dd343d2e8507b by llvm-dev
FileCheckPattern::FindRegexVarEnd - make helper function static. NFC
Fixes cppcheck warning.
The file was modifiedllvm/lib/Support/FileCheckImpl.h
Commit 8794f6787685655223be8a029bf51a1565f7a231 by llvm-dev
[X86] Cleanup prefixes + regenerate for fp-intrinsics-fma.ll
The file was modifiedllvm/test/CodeGen/X86/fp-intrinsics-fma.ll
Commit 7f1dcc8952e6a1a4ba918159ab86bd787d584930 by diana.picus
[InstCombine] Skip scalable vectors in combineLoadToOperationType
Don't try to canonicalize loads to scalable vector types to loads of
integers.
This removes one assertion when trying to use a TypeSize as a parameter
to DataLayout::isLegalInteger. It does not handle the second part of the
function (which looks at bitcasts).
This patch also contains a NFC fix for Load Analysis, where a variable
initialization that would cause the same assertion is moved closer to
its use. This allows us to run the new test for InstCombine without
having to teach LocationSize to play nicely with scalable vectors.
Differential Revision: https://reviews.llvm.org/D70075
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
The file was modifiedllvm/lib/Analysis/Loads.cpp
The file was modifiedllvm/test/Transforms/InstCombine/load.ll
Commit 636412bf31fc4285d63faeea67e4d71e44e3799c by flo
[AArch64ExpandPseudos] Preserve renamable state when expanding MOVi64 &
co.
If the MOVi operand was renamable, the operands of the expanded
instructions are also renamable.
Reviewers: thegameg, samparker, zatrazz
Reviewed By: thegameg
Differential Revision: https://reviews.llvm.org/D70061
The file was addedllvm/test/CodeGen/AArch64/expand-movi-renamable.mir
The file was modifiedllvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
Commit 77cc246412ca40082c0902f1300f53d29dd98c02 by mgorny
[lldb] [Process/NetBSD] Use PT_STOP to stop the process [NFCI]
Differential Revision: https://reviews.llvm.org/D70060
The file was modifiedlldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
The file was modifiedlldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h