Started 1 mo 1 day ago
Took 4 hr 9 min on green-dragon-02

Failed Build #14725 (Sep 18, 2019 5:45:58 PM)

Revisions
  • http://llvm.org/svn/llvm-project/llvm/trunk : 372280
  • http://llvm.org/svn/llvm-project/cfe/trunk : 372269
  • http://llvm.org/svn/llvm-project/compiler-rt/trunk : 372205
  • http://llvm.org/svn/llvm-project/zorg/trunk : 371835
  • http://llvm.org/svn/llvm-project/libcxx/trunk : 372242
  • http://llvm.org/svn/llvm-project/clang-tools-extra/trunk : 372206
Changes
  1. llvm-reduce: Avoid use-after-free when removing a branch instruction

    Found my msan buildbot & pointed out by Nico Weber - thanks Nico! (detail)
    by dblaikie
  2. [Object] Extend MachOUniversalBinary::getObjectForArch

    Make the method MachOUniversalBinary::getObjectForArch return MachOUniversalBinary::ObjectForArch
    and add helper methods MachOUniversalBinary::getMachOObjectForArch, MachOUniversalBinary::getArchiveForArch
    for those who explicitly expect to get a MachOObjectFile or an Archive.

    Differential revision: https://reviews.llvm.org/D67700

    Test plan: make check-all (detail)
    by alexshap
  3. [utils] Add minimal support for MIR inputs to update_llc_test_checks.py

    update_{llc,mir}_test_checks.py applicability is determined by the
    output (assembly or MIR), not the input, which makes
    update_llc_test_checks.py the right tool to generate tests that start at
    MIR and stop at the final assembly.

    This commit adds the minimal support for this path. Main limitation that
    remains:

    - MIR has to have LLVM IR section, and the CHECK lines will be inserted
      into the LLVM IR functions that correspond to the MIR functions.

    Running
      ../utils/update_llc_test_checks.py --llc-binary ./bin/llc
    on a slightly modified  ../test/CodeGen/X86/bad-tls-fold.mir

    produces the following diff:

    +# NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
    +# RUN: llc %s -o - | FileCheck %s
    --- |
       target triple = "x86_64-unknown-linux-gnu"

    @@ -6,17 +7,31 @@
       @i = external thread_local global i32

       define i32 @or() {
    +  ; CHECK-LABEL: or:
    +  ; CHECK:       # %bb.0: # %entry
    +  ; CHECK-NEXT:    movq {{.*}}(%rip), %rax
    +  ; CHECK-NEXT:    orq $7, %rax
    +  ; CHECK-NEXT:    movq i@{{.*}}(%rip), %rcx
    +  ; CHECK-NEXT:    orq %rax, %rcx
    +  ; CHECK-NEXT:    movl %fs:(%rcx), %eax
    +  ; CHECK-NEXT:    retq
       entry:
         ret i32 undef
       }
    -
       define i32 @and() {
    +  ; CHECK-LABEL: and:
    +  ; CHECK:       # %bb.0: # %entry
    +  ; CHECK-NEXT:    movq {{.*}}(%rip), %rax
    +  ; CHECK-NEXT:    orq $7, %rax
    +  ; CHECK-NEXT:    movq i@{{.*}}(%rip), %rcx
    +  ; CHECK-NEXT:    andq %rax, %rcx
    +  ; CHECK-NEXT:    movl %fs:(%rcx), %eax
    +  ; CHECK-NEXT:    retq
       entry:
         ret i32 undef
       }
    ...

    (not applied) (detail)
    by rtereshin
  4. [utils] Amend update_llc_test_checks.py to non-llc tooling, NFC

    Very minor change aiming to make it easier to extend the script
    downstream to support non-llc, but llc-like tools. The main objective is
    to decrease the probability of merge conflicts. (detail)
    by rtereshin
  5. [WebAssembly] Restore defaults for stores per memop

    Summary:
    Large slowdowns were observed in Rust due to many small, constant
    sized copies in conjunction with poorly-optimized memory.copy
    implementations. Since memory.copy cannot be expected to be inlined
    efficiently by engines at this time, stop using it for the smallest
    copies. We continue to lower all memcpy intrinsics to memory.copy,
    though.

    Reviewers: aheejin, alexcrichton

    Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, JDevlieghere, sunfish, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67639 (detail)
    by tlively
  6. [Docs] Moves topics to new categories

    This commit moves several topics to new categories. It also removes a few duplicate links in Subsystem Documentation. (detail)
    by dr87
  7. [AArch64][GlobalISel] Support lowering musttail calls

    Since we now lower most tail calls, it makes sense to support musttail.

    Instead of always falling back to SelectionDAG, only fall back when a musttail
    call was not able to be emitted as a tail call. Once we can handle most
    incoming and outgoing arguments, we can change this to a `report_fatal_error`
    like in ISelLowering.

    Remove the assert that we don't have varargs and a musttail, and replace it
    with a return false. Implementing this requires that we implement
    `saveVarArgRegisters` from AArch64ISelLowering, which is an entirely different
    patch.

    Add GlobalISel lines to vararg-tallcall.ll to make sure that we produce correct
    code. Right now we only fall back, but eventually this will be relevant.

    Differential Revision: https://reviews.llvm.org/D67681 (detail)
    by paquette
  8. Remove the obsolete BlockByRefStruct flag from LLVM IR

    DIFlagBlockByRefStruct is an unused DIFlag that originally was used by
    clang to express (Objective-)C block captures in debug info. For the
    last year Clang has been emitting complex DIExpressions to describe
    block captures instead, which makes all the code supporting this flag
    redundant.

    This patch removes the flag and all supporting "dead" code, so we can
    reuse the bit for something else in the future.

    Since this only affects debug info generated by Clang with the block
    extension this mostly affects Apple platforms and I don't have any
    bitcode compatibility concerns for removing this. The Verifier will
    reject debug info that uses the bit and thus degrade gracefully when
    LTO'ing older bitcode with a newer compiler.

    rdar://problem/44304813

    Differential Revision: https://reviews.llvm.org/D67453 (detail)
    by Adrian Prantl
  9. llvm-reduce: Remove inaccurate doxy comment about a return that isn't returned

    Addressing post-commit code review feedback from Dávid Bolvanský -
    thanks! (detail)
    by dblaikie
  10. llvm-reduce: Fix inconsistencies between int/unsigned usage (standardize on int) (detail)
    by dblaikie
  11. [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

    Summary:
    https://bugs.llvm.org/show_bug.cgi?id=43102

    In today's edition of "Is this any better now that it isn't crashing?", I'd like to show you a very interesting test case with loop widening.

    Looking at the included test case, it's immediately obvious that this is not only a false positive, but also a very bad bug report in general. We can see how the analyzer mistakenly invalidated `b`, instead of its pointee, resulting in it reporting a null pointer dereference error. Not only that, the point at which this change of value is noted at is at the loop, rather then at the method call.

    It turns out that `FindLastStoreVisitor` works correctly, rather the supplied explodedgraph is faulty, because `BlockEdge` really is the `ProgramPoint` where this happens.
    {F9855739}
    So it's fair to say that this needs improving on multiple fronts. In any case, at least the crash is gone.

    Full ExplodedGraph: {F9855743}

    Reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, dcoughlin, rnkovacs, TWeaver

    Subscribers: JesperAntonsson, uabelho, Ka-Ka, bjope, whisperity, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, cfe-commits

    Tags: #clang

    Differential Revision: https://reviews.llvm.org/D66716 (detail)
    by szelethus
  12. gn build: Merge r372267 (detail)
    by gnsyncbot
  13. Add AutoUpgrade function to add new address space datalayout string to existing datalayouts.

    Summary:
    Add function to AutoUpgrade to change the datalayout of old X86 datalayout strings.
    This adds "-p270:32:32-p271:32:32-p272:64:64" to X86 datalayouts that are otherwise valid
    and don't already contain it.

    This also removes the compatibility changes in https://reviews.llvm.org/D66843.
    Datalayout change in https://reviews.llvm.org/D64931.

    Reviewers: rnk, echristo

    Subscribers: hiraditya, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67631 (detail)
    by akhuang
  14. gn build: Merge r372264 (detail)
    by gnsyncbot
  15. llvm-reduce: Add pass to reduce basic blocks

    Patch by Diego Treviño!

    Differential Revision: https://reviews.llvm.org/D66320 (detail)
    by dblaikie
  16. fix build, adjust test also for Windows path separator

    Introduced in 1e9c1d2b7bfc. (detail)
    by llunak
  17. [SimplifyCFG] mergeConditionalStoreToAddress(): try to pacify MSAN

    MSAN bot complains that there is use-of-uninitialized-value
    of this FreeStores later in IsWorthwhile().
    Perhaps FreeStores needs to be stored in a vector? (detail)
    by lebedevri
  18. On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

    Summary:
    In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and
    higher transitioned to Secure-PLT for PowerPC.  This part contains the
    changes in clang's PPC architecture defaults.

    Reviewers: emaste, jhibbits, hfinkel

    Reviewed By: jhibbits

    Subscribers: wuzish, nemanjai, krytarowski, kbarton, MaskRay, jsji, shchenz, steven.zhang, cfe-commits

    Tags: #clang

    Differential Revision: https://reviews.llvm.org/D67119 (detail)
    by dim
  19. On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

    Summary:
    In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and
    higher transitioned to Secure-PLT for PowerPC.  This part contains the
    changes in llvm's PPC subtarget.

    Reviewers: emaste, jhibbits, hfinkel

    Reviewed By: jhibbits

    Subscribers: wuzish, nemanjai, krytarowski, kbarton, MaskRay, jsji, shchenz, steven.zhang, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67118 (detail)
    by dim
  20. [DAGCombine][ARM][X86] (sub Carry, X)  ->  (addcarry (sub 0, X), 0, Carry)  fold

    Summary:
    `DAGCombiner::visitADDLikeCommutative()` already has a sibling fold:
    `(add X, Carry) -> (addcarry X, 0, Carry)`

    This fold, as suggested by @efriedma, helps recover from //some//
    of the regressions of D62266

    Reviewers: efriedma, deadalnix

    Subscribers: javed.absar, kristof.beyls, llvm-commits, efriedma

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D62392 (detail)
    by lebedevri
  21. [CodeGen][X86][NFC] Tests for (sub Carry, X) -> (addcarry (sub 0, X), 0, Carry) fold (D62392) (detail)
    by lebedevri

Started by timer (4 times)

This run spent:

  • 3 hr 35 min waiting;
  • 4 hr 9 min build duration;
  • 7 hr 44 min total from scheduled to completion.

Identified problems

Missing test results

The test result file Jenkins is looking for does not exist after the build.
Indication 1

Regression test failed

This build failed because a regression test in the test suite FAILed. See the test report for details.
Indication 2

Ninja target failed

Below is a link to the first failed ninja target.
Indication 3