FailedChanges

Summary

  1. [libc++] Localize common build flags into a single CMake function Also, set those flags for the cxx_experimental target. Otherwise, cxx_experimental doesn't build properly when neither the static nor the shared library is compiled (yes, that is a weird setup).
  2. Invalidate assumption cache before outlining. Subscribers: llvm-commits Tags: #llvm Reviewers: compnerd, vsk, sebpop, fhahn, tejohnson Reviewed by: vsk Differential Revision: https://reviews.llvm.org/D68478
  3. Revert [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks This reverts r371177 (git commit f879c6875563c0a8cd838f1e13b14dd33558f1f8) It caused PR43566 by removing empty, address-taken MachineBasicBlocks. Such blocks may have references from blockaddress or other operands, and need more consideration to be removed. See the PR for a test case to use when relanding.
  4. [InstCombine] Fold 'icmp eq/ne (?trunc (lshr/ashr %x, bitwidth(x)-1)), 0' -> 'icmp sge/slt %x, 0' We do indeed already get it right in some cases, but only transitively, with one-use restrictions. Since we only need to produce a single comparison, it makes sense to match the pattern directly: https://rise4fun.com/Alive/kPg
  5. [InstCombine] Right-shift shift amount reassociation with truncation (PR43564, PR42391) Initially (D65380) i believed that if we have rightshift-trunc-rightshift, we can't do any folding. But as it usually happens, i was wrong. https://rise4fun.com/Alive/GEw https://rise4fun.com/Alive/gN2O In https://bugs.llvm.org/show_bug.cgi?id=43564 we happen to have this very sequence, of two right shifts separated by trunc. And "just" so that happens, we apparently can fold the pattern if the total shift amount is either 0, or it's equal to the bitwidth of the innermost widest shift - i.e. if we are left with only the original sign bit. Which is exactly what is wanted there.
  6. [NFC][InstCombine] Autogenerate shift.ll test
  7. [NFC][InstCombine] Autogenerate icmp-shr-lt-gt.ll test
  8. [NFC][InstCombine] Tests for bit test via highest sign-bit extract (w/ trunc) (PR43564) https://rise4fun.com/Alive/x5IS
  9. [NFC][InstCombine] Tests for right-shift shift amount reassociation (w/ trunc) (PR43564, PR42391) https://rise4fun.com/Alive/GEw
  10. Add an off-by-default option to enable testing for gdb pretty printers. Summary: The current version of the pretty printers are not python3 compatible, so turn them off by default until sufficiently improved. Reviewers: MaskRay, tamur Subscribers: mgorny, christof, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68477
  11. [lit] Use better name for "test in parallel" concept In the past, lit used threads to run tests in parallel. Today we use `multiprocessing.Pool`, which uses processes. Let's stay more abstract and use "worker" everywhere. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D68475
  12. [clang] fix a typo from r372531 Reviewers: xbolva00 Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68482
  13. [MachineOutliner] Disable outlining from noreturn functions Outlining from noreturn functions doesn't do the correct thing right now. The outliner should respect that the caller is marked noreturn. In the event that we have a noreturn function, and the outlined code is in tail position, the outliner will not see that the outlined function should be tail called. As a result, you end up with a regular call containing a return. Fixing this requires that we check that all candidates live inside noreturn functions. So, for the sake of correctness, don't outline from noreturn functions right now. Add machine-outliner-noreturn.mir to test this.
  14. [InstCombine] add tests for fneg disguised as fmul; NFC
  15. [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible Use clang_target_link_libraries() in order to support linking against libclang-cpp instead of static libraries. Differential Revision: https://reviews.llvm.org/D68448
  16. [clang] [cmake] Use add_clang_tool() to install all tools Switch clang-check, clang-extdef-mapping and clang-offload-bundler to use add_clang_tool() rather than add_clang_executable() with a custom install rule. This makes them LLVM_DISTRIBUTION_COMPONENTS-friendly. Differential Revision: https://reviews.llvm.org/D68429
  17. [NFC] Add { } to silence compiler warning [-Wmissing-braces]. ../llvm-project/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:355:48: warning: suggest braces around initialization of subobject [-Wmissing-braces] return addMappingFromTable<1>(MI, MRI, { 0 }, Table); ^ {}
  18. [ScheduleDAG] When a node is cloned, add an edge between the nodes. InstrEmitter's virtual register handling assumes that clones are emitted after the cloned node. Make sure this assumption actually holds. Fixes a "Node emitted out of order - early" assertion on the testcase. This is probably a very rare case to actually hit in practice; even without the explicit edge, the scheduler will usually end up scheduling the nodes in the expected order due to other constraints. Differential Revision: https://reviews.llvm.org/D68068
  19. [test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC. Differential Revision: https://reviews.llvm.org/D68449
  20. [JITLink] Silence GCC warnings. NFC. Use parentheses in an expression with mixed && and ||. Differential Revision: https://reviews.llvm.org/D68447
  21. [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic The warnings now in -Wformat-type-confusion don't align with how we interpret 'pedantic' in clang, and don't belong in -pedantic. Differential revision: https://reviews.llvm.org/D67775
  22. [libc++] Make the modules-related flags PUBLIC instead of PRIVATE It appears that those need to be propagated to targets that use libc++ as well, otherwise they don't build properly.
  23. Add missing null pointer check in -ftime-trace code createOutputFile diagnoses the error for the caller already, so recover by not writing the output. Fixes PR43555 No test, since I couldn't think of a good, portable, simple way to make the regular -o output file writable, but outputfile.json not writable.
Revision 373808 by Louis Dionne:
[libc++] Localize common build flags into a single CMake function

Also, set those flags for the cxx_experimental target. Otherwise,
cxx_experimental doesn't build properly when neither the static nor
the shared library is compiled (yes, that is a weird setup).
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/CMakeLists.txtlibcxx.src/CMakeLists.txt
The file was modified/libcxx/trunk/src/CMakeLists.txtlibcxx.src/src/CMakeLists.txt
Revision 373807 by hiraditya:
Invalidate assumption cache before outlining.

Subscribers: llvm-commits

Tags: #llvm

Reviewers: compnerd, vsk, sebpop, fhahn, tejohnson

Reviewed by: vsk

Differential Revision: https://reviews.llvm.org/D68478
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/CodeExtractor.hllvm.src/include/llvm/Transforms/Utils/CodeExtractor.h
The file was modified/llvm/trunk/lib/Transforms/IPO/HotColdSplitting.cppllvm.src/lib/Transforms/IPO/HotColdSplitting.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/CodeExtractor.cppllvm.src/lib/Transforms/Utils/CodeExtractor.cpp
The file was modified/llvm/trunk/test/Transforms/HotColdSplit/assumption-cache-invalidation.llllvm.src/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll
Revision 373805 by rnk:
Revert [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks

This reverts r371177 (git commit f879c6875563c0a8cd838f1e13b14dd33558f1f8)

It caused PR43566 by removing empty, address-taken MachineBasicBlocks.
Such blocks may have references from blockaddress or other operands, and
need more consideration to be removed.

See the PR for a test case to use when relanding.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/MachineBlockPlacement.cppllvm.src/lib/CodeGen/MachineBlockPlacement.cpp
The file was modified/llvm/trunk/test/CodeGen/PowerPC/block-placement.mirllvm.src/test/CodeGen/PowerPC/block-placement.mir
Revision 373802 by lebedevri:
[InstCombine] Fold 'icmp eq/ne (?trunc (lshr/ashr %x, bitwidth(x)-1)), 0' -> 'icmp sge/slt %x, 0'

We do indeed already get it right in some cases, but only transitively,
with one-use restrictions. Since we only need to produce a single
comparison, it makes sense to match the pattern directly:
  https://rise4fun.com/Alive/kPg
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cppllvm.src/lib/Transforms/InstCombine/InstCombineCompares.cpp
The file was modified/llvm/trunk/test/Transforms/InstCombine/shift.llllvm.src/test/Transforms/InstCombine/shift.ll
The file was modified/llvm/trunk/test/Transforms/InstCombine/sign-bit-test-via-right-shifting-all-other-bits.llllvm.src/test/Transforms/InstCombine/sign-bit-test-via-right-shifting-all-other-bits.ll
Revision 373801 by lebedevri:
[InstCombine] Right-shift shift amount reassociation with truncation (PR43564, PR42391)

Initially (D65380) i believed that if we have rightshift-trunc-rightshift,
we can't do any folding. But as it usually happens, i was wrong.

https://rise4fun.com/Alive/GEw
https://rise4fun.com/Alive/gN2O

In https://bugs.llvm.org/show_bug.cgi?id=43564 we happen to have
this very sequence, of two right shifts separated by trunc.
And "just" so that happens, we apparently can fold the pattern
if the total shift amount is either 0, or it's equal to the bitwidth
of the innermost widest shift - i.e. if we are left with only the
original sign bit. Which is exactly what is wanted there.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineShifts.cppllvm.src/lib/Transforms/InstCombine/InstCombineShifts.cpp
The file was modified/llvm/trunk/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-ashr.llllvm.src/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-ashr.ll
The file was modified/llvm/trunk/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-lshr.llllvm.src/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-lshr.ll
The file was modified/llvm/trunk/test/Transforms/InstCombine/sign-bit-test-via-right-shifting-all-other-bits.llllvm.src/test/Transforms/InstCombine/sign-bit-test-via-right-shifting-all-other-bits.ll
Revision 373800 by lebedevri:
[NFC][InstCombine] Autogenerate shift.ll test
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/shift.llllvm.src/test/Transforms/InstCombine/shift.ll
Revision 373799 by lebedevri:
[NFC][InstCombine] Autogenerate icmp-shr-lt-gt.ll test
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/icmp-shr-lt-gt.llllvm.src/test/Transforms/InstCombine/icmp-shr-lt-gt.ll
Revision 373798 by lebedevri:
[NFC][InstCombine] Tests for bit test via highest sign-bit extract (w/ trunc) (PR43564)

https://rise4fun.com/Alive/x5IS
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/InstCombine/sign-bit-test-via-right-shifting-all-other-bits.llllvm.src/test/Transforms/InstCombine/sign-bit-test-via-right-shifting-all-other-bits.ll
Revision 373797 by lebedevri:
[NFC][InstCombine] Tests for right-shift shift amount reassociation (w/ trunc) (PR43564, PR42391)

https://rise4fun.com/Alive/GEw
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-ashr.llllvm.src/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-ashr.ll
The file was added/llvm/trunk/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-lshr.llllvm.src/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-lshr.ll
The file was modified/llvm/trunk/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-shl.llllvm.src/test/Transforms/InstCombine/shift-amount-reassociation-with-truncation-shl.ll
Revision 373796 by saugustine:
Add an off-by-default option to enable testing for gdb pretty printers.

Summary:
The current version of the pretty printers are not python3 compatible,
so turn them off by default until sufficiently improved.

Reviewers: MaskRay, tamur

Subscribers: mgorny, christof, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68477
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/CMakeLists.txtlibcxx.src/CMakeLists.txt
The file was modified/libcxx/trunk/test/CMakeLists.txtlibcxx.src/test/CMakeLists.txt
Revision 373794 by yln:
[lit] Use better name for "test in parallel" concept

In the past, lit used threads to run tests in parallel. Today we use
`multiprocessing.Pool`, which uses processes. Let's stay more abstract
and use "worker" everywhere.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D68475
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/main.pyllvm.src/utils/lit/lit/main.py
The file was modified/llvm/trunk/utils/lit/lit/run.pyllvm.src/utils/lit/lit/run.py
The file was modified/llvm/trunk/utils/lit/tests/discovery.pyllvm.src/utils/lit/tests/discovery.py
The file was modified/llvm/trunk/utils/lit/tests/parallelism-groups.pyllvm.src/utils/lit/tests/parallelism-groups.py
Revision 373792 by yuanfang:
[clang] fix a typo from r372531

Reviewers: xbolva00

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68482
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaChecking.cppclang.src/lib/Sema/SemaChecking.cpp
The file was modified/cfe/trunk/test/Sema/warn-integer-constants-in-ternary.cclang.src/test/Sema/warn-integer-constants-in-ternary.c
Revision 373791 by paquette:
[MachineOutliner] Disable outlining from noreturn functions

Outlining from noreturn functions doesn't do the correct thing right now. The
outliner should respect that the caller is marked noreturn. In the event that
we have a noreturn function, and the outlined code is in tail position, the
outliner will not see that the outlined function should be tail called. As a
result, you end up with a regular call containing a return.

Fixing this requires that we check that all candidates live inside noreturn
functions. So, for the sake of correctness, don't outline from noreturn
functions right now.

Add machine-outliner-noreturn.mir to test this.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/MachineOutliner.cppllvm.src/lib/CodeGen/MachineOutliner.cpp
The file was added/llvm/trunk/test/CodeGen/AArch64/machine-outliner-noreturn.mirllvm.src/test/CodeGen/AArch64/machine-outliner-noreturn.mir
Revision 373788 by spatel:
[InstCombine] add tests for fneg disguised as fmul; NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/fmul.llllvm.src/test/Transforms/InstCombine/fmul.ll
Revision 373786 by mgorny:
[clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

Use clang_target_link_libraries() in order to support linking against
libclang-cpp instead of static libraries.

Differential Revision: https://reviews.llvm.org/D68448
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-apply-replacements/tool/CMakeLists.txtclang-tools-extra.src/clang-apply-replacements/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-change-namespace/tool/CMakeLists.txtclang-tools-extra.src/clang-change-namespace/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-doc/tool/CMakeLists.txtclang-tools-extra.src/clang-doc/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-include-fixer/find-all-symbols/tool/CMakeLists.txtclang-tools-extra.src/clang-include-fixer/find-all-symbols/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-include-fixer/tool/CMakeLists.txtclang-tools-extra.src/clang-include-fixer/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-move/tool/CMakeLists.txtclang-tools-extra.src/clang-move/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-query/tool/CMakeLists.txtclang-tools-extra.src/clang-query/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-reorder-fields/tool/CMakeLists.txtclang-tools-extra.src/clang-reorder-fields/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-tidy/CMakeLists.txtclang-tools-extra.src/clang-tidy/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clang-tidy/tool/CMakeLists.txtclang-tools-extra.src/clang-tidy/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/fuzzer/CMakeLists.txtclang-tools-extra.src/clangd/fuzzer/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/index/dex/dexp/CMakeLists.txtclang-tools-extra.src/clangd/index/dex/dexp/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/indexer/CMakeLists.txtclang-tools-extra.src/clangd/indexer/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/tool/CMakeLists.txtclang-tools-extra.src/clangd/tool/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/unittests/CMakeLists.txtclang-tools-extra.src/clangd/unittests/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/xpc/test-client/CMakeLists.txtclang-tools-extra.src/clangd/xpc/test-client/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/modularize/CMakeLists.txtclang-tools-extra.src/modularize/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/pp-trace/CMakeLists.txtclang-tools-extra.src/pp-trace/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/tool-template/CMakeLists.txtclang-tools-extra.src/tool-template/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-apply-replacements/CMakeLists.txtclang-tools-extra.src/unittests/clang-apply-replacements/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-change-namespace/CMakeLists.txtclang-tools-extra.src/unittests/clang-change-namespace/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-doc/CMakeLists.txtclang-tools-extra.src/unittests/clang-doc/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-include-fixer/CMakeLists.txtclang-tools-extra.src/unittests/clang-include-fixer/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-include-fixer/find-all-symbols/CMakeLists.txtclang-tools-extra.src/unittests/clang-include-fixer/find-all-symbols/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-move/CMakeLists.txtclang-tools-extra.src/unittests/clang-move/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-query/CMakeLists.txtclang-tools-extra.src/unittests/clang-query/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/unittests/clang-tidy/CMakeLists.txtclang-tools-extra.src/unittests/clang-tidy/CMakeLists.txt
Revision 373785 by mgorny:
[clang] [cmake] Use add_clang_tool() to install all tools

Switch clang-check, clang-extdef-mapping and clang-offload-bundler
to use add_clang_tool() rather than add_clang_executable() with a custom
install rule.  This makes them LLVM_DISTRIBUTION_COMPONENTS-friendly.

Differential Revision: https://reviews.llvm.org/D68429
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/clang-check/CMakeLists.txtclang.src/tools/clang-check/CMakeLists.txt
The file was modified/cfe/trunk/tools/clang-extdef-mapping/CMakeLists.txtclang.src/tools/clang-extdef-mapping/CMakeLists.txt
The file was modified/cfe/trunk/tools/clang-offload-bundler/CMakeLists.txtclang.src/tools/clang-offload-bundler/CMakeLists.txt
Revision 373784 by huihuiz:
[NFC] Add { } to silence compiler warning [-Wmissing-braces].

../llvm-project/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:355:48: warning: suggest braces around initialization of subobject [-Wmissing-braces]
      return addMappingFromTable<1>(MI, MRI, { 0 }, Table);
                                               ^
                                               {}
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cppllvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
Revision 373782 by efriedma:
[ScheduleDAG] When a node is cloned, add an edge between the nodes.

InstrEmitter's virtual register handling assumes that clones are emitted
after the cloned node.  Make sure this assumption actually holds.

Fixes a "Node emitted out of order - early" assertion on the testcase.

This is probably a very rare case to actually hit in practice; even
without the explicit edge, the scheduler will usually end up scheduling
the nodes in the expected order due to other constraints.

Differential Revision: https://reviews.llvm.org/D68068
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cppllvm.src/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
The file was added/llvm/trunk/test/CodeGen/Thumb/scheduler-clone-cpsr-def.llllvm.src/test/CodeGen/Thumb/scheduler-clone-cpsr-def.ll
Revision 373780 by mstorsjo:
[test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC.

Differential Revision: https://reviews.llvm.org/D68449
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.testllvm.src/test/tools/llvm-symbolizer/coff-dwarf.test
The file was modified/llvm/trunk/test/tools/llvm-symbolizer/coff-exports.testllvm.src/test/tools/llvm-symbolizer/coff-exports.test
Revision 373779 by mstorsjo:
[JITLink] Silence GCC warnings. NFC.

Use parentheses in an expression with mixed && and ||.

Differential Revision: https://reviews.llvm.org/D68447
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.hllvm.src/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h
Revision 373774 by epilk:
[Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

The warnings now in -Wformat-type-confusion don't align with how we interpret
'pedantic' in clang, and don't belong in -pedantic.

Differential revision: https://reviews.llvm.org/D67775
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/FormatString.hclang.src/include/clang/AST/FormatString.h
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticGroups.tdclang.src/include/clang/Basic/DiagnosticGroups.td
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.tdclang.src/include/clang/Basic/DiagnosticSemaKinds.td
The file was modified/cfe/trunk/lib/AST/FormatString.cppclang.src/lib/AST/FormatString.cpp
The file was modified/cfe/trunk/lib/Sema/SemaChecking.cppclang.src/lib/Sema/SemaChecking.cpp
The file was modified/cfe/trunk/test/Sema/format-bool.cclang.src/test/Sema/format-bool.c
The file was modified/cfe/trunk/test/Sema/format-strings-pedantic.cclang.src/test/Sema/format-strings-pedantic.c
The file was added/cfe/trunk/test/Sema/format-type-confusion.cclang.src/test/Sema/format-type-confusion.c
Revision 373773 by Louis Dionne:
[libc++] Make the modules-related flags PUBLIC instead of PRIVATE

It appears that those need to be propagated to targets that use libc++
as well, otherwise they don't build properly.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/CMakeLists.txtlibcxx.src/CMakeLists.txt
Revision 373771 by rnk:
Add missing null pointer check in -ftime-trace code

createOutputFile diagnoses the error for the caller already, so recover
by not writing the output.

Fixes PR43555

No test, since I couldn't think of a good, portable, simple way to make
the regular -o output file writable, but outputfile.json not writable.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/driver/cc1_main.cppclang.src/tools/driver/cc1_main.cpp