FailedChanges

Summary

  1. Allow update_test_checks.py to not scrub names. Add a --preserve-names option to tell the script not to replace IR names. Sometimes tests want those names. For example if a test is looking for a modification to an existing instruction we'll want to make the names. Differential Revision: https://reviews.llvm.org/D68081
  2. Sema - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
  3. [clang] Add test for FindNextToken in Lexer. Reviewers: ilya-biryukov Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68565
  4. Fix another sphinx warning. Differential Revision: https://reviews.llvm.org/D64746
  5. Regenerate ptr-rotate.ll . NFC
  6. [Mips] Always save RA when disabling frame pointer elimination This ensures that frame-based unwinding will continue to work when calling a noreturn function; there is not much use having the caller's frame pointer saved if you don't also have the caller's program counter. Patch by James Clarke. Differential Revision: https://reviews.llvm.org/D68542
  7. [Mips] Fix evaluating J-format branch targets J/JAL/JALX/JALS are absolute branches, but stay within the current 256 MB-aligned region, so we must include the high bits of the instruction address when calculating the branch target. Patch by James Clarke. Differential Revision: https://reviews.llvm.org/D68548
  8. RewriteModernObjC - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
  9. AST - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
  10. [LLVM-C] Add bindings to create macro debug info Summary: The C API doesn't have the bindings to create macro debug information. Reviewers: whitequark, CodaFi, deadalnix Reviewed By: whitequark Subscribers: aprantl, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D58334
  11. Fix sphinx warnings. Differential Revision: https://reviews.llvm.org/D64746
  12. Test commit Fix comment.
  13. [FPEnv] Add constrained intrinsics for lrint and lround Earlier in the year intrinsics for lrint, llrint, lround and llround were added to llvm. The constrained versions are now implemented here. Reviewed by: andrew.w.kaylor, craig.topper, cameron.mcinally Approved by: craig.topper Differential Revision: https://reviews.llvm.org/D64746
  14. gn build: use better triple on windows The CMake build uses "x86_64-pc-windows-msvc". The "-msvc" suffix is important because e.g. clang/test/lit.cfg.py matches against the suffix "windows-msvc" to compute the presence of the "ms-sdk" and the absence of the "LP64" feature. Differential Revision: https://reviews.llvm.org/D68572
  15. Revert r373888 "[IA] Recognize hexadecimal escape sequences" It broke MC/AsmParser/directive_ascii.s on all bots: Assertion failed: (Index < Length && "Invalid index!"), function operator[], file ../../llvm/include/llvm/ADT/StringRef.h, line 243.
  16. [clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch. Summary: Also fixes a potential user-after-scope issue of "Path". Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68564
  17. [ASTImporter][NFC] Enable disabled but passing test RedeclChainShouldBeCorrectAmongstNamespaces
  18. [ASTImporter][NFC] Update ASTImporter internals docs
  19. [ASTImporter][NFC] Fix typo in user docs
  20. [AMDGPU] Fix test checks The GFX10-DENORM-STRICT checks were only passing by accident. Fix them to make the test more robust in the face of scheduling or register allocation changes.
  21. [clangd] If an undocumented definition exists, don't accept documentation from other forward decls. Summary: This fixes cases like: foo.h class Undocumented{} bar.h // break an include cycle. we should refactor this! class Undocumented; Where the comment doesn't describe the class. Note that a forward decl that is *visible to the definition* will still have its doc comment used, by SymbolCollector: Merge isn't involved here. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68467
  22. [llvm-readelf/llvm-objdump] - Improve/refactor the implementation of SHT_LLVM_ADDRSIG section dumping. This patch: * Adds a llvm-readobj/llvm-readelf test file for SHT_LLVM_ADDRSIG sections. (we do not have any) * Enables dumping of SHT_LLVM_ADDRSIG with --all. * Changes the logic to report a warning instead of an error when something goes wrong during dumping (allows to continue dumping SHT_LLVM_ADDRSIG and other sections on error). * Refactors a piece of logic to a new toULEB128Array helper which might be used for GNU-style dumping implementation. Differential revision: https://reviews.llvm.org/D68383
  23. [clangd] Collect missing macro references. Summary: Semantic highlghting is missing a few macro references. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68458
  24. [IA] Recognize hexadecimal escape sequences Summary: Implement support for hexadecimal escape sequences to match how GNU 'as' handles them. I.e., read all hexadecimal characters and truncate to the lower 16 bits. Reviewers: nickdesaulniers Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68483
Revision 373912 by greened:
Allow update_test_checks.py to not scrub names.

Add a --preserve-names option to tell the script not to replace IR names.
Sometimes tests want those names.  For example if a test is looking for a
modification to an existing instruction we'll want to make the names.

Differential Revision: https://reviews.llvm.org/D68081
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/UpdateTestChecks/common.pyllvm.src/utils/UpdateTestChecks/common.py
The file was modified/llvm/trunk/utils/update_test_checks.pyllvm.src/utils/update_test_checks.py
Revision 373911 by rksimon:
Sema - silence static analyzer getAs<> null dereference warnings. NFCI.

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaAccess.cppclang.src/lib/Sema/SemaAccess.cpp
The file was modified/cfe/trunk/lib/Sema/SemaChecking.cppclang.src/lib/Sema/SemaChecking.cpp
The file was modified/cfe/trunk/lib/Sema/SemaCoroutine.cppclang.src/lib/Sema/SemaCoroutine.cpp
The file was modified/cfe/trunk/lib/Sema/SemaDecl.cppclang.src/lib/Sema/SemaDecl.cpp
Revision 373910 by usaxena95:
[clang] Add test for FindNextToken in Lexer.

Reviewers: ilya-biryukov

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68565
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/Lex/LexerTest.cppclang.src/unittests/Lex/LexerTest.cpp
Revision 373909 by kpn:
Fix another sphinx warning.

Differential Revision: https://reviews.llvm.org/D64746
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/LangRef.rstllvm.src/docs/LangRef.rst
Revision 373908 by deadalnix:
Regenerate ptr-rotate.ll . NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/ptr-rotate.llllvm.src/test/CodeGen/X86/ptr-rotate.ll
Revision 373907 by atanasyan:
[Mips] Always save RA when disabling frame pointer elimination

This ensures that frame-based unwinding will continue to work when
calling a noreturn function; there is not much use having the caller's
frame pointer saved if you don't also have the caller's program counter.

Patch by James Clarke.

Differential Revision: https://reviews.llvm.org/D68542
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cppllvm.src/lib/Target/Mips/MipsSEFrameLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/Mips/cconv/vector.llllvm.src/test/CodeGen/Mips/cconv/vector.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/dynamic-stack-realignment.llllvm.src/test/CodeGen/Mips/dynamic-stack-realignment.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/frame-address.llllvm.src/test/CodeGen/Mips/frame-address.ll
The file was added/llvm/trunk/test/CodeGen/Mips/no-frame-pointer-elim.llllvm.src/test/CodeGen/Mips/no-frame-pointer-elim.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/tnaked.llllvm.src/test/CodeGen/Mips/tnaked.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/v2i16tof32.llllvm.src/test/CodeGen/Mips/v2i16tof32.ll
Revision 373906 by atanasyan:
[Mips] Fix evaluating J-format branch targets

J/JAL/JALX/JALS are absolute branches, but stay within the current
256 MB-aligned region, so we must include the high bits of the
instruction address when calculating the branch target.

Patch by James Clarke.

Differential Revision: https://reviews.llvm.org/D68548
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cppllvm.src/lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp
The file was added/llvm/trunk/test/MC/Mips/micromips-jump-pc-region.sllvm.src/test/MC/Mips/micromips-jump-pc-region.s
The file was added/llvm/trunk/test/MC/Mips/mips-jump-pc-region.sllvm.src/test/MC/Mips/mips-jump-pc-region.s
Revision 373905 by rksimon:
RewriteModernObjC - silence static analyzer getAs<> null dereference warnings. NFCI.

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.cppclang.src/lib/Frontend/Rewrite/RewriteModernObjC.cpp
Revision 373904 by rksimon:
AST - silence static analyzer getAs<> null dereference warnings. NFCI.

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ExprCXX.cppclang.src/lib/AST/ExprCXX.cpp
The file was modified/cfe/trunk/lib/AST/Interp/Program.cppclang.src/lib/AST/Interp/Program.cpp
The file was modified/cfe/trunk/lib/AST/Mangle.cppclang.src/lib/AST/Mangle.cpp
The file was modified/cfe/trunk/lib/AST/StmtPrinter.cppclang.src/lib/AST/StmtPrinter.cpp
The file was modified/cfe/trunk/lib/AST/TemplateBase.cppclang.src/lib/AST/TemplateBase.cpp
The file was modified/cfe/trunk/lib/AST/TypePrinter.cppclang.src/lib/AST/TypePrinter.cpp
Revision 373903 by whitequark:
[LLVM-C] Add bindings to create macro debug info

Summary: The C API doesn't have the bindings to create macro debug information.

Reviewers: whitequark, CodaFi, deadalnix

Reviewed By: whitequark

Subscribers: aprantl, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D58334
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm-c/DebugInfo.hllvm.src/include/llvm-c/DebugInfo.h
The file was modified/llvm/trunk/lib/IR/DebugInfo.cppllvm.src/lib/IR/DebugInfo.cpp
The file was modified/llvm/trunk/test/Bindings/llvm-c/debug_info.llllvm.src/test/Bindings/llvm-c/debug_info.ll
The file was modified/llvm/trunk/tools/llvm-c-test/debuginfo.cllvm.src/tools/llvm-c-test/debuginfo.c
Revision 373902 by kpn:
Fix sphinx warnings.

Differential Revision: https://reviews.llvm.org/D64746
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/LangRef.rstllvm.src/docs/LangRef.rst
Revision 373901 by mbrkusanin:
Test commit

Fix comment.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsSEISelDAGToDAG.hllvm.src/lib/Target/Mips/MipsSEISelDAGToDAG.h
Revision 373900 by kpn:
[FPEnv] Add constrained intrinsics for lrint and lround

Earlier in the year intrinsics for lrint, llrint, lround and llround were
added to llvm. The constrained versions are now implemented here.

Reviewed by: andrew.w.kaylor, craig.topper, cameron.mcinally
Approved by: craig.topper
Differential Revision: https://reviews.llvm.org/D64746
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/LangRef.rstllvm.src/docs/LangRef.rst
The file was modified/llvm/trunk/include/llvm/CodeGen/ISDOpcodes.hllvm.src/include/llvm/CodeGen/ISDOpcodes.h
The file was modified/llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.hllvm.src/include/llvm/CodeGen/SelectionDAGNodes.h
The file was modified/llvm/trunk/include/llvm/CodeGen/TargetLowering.hllvm.src/include/llvm/CodeGen/TargetLowering.h
The file was modified/llvm/trunk/include/llvm/IR/IntrinsicInst.hllvm.src/include/llvm/IR/IntrinsicInst.h
The file was modified/llvm/trunk/include/llvm/IR/Intrinsics.tdllvm.src/include/llvm/IR/Intrinsics.td
The file was modified/llvm/trunk/include/llvm/Target/TargetSelectionDAG.tdllvm.src/include/llvm/Target/TargetSelectionDAG.td
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cppllvm.src/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cppllvm.src/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cppllvm.src/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cppllvm.src/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
The file was modified/llvm/trunk/lib/CodeGen/TargetLoweringBase.cppllvm.src/lib/CodeGen/TargetLoweringBase.cpp
The file was modified/llvm/trunk/lib/IR/IntrinsicInst.cppllvm.src/lib/IR/IntrinsicInst.cpp
The file was modified/llvm/trunk/lib/IR/Verifier.cppllvm.src/lib/IR/Verifier.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/fp-intrinsics.llllvm.src/test/CodeGen/X86/fp-intrinsics.ll
The file was modified/llvm/trunk/test/Feature/fp-intrinsics.llllvm.src/test/Feature/fp-intrinsics.ll
Revision 373899 by nico:
gn build: use better triple on windows

The CMake build uses "x86_64-pc-windows-msvc". The "-msvc" suffix is
important because e.g. clang/test/lit.cfg.py matches against the
suffix "windows-msvc" to compute the presence of the "ms-sdk" and
the absence of the "LP64" feature.

Differential Revision: https://reviews.llvm.org/D68572
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/llvm/triples.gnillvm.src/utils/gn/secondary/llvm/triples.gni
Revision 373898 by nico:
Revert r373888 "[IA] Recognize hexadecimal escape sequences"

It broke MC/AsmParser/directive_ascii.s on all bots:

    Assertion failed: (Index < Length && "Invalid index!"), function operator[],
        file ../../llvm/include/llvm/ADT/StringRef.h, line 243.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/MC/MCParser/AsmParser.cppllvm.src/lib/MC/MCParser/AsmParser.cpp
The file was modified/llvm/trunk/test/MC/AsmParser/directive_ascii.sllvm.src/test/MC/AsmParser/directive_ascii.s
Revision 373897 by hokein:
[clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch.

Summary: Also fixes a potential user-after-scope issue of "Path".

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68564
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/ClangdLSPServer.cppclang-tools-extra.src/clangd/ClangdLSPServer.cpp
The file was modified/clang-tools-extra/trunk/clangd/ClangdServer.cppclang-tools-extra.src/clangd/ClangdServer.cpp
The file was modified/clang-tools-extra/trunk/clangd/HeaderSourceSwitch.cppclang-tools-extra.src/clangd/HeaderSourceSwitch.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/HeaderSourceSwitchTests.cppclang-tools-extra.src/clangd/unittests/HeaderSourceSwitchTests.cpp
Revision 373896 by martong:
[ASTImporter][NFC] Enable disabled but passing test

RedeclChainShouldBeCorrectAmongstNamespaces
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/AST/ASTImporterTest.cppclang.src/unittests/AST/ASTImporterTest.cpp
Revision 373895 by martong:
[ASTImporter][NFC] Update ASTImporter internals docs
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/InternalsManual.rstclang.src/docs/InternalsManual.rst
Revision 373894 by martong:
[ASTImporter][NFC] Fix typo in user docs
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/LibASTImporter.rstclang.src/docs/LibASTImporter.rst
Revision 373893 by foad:
[AMDGPU] Fix test checks

The GFX10-DENORM-STRICT checks were only passing by accident. Fix them
to make the test more robust in the face of scheduling or register
allocation changes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/fmuladd.f16.llllvm.src/test/CodeGen/AMDGPU/fmuladd.f16.ll
Revision 373892 by sammccall:
[clangd] If an undocumented definition exists, don't accept documentation from other forward decls.

Summary:
This fixes cases like:
  foo.h
    class Undocumented{}
  bar.h
    // break an include cycle. we should refactor this!
    class Undocumented;
Where the comment doesn't describe the class.

Note that a forward decl that is *visible to the definition* will still have
its doc comment used, by SymbolCollector: Merge isn't involved here.

Reviewers: ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68467
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/index/Merge.cppclang-tools-extra.src/clangd/index/Merge.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/IndexTests.cppclang-tools-extra.src/clangd/unittests/IndexTests.cpp
Revision 373890 by grimar:
[llvm-readelf/llvm-objdump] - Improve/refactor the implementation of SHT_LLVM_ADDRSIG section dumping.

This patch:

* Adds a llvm-readobj/llvm-readelf test file for SHT_LLVM_ADDRSIG sections. (we do not have any)
* Enables dumping of SHT_LLVM_ADDRSIG with --all.
* Changes the logic to report a warning instead of an error when something goes wrong during dumping
  (allows to continue dumping SHT_LLVM_ADDRSIG and other sections on error).
* Refactors a piece of logic to a new toULEB128Array helper which might be used for GNU-style
  dumping implementation.

Differential revision: https://reviews.llvm.org/D68383
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/llvm-readobj/all.testllvm.src/test/tools/llvm-readobj/all.test
The file was added/llvm/trunk/test/tools/llvm-readobj/elf-addrsig.testllvm.src/test/tools/llvm-readobj/elf-addrsig.test
The file was modified/llvm/trunk/tools/llvm-readobj/ELFDumper.cppllvm.src/tools/llvm-readobj/ELFDumper.cpp
The file was modified/llvm/trunk/tools/llvm-readobj/llvm-readobj.cppllvm.src/tools/llvm-readobj/llvm-readobj.cpp
Revision 373889 by hokein:
[clangd] Collect missing macro references.

Summary: Semantic highlghting is missing a few macro references.

Reviewers: ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68458
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/CollectMacros.hclang-tools-extra.src/clangd/CollectMacros.h
The file was modified/clang-tools-extra/trunk/clangd/unittests/SemanticHighlightingTests.cppclang-tools-extra.src/clangd/unittests/SemanticHighlightingTests.cpp
Revision 373888 by void:
[IA] Recognize hexadecimal escape sequences

Summary:
Implement support for hexadecimal escape sequences to match how GNU 'as'
handles them. I.e., read all hexadecimal characters and truncate to the
lower 16 bits.

Reviewers: nickdesaulniers

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68483
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/MC/MCParser/AsmParser.cppllvm.src/lib/MC/MCParser/AsmParser.cpp
The file was modified/llvm/trunk/test/MC/AsmParser/directive_ascii.sllvm.src/test/MC/AsmParser/directive_ascii.s