FailedChanges

Summary

  1. [OPENMP50]Treat range-based for as canonical loop. According to OpenMP 5.0, range-based for is also considered as a canonical form of loops.
  2. AMDGPU/GlobalISel: Select more G_INSERT cases At minimum handle the s64 insert type, which are emitted in real cases during legalization. We really need TableGen to emit something to emit something like the inverse of composeSubRegIndices do determine the subreg index to use.
  3. GlobalISel: Add target pre-isel instructions Allows targets to introduce regbankselectable pseudo-instructions. Currently the closet feature to this is an intrinsic. However this requires creating a public intrinsic declaration. This litters the public intrinsic namespace with operations we don't necessarily want to expose to IR producers, and would rather leave as private to the backend. Use a new instruction bit. A previous attempt tried to keep using enum value ranges, but it turned into a mess.
  4. [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build Differential Revision: https://reviews.llvm.org/D68412
  5. Second attempt to add iterator_range::empty() Doing this makes MSVC complain that `empty(someRange)` could refer to either C++17's std::empty or LLVM's llvm::empty, which previously we avoided via SFINAE because std::empty is defined in terms of an empty member rather than begin and end. So, switch callers over to the new method as it is added. https://reviews.llvm.org/D68439
  6. Try to get clangd tests passing on Windows. Part of PR43592. See also r328645.
  7. [scudo][standalone] Correct releaseToOS behavior Summary: There was an issue in `releaseToOSMaybe`: one of the criteria to decide if we should proceed with the release was wrong. Namely: ``` const uptr N = Sci->Stats.PoppedBlocks - Sci->Stats.PushedBlocks; if (N * BlockSize < PageSize) return; // No chance to release anything. ``` I meant to check if the amount of bytes in the free list was lower than a page, but this actually checks if the amount of **in use** bytes was lower than a page. The correct code is: ``` const uptr BytesInFreeList = Region->AllocatedUser - (Region->Stats.PoppedBlocks - Region->Stats.PushedBlocks) * BlockSize; if (BytesInFreeList < PageSize) return 0; // No chance to release anything. ``` Consequences of the bug: - if a class size has less than a page worth of in-use bytes (allocated or in a cache), reclaiming would not occur, whatever the amount of blocks in the free list; in real world scenarios this is unlikely to happen and be impactful; - if a class size had less than a page worth of free bytes (and enough in-use bytes, etc), then reclaiming would be attempted, with likely no result. This means the reclaiming was overzealous at times. I didn't have a good way to test for this, so I changed the prototype of the function to return the number of bytes released, allowing to get the information needed. The test added fails with the initial criteria. Another issue is that `ReleaseToOsInterval` can actually be 0, meaning we always try to release (side note: it's terrible for performances). so change a `> 0` check to `>= 0`. Additionally, decrease the `CanRelease` threshold to `PageSize / 32`. I still have to make that configurable but I will do it at another time. Finally, rename some variables in `printStats`: I feel like "available" was too ambiguous, so change it to "total". Reviewers: morehouse, hctim, eugenis, vitalybuka, cferris Reviewed By: morehouse Subscribers: delcypher, #sanitizers, llvm-commits Tags: #llvm, #sanitizers Differential Revision: https://reviews.llvm.org/D68471
  8. Fix Calling Convention through aliases r369697 changed the behavior of stripPointerCasts to no longer include aliases. However, the code in CGDeclCXX.cpp's createAtExitStub counted on the looking through aliases to properly set the calling convention of a call. The result of the change was that the calling convention mismatch of the call would be replaced with a llvm.trap, causing a runtime crash. Differential Revision: https://reviews.llvm.org/D68584
  9. [libTooling][NFC] Fix build break in r373916. r373916 used raw strings inside macro calls, which breaks some builds.
  10. [clangd] Fix raciness in code completion tests Reviewers: sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68273
  11. [Remarks] Pass StringBlockValue as StringRef. After changing the remark serialization, we now pass StringRefs to the serializer. We should use StringRef for StringBlockVal, to avoid creating temporary objects, which then cause StringBlockVal.Value to point to invalid memory. Reviewers: thegameg, anemet Reviewed By: thegameg Differential Revision: https://reviews.llvm.org/D68571
  12. [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete() Summary: clang-format is incorrectly thinking the parameter parens are part of a cast operation, this is resulting in there sometimes being not space between the paren and the noexcept (and other keywords like volatile etc..) ``` void operator++(int) noexcept; void operator++(int &) noexcept; void operator delete(void *, std::size_t, const std::nothrow_t &)noexcept; ``` Reviewers: klimek, owenpan, mitchell-stellar Reviewed By: mitchell-stellar Subscribers: cfe-commits Tags: #clang-format, #clang Differential Revision: https://reviews.llvm.org/D68481
  13. [clang-format] [NFC] Ensure clang-format is itself clang-formatted. Summary: Before making a proposed change, ensure ClangFormat.cpp is fully clang-formatted, no functional change just clang-formatting using the in tree .clang-format. Reviewers: mitchell-stellar Reviewed By: mitchell-stellar Subscribers: Eugene.Zelenko, cfe-commits Tags: #clang-format, #clang Differential Revision: https://reviews.llvm.org/D68551
  14. Fix build errors caused by rL373914.
  15. Codegen - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
  16. [llvm-profdata] Minor format fix Summary: Minor format fix for output of "llvm-profdata -show" Reviewers: wmi Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68440
  17. [libTooling] Add `toString` method to the Stencil class Summary: `toString` generates a string representation of the stencil. Patch by Harshal T. Lehri. Reviewers: gribozavr Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68574
  18. [X86][SSE] getTargetShuffleInputs - move VT.isSimple/isVector checks inside. NFCI. Stop all the callers from having to check the value type before calling getTargetShuffleInputs.
  19. [SampleFDO] Add compression support for any section in ExtBinary profile format Previously ExtBinary profile format only supports compression using zlib for profile symbol list. In this patch, we extend the compression support to any section. User can select some or all of the sections to compress. In an experiment, for a 45M profile in ExtBinary format, compressing name table reduced its size to 24M, and compressing all the sections reduced its size to 11M. Differential Revision: https://reviews.llvm.org/D68253
  20. [LoopVectorize] add test that asserted after cost model change (PR43582); NFC
Revision 373939 by abataev:
[OPENMP50]Treat range-based for as canonical loop.

According to OpenMP 5.0, range-based for is also considered as a
canonical form of loops.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/StmtOpenMP.hclang.src/include/clang/AST/StmtOpenMP.h
The file was modified/cfe/trunk/include/clang/Sema/Sema.hclang.src/include/clang/Sema/Sema.h
The file was modified/cfe/trunk/lib/CodeGen/CGStmtOpenMP.cppclang.src/lib/CodeGen/CGStmtOpenMP.cpp
The file was modified/cfe/trunk/lib/Parse/ParseDecl.cppclang.src/lib/Parse/ParseDecl.cpp
The file was modified/cfe/trunk/lib/Sema/SemaOpenMP.cppclang.src/lib/Sema/SemaOpenMP.cpp
The file was modified/cfe/trunk/lib/Sema/SemaStmt.cppclang.src/lib/Sema/SemaStmt.cpp
The file was modified/cfe/trunk/test/OpenMP/distribute_parallel_for_simd_loop_messages.cppclang.src/test/OpenMP/distribute_parallel_for_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/distribute_simd_loop_messages.cppclang.src/test/OpenMP/distribute_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/for_ast_print.cppclang.src/test/OpenMP/for_ast_print.cpp
The file was modified/cfe/trunk/test/OpenMP/for_loop_messages.cppclang.src/test/OpenMP/for_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/for_simd_loop_messages.cppclang.src/test/OpenMP/for_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/parallel_for_codegen.cppclang.src/test/OpenMP/parallel_for_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/parallel_for_loop_messages.cppclang.src/test/OpenMP/parallel_for_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/parallel_for_simd_loop_messages.cppclang.src/test/OpenMP/parallel_for_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/simd_loop_messages.cppclang.src/test/OpenMP/simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/target_parallel_for_loop_messages.cppclang.src/test/OpenMP/target_parallel_for_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/target_parallel_for_simd_loop_messages.cppclang.src/test/OpenMP/target_parallel_for_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/target_simd_loop_messages.cppclang.src/test/OpenMP/target_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/target_teams_distribute_loop_messages.cppclang.src/test/OpenMP/target_teams_distribute_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/target_teams_distribute_parallel_for_loop_messages.cppclang.src/test/OpenMP/target_teams_distribute_parallel_for_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/target_teams_distribute_parallel_for_simd_loop_messages.cppclang.src/test/OpenMP/target_teams_distribute_parallel_for_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_loop_messages.cppclang.src/test/OpenMP/taskloop_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_simd_loop_messages.cppclang.src/test/OpenMP/taskloop_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_loop_messages.cppclang.src/test/OpenMP/teams_distribute_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_parallel_for_loop_messages.cppclang.src/test/OpenMP/teams_distribute_parallel_for_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cppclang.src/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_simd_loop_messages.cppclang.src/test/OpenMP/teams_distribute_simd_loop_messages.cpp
Revision 373938 by arsenm:
AMDGPU/GlobalISel: Select more G_INSERT cases

At minimum handle the s64 insert type, which are emitted in real cases
during legalization.

We really need TableGen to emit something to emit something like the
inverse of composeSubRegIndices do determine the subreg index to use.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUInstructionSelector.cppllvm.src/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/inst-select-insert.mirllvm.src/test/CodeGen/AMDGPU/GlobalISel/inst-select-insert.mir
Revision 373937 by arsenm:
GlobalISel: Add target pre-isel instructions

Allows targets to introduce regbankselectable
pseudo-instructions. Currently the closet feature to this is an
intrinsic. However this requires creating a public intrinsic
declaration. This litters the public intrinsic namespace with
operations we don't necessarily want to expose to IR producers, and
would rather leave as private to the backend.

Use a new instruction bit. A previous attempt tried to keep using enum
value ranges, but it turned into a mess.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/MachineInstr.hllvm.src/include/llvm/CodeGen/MachineInstr.h
The file was modified/llvm/trunk/include/llvm/MC/MCInstrDesc.hllvm.src/include/llvm/MC/MCInstrDesc.h
The file was modified/llvm/trunk/include/llvm/Target/GenericOpcodes.tdllvm.src/include/llvm/Target/GenericOpcodes.td
The file was modified/llvm/trunk/include/llvm/Target/Target.tdllvm.src/include/llvm/Target/Target.td
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cppllvm.src/lib/CodeGen/GlobalISel/RegBankSelect.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUGISel.tdllvm.src/lib/Target/AMDGPU/AMDGPUGISel.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUInstructionSelector.cppllvm.src/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cppllvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cppllvm.src/lib/Target/AMDGPU/SIInstrInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstructions.tdllvm.src/lib/Target/AMDGPU/SIInstructions.td
The file was added/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgpu-ffbh-u32.mirllvm.src/test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgpu-ffbh-u32.mir
The file was added/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgpu-ffbh-u32.mirllvm.src/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgpu-ffbh-u32.mir
The file was modified/llvm/trunk/utils/TableGen/CodeGenInstruction.cppllvm.src/utils/TableGen/CodeGenInstruction.cpp
The file was modified/llvm/trunk/utils/TableGen/CodeGenInstruction.hllvm.src/utils/TableGen/CodeGenInstruction.h
The file was modified/llvm/trunk/utils/TableGen/InstrInfoEmitter.cppllvm.src/utils/TableGen/InstrInfoEmitter.cpp
Revision 373936 by mgorny:
[clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build

Differential Revision: https://reviews.llvm.org/D68412
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/CMakeLists.txtclang.src/CMakeLists.txt
Revision 373935 by jrose:
Second attempt to add iterator_range::empty()

Doing this makes MSVC complain that `empty(someRange)` could refer to
either C++17's std::empty or LLVM's llvm::empty, which previously we
avoided via SFINAE because std::empty is defined in terms of an empty
member rather than begin and end. So, switch callers over to the new
method as it is added.

https://reviews.llvm.org/D68439
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/iterator_range.hllvm.src/include/llvm/ADT/iterator_range.h
The file was modified/llvm/trunk/lib/Analysis/LazyCallGraph.cppllvm.src/lib/Analysis/LazyCallGraph.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cppllvm.src/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/InstructionSelector.cppllvm.src/lib/CodeGen/GlobalISel/InstructionSelector.cpp
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/LegalizerInfo.cppllvm.src/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cppllvm.src/lib/CodeGen/GlobalISel/RegBankSelect.cpp
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/RegisterBankInfo.cppllvm.src/lib/CodeGen/GlobalISel/RegisterBankInfo.cpp
The file was modified/llvm/trunk/lib/CodeGen/MachineModuleInfo.cppllvm.src/lib/CodeGen/MachineModuleInfo.cpp
The file was modified/llvm/trunk/lib/ExecutionEngine/Orc/ExecutionUtils.cppllvm.src/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
The file was modified/llvm/trunk/lib/IR/DebugInfo.cppllvm.src/lib/IR/DebugInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cppllvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPFAbstractMemberAccess.cppllvm.src/lib/Target/BPF/BPFAbstractMemberAccess.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPFAsmPrinter.cppllvm.src/lib/Target/BPF/BPFAsmPrinter.cpp
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cppllvm.src/lib/Target/PowerPC/PPCInstrInfo.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/PartialInlining.cppllvm.src/lib/Transforms/IPO/PartialInlining.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cppllvm.src/lib/Transforms/Scalar/IndVarSimplify.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/NewGVN.cppllvm.src/lib/Transforms/Scalar/NewGVN.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/PredicateInfo.cppllvm.src/lib/Transforms/Utils/PredicateInfo.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cppllvm.src/lib/Transforms/Utils/SimplifyCFG.cpp
Revision 373932 by nico:
Try to get clangd tests passing on Windows.

Part of PR43592. See also r328645.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/test/semantic-highlighting.testclang-tools-extra.src/clangd/test/semantic-highlighting.test
The file was modified/clang-tools-extra/trunk/clangd/test/type-hierarchy.testclang-tools-extra.src/clangd/test/type-hierarchy.test
Revision 373930 by cryptoad:
[scudo][standalone] Correct releaseToOS behavior

Summary:
There was an issue in `releaseToOSMaybe`: one of the criteria to
decide if we should proceed with the release was wrong. Namely:

```
const uptr N = Sci->Stats.PoppedBlocks - Sci->Stats.PushedBlocks;
if (N * BlockSize < PageSize)
  return; // No chance to release anything.
```

I meant to check if the amount of bytes in the free list was lower
than a page, but this actually checks if the amount of **in use** bytes
was lower than a page.

The correct code is:

```
const uptr BytesInFreeList =
  Region->AllocatedUser -
  (Region->Stats.PoppedBlocks - Region->Stats.PushedBlocks) * BlockSize;
if (BytesInFreeList < PageSize)
  return 0; // No chance to release anything.
```

Consequences of the bug:
- if a class size has less than a page worth of in-use bytes (allocated
  or in a cache), reclaiming would not occur, whatever the amount of
  blocks in the free list; in real world scenarios this is unlikely to
  happen and be impactful;
- if a class size had less than a page worth of free bytes (and enough
  in-use bytes, etc), then reclaiming would be attempted, with likely
  no result. This means the reclaiming was overzealous at times.

I didn't have a good way to test for this, so I changed the prototype
of the function to return the number of bytes released, allowing to
get the information needed. The test added fails with the initial
criteria.

Another issue is that `ReleaseToOsInterval` can actually be 0, meaning
we always try to release (side note: it's terrible for performances).
so change a `> 0` check to `>= 0`.

Additionally, decrease the `CanRelease` threshold to `PageSize / 32`.
I still have to make that configurable but I will do it at another time.

Finally, rename some variables in `printStats`: I feel like "available"
was too ambiguous, so change it to "total".

Reviewers: morehouse, hctim, eugenis, vitalybuka, cferris

Reviewed By: morehouse

Subscribers: delcypher, #sanitizers, llvm-commits

Tags: #llvm, #sanitizers

Differential Revision: https://reviews.llvm.org/D68471
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/scudo/standalone/primary32.hcompiler-rt.src/lib/scudo/standalone/primary32.h
The file was modified/compiler-rt/trunk/lib/scudo/standalone/primary64.hcompiler-rt.src/lib/scudo/standalone/primary64.h
The file was modified/compiler-rt/trunk/lib/scudo/standalone/tests/primary_test.cppcompiler-rt.src/lib/scudo/standalone/tests/primary_test.cpp
Revision 373929 by erichkeane:
Fix Calling Convention through aliases

r369697 changed the behavior of stripPointerCasts to no longer include
aliases.  However, the code in CGDeclCXX.cpp's createAtExitStub counted
on the looking through aliases to properly set the calling convention of
a call.

The result of the change was that the calling convention mismatch of the
call would be replaced with a llvm.trap, causing a runtime crash.

Differential Revision: https://reviews.llvm.org/D68584
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGDeclCXX.cppclang.src/lib/CodeGen/CGDeclCXX.cpp
The file was added/cfe/trunk/test/CodeGenCXX/call-conv-thru-alias.cppclang.src/test/CodeGenCXX/call-conv-thru-alias.cpp
The file was modified/llvm/trunk/include/llvm/IR/Value.hllvm.src/include/llvm/IR/Value.h
The file was modified/llvm/trunk/lib/IR/Value.cppllvm.src/lib/IR/Value.cpp
Revision 373928 by ymandel:
[libTooling][NFC] Fix build break in r373916.

r373916 used raw strings inside macro calls, which breaks some builds.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/Tooling/StencilTest.cppclang.src/unittests/Tooling/StencilTest.cpp
Revision 373924 by kadircet:
[clangd] Fix raciness in code completion tests

Reviewers: sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68273
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/unittests/CodeCompleteTests.cppclang-tools-extra.src/clangd/unittests/CodeCompleteTests.cpp
Revision 373923 by fhahn:
[Remarks] Pass StringBlockValue as StringRef.

After changing the remark serialization, we now pass StringRefs to the
serializer. We should use StringRef for StringBlockVal, to avoid
creating temporary objects, which then cause StringBlockVal.Value to
point to invalid memory.

Reviewers: thegameg, anemet

Reviewed By: thegameg

Differential Revision: https://reviews.llvm.org/D68571
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Remarks/YAMLRemarkSerializer.cppllvm.src/lib/Remarks/YAMLRemarkSerializer.cpp
Revision 373922 by paulhoad:
[clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

Summary:
clang-format is incorrectly thinking the parameter parens are part of a cast operation, this is resulting in there sometimes being not space between the paren and the noexcept (and other keywords like volatile etc..)

```
void operator++(int) noexcept;
void operator++(int &) noexcept;
void operator delete(void *, std::size_t, const std::nothrow_t &)noexcept;
```

Reviewers: klimek, owenpan, mitchell-stellar

Reviewed By: mitchell-stellar

Subscribers: cfe-commits

Tags: #clang-format, #clang

Differential Revision: https://reviews.llvm.org/D68481
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Format/TokenAnnotator.cppclang.src/lib/Format/TokenAnnotator.cpp
The file was modified/cfe/trunk/unittests/Format/FormatTest.cppclang.src/unittests/Format/FormatTest.cpp
Revision 373921 by paulhoad:
[clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Summary:
Before making a proposed change, ensure ClangFormat.cpp is fully clang-formatted,

no functional change just clang-formatting using the in tree .clang-format.

Reviewers: mitchell-stellar

Reviewed By: mitchell-stellar

Subscribers: Eugene.Zelenko, cfe-commits

Tags: #clang-format, #clang

Differential Revision: https://reviews.llvm.org/D68551
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/clang-format/ClangFormat.cppclang.src/tools/clang-format/ClangFormat.cpp
Revision 373919 by wmi:
Fix build errors caused by rL373914.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ProfileData/SampleProfWriter.hllvm.src/include/llvm/ProfileData/SampleProfWriter.h
The file was modified/llvm/trunk/lib/ProfileData/SampleProfReader.cppllvm.src/lib/ProfileData/SampleProfReader.cpp
Revision 373918 by rksimon:
Codegen - silence static analyzer getAs<> null dereference warnings. NFCI.

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGAtomic.cppclang.src/lib/CodeGen/CGAtomic.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGCXX.cppclang.src/lib/CodeGen/CGCXX.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGClass.cppclang.src/lib/CodeGen/CGClass.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGDebugInfo.cppclang.src/lib/CodeGen/CGDebugInfo.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGExpr.cppclang.src/lib/CodeGen/CGExpr.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGObjCGNU.cppclang.src/lib/CodeGen/CGObjCGNU.cpp
The file was modified/cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cppclang.src/lib/CodeGen/MicrosoftCXXABI.cpp
The file was modified/cfe/trunk/lib/CodeGen/TargetInfo.cppclang.src/lib/CodeGen/TargetInfo.cpp
Revision 373917 by wenlei:
[llvm-profdata] Minor format fix

Summary: Minor format fix for output of "llvm-profdata -show"

Reviewers: wmi

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68440
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/ProfileData/SampleProf.cppllvm.src/lib/ProfileData/SampleProf.cpp
Revision 373916 by ymandel:
[libTooling] Add `toString` method to the Stencil class

Summary:
`toString` generates a string representation of the stencil.

Patch by Harshal T. Lehri.

Reviewers: gribozavr

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68574
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Tooling/Refactoring/Stencil.hclang.src/include/clang/Tooling/Refactoring/Stencil.h
The file was modified/cfe/trunk/lib/Tooling/Refactoring/Stencil.cppclang.src/lib/Tooling/Refactoring/Stencil.cpp
The file was modified/cfe/trunk/unittests/Tooling/StencilTest.cppclang.src/unittests/Tooling/StencilTest.cpp
Revision 373915 by rksimon:
[X86][SSE] getTargetShuffleInputs - move VT.isSimple/isVector checks inside. NFCI.

Stop all the callers from having to check the value type before calling getTargetShuffleInputs.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 373914 by wmi:
[SampleFDO] Add compression support for any section in ExtBinary profile format

Previously ExtBinary profile format only supports compression using zlib for
profile symbol list. In this patch, we extend the compression support to any
section. User can select some or all of the sections to compress. In an
experiment, for a 45M profile in ExtBinary format, compressing name table
reduced its size to 24M, and compressing all the sections reduced its size
to 11M.

Differential Revision: https://reviews.llvm.org/D68253
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ProfileData/SampleProf.hllvm.src/include/llvm/ProfileData/SampleProf.h
The file was modified/llvm/trunk/include/llvm/ProfileData/SampleProfReader.hllvm.src/include/llvm/ProfileData/SampleProfReader.h
The file was modified/llvm/trunk/include/llvm/ProfileData/SampleProfWriter.hllvm.src/include/llvm/ProfileData/SampleProfWriter.h
The file was modified/llvm/trunk/lib/ProfileData/SampleProf.cppllvm.src/lib/ProfileData/SampleProf.cpp
The file was modified/llvm/trunk/lib/ProfileData/SampleProfReader.cppllvm.src/lib/ProfileData/SampleProfReader.cpp
The file was modified/llvm/trunk/lib/ProfileData/SampleProfWriter.cppllvm.src/lib/ProfileData/SampleProfWriter.cpp
The file was modified/llvm/trunk/test/Transforms/SampleProfile/compressed-profile-symbol-list.llllvm.src/test/Transforms/SampleProfile/compressed-profile-symbol-list.ll
The file was added/llvm/trunk/test/Transforms/SampleProfile/profile-format-compress.llllvm.src/test/Transforms/SampleProfile/profile-format-compress.ll
The file was modified/llvm/trunk/test/Transforms/SampleProfile/uncompressed-profile-symbol-list.llllvm.src/test/Transforms/SampleProfile/uncompressed-profile-symbol-list.ll
The file was added/llvm/trunk/test/tools/llvm-profdata/profile-symbol-list-compress.testllvm.src/test/tools/llvm-profdata/profile-symbol-list-compress.test
The file was added/llvm/trunk/test/tools/llvm-profdata/roundtrip-compress.testllvm.src/test/tools/llvm-profdata/roundtrip-compress.test
The file was modified/llvm/trunk/tools/llvm-profdata/llvm-profdata.cppllvm.src/tools/llvm-profdata/llvm-profdata.cpp
Revision 373913 by spatel:
[LoopVectorize] add test that asserted after cost model change (PR43582); NFC
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/LoopVectorize/X86/cost-model-assert.llllvm.src/test/Transforms/LoopVectorize/X86/cost-model-assert.ll