FailedChanges

Summary

  1. Revert 374481 "[tsan,msan] Insert module constructors in a module pass" CodeGen/sanitizer-module-constructor.c fails on mac and windows, see e.g. http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11424
  2. [CUDA][HIP} Add a test for constexpr default ctor Differential Revision: https://reviews.llvm.org/D68753
  3. [JITLink] Disable the MachO/AArch64 testcase while investigating bot failures. The windows bots are failing due to a memory layout error. Temporarily disabling while I investigate whether this can be worked around, or whether the test should be disabled on Windows.
  4. [JITLink] Fix MachO/arm64 GOTPAGEOFF encoding. The original implementation failed to shift the immediate down. This should fix some of the bot failures due to r374476.
  5. [Attributor][FIX] Do not replace musstail calls with constant
  6. Fix assertion failure for a cv-qualified array as a non-type template parameter type. We were both failing to decay the array type to a pointer and failing to remove the top-level cv-qualifications. Fix this by decaying array parameters even if the parameter type is dependent.
  7. AMDGPU: Move SelectFlatOffset back into AMDGPUISelDAGToDAG
  8. Get ClangdXPC.framework building (barely) with CMake's Xcode generator The output directories for CMake's Xcode project generator are specific to the configuration, and so looking in CMAKE_LIBRARY_OUTPUT_DIRECTORY isn't going to work. Fortunately, CMake already provides generator expressions to find the output of a given target. I call this "barely" building because the built framework isn't going to respect the configuration; that is, I can't have both Debug and RelWithDebInfo variants of ClangdXPC.framework at the same time like I can with normal library or executable targets. To do that we'd have to put the framework in a configuration-specific output directory or use CMake's native support for frameworks instead. https://reviews.llvm.org/D68846
  9. [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS. The intended usage is to measure relatively expensive operations. So the cost of the statistic is negligible compared to the cost of a measured operation and can be enabled all the time without impairing the compilation time. rdar://problem/55715134 Reviewers: dsanders, bogner, rtereshin Reviewed By: dsanders Subscribers: hiraditya, jkorous, dexonsmith, ributzka, cfe-commits, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68252
  10. Include whether the destructor is constexpr in -ast-dump output for a clss.
  11. [X86] Improve the AVX512 bailout in combineTruncateWithSat to allow pack instructions in more situations. If we don't have VLX we won't end up selecting a saturating truncate for 256-bit or smaller vectors so we should just use the pack lowering.
  12. [X86] Update trunc_packus_v32i32_v32i8 test in min-legal-vector-width.ll to use a load for the large type and add the min-legal-vector-width attribute. The attribute is needed to avoid zmm registers. Using memory avoids argument splitting for large vectors.
  13. Move most CXXRecordDecl::DefinitionData bit-fields out into a separate file. Reduces duplication and thereby reduces the risk that someone will forget to update one of these places, as I did when adding DefaultedDestructorIsConstexpr (though I've been unable to produce a testcase for which that matters so far).
  14. gn build: Merge r374476
  15. [tsan,msan] Insert module constructors in a module pass Summary: If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877. Reviewers: eugenis, leonardchan Reviewed By: leonardchan Subscribers: hiraditya, cfe-commits, llvm-commits Tags: #clang, #llvm Differential Revision: https://reviews.llvm.org/D68832
  16. [msan, NFC] Move option parsing into constructor
  17. Fix compilation warning due to typo.
  18. [tooling] Fix assertion on MacOSX.
  19. [JITLink] Add an initial implementation of JITLink for MachO/AArch64. This implementation has support for all relocation types except TLV. Compact unwind sections are not yet supported, so exceptions/unwinding will not work.
  20. [JITLink] Move MachO/x86 got test further down in the data section. 'named_data' should be the first symbol in the data section.
  21. docs/DeveloperPolicy: Add instructions for requesting GitHub commit access Subscribers: mehdi_amini, jtony, xbolva00, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66840
  22. Fix check-interception link error in compiler-rt debug mode
  23. [MemorySSA] Update Phi simplification. When simplifying a Phi to the unique value found incoming, check that there wasn't a Phi already created to break a cycle. If so, remove it. Resolves PR43541. Some additional nits included.
  24. [tooling] Teach Tooling to understand compilation with offloading. Summary: - So far, we only recognize the host compilation with offloading and skip the offloading part. Reviewers: tra, yaxunl Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68660
Revision 374503 by nico:
Revert 374481 "[tsan,msan] Insert module constructors in a module pass"

CodeGen/sanitizer-module-constructor.c fails on mac and windows, see e.g.
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11424
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/BackendUtil.cppclang.src/lib/CodeGen/BackendUtil.cpp
The file was removed/cfe/trunk/test/CodeGen/sanitizer-module-constructor.cclang.src/test/CodeGen/sanitizer-module-constructor.c
The file was modified/llvm/trunk/include/llvm/Transforms/Instrumentation/MemorySanitizer.hllvm.src/include/llvm/Transforms/Instrumentation/MemorySanitizer.h
The file was modified/llvm/trunk/include/llvm/Transforms/Instrumentation/ThreadSanitizer.hllvm.src/include/llvm/Transforms/Instrumentation/ThreadSanitizer.h
The file was modified/llvm/trunk/lib/Passes/PassRegistry.defllvm.src/lib/Passes/PassRegistry.def
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cppllvm.src/lib/Transforms/Instrumentation/MemorySanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/ThreadSanitizer.cppllvm.src/lib/Transforms/Instrumentation/ThreadSanitizer.cpp
The file was modified/llvm/trunk/test/Instrumentation/MemorySanitizer/msan_basic.llllvm.src/test/Instrumentation/MemorySanitizer/msan_basic.ll
The file was modified/llvm/trunk/test/Instrumentation/ThreadSanitizer/tsan_basic.llllvm.src/test/Instrumentation/ThreadSanitizer/tsan_basic.ll
Revision 374502 by yaxunl:
[CUDA][HIP} Add a test for constexpr default ctor

Differential Revision: https://reviews.llvm.org/D68753
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/test/SemaCUDA/constexpr-ctor.cuclang.src/test/SemaCUDA/constexpr-ctor.cu
Revision 374500 by Lang Hames:
[JITLink] Disable the MachO/AArch64 testcase while investigating bot failures.

The windows bots are failing due to a memory layout error. Temporarily disabling
while I investigate whether this can be worked around, or whether the test
should be disabled on Windows.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/ExecutionEngine/JITLink/AArch64/lit.local.cfgllvm.src/test/ExecutionEngine/JITLink/AArch64/lit.local.cfg
Revision 374499 by Lang Hames:
[JITLink] Fix MachO/arm64 GOTPAGEOFF encoding.

The original implementation failed to shift the immediate down.

This should fix some of the bot failures due to r374476.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/ExecutionEngine/JITLink/MachO_arm64.cppllvm.src/lib/ExecutionEngine/JITLink/MachO_arm64.cpp
Revision 374498 by jdoerfert:
[Attributor][FIX] Do not replace musstail calls with constant
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/arg_returned.llllvm.src/test/Transforms/FunctionAttrs/arg_returned.ll
Revision 374496 by rsmith:
Fix assertion failure for a cv-qualified array as a non-type template
parameter type.

We were both failing to decay the array type to a pointer and failing to
remove the top-level cv-qualifications. Fix this by decaying array
parameters even if the parameter type is dependent.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaTemplate.cppclang.src/lib/Sema/SemaTemplate.cpp
The file was modified/cfe/trunk/test/SemaTemplate/temp_arg_nontype.cppclang.src/test/SemaTemplate/temp_arg_nontype.cpp
Revision 374495 by arsenm:
AMDGPU: Move SelectFlatOffset back into AMDGPUISelDAGToDAG
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cppllvm.src/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUISelLowering.cppllvm.src/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUISelLowering.hllvm.src/lib/Target/AMDGPU/AMDGPUISelLowering.h
Revision 374494 by jrose:
Get ClangdXPC.framework building (barely) with CMake's Xcode generator

The output directories for CMake's Xcode project generator are
specific to the configuration, and so looking in
CMAKE_LIBRARY_OUTPUT_DIRECTORY isn't going to work. Fortunately, CMake
already provides generator expressions to find the output of a given
target.

I call this "barely" building because the built framework isn't going
to respect the configuration; that is, I can't have both Debug and
RelWithDebInfo variants of ClangdXPC.framework at the same time like I
can with normal library or executable targets. To do that we'd have to
put the framework in a configuration-specific output directory or use
CMake's native support for frameworks instead.

https://reviews.llvm.org/D68846
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/xpc/cmake/modules/CreateClangdXPCFramework.cmakeclang-tools-extra.src/clangd/xpc/cmake/modules/CreateClangdXPCFramework.cmake
Revision 374490 by vsapsai:
[Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

The intended usage is to measure relatively expensive operations. So the
cost of the statistic is negligible compared to the cost of a measured
operation and can be enabled all the time without impairing the
compilation time.

rdar://problem/55715134

Reviewers: dsanders, bogner, rtereshin

Reviewed By: dsanders

Subscribers: hiraditya, jkorous, dexonsmith, ributzka, cfe-commits, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68252
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/Statistic.hllvm.src/include/llvm/ADT/Statistic.h
The file was modified/llvm/trunk/lib/Support/Statistic.cppllvm.src/lib/Support/Statistic.cpp
The file was modified/llvm/trunk/unittests/ADT/StatisticTest.cppllvm.src/unittests/ADT/StatisticTest.cpp
Revision 374488 by rsmith:
Include whether the destructor is constexpr in -ast-dump output for a
clss.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/TextNodeDumper.cppclang.src/lib/AST/TextNodeDumper.cpp
Revision 374487 by ctopper:
[X86] Improve the AVX512 bailout in combineTruncateWithSat to allow pack instructions in more situations.

If we don't have VLX we won't end up selecting a saturating
truncate for 256-bit or smaller vectors so we should just use
the pack lowering.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/masked_store_trunc_ssat.llllvm.src/test/CodeGen/X86/masked_store_trunc_ssat.ll
The file was modified/llvm/trunk/test/CodeGen/X86/pmaddubsw.llllvm.src/test/CodeGen/X86/pmaddubsw.ll
The file was modified/llvm/trunk/test/CodeGen/X86/vector-trunc-packus.llllvm.src/test/CodeGen/X86/vector-trunc-packus.ll
The file was modified/llvm/trunk/test/CodeGen/X86/vector-trunc-ssat.llllvm.src/test/CodeGen/X86/vector-trunc-ssat.ll
Revision 374486 by ctopper:
[X86] Update trunc_packus_v32i32_v32i8 test in min-legal-vector-width.ll to use a load for the large type and add the min-legal-vector-width attribute.

The attribute is needed to avoid zmm registers. Using memory
avoids argument splitting for large vectors.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/min-legal-vector-width.llllvm.src/test/CodeGen/X86/min-legal-vector-width.ll
Revision 374484 by rsmith:
Move most CXXRecordDecl::DefinitionData bit-fields out into a separate
file.

Reduces duplication and thereby reduces the risk that someone will
forget to update one of these places, as I did when adding
DefaultedDestructorIsConstexpr (though I've been unable to produce
a testcase for which that matters so far).
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/include/clang/AST/CXXRecordDeclDefinitionBits.defclang.src/include/clang/AST/CXXRecordDeclDefinitionBits.def
The file was modified/cfe/trunk/include/clang/AST/DeclCXX.hclang.src/include/clang/AST/DeclCXX.h
The file was modified/cfe/trunk/lib/AST/ASTImporter.cppclang.src/lib/AST/ASTImporter.cpp
The file was modified/cfe/trunk/lib/AST/DeclCXX.cppclang.src/lib/AST/DeclCXX.cpp
The file was modified/cfe/trunk/lib/Serialization/ASTReaderDecl.cppclang.src/lib/Serialization/ASTReaderDecl.cpp
The file was modified/cfe/trunk/lib/Serialization/ASTWriter.cppclang.src/lib/Serialization/ASTWriter.cpp
Revision 374482 by gnsyncbot:
gn build: Merge r374476
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/llvm/lib/ExecutionEngine/JITLink/BUILD.gnllvm.src/utils/gn/secondary/llvm/lib/ExecutionEngine/JITLink/BUILD.gn
Revision 374481 by Vitaly Buka:
[tsan,msan] Insert module constructors in a module pass

Summary:
If we insert them from function pass some analysis may be missing or invalid.
Fixes PR42877.

Reviewers: eugenis, leonardchan

Reviewed By: leonardchan

Subscribers: hiraditya, cfe-commits, llvm-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D68832
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/BackendUtil.cppclang.src/lib/CodeGen/BackendUtil.cpp
The file was added/cfe/trunk/test/CodeGen/sanitizer-module-constructor.cclang.src/test/CodeGen/sanitizer-module-constructor.c
The file was modified/llvm/trunk/include/llvm/Transforms/Instrumentation/MemorySanitizer.hllvm.src/include/llvm/Transforms/Instrumentation/MemorySanitizer.h
The file was modified/llvm/trunk/include/llvm/Transforms/Instrumentation/ThreadSanitizer.hllvm.src/include/llvm/Transforms/Instrumentation/ThreadSanitizer.h
The file was modified/llvm/trunk/lib/Passes/PassRegistry.defllvm.src/lib/Passes/PassRegistry.def
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cppllvm.src/lib/Transforms/Instrumentation/MemorySanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/ThreadSanitizer.cppllvm.src/lib/Transforms/Instrumentation/ThreadSanitizer.cpp
The file was modified/llvm/trunk/test/Instrumentation/MemorySanitizer/msan_basic.llllvm.src/test/Instrumentation/MemorySanitizer/msan_basic.ll
The file was modified/llvm/trunk/test/Instrumentation/ThreadSanitizer/tsan_basic.llllvm.src/test/Instrumentation/ThreadSanitizer/tsan_basic.ll
Revision 374480 by Vitaly Buka:
[msan, NFC] Move option parsing into constructor
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/Instrumentation/MemorySanitizer.hllvm.src/include/llvm/Transforms/Instrumentation/MemorySanitizer.h
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cppllvm.src/lib/Transforms/Instrumentation/MemorySanitizer.cpp
Revision 374479 by hliao:
Fix compilation warning due to typo.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/ExecutionEngine/JITLink/MachO_arm64.cppllvm.src/lib/ExecutionEngine/JITLink/MachO_arm64.cpp
Revision 374478 by hliao:
[tooling] Fix assertion on MacOSX.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Tooling/Tooling.cppclang.src/lib/Tooling/Tooling.cpp
Revision 374476 by Lang Hames:
[JITLink] Add an initial implementation of JITLink for MachO/AArch64.

This implementation has support for all relocation types except TLV.

Compact unwind sections are not yet supported, so exceptions/unwinding will not
work.
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/include/llvm/ExecutionEngine/JITLink/MachO_arm64.hllvm.src/include/llvm/ExecutionEngine/JITLink/MachO_arm64.h
The file was modified/llvm/trunk/lib/ExecutionEngine/JITLink/CMakeLists.txtllvm.src/lib/ExecutionEngine/JITLink/CMakeLists.txt
The file was modified/llvm/trunk/lib/ExecutionEngine/JITLink/MachO.cppllvm.src/lib/ExecutionEngine/JITLink/MachO.cpp
The file was added/llvm/trunk/lib/ExecutionEngine/JITLink/MachO_arm64.cppllvm.src/lib/ExecutionEngine/JITLink/MachO_arm64.cpp
The file was added/llvm/trunk/test/ExecutionEngine/JITLink/AArch64llvm.src/test/ExecutionEngine/JITLink/AArch64
The file was added/llvm/trunk/test/ExecutionEngine/JITLink/AArch64/MachO_Arm64_relocations.sllvm.src/test/ExecutionEngine/JITLink/AArch64/MachO_Arm64_relocations.s
The file was added/llvm/trunk/test/ExecutionEngine/JITLink/AArch64/lit.local.cfgllvm.src/test/ExecutionEngine/JITLink/AArch64/lit.local.cfg
Revision 374475 by Lang Hames:
[JITLink] Move MachO/x86 got test further down in the data section.

'named_data' should be the first symbol in the data section.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.sllvm.src/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.s
Revision 374474 by tstellar:
docs/DeveloperPolicy: Add instructions for requesting GitHub commit access

Subscribers: mehdi_amini, jtony, xbolva00, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66840
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/DeveloperPolicy.rstllvm.src/docs/DeveloperPolicy.rst
Revision 374472 by rnk:
Fix check-interception link error in compiler-rt debug mode
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/interception/tests/CMakeLists.txtcompiler-rt.src/lib/interception/tests/CMakeLists.txt
Revision 374471 by asbirlea:
[MemorySSA] Update Phi simplification.

When simplifying a Phi to the unique value found incoming, check that
there wasn't a Phi already created to break a cycle. If so, remove it.
Resolves PR43541.

Some additional nits included.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/MemorySSAUpdater.cppllvm.src/lib/Analysis/MemorySSAUpdater.cpp
The file was added/llvm/trunk/test/Analysis/MemorySSA/pr43541.llllvm.src/test/Analysis/MemorySSA/pr43541.ll
Revision 374470 by hliao:
[tooling] Teach Tooling to understand compilation with offloading.

Summary:
- So far, we only recognize the host compilation with offloading and
  skip the offloading part.

Reviewers: tra, yaxunl

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D68660
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Tooling/Tooling.cppclang.src/lib/Tooling/Tooling.cpp
The file was added/cfe/trunk/test/Tooling/clang-check-offload.cppclang.src/test/Tooling/clang-check-offload.cpp