FailedChanges

Summary

  1. [libc++][test] Silence MSVC warning in std::optional test `make_optional<string>(4, 'X')` passes `4` (an `int`) as the first argument to `string`'s `(size_t, charT)` constructor, triggering a signed/unsigned mismatch warning when compiling with MSVC at `/W4`. The incredibly simple fix is to instead use an unsigned literal (`4u`).
  2. Revert r374648: "Reland r374388: [lit] Make internal diff work in pipelines" This series of patches still breaks a Windows bot.
  3. Revert r374649: "Reland r374389: [lit] Clean up internal diff's encoding handling" This series of patches still breaks a Windows bot.
  4. Revert r374650: "Reland r374390: [lit] Extend internal diff to support `-` argument" This series of patches still breaks a Windows bot.
  5. Revert 374651: "Reland r374392: [lit] Extend internal diff to support -U" This series of patches still breaks a Windows bot.
  6. Revert r374652: "[lit] Fix internal diff's --strip-trailing-cr and use it" This series of patches still breaks a Windows bot.
  7. Revert r374653: "[lit] Fix a few oversights in r374651 that broke some bots" This series of patches still breaks a Windows bot.
  8. Revert r374665: "[lit] Try yet again to fix new tests that fail on Windows bots" This series of patches still breaks a Windows bot.
  9. Revert r374666: "[lit] Adjust error handling for decode introduced by r374665" This series of patches still breaks a Windows bot.
  10. Revert r374671: "[lit] Try errors="ignore" for decode introduced by r374665" This series of patches still breaks a Windows bot.
  11. [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
  12. SymbolRecord - consistently use explicit for single operand constructors
  13. SymbolRecord - fix uninitialized variable warnings. NFCI.
  14. [lit] Try errors="ignore" for decode introduced by r374665 Still trying to fix the same error as in r374666.
  15. [NFC][LoopIdiom] Adjust FIXME to be self-explanatory
  16. Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI.
  17. Fix cppcheck shadow variable name warnings. NFCI.
  18. [X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI.
  19. [lit] Adjust error handling for decode introduced by r374665 On that decode, Windows bots fail with: ``` UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128) ``` That's the same error as before r374665 except it's now at the decode before the write to stdout.
  20. [lit] Try yet again to fix new tests that fail on Windows bots I seem to have misread the bot logs on my last attempt. When lit's internal diff runs on Windows under Python 2.7, it's text diffs not binary diffs that need decoding to avoid this error when writing the diff to stdout: ``` UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128) ``` There is no `decode` attribute in this case under Python 3.6.8 under Ubuntu, so this patch checks for the `decode` attribute before using it here. Hopefully nothing else is needed when `decode` isn't available. It might take a couple more attempts to figure out what error handling, if any, is needed for this decoding.
  21. Revert r374657: "[lit] Try again to fix new tests that fail on Windows bots"
Revision 374684 by caseycarter:
[libc++][test] Silence MSVC warning in std::optional test

`make_optional<string>(4, 'X')` passes `4` (an `int`) as the first argument to `string`'s `(size_t, charT)` constructor, triggering a signed/unsigned mismatch warning when compiling with MSVC at `/W4`. The incredibly simple fix is to instead use an unsigned literal (`4u`).
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/test/std/utilities/optional/optional.specalg/make_optional_explicit.pass.cpplibcxx.src/test/std/utilities/optional/optional.specalg/make_optional_explicit.pass.cpp
Revision 374683 by jdenny:
Revert r374648: "Reland r374388: [lit] Make internal diff work in pipelines"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/TestRunner.pyllvm.src/utils/lit/lit/TestRunner.py
The file was removed/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was added/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py
Revision 374682 by jdenny:
Revert r374649: "Reland r374389: [lit] Clean up internal diff's encoding handling"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.binllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.bin
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16llvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8llvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8
The file was modified/llvm/trunk/utils/lit/tests/max-failures.pyllvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py
Revision 374681 by jdenny:
Revert r374650: "Reland r374390: [lit] Extend internal diff to support `-` argument"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was modified/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was modified/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
The file was modified/llvm/trunk/utils/lit/tests/max-failures.pyllvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py
Revision 374680 by jdenny:
Revert 374651: "Reland r374392: [lit] Extend internal diff to support -U"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-unified.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was modified/llvm/trunk/utils/lit/tests/max-failures.pyllvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py
Revision 374679 by jdenny:
Revert r374652: "[lit] Fix internal diff's --strip-trailing-cr and use it"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/MC/AsmParser/preserve-comments.sllvm.src/test/MC/AsmParser/preserve-comments.s
The file was modified/llvm/trunk/test/tools/llvm-cxxmap/remap.testllvm.src/test/tools/llvm-cxxmap/remap.test
The file was modified/llvm/trunk/test/tools/llvm-profdata/profile-symbol-list.testllvm.src/test/tools/llvm-profdata/profile-symbol-list.test
The file was modified/llvm/trunk/test/tools/llvm-profdata/roundtrip.testllvm.src/test/tools/llvm-profdata/roundtrip.test
The file was modified/llvm/trunk/test/tools/llvm-profdata/sample-remap.testllvm.src/test/tools/llvm-profdata/sample-remap.test
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.dosllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.dos
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.unixllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.unix
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txt
The file was modified/llvm/trunk/utils/lit/tests/max-failures.pyllvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py
Revision 374678 by jdenny:
Revert r374653: "[lit] Fix a few oversights in r374651 that broke some bots"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/MC/ARM/preserve-comments-arm.sllvm.src/test/MC/ARM/preserve-comments-arm.s
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py
Revision 374677 by jdenny:
Revert r374665: "[lit] Try yet again to fix new tests that fail on Windows bots"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374676 by jdenny:
Revert r374666: "[lit] Adjust error handling for decode introduced by r374665"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374675 by jdenny:
Revert r374671: "[lit] Try errors="ignore" for decode introduced by r374665"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374674 by rksimon:
[X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.hllvm.src/lib/Target/X86/X86ISelLowering.h
Revision 374673 by rksimon:
SymbolRecord - consistently use explicit for single operand constructors
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/SymbolRecord.hllvm.src/include/llvm/DebugInfo/CodeView/SymbolRecord.h
Revision 374672 by rksimon:
SymbolRecord - fix uninitialized variable warnings. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/SymbolRecord.hllvm.src/include/llvm/DebugInfo/CodeView/SymbolRecord.h
Revision 374671 by jdenny:
[lit] Try errors="ignore" for decode introduced by r374665

Still trying to fix the same error as in r374666.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374670 by lebedevri:
[NFC][LoopIdiom] Adjust FIXME to be self-explanatory
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cppllvm.src/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
Revision 374669 by rksimon:
Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 374668 by rksimon:
Fix cppcheck shadow variable name warnings. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 374667 by rksimon:
[X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 374666 by jdenny:
[lit] Adjust error handling for decode introduced by r374665

On that decode, Windows bots fail with:

```
UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128)
```

That's the same error as before r374665 except it's now at the decode
before the write to stdout.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374665 by jdenny:
[lit] Try yet again to fix new tests that fail on Windows bots

I seem to have misread the bot logs on my last attempt.  When lit's
internal diff runs on Windows under Python 2.7, it's text diffs not
binary diffs that need decoding to avoid this error when writing the
diff to stdout:

```
UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128)
```

There is no `decode` attribute in this case under Python 3.6.8 under
Ubuntu, so this patch checks for the `decode` attribute before using
it here.  Hopefully nothing else is needed when `decode` isn't
available.

It might take a couple more attempts to figure out what error
handling, if any, is needed for this decoding.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374664 by jdenny:
Revert r374657: "[lit] Try again to fix new tests that fail on Windows bots"
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.pyllvm.src/utils/lit/tests/shtest-shell.py